GNU bug report logs - #41019
util-linux runstatedir is not actually a state directory

Previous Next

To reply to this bug, email your comments to 41019 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: <bug-guix <at> gnu.org>
Subject: util-linux runstatedir is not actually a state directory
Date: Sat, 2 May 2020 11:55:25 +0200

[Message part 1 (text/plain, inline)]

Hi,

util-linux tries to use a "uuidd" daemon to generate uuids.  It tries to
communicate with it via socket in $runstatedir/var/run/uuidd/ .

Unfortunately, we do not set runstatedir which means that we'll uselessly
refer to a socket inside util-linux's derivation output directory that never
will be there.

Better would be to refer to /var/run directly, or to remove that functionality
from our version of util-linux.

Git checkout:
  repository: /home/dannym/src/guix-raghav/guix
  branch: master
  commit: 807986a55fc2849d6986efb79f9a015cf4132e09

I stumbled upon that while trying to get F2FS's fsck to work (bug 41015).
We try to build a static version of f2fs-tools (f2fs-tools-static in
guix master), but it retains a reference from mkfs to the non-static
util-linux because of the problem above.

Details of that part of util-linux:

./libuuid/src/uuidd.h: * Definitions used by the uuidd daemon
./libuuid/src/uuidd.h:#define UUIDD_DIR         _PATH_RUNSTATEDIR "/uuidd"
./libuuid/src/uuidd.h:#define UUIDD_PIDFILE_PATH        UUIDD_DIR "/uuidd.pid"
./libuuid/src/uuidd.h:#define UUIDD_PATH                "/usr/sbin/uuidd"
./libuuid/src/gen_uuid.c:#include "uuidd.h"
./libuuid/src/gen_uuid.c: * Try using the uuidd daemon to generate the UUID
./libuuid/src/gen_uuid.c: * Tries to guarantee uniqueness of the generated UUIDs
 by obtaining them from the uuidd daemon,
./libuuid/src/gen_uuid.c: * or, if uuidd is not usable, by using the global cloc
k state counter (see get_clock()).
UUIDD_SOCKET_PATH 
./libuuid/src/uuidd.h:#define UUIDD_SOCKET_PATH UUIDD_DIR "/request"
./libuuid/src/uuidd.h:#define UUIDD_DIR         _PATH_RUNSTATEDIR "/uuidd"

/gnu/store/xymkwf57x988q8cny2is1dgzrbr9xdfi-util-linux-2.34/var/run/uuidd

[Message part 2 (application/pgp-signature, inline)]

Message #8 received at 41019 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 41019 <at> debbugs.gnu.org
Subject: Re: bug#41019: util-linux runstatedir is not actually a state
 directory
Date: Sat, 2 May 2020 12:14:09 +0200

[Message part 1 (text/plain, inline)]

Note: once that bug is fixed, still have to add:

diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index 44ee4f10aa..6a1840dbf6 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -245,6 +245,9 @@ FILE-SYSTEMS."
           '())
     ,@(if (find (file-system-type-predicate "jfs") file-systems)
           (list jfs_fsck/static)
+          '())
+    ,@(if (find (file-system-type-predicate "f2fs") file-systems)
+          (list f2fs-fsck/static)
           '())))
 
 (define-syntax vhash                              ;TODO: factorize

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 41019 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 41019 <at> debbugs.gnu.org
Subject: Re: bug#41019: util-linux runstatedir is not actually a state
 directory
Date: Mon, 4 May 2020 00:14:44 +0200

[Message part 1 (text/plain, inline)]

> Note: once that bug is fixed, still have to add:
> 
> diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
> index 44ee4f10aa..6a1840dbf6 100644
> --- a/gnu/system/linux-initrd.scm
> +++ b/gnu/system/linux-initrd.scm
> @@ -245,6 +245,9 @@ FILE-SYSTEMS."
>            '())
>      ,@(if (find (file-system-type-predicate "jfs") file-systems)
>            (list jfs_fsck/static)
> +          '())
> +    ,@(if (find (file-system-type-predicate "f2fs") file-systems)
> +          (list f2fs-fsck/static)
>            '())))

Added that in guix master in commit 33eab4a10dcd2a6580f168f18455df1d4653d14b.

Also added horrible workaround for this bug in commit
da09c63e78ebebeabb347f483d7284b87ff51c2f.

[Message part 2 (application/pgp-signature, inline)]

Message #14 received at 41019 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 41019 <at> debbugs.gnu.org
Subject: Re: bug#41019: util-linux runstatedir is not actually a state
 directory
Date: Tue, 5 May 2020 12:17:16 -0400

On Mon, May 04, 2020 at 12:14:44AM +0200, Danny Milosavljevic wrote:
> Also added horrible workaround for this bug in commit
> da09c63e78ebebeabb347f483d7284b87ff51c2f.

Do you want to leave the bug ticket open? Or is it "done"?

Message #17 received at 41019 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 41019 <at> debbugs.gnu.org
Subject: Re: bug#41019: util-linux runstatedir is not actually a state
 directory
Date: Tue, 5 May 2020 19:16:50 +0200

[Message part 1 (text/plain, inline)]

I'd prefer if we left the bug report still open and eventually fixed this
bug--although util-linux has a huge number of dependents.

The workaround is just removing the store reference from the executable file,
after the fact.
I mean it works because then libuuid.a can't find the socket for uuidd using
the name "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", but that's not the right way :P

[Message part 2 (application/pgp-signature, inline)]

Message #20 received at 41019 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>,
 Leo Famulari <leo <at> famulari.name>
Cc: 41019 <at> debbugs.gnu.org
Subject: Re: bug#41019: util-linux runstatedir is not actually a state
 directory
Date: Tue, 05 May 2020 20:08:35 +0200

[Message part 1 (text/plain, inline)]

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> I'd prefer if we left the bug report still open and eventually fixed this
> bug--although util-linux has a huge number of dependents.

You could create a 'util-linux/fixed' variable for this package if you
know how to fix it, and merge it with util-linux in the next
core-updates round.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.