GNU bug report logs - #41036
ruby: Add 2.7.3.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41036 in the body.
You can then email your comments to 41036 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: ruby: Add 2.7.3.
Date: Sat, 02 May 2020 23:25:53 +0000

[Message part 1 (text/plain, inline)]

This patch adds Ruby 2.7.3, the latest release.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ruby-2.7.patch (text/x-patch, attachment)]

Message #8 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: "41036 <at> debbugs.gnu.org" <41036 <at> debbugs.gnu.org>
Subject: ruby: Add ruby-2.5 as an alias to ruby
Date: Sat, 02 May 2020 23:34:02 +0000

[Message part 1 (text/plain, inline)]

The current ruby in Guix is 2.5, this alias allows to explicitly depend on ruby <at> 2.5.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-ruby-2.5-as-an-alias-to-ruby.patch (text/x-patch, attachment)]

Message #11 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: "41036 <at> debbugs.gnu.org" <41036 <at> debbugs.gnu.org>
Subject: ruby: Update to 2.7.3
Date: Sat, 02 May 2020 23:34:46 +0000

[Message part 1 (text/plain, inline)]

Ruby 2.7.3 is the latest release. This patch updates the ruby package to point to 2.7.

[Message part 2 (text/html, inline)]

[0001-gnu-ruby-Update-to-2.7.3.patch (text/x-patch, attachment)]

Message #14 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: "41036 <at> debbugs.gnu.org" <41036 <at> debbugs.gnu.org>
Subject: Re: [bug#41036] ruby: Update to 2.7.3
Date: Thu, 07 May 2020 09:47:45 +0200

Hi,

Ryan Prior <rprior <at> protonmail.com> skribis:

> Ruby 2.7.3 is the latest release. This patch updates the ruby package to point to 2.7.

‘guix refresh -l ruby <at> 2.5’ says there are 4K packages depending on it
(which I didn’t expect).  So this change should probably go to the next
‘core-updates’ according to our guidelines (info "(guix) Submitting
Patches").

Did you have a chance to test the impact of this change on Ruby
packages?  Perhaps you should ping other people who last upgraded Ruby.

Thanks,
Ludo’.

Message #17 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>, Mikhail Kirillov <w96k.ru <at> gmail.com>,
 Jelle Licht <jlicht <at> fsfe.org>, Brian Leung <bkleung89 <at> gmail.com>,
 "Collin J. Doering" <collin <at> rekahsoft.ca>,
 "Diego N. Barbato" <dnbarbato <at> posteo.de>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 41036 <at> debbugs.gnu.org
Subject: Re: [bug#41036] ruby: Update to 2.7.3
Date: Thu, 07 May 2020 19:27:29 +0000

Hi there! I'm Ryan Prior, a rubyist and Guix maintainer. I'm writing you
because I'd like your feedback on my patches to add Ruby 2.7.3 to Guix
and eventually to make that the default version of Ruby. I got your
email address from the Ruby package in Guix master.

You can find my version of the Ruby package here:
https://github.com/ryanprior/guix-packages#ruby

Discussion is in the Guix issue tracker here:
https://issues.guix.gnu.org/issue/41036

Thank you for contributing to Ruby and Guix, I appreciate your time!


Ludovic Courtès (cc'd) <ludo <at> gnu.org> writes:

> ‘guix refresh -l ruby <at> 2.5’ says there are 4K packages depending on it
> (which I didn’t expect).  So this change should probably go to the next
> ‘core-updates’ according to our guidelines (info "(guix) Submitting
> Patches").

I think it's a high priority to get 2.7 into Guix so people can start
testing it and building off of it, but fine to hold off
making it the default until the next core-update cycle.

> Did you have a chance to test the impact of this change on Ruby
> packages?  Perhaps you should ping other people who last upgraded
> Ruby.

I've tried a few core things like irb and bundler but have yet to
undertake a more serious testing plan.

Thank you for the suggestion Ludo!


Warmly,
Ryan Prior

Message #20 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 41036 <at> debbugs.gnu.org
Subject: Re: [bug#41036] ruby: Update to 2.7.3
Date: Tue, 12 May 2020 10:10:37 +0200

Hey Ryan,

Ryan Prior <rprior <at> protonmail.com> writes:

> Hi there! I'm Ryan Prior, a rubyist and Guix maintainer. I'm writing you
> because I'd like your feedback on my patches to add Ruby 2.7.3 to Guix
> and eventually to make that the default version of Ruby. I got your
> email address from the Ruby package in Guix master.

The only reason for my copyright line in gnu/packages/ruby.scm is that I
added the package ruby-wayback-machine-downloader [0] for which I used
the importer.  I know almost nothing about Ruby.

You might get more helpful feedback from the people who have contributed
to the Ruby package itself [1].

[...]

HTH,

Diego

[0]: https://git.savannah.gnu.org/cgit/guix.git/log/gnu/packages/ruby.scm?qt=author&q=barbato
[1]: https://git.savannah.gnu.org/cgit/guix.git/log/?qt=grep&q=gnu%3A+ruby%3A

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Ryan Prior <rprior <at> protonmail.com>, 
 Ryan Prior via Guix-patches <guix-patches <at> gnu.org>
Cc: "41036 <at> debbugs.gnu.org" <41036 <at> debbugs.gnu.org>
Subject: Re: [EXT] [bug#41036] ruby: Update to 2.7.3
Date: Tue, 12 May 2020 08:47:51 -0400

On Sat, May 2, 2020 at 7:35 PM Ryan Prior via Guix-patches via
<guix-patches <at> gnu.org> wrote:
>
> Ruby 2.7.3 is the latest release. This patch updates the ruby package to point to 2.7.

According to the Ruby releases page the latest release is 2.7.1, not
2.7.3. Am I missing something?

https://www.ruby-lang.org/en/downloads/releases/

- Dave

Message #29 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: "Thompson, David" <dthompson2 <at> worcester.edu>
Cc: "41036 <at> debbugs.gnu.org" <41036 <at> debbugs.gnu.org>
Subject: Re: [EXT] [bug#41036] ruby: Update to 2.7.3
Date: Tue, 12 May 2020 17:55:33 +0000

Thompson, David <dthompson2 <at> worcester.edu> writes:

> On Sat, May 2, 2020 at 7:35 PM Ryan Prior via Guix-patches via
> <guix-patches <at> gnu.org> wrote:
>>
>> Ruby 2.7.3 is the latest release. This patch updates the ruby package to point to 2.7.
>
> According to the Ruby releases page the latest release is 2.7.1, not
> 2.7.3. Am I missing something?

Hi David, I think I got confused when writing my email to debbugs. The
package says 2.7.1, which is correct, and all references in email
correspondence and patch titles to 2.7.3 should have been to 2.7.1.

Thank you for the correction!

Ryan

Message #32 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: 41036 <at> debbugs.gnu.org
Subject: Re: [bug#41036] ruby: Add 2.7.3.
Date: Wed, 13 May 2020 18:54:33 +0100

[Message part 1 (text/plain, inline)]

Ryan Prior via Guix-patches via <guix-patches <at> gnu.org> writes:

> This patch adds Ruby 2.7.3, the latest release.

Hi Ryan,

Thanks for the patch, I've tweaked this to also pass --enable-shared to
ruby-2.7, as that's done for Ruby 2.6. I've pushed this to the master
branch as [1].

1: 1cc7d3404f8b6b9bf0407e4c752c38fcc188cdba

Perhaps we can use this bug now to track getting Ruby 2.7 as the default
Ruby in Guix. As Ludo said in a previous message, that'll need to happen
on core-updates, which I'll start looking in to...

Thanks again,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: Ryan Prior <rprior <at> protonmail.com>, 41036 <at> debbugs.gnu.org
Subject: Re: [bug#41036] ruby: Add 2.7.3.
Date: Wed, 17 Jun 2020 12:03:42 +0200

Hi Christopher,

Christopher Baines <mail <at> cbaines.net> skribis:

> Ryan Prior via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> This patch adds Ruby 2.7.3, the latest release.
>
> Hi Ryan,
>
> Thanks for the patch, I've tweaked this to also pass --enable-shared to
> ruby-2.7, as that's done for Ruby 2.6. I've pushed this to the master
> branch as [1].
>
> 1: 1cc7d3404f8b6b9bf0407e4c752c38fcc188cdba
>
> Perhaps we can use this bug now to track getting Ruby 2.7 as the default
> Ruby in Guix. As Ludo said in a previous message, that'll need to happen
> on core-updates, which I'll start looking in to...

Would now be a good time to apply it?

Thanks,
Ludo’.

Message #38 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>, Ryan Prior
 <rprior <at> protonmail.com>
Cc: 41036 <at> debbugs.gnu.org
Subject: Re: [bug#41036] ruby: Add 2.7.3.
Date: Fri, 19 Jun 2020 09:54:42 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Christopher,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Ryan Prior via Guix-patches via <guix-patches <at> gnu.org> writes:
>>
>>> This patch adds Ruby 2.7.3, the latest release.
>>
>> Hi Ryan,
>>
>> Thanks for the patch, I've tweaked this to also pass --enable-shared to
>> ruby-2.7, as that's done for Ruby 2.6. I've pushed this to the master
>> branch as [1].
>>
>> 1: 1cc7d3404f8b6b9bf0407e4c752c38fcc188cdba
>>
>> Perhaps we can use this bug now to track getting Ruby 2.7 as the default
>> Ruby in Guix. As Ludo said in a previous message, that'll need to happen
>> on core-updates, which I'll start looking in to...
>
> Would now be a good time to apply it?

Yep, I've tried just now, but I was unsuccessful. Unfortunately I'm not
familiar with dealing with patches, and I couldn't seem to get this one
to apply at all.

Ryan, would you be able to rebase the relevant commit and share an
updated patch, that might help me apply it. Also, if there's a branch I
can pull from, that works as well.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41036 <at> debbugs.gnu.org
Subject: [PATCH 0/2] New patches to update Ruby to 2.7
Date: Sun, 21 Jun 2020 03:02:17 +0000

Here are the new patches you asked for, they should apply cleanly to master.

Ryan Prior (2):
  gnu: Renames ruby to ruby-2.6.
  gnu: Ruby: Update to 2.7.

 gnu/packages/ruby.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.26.2

Message #44 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41036 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: Renames ruby to ruby-2.6.
Date: Sun, 21 Jun 2020 03:02:26 +0000

* gnu/packages/ruby.scm (ruby): Rename to ruby-2.6.
* gnu/packages/ruby.scm (ruby-2.7): Inherit from ruby-2.6.
* gnu/packages/ruby.scm (ruby-2.5): Inherit from ruby-2.6.
* gnu/packages/ruby.scm (ruby-2.4): Inherit from ruby-2.6.
---
 gnu/packages/ruby.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 08c55e4e3c..a0fae70cc6 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -75,7 +75,7 @@
   #:use-module (guix build-system ruby)
   #:use-module ((srfi srfi-1) #:select (alist-delete)))
 
-(define-public ruby
+(define-public ruby-2.6
   (package
     (name "ruby")
     (version "2.6.5")
@@ -133,7 +133,7 @@ a focus on simplicity and productivity.")
 
 (define-public ruby-2.7
   (package
-    (inherit ruby)
+    (inherit ruby-2.6)
     (version "2.7.1")
     (source
      (origin
@@ -176,7 +176,7 @@ a focus on simplicity and productivity.")
 
 (define-public ruby-2.5
   (package
-    (inherit ruby)
+    (inherit ruby-2.6)
     (version "2.5.8")
     (source
      (origin
@@ -195,7 +195,7 @@ a focus on simplicity and productivity.")
 
 (define-public ruby-2.4
   (package
-    (inherit ruby)
+    (inherit ruby-2.6)
     (version "2.4.10")
     (source
      (origin
@@ -212,6 +212,8 @@ a focus on simplicity and productivity.")
                    (delete-file-recursively "ext/fiddle/libffi-3.2.1")
                    #t))))))
 
+(define-public ruby ruby-2.6)
+
 (define-public mruby
   (package
     (name "mruby")
-- 
2.26.2

Message #47 received at 41036 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41036 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Ruby: Update to 2.7.
Date: Sun, 21 Jun 2020 03:02:29 +0000

* gnu/packages/ruby.scm (ruby): Update to 2.7.
---
 gnu/packages/ruby.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index a0fae70cc6..b76b5fe411 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -212,7 +212,7 @@ a focus on simplicity and productivity.")
                    (delete-file-recursively "ext/fiddle/libffi-3.2.1")
                    #t))))))
 
-(define-public ruby ruby-2.6)
+(define-public ruby ruby-2.7)
 
 (define-public mruby
   (package
-- 
2.26.2

Message #52 received at 41036-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: 41036-done <at> debbugs.gnu.org
Subject: Re: [bug#41036] [PATCH 0/2] New patches to update Ruby to 2.7
Date: Wed, 24 Jun 2020 21:28:51 +0100

[Message part 1 (text/plain, inline)]

Ryan Prior via Guix-patches via <guix-patches <at> gnu.org> writes:

> Here are the new patches you asked for, they should apply cleanly to master.
>
> Ryan Prior (2):
>   gnu: Renames ruby to ruby-2.6.
>   gnu: Ruby: Update to 2.7.
>
>  gnu/packages/ruby.scm | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Great, thanks.

I've tweaked the commit messages a bit, and now pushed these patches to
core-updates.

I think the way ruby-2.7 inherits from ruby-2.6 is a bit odd, but I like
that this change is small in terms of the diff. Anyway, how to lay out
the package definitions is a lesser issue compared to what's actually
defined.

Now comes the challenge of actually fixing all the packages this change
will have broken. If updates to packages that fix issues with Ruby 2.7
don't cause too many rebuilds or break anything on master, then pushing
those to master is good. The master branch can then be merged in to
core-updates to get those changes applied there as well. Otherwise, the
fixes should be applied to core-updates.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.