GNU bug report logs - #41048
[PATCH] doc: add comment about ofl for Pam mount.

Previous Next

Package: guix-patches;

Reported by: Michael Rohleder <mike <at> rohleder.de>

Date: Sun, 3 May 2020 12:43:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41048 in the body.
You can then email your comments to 41048 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#41048; Package guix-patches. (Sun, 03 May 2020 12:43:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Michael Rohleder <mike <at> rohleder.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 03 May 2020 12:43:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] doc: add comment about ofl for Pam mount.
Date: Sun, 03 May 2020 14:42:26 +0200
[Message part 1 (text/plain, inline)]
Pam mount uses `ofl` from hxtools [1] to kill processes that have open
files on the filesystem mounted.
As we dont have hxtools (and I think we shouldnt), one has to configure
pam mount to use something else, eg `fuser`. This is an attempt to
document that somehow.

[0001-doc-guix.texi-Pam-mount-add-comment-about-ovl.patch (text/x-patch, inline)]
From 7a3cd9cd00cbd95e599a8d79400591e2fc589f33 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Sun, 3 May 2020 14:17:37 +0200
Subject: [PATCH] doc: add comment about ofl for Pam mount.

* doc/guix.texi: (Pam Mount) add comment about ofl.
---
 doc/guix.texi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index d5d8662937..aa182df183 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25441,6 +25441,8 @@ the partition where he stores his data:
                        (hup "0")
                        (term "no")
                        (kill "no")))
+            ;; if anything above is "true":
+            ;; (ofl "/run/current-system/profile/bin/fuser -km %(MNTPT)")
             (mkmountpoint (@@ (enable "1")
                              (remove "true")))))
 
-- 
2.26.2

[Message part 3 (text/plain, inline)]
Footnotes: 
[1]  https://github.com/ghthor/hxtools

-- 
"These download files are in Microsoft Word 6.0 format.  After unzipping, 
these files can be viewed in any text editor, including all versions of 
Microsoft Word, WordPad, and Microsoft Word Viewer."  [Microsoft website]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#41048; Package guix-patches. (Wed, 02 Sep 2020 14:50:01 GMT) Full text and rfc822 format available.

Message #8 received at 41048 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 41048 <at> debbugs.gnu.org
Subject: Re: [bug#41048] [PATCH] doc: add comment about ofl for Pam mount.
Date: Wed, 02 Sep 2020 16:49:38 +0200
Hi,

This patch fell through the cracks…

Michael Rohleder <mike <at> rohleder.de> skribis:

> Pam mount uses `ofl` from hxtools [1] to kill processes that have open
> files on the filesystem mounted.
> As we dont have hxtools (and I think we shouldnt), one has to configure
> pam mount to use something else, eg `fuser`. This is an attempt to
> document that somehow.
>
> From 7a3cd9cd00cbd95e599a8d79400591e2fc589f33 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike <at> rohleder.de>
> Date: Sun, 3 May 2020 14:17:37 +0200
> Subject: [PATCH] doc: add comment about ofl for Pam mount.
>
> * doc/guix.texi: (Pam Mount) add comment about ofl.
> ---
>  doc/guix.texi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index d5d8662937..aa182df183 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -25441,6 +25441,8 @@ the partition where he stores his data:
>                         (hup "0")
>                         (term "no")
>                         (kill "no")))
> +            ;; if anything above is "true":
> +            ;; (ofl "/run/current-system/profile/bin/fuser -km %(MNTPT)")

It’s not clear what these two lines mean.  The idea is to tell users to
configure PAM Mount to use ‘fuser’ as a replacement for ‘ofl’, right?  I
think that’d deserve one or two sentences of explanation.  WDYT?

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#41048; Package guix-patches. (Wed, 02 Sep 2020 15:26:02 GMT) Full text and rfc822 format available.

Message #11 received at 41048 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41048 <at> debbugs.gnu.org
Subject: Re: [bug#41048] [PATCH] doc: add comment about ofl for Pam mount.
Date: Wed, 02 Sep 2020 17:25:19 +0200
[Message part 1 (text/plain, inline)]
Hi Ludo!

Ludovic Courtès <ludo <at> gnu.org> writes:
>> +            ;; if anything above is "true":
>> +            ;; (ofl "/run/current-system/profile/bin/fuser -km %(MNTPT)")
>
> It’s not clear what these two lines mean.  The idea is to tell users to
> configure PAM Mount to use ‘fuser’ as a replacement for ‘ofl’, right?  I
> think that’d deserve one or two sentences of explanation.  WDYT?

Yes, that is/was the idea, because killing processes would not work
otherwise.
Now that we have autofs, I don't think it's relevant any more, so we can
close it?

-- 
No one gets sick on Wednesdays.
[signature.asc (application/pgp-signature, inline)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Wed, 02 Sep 2020 20:19:01 GMT) Full text and rfc822 format available.

Notification sent to Michael Rohleder <mike <at> rohleder.de>:
bug acknowledged by developer. (Wed, 02 Sep 2020 20:19:02 GMT) Full text and rfc822 format available.

Message #16 received at 41048-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 41048-done <at> debbugs.gnu.org
Subject: Re: [bug#41048] [PATCH] doc: add comment about ofl for Pam mount.
Date: Wed, 02 Sep 2020 22:18:42 +0200
Hi Michael,

Michael Rohleder <mike <at> rohleder.de> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>>> +            ;; if anything above is "true":
>>> +            ;; (ofl "/run/current-system/profile/bin/fuser -km %(MNTPT)")
>>
>> It’s not clear what these two lines mean.  The idea is to tell users to
>> configure PAM Mount to use ‘fuser’ as a replacement for ‘ofl’, right?  I
>> think that’d deserve one or two sentences of explanation.  WDYT?
>
> Yes, that is/was the idea, because killing processes would not work
> otherwise.

OK.

> Now that we have autofs, I don't think it's relevant any more, so we can
> close it?

Fine with me, done!

Thanks,
Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 01 Oct 2020 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.