GNU bug report logs - #41054
Breaking up makeicecat into functions

Previous Next

To reply to this bug, email your comments to 41054 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: R Moog <moog621 <at> gmail.com>
To: bug-gnuzilla <at> gnu.org
Subject: Breaking up makeicecat into functions
Date: Sun, 3 May 2020 15:50:07 +0200

[Message part 1 (text/plain, inline)]

Hello,

I would like to send a patch for the makeicecat script. It comes from the
68 branch, git commit 8f9f30e1e9cf2b411ce2747024d4f72edda86904. Here's a
definite list of issues addressed in this patch:
1. Shebang changed to /usr/bin/env bash in order to support systems that
put the bash binary elsewhere than /bin, for example FreeBSD.
2. Everything that makeicecat does is enclosed in functions with
descriptive names. The abstraction of work scope is increasing towards the
end, which lets the reader better understand what makeicecat really does
and in what order.
3. References to /tmp are now based in the current directory. Accessing
paths outside of the sandbox is illegal in Portage sandbox, which voids the
effort of packaging IceCat for Gentoo Linux. Which I maintain in an
unofficial Gentoo overlay. So far I have sed'ed those out during src_unpack
phase, but I think it's only fair that everyone gets a better behaved
makeicecat.

Best regards,
Michał Dec

[Message part 2 (text/html, inline)]

[makeicecat.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.