GNU bug report logs - #41104
28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun

Previous Next

Package: emacs;

Reported by: Michael Heerdegen <michael_heerdegen <at> web.de>

Date: Wed, 6 May 2020 03:06:02 UTC

Severity: normal

Found in version 28.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41104 in the body.
You can then email your comments to 41104 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#41104; Package emacs. (Wed, 06 May 2020 03:06:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Michael Heerdegen <michael_heerdegen <at> web.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 06 May 2020 03:06:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; nadvice: `find-function-library' infloops for adviced
 autoload fun
Date: Wed, 06 May 2020 05:05:07 +0200

Hello,

in *scratch* eval this:

#+begin_src emacs-lisp
(require 'find-func)

;; we don't require 'dired so it is an autoload fun.  Then:

(advice-add 'dired
            :override
            (defun my-dired (&rest args) t))

;; And

(find-function-library 'dired)

;; infloops.
#+end_src

The problem seems be that `find-function-advised-original' unexpectedly
returns the original symbol because `advice--cd*r' returns nil in this
case.

TIA,

Michael.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#41104; Package emacs. (Mon, 06 Jun 2022 13:34:02 GMT) Full text and rfc822 format available.

Message #8 received at 41104 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 41104 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#41104: 28.0.50; nadvice: `find-function-library' infloops
 for adviced autoload fun
Date: Mon, 06 Jun 2022 15:33:48 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> #+begin_src emacs-lisp
> (require 'find-func)
>
> ;; we don't require 'dired so it is an autoload fun.  Then:
>
> (advice-add 'dired
>             :override
>             (defun my-dired (&rest args) t))
>
> ;; And
>
> (find-function-library 'dired)
>
> ;; infloops.
> #+end_src
>
> The problem seems be that `find-function-advised-original' unexpectedly
> returns the original symbol because `advice--cd*r' returns nil in this
> case.

This issue is still present on the trunk.  Perhaps Stefan has some
comments; added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Reply sent to Stefan Monnier <monnier <at> iro.umontreal.ca>:
You have taken responsibility. (Tue, 07 Jun 2022 14:33:02 GMT) Full text and rfc822 format available.
Notification sent to Michael Heerdegen <michael_heerdegen <at> web.de>:
bug acknowledged by developer. (Tue, 07 Jun 2022 14:33:02 GMT) Full text and rfc822 format available.

Message #13 received at 41104-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 41104-done <at> debbugs.gnu.org
Subject: Re: bug#41104: 28.0.50; nadvice: `find-function-library' infloops
 for adviced autoload fun
Date: Tue, 07 Jun 2022 10:31:56 -0400

> The problem seems be that `find-function-advised-original' unexpectedly
> returns the original symbol because `advice--cd*r' returns nil in this
> case.

I believe the problem is now fixed in `master`.


        Stefan
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 06 Jul 2022 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 288 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.