GNU bug report logs - #41131
[PATCH] hash-table-merge! ignores other-ht

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guile; Reported by: "Ricardo G. Herdt" <r.herdt@HIDDEN>; Keywords: patch; dated Fri, 8 May 2020 00:20:01 UTC; Maintainer for guile is bug-guile@HIDDEN.
Added tag(s) patch. Request was from "Ricardo G. Herdt" <r.herdt@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Changed bug title to '[PATCH] hash-table-merge! ignores other-ht' from 'Bug in hash-table-merge! (and patch)' Request was from "Ricardo G. Herdt" <r.herdt@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 8 May 2020 00:19:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 07 20:19:35 2020
Received: from localhost ([127.0.0.1]:44165 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jWqjm-0004Ui-VP
	for submit <at> debbugs.gnu.org; Thu, 07 May 2020 20:19:35 -0400
Received: from lists.gnu.org ([209.51.188.17]:38766)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <r.herdt@HIDDEN>) id 1jWqHI-0003j1-77
 for submit <at> debbugs.gnu.org; Thu, 07 May 2020 19:50:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:34164)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <r.herdt@HIDDEN>) id 1jWqHH-0003Kq-Ux
 for bug-guile@HIDDEN; Thu, 07 May 2020 19:50:07 -0400
Received: from mout01.posteo.de ([185.67.36.65]:59856)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <r.herdt@HIDDEN>) id 1jWqHG-0002yy-MJ
 for bug-guile@HIDDEN; Thu, 07 May 2020 19:50:07 -0400
Received: from submission (posteo.de [89.146.220.130]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 093C416005C
 for <bug-guile@HIDDEN>; Fri,  8 May 2020 01:50:01 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
 t=1588895402; bh=m6YwxVT+yhH4/+0OI2gqsQPdD9B7ByWUM0gV2z4OeWI=;
 h=Date:From:To:Subject:From;
 b=ECjmaT3c3W4x0oeex8rla3oVT1LOmyRJG2yuAU5M+8AGp+wDgfBGDQyV5obZIeNd/
 ultA1iDLnnP2ocrZpGvHXuHcHVoR9+GKN/4F/zsqsd0HM1jjDaGsC65ewMKboL759e
 dxLuhdo5gg4tu0GU/cHkrporY36d7X7Pa05A+2bPXX9KnS5sn6oN08X9kAGZRH/6GE
 9HppCCO0B6JHX2pUIUP156FCw3Jp/7gYPZy5GASPHX2C7AZ2MLE7CAk6VpJqMAoe+A
 b1B2IPc/9buPCz0A8LniR6fSphjdUxjpn6KGdhkNKy7J6v16wopgoumNZi1OgJnO/4
 dVvEqi/9ZIUsw==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 49J9Dn2WmKz9rxX
 for <bug-guile@HIDDEN>; Fri,  8 May 2020 01:50:01 +0200 (CEST)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_5212ecabfe80dbc72e77809617dd3d50"
Date: Fri, 08 May 2020 01:50:01 +0200
From: "Ricardo G. Herdt" <r.herdt@HIDDEN>
To: bug-guile@HIDDEN
Subject: Bug in hash-table-merge! (and patch)
Message-ID: <ff3f98118ceb25811284e08551ec3771@HIDDEN>
X-Sender: r.herdt@HIDDEN
User-Agent: Posteo Webmail
Received-SPF: pass client-ip=185.67.36.65; envelope-from=r.herdt@HIDDEN;
 helo=mout01.posteo.de
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/07 19:50:02
X-ACL-Warn: Detected OS   = Linux 3.11 and newer
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=0.001,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Thu, 07 May 2020 20:19:34 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=_5212ecabfe80dbc72e77809617dd3d50
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

Hi,

I just found this bug in the hash-table-merge! function 
(modul/srfi/srfi-69.scm). Instead of merging both hash tables, it was 
ignoring one of them (other-ht). Attached is the fix, where it now folds 
over other-ht and store its data in ht.

Cheers,

Ricardo G. Herdt

--=_5212ecabfe80dbc72e77809617dd3d50
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-Fix-hash-table-merge-bug.patch
Content-Disposition: attachment;
 filename=0001-Fix-hash-table-merge-bug.patch;
 size=831

RnJvbSAxODBhOWUxNGI4MDcyOTVhYTMxOTY2YTUyYmZkNzMyNjQ3NDU4ZWY5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiUmljYXJkbyBHLiBIZXJkdCIgPHIuaGVyZHRAcG9zdGVvLmRl
PgpEYXRlOiBGcmksIDggTWF5IDIwMjAgMDE6Mzc6MjQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBG
aXggaGFzaC10YWJsZS1tZXJnZSEgYnVnLgoKKiBtb2R1bGUvc3JmaS9zcmZpLTY5LnNjbSA6IGZv
bGQgb3ZlciBzZWNvbmQgaGFzaCB0YWJsZS4KLS0tCiBtb2R1bGUvc3JmaS9zcmZpLTY5LnNjbSB8
IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlm
ZiAtLWdpdCBhL21vZHVsZS9zcmZpL3NyZmktNjkuc2NtIGIvbW9kdWxlL3NyZmkvc3JmaS02OS5z
Y20KaW5kZXggYjk0ODZjNDY1Li45MWJjYzc3ZGIgMTAwNjQ0Ci0tLSBhL21vZHVsZS9zcmZpL3Ny
ZmktNjkuc2NtCisrKyBiL21vZHVsZS9zcmZpL3NyZmktNjkuc2NtCkBAIC0zMzAsNyArMzMwLDcg
QEAgQW5zd2VyIHRoZSBmaW5hbCBGIHJlc3VsdC4iCiAgICJBZGQgYWxsIGtleS92YWx1ZSBwYWly
cyBmcm9tIE9USEVSLUhUIHRvIEhULCBvdmVycmlkaW5nIEhUJ3MKIG1hcHBpbmdzIHdoZXJlIHBy
ZXNlbnQuICBSZXR1cm4gSFQuIgogICAoaGFzaC10YWJsZS1mb2xkCi0gICBodCAobGFtYmRhIChr
IHYgaWduKSAoaGFzaC10YWJsZS1zZXQhIGh0IGsgdikpICNmKQorICAgb3RoZXItaHQgKGxhbWJk
YSAoayB2IGlnbikgKGhhc2gtdGFibGUtc2V0ISBodCBrIHYpKSAjZikKICAgaHQpCiAKIDs7OyBz
cmZpLTY5LnNjbSBlbmRzIGhlcmUKLS0gCjIuMjAuMQoK
--=_5212ecabfe80dbc72e77809617dd3d50
Content-Transfer-Encoding: base64
Content-Type: text/plain;
 name=Changelog
Content-Disposition: attachment;
 filename=Changelog;
 size=170

MjAyMC0wNS0wOCBSaWNhcmRvIEcuIEhlcmR0IDxyLmhlcmR0QHBvc3Rlby5kZT4KCiogc3JmaS02
OS5zY206IGhhc2gtdGFibGUtbWVyZ2UhIHdhcyBpZ25vcmluZyB0aGUgc2Vjb25kIGhhc2ggdGFi
bGUuCkZvbGQgb3ZlciBvdGhlci1odCwgYW5kIHN0b3JlIGl0cyBrZXktdmFsdWVzIGluIGh0Lgo=
--=_5212ecabfe80dbc72e77809617dd3d50--





Acknowledgement sent to "Ricardo G. Herdt" <r.herdt@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-guile@HIDDEN. Full text available.
Report forwarded to bug-guile@HIDDEN:
bug#41131; Package guile. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 1 Jun 2020 08:00:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.