GNU bug report logs - #41238
guix deploy close ssh session after each store items sent

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41238 in the body.
You can then email your comments to 41238 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: bug-guix <at> gnu.org
Subject: guix deploy close ssh session after each store items sent
Date: Wed, 13 May 2020 16:32:55 +0000

Hey Guix,

“guix deploy” bugs; they keep coming! “guix deploy” doesn't make use of 
SSH
channels[0], instead it close the SSH session each time after sending 
store
items. This may be unnoticeable by users using a password-less SSH key
(bad!) or an SSH agent (better!) but for the other it mean entering the
password ~5 times per host per deployment which get old very quick. In 
my
case I use a keycard that require me to physically interact with it for
each authentication request, it means multiple touch per deployment,
reducing it just one would be a great relief.

[0]: 
https://github.com/artyom-poptsov/guile-ssh/blob/b11182d5582844df0c8d1fcb7177ff85f8ac3bcd/doc/api-sessions.texi#L17

- Brice

Message #8 received at 41238 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 41238 <at> debbugs.gnu.org
Subject: Re: bug#41238: guix deploy close ssh session after each store items
 sent
Date: Fri, 15 May 2020 09:59:38 +0300

[Message part 1 (text/plain, inline)]

Brice Waegeneire <brice <at> waegenei.re> writes:

> “guix deploy” bugs; they keep coming! “guix deploy” doesn't make use of SSH
> channels[0], instead it close the SSH session each time after sending store
> items.

Did you try a built in SSH's “Control*” feature?

ssh_config (0)

  ControlMaster auto
  ControlPath ~/.ssh/master-%r@%h:%p
  ControlPersist yes

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 41238 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 41238 <at> debbugs.gnu.org
Subject: Re: bug#41238: guix deploy close ssh session after each store items
 sent
Date: Fri, 15 May 2020 07:46:25 +0000

On 2020-05-15 06:59, Oleg Pykhalov wrote:
> Brice Waegeneire <brice <at> waegenei.re> writes:
> 
>> “guix deploy” bugs; they keep coming! “guix deploy” doesn't make use 
>> of SSH
>> channels[0], instead it close the SSH session each time after sending 
>> store
>> items.
> 
> Did you try a built in SSH's “Control*” feature?
> 
> ssh_config (0)
> 
>   ControlMaster auto
>   ControlPath ~/.ssh/master-%r@%h:%p
>   ControlPersist yes

Of course, it's my default setting for SSH (and the host I tried to 
deploy
to). But “guix deploy” don't support it; it's the core of the issue 
here.

I didn't mention those options in the initial bug report because IFAIK 
the
ssh functionality for “guix deploy” is provided by guile-ssh, a wrapper
around libssh which isn't related to OpenSSH in any way. So the 
“Control*”
options doesn't apply here, instead they talk about channels and 
session[0]
which seems to be the terms used in the SSH specification.

[0]: https://api.libssh.org/stable/libssh_tutor_guided_tour.html

Message #16 received at 41238-close <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: 41238-close <at> debbugs.gnu.org
Subject: Re: bug#41238: guix deploy close ssh session after each store items
 sent
Date: Tue, 18 Jan 2022 08:08:51 +0100

Hello Guix,

Brice Waegeneire <brice <at> waegenei.re> writes:

> “guix deploy” bugs; they keep coming! “guix deploy” doesn't make use of SSH
> channels[0], instead it close the SSH session each time after sending store
> items.

[...]

Ludo‘ fixed the issue with the commit 7f20e59a13a6acc3331e04185b8f1ed2538dcd0a.

For posterity, here is the workaround I was using a few month ago and is now
unecessary. The session filed needed to be manually set with a call to
"openssh-ssh-session" from (guix ssh):

--8<---------------cut here---------------start------------->8---
(machine-ssh-configuration
  (host-name "foo")
  (system "x86_64-linux")
  (session (open-ssh-session "foo" #:user "root"))
  (host-key "..."))
--8<---------------cut here---------------end--------------->8---

Currently the following suffice:

--8<---------------cut here---------------start------------->8---
(machine-ssh-configuration
  (host-name "foo")
  (system "x86_64-linux")
  (user "root") 
  (host-key "..."))
--8<---------------cut here---------------end--------------->8---

Cheers,
- Brice

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.