GNU bug report logs - #41259
[PATCH] etc: Add a systemd unit to bind-mount @storedir@ read-only.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Tobias Geerinckx-Rice <me@HIDDEN>; Keywords: patch; dated Thu, 14 May 2020 13:50:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 41259 <at> debbugs.gnu.org:


Received: (at 41259) by debbugs.gnu.org; 14 May 2020 18:49:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 14:49:56 2020
Received: from localhost ([127.0.0.1]:34819 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZIvV-000704-Aw
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 14:49:56 -0400
Received: from lepiller.eu ([89.234.186.109]:57728)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1jZIvQ-0006zr-48
 for 41259 <at> debbugs.gnu.org; Thu, 14 May 2020 14:49:48 -0400
Received: from lepiller.eu (localhost [127.0.0.1])
 by lepiller.eu (OpenSMTPD) with ESMTP id 3af5939e;
 Thu, 14 May 2020 18:49:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date
 :in-reply-to:references:mime-version:content-type
 :content-transfer-encoding:subject:to:from:message-id; s=dkim;
 bh=p+jyHuVc+4yorLoy+DLV4qHu5bky1q1bEW7SaPmAFqw=; b=LP+8FM5M2EGz
 6tp+oUgiO9uJzE2hkZgBFaWvMLcv/q6T9Xn+pCQ7Y644Q7lsvgSxgQSAMpD2LJi9
 sUTKkkAgjNu/pc8bjijC+7reeGhvFpihKWRZdewSH4lP01cudMYO8pwVhHX8HusX
 /1eVZCl+AWTsqWhW2Vgb0h6fqCRQPx0yWg6yKu1jVAzqDZBsEAobzfEgE7WnJWkf
 iChuwTlpCp01QDhS+iwSud+r3rKhx/RK+LNnx1H6LTYa1q8AOVvp73vx0Q4GbDsF
 mEHC03SCT3ZDNHRmWe7x9FaVkGVFKUeC+X/vq33CmbT11YGaUP6kkpOUP6jGVsDp
 C7XfBn4X8A==
Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id f3a7f343
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 14 May 2020 18:49:38 +0000 (UTC)
Date: Thu, 14 May 2020 14:49:15 -0400
User-Agent: K-9 Mail for Android
In-Reply-To: <A2F0E860-28E9-42A6-AE02-0BDBB876106E@HIDDEN>
References: <20200514134846.29037-1-me@HIDDEN>
 <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
 <A2F0E860-28E9-42A6-AE02-0BDBB876106E@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount
 @storedir@ read-only.
To: 41259 <at> debbugs.gnu.org,me@HIDDEN
From: Julien Lepiller <julien@HIDDEN>
Message-ID: <0CDBC9C6-B6B1-4696-A2C0-7D5BD3BA887D@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 41259
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Le 14 mai 2020 12:35:12 GMT-04:00, Julien Lepiller <julien@lepiller=2Eeu> a=
 =C3=A9crit :
>Le 14 mai 2020 10:01:51 GMT-04:00, Julien Lepiller <julien@lepiller=2Eeu>
>a =C3=A9crit :
>>Le 14 mai 2020 09:48:46 GMT-04:00, Tobias Geerinckx-Rice via
>>Guix-patches via <guix-patches@gnu=2Eorg> a =C3=A9crit :
>>>* etc/gnu-store=2Emount=2Ein: New file=2E
>>>* nix/local=2Emk (nodist_systemdservice_DATA): Add it=2E
>>>(etc/%=2Emount): New rule=2E
>>>* etc/guix-install=2Esh (sys_enable_guix_daemon): Install it=2E
>>>* doc/guix=2Etexi (Binary Installation): Document it=2E
>>>---
>>>
>>>For
>>><https://lists=2Egnu=2Eorg/archive/html/help-guix/2020-05/msg00097=2Eht=
ml>=2E
>>>
>>> doc/guix=2Etexi          |  5 +++--
>>> etc/gnu-store=2Emount=2Ein | 14 ++++++++++++++
>>> etc/guix-install=2Esh    | 12 +++++++++---
>>> nix/local=2Emk           | 12 +++++++++++-
>>> 4 files changed, 37 insertions(+), 6 deletions(-)
>>> create mode 100644 etc/gnu-store=2Emount=2Ein
>>>
>>>diff --git a/doc/guix=2Etexi b/doc/guix=2Etexi
>>>index d6fbd85fde=2E=2E5d80a7e405 100644
>>>--- a/doc/guix=2Etexi
>>>+++ b/doc/guix=2Etexi
>>>@@ -659,9 +659,10 @@ with these commands:
>>> @c
>>https://lists=2Egnu=2Eorg/archive/html/guix-devel/2017-01/msg01199=2Ehtm=
l
>>>=20
>>> @example
>>>-# cp
>>~root/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eservice
>>>\
>>>+# cp ~root/=2Econfig/guix/current/lib/systemd/system/gnu-store=2Emount=
 \
>>>+   =20
>>~root/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eservice
>>>\
>>>      /etc/systemd/system/
>>>-# systemctl enable --now guix-daemon
>>>+# systemctl enable --now gnu-store=2Emount guix-daemon
>>> @end example
>>>=20
>>> If your host distro uses the Upstart init system:
>>>diff --git a/etc/gnu-store=2Emount=2Ein b/etc/gnu-store=2Emount=2Ein
>>>new file mode 100644
>>>index 0000000000=2E=2Ec94f2db72b
>>>--- /dev/null
>>>+++ b/etc/gnu-store=2Emount=2Ein
>>>@@ -0,0 +1,14 @@
>>>+[Unit]
>>>+Description=3DRead-only @storedir@ for GNU Guix
>>>+DefaultDependencies=3Dno
>>>+ConditionPathExists=3D@storedir@
>>>+Before=3Dguix-daemon=2Eservice
>>>+
>>>+[Install]
>>>+WantedBy=3Dguix-daemon=2Eservice
>>>+
>>>+[Mount]
>>>+What=3D@storedir@
>>>+Where=3D@storedir@
>>>+Type=3Dnone
>>>+Options=3Dbind,ro
>>>diff --git a/etc/guix-install=2Esh b/etc/guix-install=2Esh
>>>index 4909d3f162=2E=2Ed252c132fb 100755
>>>--- a/etc/guix-install=2Esh
>>>+++ b/etc/guix-install=2Esh
>>>@@ -342,7 +342,13 @@ sys_enable_guix_daemon()
>>>                 _msg "${PAS}enabled Guix daemon via upstart"
>>>             ;;
>>>         systemd)
>>>-            { cp
>>>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Es=
ervice"
>>>\
>>>+            { # systemd =2Emount units must be named after the target
>>>directory=2E
>>>+              # Here we assume a hard-coded name of /gnu/store=2E
>>>+              cp
>>>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/gnu-store=2Emou=
nt"
>>>\
>>>+                 /etc/systemd/system/;
>>>+              chmod 664 /etc/systemd/system/gnu-store=2Emount;
>>>+
>>>+              cp
>>>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Es=
ervice"
>>>\
>>>                  /etc/systemd/system/;
>>>               chmod 664 /etc/systemd/system/guix-daemon=2Eservice;
>>>=20
>>>@@ -357,8 +363,8 @@ sys_enable_guix_daemon()
>>> 	      fi;
>>>=20
>>>               systemctl daemon-reload &&
>>>-                  systemctl start guix-daemon &&
>>>-                  systemctl enable guix-daemon; } &&
>>>+                  systemctl start  gnu-store=2Emount guix-daemon &&
>>>+                  systemctl enable gnu-store=2Emount guix-daemon; } &&
>>>                 _msg "${PAS}enabled Guix daemon via systemd"
>>>             ;;
>>>         sysv-init)
>>>diff --git a/nix/local=2Emk b/nix/local=2Emk
>>>index a64bdd2137=2E=2E435fdd389a 100644
>>>--- a/nix/local=2Emk
>>>+++ b/nix/local=2Emk
>>>@@ -155,7 +155,17 @@ noinst_HEADERS =3D						\
>>>=20
>>> # The '=2Eservice' files for systemd=2E
>>> systemdservicedir =3D $(libdir)/systemd/system
>>>-nodist_systemdservice_DATA =3D etc/guix-daemon=2Eservice
>>>etc/guix-publish=2Eservice
>>>+nodist_systemdservice_DATA =3D			\
>>>+  etc/gnu-store=2Emount				\
>>>+  etc/guix-daemon=2Eservice			\
>>>+  etc/guix-publish=2Eservice
>>>+
>>>+etc/%=2Emount: etc/%=2Emount=2Ein	\
>>>+			 $(top_builddir)/config=2Estatus
>>>+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";	\
>>>+	$(SED) -e 's|@''storedir''@|$(storedir)|' <	\
>>>+	       "$<" > "$@=2Etmp";		\
>>>+	mv "$@=2Etmp" "$@"
>>>=20
>>> etc/guix-%=2Eservice: etc/guix-%=2Eservice=2Ein	\
>>> 			 $(top_builddir)/config=2Estatus
>>
>>I see that's how it's done with the existing service, but why sed the
>>=2Ein file when we could let configure=2Eac take care of it?
>>
>>I'll try that on a VM of a foreign distro soonish and report=2E Thanks!
>
>I tested it on a debian VM and it worked well=2E I tested the installer
>script and it fails at installing the =2Emount unit, because it does not
>exist in the tarball=2E
>
>After installing the unit manually, I could start the =2Emount service
>and found that I was not able to remove store store items with rm=2E I
>checked that Guix is able to install new store items=2E

For non systemd distros, adding the following line to /etc/fstab works:

@storedir@ @storedir@ none defaults,bind,ro 0 0

Then running "mount -a" remounts the store read-only=2E

I'm not sure how to integrate this properly in the installer script=2E




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at 41259 <at> debbugs.gnu.org:


Received: (at 41259) by debbugs.gnu.org; 14 May 2020 16:35:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 12:35:47 2020
Received: from localhost ([127.0.0.1]:34582 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZGpY-0000if-N2
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 12:35:47 -0400
Received: from lepiller.eu ([89.234.186.109]:57650)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1jZGpT-0000iO-42
 for 41259 <at> debbugs.gnu.org; Thu, 14 May 2020 12:35:31 -0400
Received: from lepiller.eu (localhost [127.0.0.1])
 by lepiller.eu (OpenSMTPD) with ESMTP id 081242b0;
 Thu, 14 May 2020 16:35:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date
 :in-reply-to:references:mime-version:content-type
 :content-transfer-encoding:subject:to:from:message-id; s=dkim;
 bh=1uQJMRWdBdem92tZzO+DH+4Pk8jFiRNvI4x9znnSftk=; b=Li4zKtpQELLQ
 fgNruvbxTwDwT9Q953DcWJNIt//t5/G5g8xQCUK62dpUOLGisDPgTjIoZFbuDJ+s
 LWV1omCuXbeAa7WQGofXXv9Zd7/YwGby3v+Um2vWqKrRzVs8P0POhOGVPWxCRK8l
 UWjsRYMp7zAr+++V5+ijzRssjGR/ffUbrbG4pVuz1Vxd1YfImaOzSq1x9WlP8MeF
 2nb9G9Lno2Osd891rR3jhycP/DFu0mNVWlEy5BWzofV+djSveT/pZUmCfJUOZNAA
 9FpzHTx91IeeOaao8mxBWfgAV8W/3VcLOaFFyMKvOuHaZbzH256rYuklEDOg5V/y
 n1o6uh3SiA==
Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id fe7d552c
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 14 May 2020 16:35:24 +0000 (UTC)
Date: Thu, 14 May 2020 12:35:12 -0400
User-Agent: K-9 Mail for Android
In-Reply-To: <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
References: <20200514134846.29037-1-me@HIDDEN>
 <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount
 @storedir@ read-only.
To: guix-patches@HIDDEN, Tobias Geerinckx-Rice <me@HIDDEN>,
 41259 <at> debbugs.gnu.org
From: Julien Lepiller <julien@HIDDEN>
Message-ID: <A2F0E860-28E9-42A6-AE02-0BDBB876106E@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 41259
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Le 14 mai 2020 10:01:51 GMT-04:00, Julien Lepiller <julien@lepiller=2Eeu> a=
 =C3=A9crit :
>Le 14 mai 2020 09:48:46 GMT-04:00, Tobias Geerinckx-Rice via
>Guix-patches via <guix-patches@gnu=2Eorg> a =C3=A9crit :
>>* etc/gnu-store=2Emount=2Ein: New file=2E
>>* nix/local=2Emk (nodist_systemdservice_DATA): Add it=2E
>>(etc/%=2Emount): New rule=2E
>>* etc/guix-install=2Esh (sys_enable_guix_daemon): Install it=2E
>>* doc/guix=2Etexi (Binary Installation): Document it=2E
>>---
>>
>>For
>><https://lists=2Egnu=2Eorg/archive/html/help-guix/2020-05/msg00097=2Ehtm=
l>=2E
>>
>> doc/guix=2Etexi          |  5 +++--
>> etc/gnu-store=2Emount=2Ein | 14 ++++++++++++++
>> etc/guix-install=2Esh    | 12 +++++++++---
>> nix/local=2Emk           | 12 +++++++++++-
>> 4 files changed, 37 insertions(+), 6 deletions(-)
>> create mode 100644 etc/gnu-store=2Emount=2Ein
>>
>>diff --git a/doc/guix=2Etexi b/doc/guix=2Etexi
>>index d6fbd85fde=2E=2E5d80a7e405 100644
>>--- a/doc/guix=2Etexi
>>+++ b/doc/guix=2Etexi
>>@@ -659,9 +659,10 @@ with these commands:
>> @c
>https://lists=2Egnu=2Eorg/archive/html/guix-devel/2017-01/msg01199=2Ehtml
>>=20
>> @example
>>-# cp
>~root/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eservice
>>\
>>+# cp ~root/=2Econfig/guix/current/lib/systemd/system/gnu-store=2Emount =
\
>>+   =20
>~root/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eservice
>>\
>>      /etc/systemd/system/
>>-# systemctl enable --now guix-daemon
>>+# systemctl enable --now gnu-store=2Emount guix-daemon
>> @end example
>>=20
>> If your host distro uses the Upstart init system:
>>diff --git a/etc/gnu-store=2Emount=2Ein b/etc/gnu-store=2Emount=2Ein
>>new file mode 100644
>>index 0000000000=2E=2Ec94f2db72b
>>--- /dev/null
>>+++ b/etc/gnu-store=2Emount=2Ein
>>@@ -0,0 +1,14 @@
>>+[Unit]
>>+Description=3DRead-only @storedir@ for GNU Guix
>>+DefaultDependencies=3Dno
>>+ConditionPathExists=3D@storedir@
>>+Before=3Dguix-daemon=2Eservice
>>+
>>+[Install]
>>+WantedBy=3Dguix-daemon=2Eservice
>>+
>>+[Mount]
>>+What=3D@storedir@
>>+Where=3D@storedir@
>>+Type=3Dnone
>>+Options=3Dbind,ro
>>diff --git a/etc/guix-install=2Esh b/etc/guix-install=2Esh
>>index 4909d3f162=2E=2Ed252c132fb 100755
>>--- a/etc/guix-install=2Esh
>>+++ b/etc/guix-install=2Esh
>>@@ -342,7 +342,13 @@ sys_enable_guix_daemon()
>>                 _msg "${PAS}enabled Guix daemon via upstart"
>>             ;;
>>         systemd)
>>-            { cp
>>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Ese=
rvice"
>>\
>>+            { # systemd =2Emount units must be named after the target
>>directory=2E
>>+              # Here we assume a hard-coded name of /gnu/store=2E
>>+              cp
>>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/gnu-store=2Emoun=
t"
>>\
>>+                 /etc/systemd/system/;
>>+              chmod 664 /etc/systemd/system/gnu-store=2Emount;
>>+
>>+              cp
>>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Ese=
rvice"
>>\
>>                  /etc/systemd/system/;
>>               chmod 664 /etc/systemd/system/guix-daemon=2Eservice;
>>=20
>>@@ -357,8 +363,8 @@ sys_enable_guix_daemon()
>> 	      fi;
>>=20
>>               systemctl daemon-reload &&
>>-                  systemctl start guix-daemon &&
>>-                  systemctl enable guix-daemon; } &&
>>+                  systemctl start  gnu-store=2Emount guix-daemon &&
>>+                  systemctl enable gnu-store=2Emount guix-daemon; } &&
>>                 _msg "${PAS}enabled Guix daemon via systemd"
>>             ;;
>>         sysv-init)
>>diff --git a/nix/local=2Emk b/nix/local=2Emk
>>index a64bdd2137=2E=2E435fdd389a 100644
>>--- a/nix/local=2Emk
>>+++ b/nix/local=2Emk
>>@@ -155,7 +155,17 @@ noinst_HEADERS =3D						\
>>=20
>> # The '=2Eservice' files for systemd=2E
>> systemdservicedir =3D $(libdir)/systemd/system
>>-nodist_systemdservice_DATA =3D etc/guix-daemon=2Eservice
>>etc/guix-publish=2Eservice
>>+nodist_systemdservice_DATA =3D			\
>>+  etc/gnu-store=2Emount				\
>>+  etc/guix-daemon=2Eservice			\
>>+  etc/guix-publish=2Eservice
>>+
>>+etc/%=2Emount: etc/%=2Emount=2Ein	\
>>+			 $(top_builddir)/config=2Estatus
>>+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";	\
>>+	$(SED) -e 's|@''storedir''@|$(storedir)|' <	\
>>+	       "$<" > "$@=2Etmp";		\
>>+	mv "$@=2Etmp" "$@"
>>=20
>> etc/guix-%=2Eservice: etc/guix-%=2Eservice=2Ein	\
>> 			 $(top_builddir)/config=2Estatus
>
>I see that's how it's done with the existing service, but why sed the
>=2Ein file when we could let configure=2Eac take care of it?
>
>I'll try that on a VM of a foreign distro soonish and report=2E Thanks!

I tested it on a debian VM and it worked well=2E I tested the installer sc=
ript and it fails at installing the =2Emount unit, because it does not exis=
t in the tarball=2E

After installing the unit manually, I could start the =2Emount service and=
 found that I was not able to remove store store items with rm=2E I checked=
 that Guix is able to install new store items=2E




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 14 May 2020 16:35:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 12:35:51 2020
Received: from localhost ([127.0.0.1]:34584 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZGpn-0000j7-N3
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 12:35:51 -0400
Received: from lists.gnu.org ([209.51.188.17]:50786)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1jZGpY-0000ie-Dm
 for submit <at> debbugs.gnu.org; Thu, 14 May 2020 12:35:38 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60686)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <julien@HIDDEN>)
 id 1jZGpY-0005Oj-6W
 for guix-patches@HIDDEN; Thu, 14 May 2020 12:35:32 -0400
Received: from lepiller.eu ([2a00:5884:8208::1]:45986)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <julien@HIDDEN>)
 id 1jZGpT-00028v-RF
 for guix-patches@HIDDEN; Thu, 14 May 2020 12:35:31 -0400
Received: from lepiller.eu (localhost [127.0.0.1])
 by lepiller.eu (OpenSMTPD) with ESMTP id 081242b0;
 Thu, 14 May 2020 16:35:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date
 :in-reply-to:references:mime-version:content-type
 :content-transfer-encoding:subject:to:from:message-id; s=dkim;
 bh=1uQJMRWdBdem92tZzO+DH+4Pk8jFiRNvI4x9znnSftk=; b=Li4zKtpQELLQ
 fgNruvbxTwDwT9Q953DcWJNIt//t5/G5g8xQCUK62dpUOLGisDPgTjIoZFbuDJ+s
 LWV1omCuXbeAa7WQGofXXv9Zd7/YwGby3v+Um2vWqKrRzVs8P0POhOGVPWxCRK8l
 UWjsRYMp7zAr+++V5+ijzRssjGR/ffUbrbG4pVuz1Vxd1YfImaOzSq1x9WlP8MeF
 2nb9G9Lno2Osd891rR3jhycP/DFu0mNVWlEy5BWzofV+djSveT/pZUmCfJUOZNAA
 9FpzHTx91IeeOaao8mxBWfgAV8W/3VcLOaFFyMKvOuHaZbzH256rYuklEDOg5V/y
 n1o6uh3SiA==
Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id fe7d552c
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 14 May 2020 16:35:24 +0000 (UTC)
Date: Thu, 14 May 2020 12:35:12 -0400
User-Agent: K-9 Mail for Android
In-Reply-To: <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
References: <20200514134846.29037-1-me@HIDDEN>
 <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount
 @storedir@ read-only.
To: guix-patches@HIDDEN, Tobias Geerinckx-Rice <me@HIDDEN>,
 41259 <at> debbugs.gnu.org
From: Julien Lepiller <julien@HIDDEN>
Message-ID: <A2F0E860-28E9-42A6-AE02-0BDBB876106E@HIDDEN>
Received-SPF: none client-ip=2a00:5884:8208::1;
 envelope-from=julien@HIDDEN; helo=lepiller.eu
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Le 14 mai 2020 10:01:51 GMT-04:00, Julien Lepiller <julien@lepiller=2Eeu> a=
 =C3=A9crit :
>Le 14 mai 2020 09:48:46 GMT-04:00, Tobias Geerinckx-Rice via
>Guix-patches via <guix-patches@gnu=2Eorg> a =C3=A9crit :
>>* etc/gnu-store=2Emount=2Ein: New file=2E
>>* nix/local=2Emk (nodist_systemdservice_DATA): Add it=2E
>>(etc/%=2Emount): New rule=2E
>>* etc/guix-install=2Esh (sys_enable_guix_daemon): Install it=2E
>>* doc/guix=2Etexi (Binary Installation): Document it=2E
>>---
>>
>>For
>><https://lists=2Egnu=2Eorg/archive/html/help-guix/2020-05/msg00097=2Ehtm=
l>=2E
>>
>> doc/guix=2Etexi          |  5 +++--
>> etc/gnu-store=2Emount=2Ein | 14 ++++++++++++++
>> etc/guix-install=2Esh    | 12 +++++++++---
>> nix/local=2Emk           | 12 +++++++++++-
>> 4 files changed, 37 insertions(+), 6 deletions(-)
>> create mode 100644 etc/gnu-store=2Emount=2Ein
>>
>>diff --git a/doc/guix=2Etexi b/doc/guix=2Etexi
>>index d6fbd85fde=2E=2E5d80a7e405 100644
>>--- a/doc/guix=2Etexi
>>+++ b/doc/guix=2Etexi
>>@@ -659,9 +659,10 @@ with these commands:
>> @c
>https://lists=2Egnu=2Eorg/archive/html/guix-devel/2017-01/msg01199=2Ehtml
>>=20
>> @example
>>-# cp
>~root/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eservice
>>\
>>+# cp ~root/=2Econfig/guix/current/lib/systemd/system/gnu-store=2Emount =
\
>>+   =20
>~root/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eservice
>>\
>>      /etc/systemd/system/
>>-# systemctl enable --now guix-daemon
>>+# systemctl enable --now gnu-store=2Emount guix-daemon
>> @end example
>>=20
>> If your host distro uses the Upstart init system:
>>diff --git a/etc/gnu-store=2Emount=2Ein b/etc/gnu-store=2Emount=2Ein
>>new file mode 100644
>>index 0000000000=2E=2Ec94f2db72b
>>--- /dev/null
>>+++ b/etc/gnu-store=2Emount=2Ein
>>@@ -0,0 +1,14 @@
>>+[Unit]
>>+Description=3DRead-only @storedir@ for GNU Guix
>>+DefaultDependencies=3Dno
>>+ConditionPathExists=3D@storedir@
>>+Before=3Dguix-daemon=2Eservice
>>+
>>+[Install]
>>+WantedBy=3Dguix-daemon=2Eservice
>>+
>>+[Mount]
>>+What=3D@storedir@
>>+Where=3D@storedir@
>>+Type=3Dnone
>>+Options=3Dbind,ro
>>diff --git a/etc/guix-install=2Esh b/etc/guix-install=2Esh
>>index 4909d3f162=2E=2Ed252c132fb 100755
>>--- a/etc/guix-install=2Esh
>>+++ b/etc/guix-install=2Esh
>>@@ -342,7 +342,13 @@ sys_enable_guix_daemon()
>>                 _msg "${PAS}enabled Guix daemon via upstart"
>>             ;;
>>         systemd)
>>-            { cp
>>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Ese=
rvice"
>>\
>>+            { # systemd =2Emount units must be named after the target
>>directory=2E
>>+              # Here we assume a hard-coded name of /gnu/store=2E
>>+              cp
>>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/gnu-store=2Emoun=
t"
>>\
>>+                 /etc/systemd/system/;
>>+              chmod 664 /etc/systemd/system/gnu-store=2Emount;
>>+
>>+              cp
>>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Ese=
rvice"
>>\
>>                  /etc/systemd/system/;
>>               chmod 664 /etc/systemd/system/guix-daemon=2Eservice;
>>=20
>>@@ -357,8 +363,8 @@ sys_enable_guix_daemon()
>> 	      fi;
>>=20
>>               systemctl daemon-reload &&
>>-                  systemctl start guix-daemon &&
>>-                  systemctl enable guix-daemon; } &&
>>+                  systemctl start  gnu-store=2Emount guix-daemon &&
>>+                  systemctl enable gnu-store=2Emount guix-daemon; } &&
>>                 _msg "${PAS}enabled Guix daemon via systemd"
>>             ;;
>>         sysv-init)
>>diff --git a/nix/local=2Emk b/nix/local=2Emk
>>index a64bdd2137=2E=2E435fdd389a 100644
>>--- a/nix/local=2Emk
>>+++ b/nix/local=2Emk
>>@@ -155,7 +155,17 @@ noinst_HEADERS =3D						\
>>=20
>> # The '=2Eservice' files for systemd=2E
>> systemdservicedir =3D $(libdir)/systemd/system
>>-nodist_systemdservice_DATA =3D etc/guix-daemon=2Eservice
>>etc/guix-publish=2Eservice
>>+nodist_systemdservice_DATA =3D			\
>>+  etc/gnu-store=2Emount				\
>>+  etc/guix-daemon=2Eservice			\
>>+  etc/guix-publish=2Eservice
>>+
>>+etc/%=2Emount: etc/%=2Emount=2Ein	\
>>+			 $(top_builddir)/config=2Estatus
>>+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";	\
>>+	$(SED) -e 's|@''storedir''@|$(storedir)|' <	\
>>+	       "$<" > "$@=2Etmp";		\
>>+	mv "$@=2Etmp" "$@"
>>=20
>> etc/guix-%=2Eservice: etc/guix-%=2Eservice=2Ein	\
>> 			 $(top_builddir)/config=2Estatus
>
>I see that's how it's done with the existing service, but why sed the
>=2Ein file when we could let configure=2Eac take care of it?
>
>I'll try that on a VM of a foreign distro soonish and report=2E Thanks!

I tested it on a debian VM and it worked well=2E I tested the installer sc=
ript and it fails at installing the =2Emount unit, because it does not exis=
t in the tarball=2E

After installing the unit manually, I could start the =2Emount service and=
 found that I was not able to remove store store items with rm=2E I checked=
 that Guix is able to install new store items=2E




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at 41259 <at> debbugs.gnu.org:


Received: (at 41259) by debbugs.gnu.org; 14 May 2020 14:25:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 10:25:30 2020
Received: from localhost ([127.0.0.1]:34351 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZEni-0005KV-Ly
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 10:25:30 -0400
Received: from tobias.gr ([80.241.217.52]:36136)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jZEng-0005KL-FI
 for 41259 <at> debbugs.gnu.org; Thu, 14 May 2020 10:25:29 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id dbb8268c;
 Thu, 14 May 2020 14:25:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=Mbc/huYYJhfVQMoP/vS1i7
 x379+RxaaxKBY200j4kiA=; b=n8wTkqY/xPekyA3hk3jZSRVw0qqrkqFyV6dCrd
 j8dzoYmBrzdV+WIZcyi+Qpt0Kc6Ky2mEDCNxcV2h4q1IezUVkvt75SOEPapChr1c
 1bihB742MGNW0mZ7NYXOiUMp+G2ic4+Mbb7jKjITfeEb6Emqox1uq+VflNZDZhzw
 9vH+vpMkQZZQPVl4na92W8z+aXPDtyYzAiEbju8Ek+TOT3eyxSfDsSZuys5HYylA
 khgCDBZhktjoBC5BW/z/GfVFLbr8ol1KjB7ECaM3GMW9j4BNlKzgNS+EGfh9qoE+
 vVSlVYgR5NNunbplqPvUFzM5lo27/QxU9j0HI5131Ko8C+gA==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id c7efcf27
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 14 May 2020 14:25:29 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: Marius Bakke <mbakke@HIDDEN>
Subject: Re: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount
 @storedir@ read-only.
References: <20200514134846.29037-1-me@HIDDEN>
 <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN> <874ksivc2p.fsf@HIDDEN>
In-reply-to: <874ksivc2p.fsf@HIDDEN>
Date: Thu, 14 May 2020 16:25:26 +0200
Message-ID: <87a72ad25l.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41259
Cc: 41259 <at> debbugs.gnu.org, Julien Lepiller <julien@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Marius Bakke =E5=86=99=E9=81=93=EF=BC=9A
>> I see that's how it's done with the existing service, but why=20
>> sed the .in file when we could let configure.ac take care of=20
>> it?
>
> Because --storedir can in theory be something like=20
> '$prefix/store',
> which would not get properly expanded by configure.

Makes sense.  Thanks Marius,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXr1U1wAKCRANsP+IT1Vt
eRdZAQDyT+fZ4xQ9PdYTdQqfGei6onS+7Jpsfhpx8G2/JqvPpgD+KNc74Bo1JRYl
IFs89KblIfNuiDm1zQUw2a/AHhW5Fgw=
=5ve1
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at 41259 <at> debbugs.gnu.org:


Received: (at 41259) by debbugs.gnu.org; 14 May 2020 14:24:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 10:24:37 2020
Received: from localhost ([127.0.0.1]:34329 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZEmr-0005HJ-LZ
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 10:24:37 -0400
Received: from tobias.gr ([80.241.217.52]:36128)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jZEmp-0005HA-TS
 for 41259 <at> debbugs.gnu.org; Thu, 14 May 2020 10:24:36 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id 4ba419c8;
 Thu, 14 May 2020 14:24:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=BrYKbG84c6dEZkL4FvEMge
 pAhc8E4Kkb7V6OqOdtOVs=; b=LHvOscATGUxpeCSLG1d4KWJU6UtAB0oqQmy1ul
 On1NX76A3fUC3WkXrJrGGvNHxNcIF6rVNiWLBotzMkYTh/gpwQyzL6KbDGHoRzoe
 IRS7ySEZLAt/C646PK6eawAPrOHScQ3xj19D3t4JbL4R2ziXClL2Eo7QXIAzLpc6
 qsagOC1JbadiFCeJP3wbxJG6hv27WZ2SFsK6BkAQ8R2PlwOuxRxXkGhH7y8X1Ujb
 uDcjKeXakQjomQkWGMzF6X3V/VNXDkUbYG/M1oUDaaNQZwgL1BCrI5p6ZpnrgV6W
 ZPnfWSF+SgurKCGpTCj1WOw7vmGHP0wU+W4rbUwSiohWJPog==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 6c9d0cb0
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 14 May 2020 14:24:36 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: Tobias Geerinckx-Rice via Guix-patches <guix-patches@HIDDEN>
Subject: Re: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount
 @storedir@ read-only.
References: <20200514134846.29037-1-me@HIDDEN>
In-reply-to: <20200514134846.29037-1-me@HIDDEN>
Date: Thu, 14 May 2020 16:24:34 +0200
Message-ID: <87d076d271.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41259
Cc: 41259 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Tobias Geerinckx-Rice via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A
>                systemctl daemon-reload &&
> -                  systemctl start guix-daemon &&
> -                  systemctl enable guix-daemon; } &&
> +                  systemctl start  gnu-store.mount guix-daemon=20
> &&
> +                  systemctl enable gnu-store.mount guix-daemon;=20
> } &&

Speaking of things I wondered: I'm no systemd wizard but I think=20
=E2=80=98enable --now=E2=80=99 would be equivalent and less repetitive.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXr1UogAKCRANsP+IT1Vt
eWv4AQDZMZ5apuYVzFkDo42bl9bYt69FkyWQSPW6qPp/347vOwD/cF4yNIQfwnkS
p5pFgNY8grEeCykMFwEN+iQ6NgVaLQA=
=OKPw
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 14 May 2020 14:24:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 10:24:42 2020
Received: from localhost ([127.0.0.1]:34333 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZEmv-0005Hc-US
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 10:24:42 -0400
Received: from lists.gnu.org ([209.51.188.17]:50408)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jZEmt-0005HS-JS
 for submit <at> debbugs.gnu.org; Thu, 14 May 2020 10:24:40 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40086)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1jZEmt-0007bS-BO
 for guix-patches@HIDDEN; Thu, 14 May 2020 10:24:39 -0400
Received: from tobias.gr ([2a02:c205:2020:6054::1]:41726)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1jZEmr-0006wz-RX
 for guix-patches@HIDDEN; Thu, 14 May 2020 10:24:38 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id 4ba419c8;
 Thu, 14 May 2020 14:24:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=BrYKbG84c6dEZkL4FvEMge
 pAhc8E4Kkb7V6OqOdtOVs=; b=LHvOscATGUxpeCSLG1d4KWJU6UtAB0oqQmy1ul
 On1NX76A3fUC3WkXrJrGGvNHxNcIF6rVNiWLBotzMkYTh/gpwQyzL6KbDGHoRzoe
 IRS7ySEZLAt/C646PK6eawAPrOHScQ3xj19D3t4JbL4R2ziXClL2Eo7QXIAzLpc6
 qsagOC1JbadiFCeJP3wbxJG6hv27WZ2SFsK6BkAQ8R2PlwOuxRxXkGhH7y8X1Ujb
 uDcjKeXakQjomQkWGMzF6X3V/VNXDkUbYG/M1oUDaaNQZwgL1BCrI5p6ZpnrgV6W
 ZPnfWSF+SgurKCGpTCj1WOw7vmGHP0wU+W4rbUwSiohWJPog==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 6c9d0cb0
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 14 May 2020 14:24:36 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: Tobias Geerinckx-Rice via Guix-patches <guix-patches@HIDDEN>
Subject: Re: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount
 @storedir@ read-only.
References: <20200514134846.29037-1-me@HIDDEN>
In-reply-to: <20200514134846.29037-1-me@HIDDEN>
Date: Thu, 14 May 2020 16:24:34 +0200
Message-ID: <87d076d271.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN;
 helo=tobias.gr
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: 41259 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Tobias Geerinckx-Rice via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A
>                systemctl daemon-reload &&
> -                  systemctl start guix-daemon &&
> -                  systemctl enable guix-daemon; } &&
> +                  systemctl start  gnu-store.mount guix-daemon=20
> &&
> +                  systemctl enable gnu-store.mount guix-daemon;=20
> } &&

Speaking of things I wondered: I'm no systemd wizard but I think=20
=E2=80=98enable --now=E2=80=99 would be equivalent and less repetitive.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXr1UogAKCRANsP+IT1Vt
eWv4AQDZMZ5apuYVzFkDo42bl9bYt69FkyWQSPW6qPp/347vOwD/cF4yNIQfwnkS
p5pFgNY8grEeCykMFwEN+iQ6NgVaLQA=
=OKPw
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at 41259 <at> debbugs.gnu.org:


Received: (at 41259) by debbugs.gnu.org; 14 May 2020 14:21:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 10:21:24 2020
Received: from localhost ([127.0.0.1]:34320 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZEjj-0005BM-Pk
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 10:21:24 -0400
Received: from tobias.gr ([80.241.217.52]:36112)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jZEje-0005B7-0Y
 for 41259 <at> debbugs.gnu.org; Thu, 14 May 2020 10:21:21 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id 60625a5e;
 Thu, 14 May 2020 14:21:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=RGHbkY7XAkZStEwuTaU47i
 8SRAmACqW9RVKAUbBNDYs=; b=S0769dhZ0cUhS3iKkPY8vcc1wkHQPu60+ZF2nt
 yI1Y9SE2ttnMiMsbYCVKCcd4iTSt9/VzgTvxFoNcnijLrTj27g1z39NLjqg0UWTs
 aEHYc9NNtO2OdmtdSctqHhMyEyl2Teey/+1KDlIfzoeOx0DGnY3A0G7Cuzkko+qB
 L+1fWfq9M5PH8Zgf5/QkQZ0xEDmO40GYDMxXrTuwP9Vgek3xlODyqkoSnxztr6Kj
 fv4ljSe/LDKkAazm9ncuppkaci91xcEI62dGuSj7joPrLKnsWGntGziuRq74W4Q/
 nM5pfWz7b0q0wLH7i7WIAfdREu3+sXvfVz0Djcw26LVvFOEQ==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id ad010ad7
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 14 May 2020 14:21:18 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: Julien Lepiller <julien@HIDDEN>
Subject: Re: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount
 @storedir@ read-only.
References: <20200514134846.29037-1-me@HIDDEN>
 <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
In-reply-to: <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
Date: Thu, 14 May 2020 16:21:16 +0200
Message-ID: <87ftc2d2cj.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41259
Cc: 41259 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Julien,

Julien Lepiller =E5=86=99=E9=81=93=EF=BC=9A
>> etc/guix-%.service: etc/guix-%.service.in	\
>> 			 $(top_builddir)/config.status
>
> I see that's how it's done with the existing service, but why=20
> sed the .in file when we could let configure.ac take care of it?

=C2=AF\_(=E3=83=84)_/=C2=AF!

TBH I wondered the same thing but am not in deep-dive mode ATM.

> I'll try that on a VM of a foreign distro soonish and=20
> report. Thanks!

Thank you!  I'm still in the middle of reinstalling Guix on my=20
main laptop, which should give me back my magical KVM powers.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXr1T3AAKCRANsP+IT1Vt
ecx8AP9pb5Q0pC27b9Ucx7eRLU+s5L5SzpmdM4S6TIN3BeTfcAD/UHTAg7usE1X8
T9QUkEFzinrOZuvsJZJPXbD7lDNzUgs=
=P4td
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at 41259 <at> debbugs.gnu.org:


Received: (at 41259) by debbugs.gnu.org; 14 May 2020 14:14:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 10:14:11 2020
Received: from localhost ([127.0.0.1]:34289 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZEcg-0004w9-Aj
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 10:14:11 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:43515)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mbakke@HIDDEN>) id 1jZEca-0004vC-2p
 for 41259 <at> debbugs.gnu.org; Thu, 14 May 2020 10:14:03 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id A84475C0046;
 Thu, 14 May 2020 10:13:53 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Thu, 14 May 2020 10:13:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h=
 from:to:subject:in-reply-to:references:date:message-id
 :mime-version:content-type; s=fm2; bh=5fcAH9tulVXXHJmsWCJp/2N/Ya
 ZU+yDkHFdUof3rcIQ=; b=j9wRzGopguSbuNeej7jQ1p1j8RY6mzm8nw9k97RMTQ
 PuPxHOtBJtiUrPi3BxkUlgKT5Gnr2uPJniHSDX9sLjG+lyR2Wh4q3GPE7FgjaFPj
 CkvwVrmZPeGbuueNx946k9UINH5CeEjgJc0yC6MoeVlK5D9GOHD5FAy1PBu3CGel
 RxU3Nb6oLWyL+DpwuhoI11SWK4LpxVu16AHSG+VDK9VCc5LWSk3bTgGuTBBEQN+G
 5/G1OQM5477YP88p1dbw4IYzT++XXoKb50zuLmaFo/cAkJu6OEBteI2cv2S6ydGI
 oBvO2yeHP6kN3GED5twaO6anFkVwsWp8iU1gY9FvL/YA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5fcAH9
 tulVXXHJmsWCJp/2N/YaZU+yDkHFdUof3rcIQ=; b=WqkFXf2eV5SIU1Vp43Xndj
 GR3gLHqd0IwE0dEoyLV7+NKDcuX8hsebgsbeQwbEnjx67MnByZh1xT2BmPPI0Iz8
 JJ/WOMkZPEt27y5dTRmevXmLwuma2f6gnUwF3B+tCoFDTxH5s8WXlMj9LH41boQ0
 X99PZuvVQlPYQk1pqA9hR/ImhooDBIyUAxVRow4noRdZ9HJFFJ4KaaITcW8u7HbZ
 daegWr7vo/6T2ah1+eRL6yMz4Npd5MYIo+9yiP5xEDIcUtnVMo6QnWpbbSXt5ElE
 7XtTbqHJw8y84ZiiUGXwzneCSZznzlzVBaTaYhoXZxND31oQaPTiJOxFnq8bgv6w
 ==
X-ME-Sender: <xms:IVK9Xvs95G8tzxcFZB4nNvKc7t2g-FhhAhZgdtVZcM60E5ptHdMY8g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleeigdejtdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepofgrrhhiuhhs
 uceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecuggftrfgrth
 htvghrnhepkedugeeiledvvdegieelffejudeitdfggfeiieffheduhffgvefhueeigffh
 heeknecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeekgedrvddtvddrieekrdejhe
 enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggr
 khhkvgesfhgrshhtmhgrihhlrdgtohhm
X-ME-Proxy: <xmx:IVK9XgcCOMmgF-cKAHOmc7SNorgyiVyUYi0l4RzjWw9akZ0OVD937w>
 <xmx:IVK9Xix_f-YhMRLpGQsrHlsXEqv22tPboUJYy5kJYCzNHI3pGCeV8Q>
 <xmx:IVK9XuMZ_lm-ivQZFTUHy41fNU_3SMjEQ2N0JUKL0z1ArRS-YcRYRA>
 <xmx:IVK9XsLOQc0nRFGM-LFTqPRHXVLeU-Ux4FiOhCkMZt2-LMseNiKzlw>
Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75])
 by mail.messagingengine.com (Postfix) with ESMTPA id AF4A13060EF5;
 Thu, 14 May 2020 10:13:52 -0400 (EDT)
From: Marius Bakke <mbakke@HIDDEN>
To: Julien Lepiller <julien@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>,
 41259 <at> debbugs.gnu.org
Subject: Re: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount
 @storedir@ read-only.
In-Reply-To: <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
References: <20200514134846.29037-1-me@HIDDEN>
 <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3
 (x86_64-pc-linux-gnu)
Date: Thu, 14 May 2020 16:13:50 +0200
Message-ID: <874ksivc2p.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41259
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Julien Lepiller <julien@HIDDEN> writes:

>>+etc/%.mount: etc/%.mount.in	\
>>+			 $(top_builddir)/config.status
>>+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";	\
>>+	$(SED) -e 's|@''storedir''@|$(storedir)|' <	\
>>+	       "$<" > "$@.tmp";		\
>>+	mv "$@.tmp" "$@"
>>=20
>> etc/guix-%.service: etc/guix-%.service.in	\
>> 			 $(top_builddir)/config.status
>
> I see that's how it's done with the existing service, but why sed the .in=
 file when we could let configure.ac take care of it?

Because --storedir can in theory be something like '$prefix/store',
which would not get properly expanded by configure.  See "Installation
Directory Variables" in the GNU Autoconf manual:

  https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/=
html_node/Installation-Directory-Variables.html

(in particular scroll down to the notice about AC_CONFIG_FILES)

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl69Uh4ACgkQoqBt8qM6
VPociQf9EQ1BTKTs33f/6L5L3OoHTTGwOSxg5gzbx0PtceI9968Cr1wcYn/z7AD5
TEam6RJnwcwoZiSiXyXS5+ls/52fxjh86vAjFRV6ghULbCZeolSPVnnU9ZaMtWAx
MZhOzeYWecQUWdj0GZRWuTNUQ9ffxxPrRAvqa7eClbrELEpSu3dj6VrtBkzSVa3/
RDNQGYrrUrHshQHwr2/P1Io9UfGctQZ8eTl0wmUM7Vt4AAVQav+JNyGQ4b1DLtRK
IteWbLPmeYo2fT+MH5OwYtnWoQnOQnk+Y7u3NJO3XuiV3WSWidYG5diAEcYGPNlf
KAroIxiMqLMJ+1JJOSGuPtifufoBOQ==
=7zsJ
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at 41259 <at> debbugs.gnu.org:


Received: (at 41259) by debbugs.gnu.org; 14 May 2020 14:02:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 10:02:12 2020
Received: from localhost ([127.0.0.1]:34273 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZER5-0004bg-3u
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 10:02:12 -0400
Received: from lepiller.eu ([89.234.186.109]:57550)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1jZEQz-0004bD-W9
 for 41259 <at> debbugs.gnu.org; Thu, 14 May 2020 10:02:06 -0400
Received: from lepiller.eu (localhost [127.0.0.1])
 by lepiller.eu (OpenSMTPD) with ESMTP id 3a38144a;
 Thu, 14 May 2020 14:01:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date
 :in-reply-to:references:mime-version:content-type
 :content-transfer-encoding:subject:to:from:message-id; s=dkim;
 bh=O9myuVDsxP+laz7OC0gZvSGjM4uIVIMyJbjLsuPRI8U=; b=W1lRbQpo0tXK
 a6ZFHTaFu0sUHIZ0LxDx8BqPrypnFn7ws1kMEpZExFCq6YFyxgXPqYcWQXMvgrZf
 b3MdN/p9P7mL2joku241AQnMdV2C9yEAFdxuCFuX/0UkLJNvPsAWxSbBItRBQ8hL
 0rGCc7P/q5J/U/Oonvyx3K1S2Fba8jpdA5SgEFnu9P8jgyIVLQJr/Pc+YLQhKnUI
 uNTmgSA1U4wBs1eLUQVmY87oOqcMTWaGuqVSyhBLdkArf/3x1lpu2fZp21kelYU/
 evzgRfW1w6QUBsQxbIkxf18GyHLoveH5LR6X7oZIhY/W+eaW2bTJT3j9e4MnRSko
 dA5bkgKiqg==
Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id cc033e1b
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 14 May 2020 14:01:59 +0000 (UTC)
Date: Thu, 14 May 2020 10:01:51 -0400
User-Agent: K-9 Mail for Android
In-Reply-To: <20200514134846.29037-1-me@HIDDEN>
References: <20200514134846.29037-1-me@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [bug#41259] [PATCH] etc: Add a systemd unit to bind-mount
 @storedir@ read-only.
To: Tobias Geerinckx-Rice <me@HIDDEN>,41259 <at> debbugs.gnu.org
From: Julien Lepiller <julien@HIDDEN>
Message-ID: <A93A189C-73FB-4E7F-B1F7-B57A1366ABA3@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 41259
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Le 14 mai 2020 09:48:46 GMT-04:00, Tobias Geerinckx-Rice via Guix-patches v=
ia <guix-patches@gnu=2Eorg> a =C3=A9crit :
>* etc/gnu-store=2Emount=2Ein: New file=2E
>* nix/local=2Emk (nodist_systemdservice_DATA): Add it=2E
>(etc/%=2Emount): New rule=2E
>* etc/guix-install=2Esh (sys_enable_guix_daemon): Install it=2E
>* doc/guix=2Etexi (Binary Installation): Document it=2E
>---
>
>For
><https://lists=2Egnu=2Eorg/archive/html/help-guix/2020-05/msg00097=2Ehtml=
>=2E
>
> doc/guix=2Etexi          |  5 +++--
> etc/gnu-store=2Emount=2Ein | 14 ++++++++++++++
> etc/guix-install=2Esh    | 12 +++++++++---
> nix/local=2Emk           | 12 +++++++++++-
> 4 files changed, 37 insertions(+), 6 deletions(-)
> create mode 100644 etc/gnu-store=2Emount=2Ein
>
>diff --git a/doc/guix=2Etexi b/doc/guix=2Etexi
>index d6fbd85fde=2E=2E5d80a7e405 100644
>--- a/doc/guix=2Etexi
>+++ b/doc/guix=2Etexi
>@@ -659,9 +659,10 @@ with these commands:
> @c https://lists=2Egnu=2Eorg/archive/html/guix-devel/2017-01/msg01199=2E=
html
>=20
> @example
>-# cp ~root/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eservi=
ce
>\
>+# cp ~root/=2Econfig/guix/current/lib/systemd/system/gnu-store=2Emount \
>+     ~root/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eservi=
ce
>\
>      /etc/systemd/system/
>-# systemctl enable --now guix-daemon
>+# systemctl enable --now gnu-store=2Emount guix-daemon
> @end example
>=20
> If your host distro uses the Upstart init system:
>diff --git a/etc/gnu-store=2Emount=2Ein b/etc/gnu-store=2Emount=2Ein
>new file mode 100644
>index 0000000000=2E=2Ec94f2db72b
>--- /dev/null
>+++ b/etc/gnu-store=2Emount=2Ein
>@@ -0,0 +1,14 @@
>+[Unit]
>+Description=3DRead-only @storedir@ for GNU Guix
>+DefaultDependencies=3Dno
>+ConditionPathExists=3D@storedir@
>+Before=3Dguix-daemon=2Eservice
>+
>+[Install]
>+WantedBy=3Dguix-daemon=2Eservice
>+
>+[Mount]
>+What=3D@storedir@
>+Where=3D@storedir@
>+Type=3Dnone
>+Options=3Dbind,ro
>diff --git a/etc/guix-install=2Esh b/etc/guix-install=2Esh
>index 4909d3f162=2E=2Ed252c132fb 100755
>--- a/etc/guix-install=2Esh
>+++ b/etc/guix-install=2Esh
>@@ -342,7 +342,13 @@ sys_enable_guix_daemon()
>                 _msg "${PAS}enabled Guix daemon via upstart"
>             ;;
>         systemd)
>-            { cp
>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eser=
vice"
>\
>+            { # systemd =2Emount units must be named after the target
>directory=2E
>+              # Here we assume a hard-coded name of /gnu/store=2E
>+              cp
>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/gnu-store=2Emount=
"
>\
>+                 /etc/systemd/system/;
>+              chmod 664 /etc/systemd/system/gnu-store=2Emount;
>+
>+              cp
>"${ROOT_HOME}/=2Econfig/guix/current/lib/systemd/system/guix-daemon=2Eser=
vice"
>\
>                  /etc/systemd/system/;
>               chmod 664 /etc/systemd/system/guix-daemon=2Eservice;
>=20
>@@ -357,8 +363,8 @@ sys_enable_guix_daemon()
> 	      fi;
>=20
>               systemctl daemon-reload &&
>-                  systemctl start guix-daemon &&
>-                  systemctl enable guix-daemon; } &&
>+                  systemctl start  gnu-store=2Emount guix-daemon &&
>+                  systemctl enable gnu-store=2Emount guix-daemon; } &&
>                 _msg "${PAS}enabled Guix daemon via systemd"
>             ;;
>         sysv-init)
>diff --git a/nix/local=2Emk b/nix/local=2Emk
>index a64bdd2137=2E=2E435fdd389a 100644
>--- a/nix/local=2Emk
>+++ b/nix/local=2Emk
>@@ -155,7 +155,17 @@ noinst_HEADERS =3D						\
>=20
> # The '=2Eservice' files for systemd=2E
> systemdservicedir =3D $(libdir)/systemd/system
>-nodist_systemdservice_DATA =3D etc/guix-daemon=2Eservice
>etc/guix-publish=2Eservice
>+nodist_systemdservice_DATA =3D			\
>+  etc/gnu-store=2Emount				\
>+  etc/guix-daemon=2Eservice			\
>+  etc/guix-publish=2Eservice
>+
>+etc/%=2Emount: etc/%=2Emount=2Ein	\
>+			 $(top_builddir)/config=2Estatus
>+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";	\
>+	$(SED) -e 's|@''storedir''@|$(storedir)|' <	\
>+	       "$<" > "$@=2Etmp";		\
>+	mv "$@=2Etmp" "$@"
>=20
> etc/guix-%=2Eservice: etc/guix-%=2Eservice=2Ein	\
> 			 $(top_builddir)/config=2Estatus

I see that's how it's done with the existing service, but why sed the =2Ei=
n file when we could let configure=2Eac take care of it?

I'll try that on a VM of a foreign distro soonish and report=2E Thanks!




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at 41259 <at> debbugs.gnu.org:


Received: (at 41259) by debbugs.gnu.org; 14 May 2020 13:53:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 09:53:40 2020
Received: from localhost ([127.0.0.1]:60708 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZEIu-0003sN-PB
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 09:53:40 -0400
Received: from tobias.gr ([80.241.217.52]:35942)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jZEIt-0003sF-BX
 for 41259 <at> debbugs.gnu.org; Thu, 14 May 2020 09:53:40 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id 5ba8c527;
 Thu, 14 May 2020 13:53:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc
 :subject:references:in-reply-to:date:message-id:mime-version
 :content-type; s=2018; i=me@HIDDEN; bh=QUn//s7chuWSVftoV1T7GQ
 TRTxciPf4wK7RYcgQxR1I=; b=GKR5HemW/7rqNUW9naVu6EwJmCTZQpXBQC7SYr
 5HrYMSD5mRgj32sdLeU19ag1BQywD/DWg8l8MeNlxo01U0do4xQpklI8fgTQAikH
 ZrWluVVV/8dRPsUl+0rIIZW+CVDZvh0SGJvLBA25eRbX3CCF7wYf+a/PbDXXT/C1
 3hzVp9VPStRMPgPpssUyPCJRvQI3uC/yhS+qpVgdtkmkc8fONTtAdpX6cBcHgr+X
 ZXfVxoQvSzTzlkloDaY5PgpLYx3zpEjchu42gk1+80U8dItmCZmcUG4drWgwKrp/
 pFGmW6aVaqB9k+dDI7+CFJ9y/r97FkR/gueS8zp1IG5qNTgg==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id f41cde13
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Thu, 14 May 2020 13:53:39 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: Emmanuel Medernach <emmanuel.medernach@HIDDEN>,
 zimoun <zimon.toutoune@HIDDEN>, help-guix@HIDDEN
Subject: Re: Few questions
References: <CAC_pKx_Zi6Hm3yTq6jH4vAC=ESYqOmOtdaYsZWi25jtT0t8d_w@HIDDEN>
 <CAJ3okZ2qdTR5qsi6UkkUZM-eWEVHBLhv14biHSa6-cEko0qm6Q@HIDDEN>
 <CAC_pKx9OwELG2S7oQrJ4TVUisyV7pQg+t7r_8xD7b7-3_E7SVw@HIDDEN>
 <CAJ3okZ3vFkTqgUp+Eo_SwOdnDmkWj8Z5kes8b=g1548S2JvCbg@HIDDEN>
 <CAC_pKx9RkCiD5mQOHnHszGPhPvx56nNs9C+xeY302O__mPds6g@HIDDEN>
 <CAJ3okZ2s6qqNVSv4Xjo78Sbycc040oHFHmBrvBdeCiOp+QZ1BQ@HIDDEN>
 <CAC_pKx8KfOTdoHgVTeGsQU-iP7rH84dwQX43JjPc7vBz=7cuWA@HIDDEN>
 <878shueopr.fsf@nckx> <875zcyeomd.fsf@nckx>
 <CAC_pKx8su+z4ok5ZvyM6whnrJmE1vsVt=Op705sdt9TD=dCDdA@HIDDEN>
 <87r1vmd7h6.fsf@nckx>
In-reply-to: <87r1vmd7h6.fsf@nckx>
Date: Thu, 14 May 2020 15:53:36 +0200
Message-ID: <87lflud3mn.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41259
Cc: 41259 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Tobias Geerinckx-Rice =E5=86=99=E9=81=93=EF=BC=9A
> A simple
>
>  $ sudo mount -o bind,ro /gnu/store /gnu/store

I decided to write a q&d patch that does just that=20
<https://issues.guix.gnu.org/41259>.

Caveats:
=2D It's lightly tested (the only non-Guix System I have SSH access=20
  to is someone's laptop, currently being used to consume =E2=80=98dank=20
  memes=E2=80=99, and I cannot risk performing any action that could stop=20
  the flow of memes),
=2D it only fixes the problem on modern^Wsystemd systems (I'm fine=20
  with that),
=2D the unit name could be templated to @storedir@ as well.  Worth=20
  it?

Feedback and testing welcome.

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXr1NYAAKCRANsP+IT1Vt
eanNAQD8840t6rLLSG6porbp1niAih1kOag/WWyIRigHam2yCgD/UAURG1ss9iq2
2zPbzqsf+7fsj/WFH/+dJrvjCBF0mAE=
=1d69
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 14 May 2020 13:49:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 09:49:15 2020
Received: from localhost ([127.0.0.1]:60699 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZEEX-0003kJ-P4
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 09:49:15 -0400
Received: from lists.gnu.org ([209.51.188.17]:59236)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1jZEES-0003k8-C5
 for submit <at> debbugs.gnu.org; Thu, 14 May 2020 09:49:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:34432)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1jZEES-0007JR-4p
 for guix-patches@HIDDEN; Thu, 14 May 2020 09:49:04 -0400
Received: from tobias.gr ([2a02:c205:2020:6054::1]:41504)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1jZEEN-0006GS-7I
 for guix-patches@HIDDEN; Thu, 14 May 2020 09:49:03 -0400
Received: by tobias.gr (OpenSMTPD) with ESMTP id 9ce5d4d9
 for <guix-patches@HIDDEN>; Thu, 14 May 2020 13:48:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to
 :subject:date:message-id:mime-version:content-transfer-encoding;
 s=2018; i=me@HIDDEN; bh=xgc+nzsdeOC1rDBHOHqeTlft0tjSAcIlEwnc
 CAyVFBM=; b=RL9m0Thipb+SQ9KWvxxgTolkGGA0x1UOOrz4wC2JliM8HboxwG1k
 GFj2hfCh/WITEO4ohaoiYaJjlt0aJDr5vhq/JOMJrxkJWMqlxtvMkNIgjwUHHMLM
 yErmd2lChO00UG0VbOgNRtPyLqofvob7aeIlZ7HdcH0H+gE0VM+dz2pkW//np59J
 jGsA2FIXvdIXjKkRPfMyWoBwm8QQUU9qvKHeFPpRlCpmMrgsgLDnzjSnqXcK1POw
 mpfRcGz9gaiOf2KIF9P13FyC8kPMSuGe1+wcg0Okwijm+s+obc9P7dFfVvfxRMg6
 p8LilHCehaK+LG/Pa/e2xZbesVq4Uwjq3g==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id ea89ff14
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO)
 for <guix-patches@HIDDEN>; Thu, 14 May 2020 13:48:55 +0000 (UTC)
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] etc: Add a systemd unit to bind-mount @storedir@ read-only.
Date: Thu, 14 May 2020 15:48:46 +0200
Message-Id: <20200514134846.29037-1-me@HIDDEN>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN;
 helo=tobias.gr
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

* etc/gnu-store.mount.in: New file.
* nix/local.mk (nodist_systemdservice_DATA): Add it.
(etc/%.mount): New rule.
* etc/guix-install.sh (sys_enable_guix_daemon): Install it.
* doc/guix.texi (Binary Installation): Document it.
---

For <https://lists.gnu.org/archive/html/help-guix/2020-05/msg00097.html>.

 doc/guix.texi          |  5 +++--
 etc/gnu-store.mount.in | 14 ++++++++++++++
 etc/guix-install.sh    | 12 +++++++++---
 nix/local.mk           | 12 +++++++++++-
 4 files changed, 37 insertions(+), 6 deletions(-)
 create mode 100644 etc/gnu-store.mount.in

diff --git a/doc/guix.texi b/doc/guix.texi
index d6fbd85fde..5d80a7e405 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -659,9 +659,10 @@ with these commands:
 @c https://lists.gnu.org/archive/html/guix-devel/2017-01/msg01199.html
 
 @example
-# cp ~root/.config/guix/current/lib/systemd/system/guix-daemon.service \
+# cp ~root/.config/guix/current/lib/systemd/system/gnu-store.mount \
+     ~root/.config/guix/current/lib/systemd/system/guix-daemon.service \
      /etc/systemd/system/
-# systemctl enable --now guix-daemon
+# systemctl enable --now gnu-store.mount guix-daemon
 @end example
 
 If your host distro uses the Upstart init system:
diff --git a/etc/gnu-store.mount.in b/etc/gnu-store.mount.in
new file mode 100644
index 0000000000..c94f2db72b
--- /dev/null
+++ b/etc/gnu-store.mount.in
@@ -0,0 +1,14 @@
+[Unit]
+Description=Read-only @storedir@ for GNU Guix
+DefaultDependencies=no
+ConditionPathExists=@storedir@
+Before=guix-daemon.service
+
+[Install]
+WantedBy=guix-daemon.service
+
+[Mount]
+What=@storedir@
+Where=@storedir@
+Type=none
+Options=bind,ro
diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 4909d3f162..d252c132fb 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -342,7 +342,13 @@ sys_enable_guix_daemon()
                 _msg "${PAS}enabled Guix daemon via upstart"
             ;;
         systemd)
-            { cp "${ROOT_HOME}/.config/guix/current/lib/systemd/system/guix-daemon.service" \
+            { # systemd .mount units must be named after the target directory.
+              # Here we assume a hard-coded name of /gnu/store.
+              cp "${ROOT_HOME}/.config/guix/current/lib/systemd/system/gnu-store.mount" \
+                 /etc/systemd/system/;
+              chmod 664 /etc/systemd/system/gnu-store.mount;
+
+              cp "${ROOT_HOME}/.config/guix/current/lib/systemd/system/guix-daemon.service" \
                  /etc/systemd/system/;
               chmod 664 /etc/systemd/system/guix-daemon.service;
 
@@ -357,8 +363,8 @@ sys_enable_guix_daemon()
 	      fi;
 
               systemctl daemon-reload &&
-                  systemctl start guix-daemon &&
-                  systemctl enable guix-daemon; } &&
+                  systemctl start  gnu-store.mount guix-daemon &&
+                  systemctl enable gnu-store.mount guix-daemon; } &&
                 _msg "${PAS}enabled Guix daemon via systemd"
             ;;
         sysv-init)
diff --git a/nix/local.mk b/nix/local.mk
index a64bdd2137..435fdd389a 100644
--- a/nix/local.mk
+++ b/nix/local.mk
@@ -155,7 +155,17 @@ noinst_HEADERS =						\
 
 # The '.service' files for systemd.
 systemdservicedir = $(libdir)/systemd/system
-nodist_systemdservice_DATA = etc/guix-daemon.service etc/guix-publish.service
+nodist_systemdservice_DATA =			\
+  etc/gnu-store.mount				\
+  etc/guix-daemon.service			\
+  etc/guix-publish.service
+
+etc/%.mount: etc/%.mount.in	\
+			 $(top_builddir)/config.status
+	$(AM_V_GEN)$(MKDIR_P) "`dirname $@`";	\
+	$(SED) -e 's|@''storedir''@|$(storedir)|' <	\
+	       "$<" > "$@.tmp";		\
+	mv "$@.tmp" "$@"
 
 etc/guix-%.service: etc/guix-%.service.in	\
 			 $(top_builddir)/config.status
-- 
2.26.2





Acknowledgement sent to Tobias Geerinckx-Rice <me@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#41259; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 14 May 2020 19:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.