GNU bug report logs - #41276
[PATCH 0/9] Various small improvements to EasyPG

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Jonas Bernoulli <jonas@HIDDEN>; Keywords: patch; merged with #41268, #41269, #41270, #41271, #41272, #41273, #41274, #41275, #41277; dated Thu, 14 May 2020 19:14:07 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 15 May 2020 11:27:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 15 07:27:14 2020
Received: from localhost ([127.0.0.1]:36056 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZYUk-0007YW-Cs
	for submit <at> debbugs.gnu.org; Fri, 15 May 2020 07:27:14 -0400
Received: from mail.hostpark.net ([212.243.197.30]:57772)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZYUi-0007YN-6L
 for 41276 <at> debbugs.gnu.org; Fri, 15 May 2020 07:27:13 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id B6059166AF;
 Fri, 15 May 2020 13:27:10 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id lhJZEPay2nTw; Fri, 15 May 2020 13:27:10 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 68B15166AB;
 Fri, 15 May 2020 13:27:10 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#41276: Acknowledgement ([PATCH 0/9] Various small
 improvements to EasyPG)
In-Reply-To: <83o8qp3bgq.fsf@HIDDEN>
References: <20200514191325.22061-1-jonas@HIDDEN>
 <handler.41276.B.15894836275636.ack <at> debbugs.gnu.org>
 <87sgg26zpv.fsf@HIDDEN> <83o8qp3bgq.fsf@HIDDEN>
Date: Fri, 15 May 2020 13:27:10 +0200
Message-ID: <87pnb5781d.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
Cc: 41276 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Eli Zaretskii <eliz@HIDDEN> writes:
> A few of the patches in the series don't have commit log messages,

All of the patches do have commit messages.  The mail subject field is
used as the commit message subject line, except that the "[PATCH n/m] "
has to be removed.

> or
> the commit log messages are not in our usual format (see CONTRIBUTE,
> and also look at the other commits in the repository for examples).

I tried to follow the conventions and I did look at examples, but not
everything is crystal clear and I made some mistakes and did take some
liberties.  I am reworking the commit messages and will later publish
a new iteration.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 15 May 2020 09:33:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 15 05:33:05 2020
Received: from localhost ([127.0.0.1]:35857 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZWiH-0004Yc-D1
	for submit <at> debbugs.gnu.org; Fri, 15 May 2020 05:33:05 -0400
Received: from mail-wr1-f41.google.com ([209.85.221.41]:38331)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rpluim@HIDDEN>) id 1jZWiF-0004Y7-DX
 for 41276 <at> debbugs.gnu.org; Fri, 15 May 2020 05:33:03 -0400
Received: by mail-wr1-f41.google.com with SMTP id e1so2723975wrt.5
 for <41276 <at> debbugs.gnu.org>; Fri, 15 May 2020 02:33:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :mime-version:content-transfer-encoding;
 bh=ADhKaR8x+fzlrGWddTe0l1fb2Vf7aqIqbWq66Y0SwG8=;
 b=Ser/AHtD6sbDjovQV8db/lUM3xx4AqdD8y1sEfOaNtzohf3Jbq6Cte772QvP5EhqIi
 yJTRpfK5exquXKFtXB7iRTN/Lc/jDNRki8tIWkSdOMCysZVh1P1MHBa9nZR6TcuXqQOE
 GkhXx7rIxGd/n476l/Bh9iGeyfyF0UcJbW2Cg1WNs09+RMlUn9hhV1VqAiRQqVQwhS96
 GpJuMLAF/ZHZuopwTbqtq9gf17aJPq9Jyp/3XFaNRjrd+zJpbEC9XFl9kdwiW5znAINJ
 5Sp5ZrvPXkZQWrYe+DfXWVvxTSepGAmwqwEKABkMGwclHJBr06Lr18+d/+jiM8F3Ve6A
 BB3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:mime-version:content-transfer-encoding;
 bh=ADhKaR8x+fzlrGWddTe0l1fb2Vf7aqIqbWq66Y0SwG8=;
 b=qoNTKMSX5aEAMu3VBvP0VCwjpB4Pg0TA9XCDwVxqDX1Z9FPXdirYcRYJBQFho8+hc3
 6OFqgg4oSmZzDrNZx9FHMweieJKV4K1vNqaTKj/2cemb1m+L0ohjuWCBvSTFwL+CH1YM
 mXl8AKmLHydH5MWqf6SDO8MVdEkGJZ55JZYqINAWJqN6sXzUGXoJr3dn7fQS53bYk0HN
 hlMfA+hR9OpQFWO0AcbuozxlcaWv8//UGeaE47v9Kgro0qdWTZpxwKBL1KJX9ariN6v+
 SH+xXVoyklqJXmAdM8+HYqtwFj8OcHiqo1zJn6XhdlhaNRCR+69GlFlmtGR/lijpYcJC
 TW8Q==
X-Gm-Message-State: AOAM530NL7GQm7SmIx1MMrVQqi0AyYscxz8HGmEkUpLPA+drBe3fsYoA
 pXh6V/6YsZuG6rHqLMiM5jJUqveuvM1GcA==
X-Google-Smtp-Source: ABdhPJzMeeGfFZoZ3rIO2742NvsJb1uvyEy3cCbCTNFZuN5I/Z8yTJ3w62961uLEvqXPfQ/yjkzaTQ==
X-Received: by 2002:adf:fb08:: with SMTP id c8mr3281506wrr.421.1589535177177; 
 Fri, 15 May 2020 02:32:57 -0700 (PDT)
Received: from rpluim-mac ([2a01:e34:ecfc:a860:2596:89e6:a99a:9ba2])
 by smtp.gmail.com with ESMTPSA id w82sm2752351wmg.28.2020.05.15.02.32.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 15 May 2020 02:32:56 -0700 (PDT)
From: Robert Pluim <rpluim@HIDDEN>
To: Jonas Bernoulli <jonas@HIDDEN>
Subject: Re: bug#41276: [PATCH 2/9] Add all epa faces to epa-faces Custom group
References: <20200514201618.26313-1-jonas@HIDDEN>
 <20200514201618.26313-2-jonas@HIDDEN>
Date: Fri, 15 May 2020 11:32:55 +0200
In-Reply-To: <20200514201618.26313-2-jonas@HIDDEN> (Jonas Bernoulli's
 message of "Thu, 14 May 2020 22:16:11 +0200")
Message-ID: <m2y2pty248.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 41276
Cc: 41276 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

>>>>> On Thu, 14 May 2020 22:16:11 +0200, Jonas Bernoulli <jonas@HIDDEN=
> said:

    Jonas> 'epa-validity-face-alist' isn't actually a face but belongs in t=
hat
    Jonas> group anyway.

    Jonas> * lisp/epa.el (epa-field-name, epa-field-body,
    Jonas> epa-validity-face-alist): Add to epa-faces Custom group
    Jonas> ---
    Jonas>  lisp/epa.el | 6 +++---
    Jonas>  1 file changed, 3 insertions(+), 3 deletions(-)

Hmm, is this cause for setting the :version string on those
definitions (and on the relevant group(s))?

(info "(elisp)Customization") says:

=E2=80=98:version VERSION=E2=80=99
     This keyword specifies that the item was first introduced in Emacs
     version VERSION, or that its default value was changed in that
     version.  The value VERSION must be a string.

They=CA=BCre not new, but they=CA=BCre new in the group you=CA=BCre moving =
them to.

Robert




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 15 May 2020 09:26:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 15 05:26:10 2020
Received: from localhost ([127.0.0.1]:35852 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZWba-0004Mw-L6
	for submit <at> debbugs.gnu.org; Fri, 15 May 2020 05:26:10 -0400
Received: from mail-wr1-f66.google.com ([209.85.221.66]:47064)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rpluim@HIDDEN>) id 1jZWbX-0004MY-Mf
 for 41276 <at> debbugs.gnu.org; Fri, 15 May 2020 05:26:09 -0400
Received: by mail-wr1-f66.google.com with SMTP id w7so2634345wre.13
 for <41276 <at> debbugs.gnu.org>; Fri, 15 May 2020 02:26:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :mime-version:content-transfer-encoding;
 bh=b+p+27hfTGZx4XA57r6wXORNwUGxWExAHsldsv06zeg=;
 b=WEihnyFTQ7VWBm4FAQ81Rg/Do8lEUAM/ekhwVCHNhwihsJZQoV7mJXH0DMxH3XTFsh
 1DtADGmqZj6Rj9FVrg7MAB3TQUeInEVGb2MLTlZ4XXJyEHZZ4ElU/dqeSoSTrUQZgvA8
 XfjNaVVojXvC7me6BdzzWFCN57rNxwZkimLzfGSZRafyUYkjzFVAKqgQZOTU/aHlTdu7
 H2K0+ryb/PlxLtB/iRQDZvKad4T4zyuKlG87ozEyFuBI6EsxbqFDS9FHmxE0gwFo/LQU
 Mk8B0ZdE9ZUJcvWkqcUwW0e3jdvCstI4GB93H4utkwI8eLECdG/K7XRfoy/avWB7mVyJ
 u9eQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:mime-version:content-transfer-encoding;
 bh=b+p+27hfTGZx4XA57r6wXORNwUGxWExAHsldsv06zeg=;
 b=mLkv0272kHbPZ6TU6ZYRMRkSVONlKjFyY4wBrhMZiQHBGQhdpCmV3cQiUqRbrr0AI8
 HMYaxTYsx3pd6XNQYWuS0rC+/qqco8qMkMSEvTTZEzt+1OisMhJmBlZEDQtYg7EyLFBw
 9ZeVHpko7/DPsFhDFdvWofoM+U2YFa6ra2t4yH0rLBJ2AjKXLZF5FaAVO3WSB5FGztHi
 C5QY1C25lK9ahaxRXDLz9WtRrmBxvpmpHkd2AxhC1dSERfT/LOFAToypvsqzQHjc3uME
 kDgn9F8ed8/3oF3DWhczt2MBAy8JhgIqeHpZYSXc34fDIdo3hhwamLJoWKbkWGgWu0Gk
 JupA==
X-Gm-Message-State: AOAM530WG0g7oeBGdNKtT3tDZKKZQUxJXZLfYEk07ugnKKUcoJoCXgSH
 bWLaP8tK7jysz+yvntaM4SFz0ziVtMyW1g==
X-Google-Smtp-Source: ABdhPJw0C71tRsgtOLh0YbNpsZSttdIAX+2mogRRPVY71Kic6a7ZoX0BAjXDg9CCqWWkkjGdj4U5Kw==
X-Received: by 2002:a5d:40c2:: with SMTP id b2mr3113863wrq.13.1589534761347;
 Fri, 15 May 2020 02:26:01 -0700 (PDT)
Received: from rpluim-mac ([2a01:e34:ecfc:a860:2596:89e6:a99a:9ba2])
 by smtp.gmail.com with ESMTPSA id w18sm2723931wro.33.2020.05.15.02.26.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 15 May 2020 02:26:00 -0700 (PDT)
From: Robert Pluim <rpluim@HIDDEN>
To: Stefan Kangas <stefan@HIDDEN>
Subject: Re: bug#41276: [PATCH 0/9] Various small improvements to EasyPG
References: <20200514191325.22061-1-jonas@HIDDEN>
 <CADwFkmkyeZHrHOJSkCwzh1Lch7te5et0V_+r3mG2dUuXh+EeZw@HIDDEN>
Date: Fri, 15 May 2020 11:26:00 +0200
In-Reply-To: <CADwFkmkyeZHrHOJSkCwzh1Lch7te5et0V_+r3mG2dUuXh+EeZw@HIDDEN>
 (Stefan Kangas's message of "Thu, 14 May 2020 16:04:36 -0700")
Message-ID: <m23681zh07.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 41276
Cc: 41276 <at> debbugs.gnu.org, Jonas Bernoulli <jonas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

>>>>> On Thu, 14 May 2020 16:04:36 -0700, Stefan Kangas <stefan@HIDDEN>=
 said:

    Stefan> Jonas Bernoulli <jonas@HIDDEN> writes:
    >> This patches make various cosmetic and hopefully uncontroversial
    >> changes to epa and epg libraries.
    >>=20
    >> I am now to contributing to Emacs itself and not yet comfortable
    >> with the commit message conventions among other things.  Tell me
    >> what I am doing wrong please.

    Stefan> You might want to use `add-change-log-entry-other-window' or
    Stefan> `log-edit-generate-changelog-from-diff' to generate the ChangeL=
og
    Stefan> entries.  That way it's faster to write them, and easier to get=
 right.

It=CA=BCs a real shame that log-edit-generate-changelog-from-diff doesn't
work correctly when committing via Magit, it really helps you get all
the annoying details of ChangeLog entries right.

Robert




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 15 May 2020 07:28:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 15 03:28:16 2020
Received: from localhost ([127.0.0.1]:35760 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZUlT-0007qh-NC
	for submit <at> debbugs.gnu.org; Fri, 15 May 2020 03:28:15 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34202)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1jZUlT-0007qW-1K
 for 41276 <at> debbugs.gnu.org; Fri, 15 May 2020 03:28:15 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:52597)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1jZUlN-0001UA-Ky; Fri, 15 May 2020 03:28:09 -0400
Received: from [176.228.60.248] (port=3282 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1jZUlL-0006o7-Rs; Fri, 15 May 2020 03:28:08 -0400
Date: Fri, 15 May 2020 10:27:55 +0300
Message-Id: <83mu693bes.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Jonas Bernoulli <jonas@HIDDEN>
In-Reply-To: <20200514201618.26313-8-jonas@HIDDEN> (message from Jonas
 Bernoulli on Thu, 14 May 2020 22:16:17 +0200)
Subject: Re: bug#41276: [PATCH 8/9] epa-key-list-mode-map: Use widget-keymap as
 parent keymap
References: <20200514201618.26313-1-jonas@HIDDEN>
 <20200514201618.26313-8-jonas@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41276
Cc: 41276 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Jonas Bernoulli <jonas@HIDDEN>
> Date: Thu, 14 May 2020 22:16:17 +0200
> 
> * lisp/epa.el (epa-key-list-mode-map): Set the parent of this keymap
>   while defining this keymap.
> 
> * lisp/epa.el (epa--list-keys): Do not set the parent of the local
>   keymap here.

I'd appreciate some rationale for the changes in this case.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 15 May 2020 07:27:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 15 03:27:18 2020
Received: from localhost ([127.0.0.1]:35756 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZUkY-0007p8-8g
	for submit <at> debbugs.gnu.org; Fri, 15 May 2020 03:27:18 -0400
Received: from eggs.gnu.org ([209.51.188.92]:33986)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1jZUkL-0007oQ-0z
 for 41276 <at> debbugs.gnu.org; Fri, 15 May 2020 03:27:16 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:52590)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1jZUkF-0001NX-3Q; Fri, 15 May 2020 03:26:59 -0400
Received: from [176.228.60.248] (port=3210 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1jZUkE-0006er-70; Fri, 15 May 2020 03:26:58 -0400
Date: Fri, 15 May 2020 10:26:45 +0300
Message-Id: <83o8qp3bgq.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Jonas Bernoulli <jonas@HIDDEN>
In-Reply-To: <87sgg26zpv.fsf@HIDDEN> (message from Jonas Bernoulli on Thu, 
 14 May 2020 22:14:36 +0200)
Subject: Re: bug#41276: Acknowledgement ([PATCH 0/9] Various small
 improvements to EasyPG)
References: <20200514191325.22061-1-jonas@HIDDEN>
 <handler.41276.B.15894836275636.ack <at> debbugs.gnu.org>
 <87sgg26zpv.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41276
Cc: 41276 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Jonas Bernoulli <jonas@HIDDEN>
> Date: Thu, 14 May 2020 22:14:36 +0200
> 
> Please excuse me for ending up opening an issue per commit and just
> delete issues 41268-41275 and 41277 (but not 41276, this issue).
> 
> I sent the patches using:
>   git send-email 000* --to=bug-gnu-emacs@HIDDEN
> 
> I should have used
>   git send-email 0000-cover-letter.patch --to=bug-gnu-emacs@HIDDEN
> wait for the response
> > If you wish to submit further information on this problem, please
> > send it to 41276 <at> debbugs.gnu.org.
> and then
>   0000-cover-letter.patch
>   git send-email 000* --to=41276 <at> debbugs.gnu.org
> 
> which is what I am gonna do now.  Fingers crossed.  The patches may
> arrive in the wrong order again, I don't know how to prevent that.

A few of the patches in the series don't have commit log messages, or
the commit log messages are not in our usual format (see CONTRIBUTE,
and also look at the other commits in the repository for examples).

Also, since you are submitting the patches after you already know the
bug number, please mention the bug number in the commit log messages,
as doing that saves whoever actually installs the changeset from doing
the equivalent of "git commit --amend" to add the reference to the bug
number before pushing.

Thanks.  Let's wait with pushing for a few days so that others could
comment.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 23:04:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 19:04:48 2020
Received: from localhost ([127.0.0.1]:35170 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZMuF-0002CV-QS
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 19:04:47 -0400
Received: from mail-yb1-f177.google.com ([209.85.219.177]:35650)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1jZMuB-0002C7-1K
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 19:04:46 -0400
Received: by mail-yb1-f177.google.com with SMTP id o134so149357ybg.2
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 16:04:43 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:in-reply-to:references:user-agent
 :mime-version:date:message-id:subject:to:cc;
 bh=zWu436aP7AeJa8HEXLCG3VBCKxJASZw5Gpr8Qqbl0Do=;
 b=rqgcN8mQi0h4JRKqdvn9WuRKrbQhwu8emdKyDHdHjW6gobk29IAD9bywKFgptY669v
 Z6alfb5yL/Mwtx438z6MGpenDmosWnL+MhRpqC9Dr9x2qtqYvxSwRWvB2egO5TdffDrg
 sCWIvReU6dqEKRNaiyhtJiEVo5m/QB8OTZj5OFWijmqzOmlQ02NP6XQZGWFRg01X/5tD
 iMSehNuqlXOyJnAlzakwCOCkcgCZtdU7irlxXeqPQZHHcs52woCkh9ISx9em4Y/aw8qg
 V7njhUqsp92cehW1TeUFLHn6etBA6/688w/dp6jE8VHKSYFGrM1QSRbMNg3XX1u4ZgIC
 pj3g==
X-Gm-Message-State: AOAM530EgUk6L8PJHlut65WuzGkXa5eCkWzANbLWgBZVWat1FZAG6w75
 0oofZBV6ibBvwhdzlpswH0j42+Fh+CPTk+lhN3o=
X-Google-Smtp-Source: ABdhPJy+mUTrlOhFFcslJ4GzFSAETtbkHRghlyO0bQ0d69YBzDY25hxNaTGnXwU4hcXkyI+aLPasqmVepLQ402hcs9k=
X-Received: by 2002:a25:af86:: with SMTP id g6mr1037913ybh.85.1589497477423;
 Thu, 14 May 2020 16:04:37 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 14 May 2020 16:04:36 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <20200514191325.22061-1-jonas@HIDDEN> (Jonas Bernoulli's
 message of "Thu, 14 May 2020 21:13:16 +0200")
References: <20200514191325.22061-1-jonas@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Date: Thu, 14 May 2020 16:04:36 -0700
Message-ID: <CADwFkmkyeZHrHOJSkCwzh1Lch7te5et0V_+r3mG2dUuXh+EeZw@HIDDEN>
Subject: Re: bug#41276: [PATCH 0/9] Various small improvements to EasyPG
To: Jonas Bernoulli <jonas@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 41276
Cc: 41276 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Jonas Bernoulli <jonas@HIDDEN> writes:

> This patches make various cosmetic and hopefully uncontroversial
> changes to epa and epg libraries.
>
> I am now to contributing to Emacs itself and not yet comfortable
> with the commit message conventions among other things.  Tell me
> what I am doing wrong please.

You might want to use `add-change-log-entry-other-window' or
`log-edit-generate-changelog-from-diff' to generate the ChangeLog
entries.  That way it's faster to write them, and easier to get right.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 22:33:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 18:33:55 2020
Received: from localhost ([127.0.0.1]:35150 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZMQN-00010F-4A
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 18:33:55 -0400
Received: from mail-yb1-f194.google.com ([209.85.219.194]:41151)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1jZMQK-0000zx-Uk
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 18:33:53 -0400
Received: by mail-yb1-f194.google.com with SMTP id x18so99189ybq.8
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 15:33:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:in-reply-to:references:user-agent
 :mime-version:date:message-id:subject:to:cc;
 bh=2V6eDc5dom5NRqLtPOT76fi22Aqveg8Qo7Y+XarfFuo=;
 b=Ve3Hor9pvBvo+V4UAZbdkCKAOuPr/28lBno3JWowG5u2Grh5CINMZyLDyEJS7dJ+k9
 Lpdf/RCXTHTwZJp3CBwIx4jxSZnU6DvMrdpA1515NY6negiaYzgy8CGyAcGoFqYYvlGr
 09tGeCPUjssnL6eLEKOClYQJUOelDCb5Vnq62b+Dc+9Q7K/oWNEeKXAduyDksQU+AAMw
 IyFFmPk+pBsNix7AEUj0VNU2N4v7QCKfe6uU0mQI6ZGBk6MEx+6byR80AHWCdPRV5R+C
 83O6R1Sz5/Rb8ycESIx7dS8x6YvUT5o/E0p+RNTZ+NHjys+vUhA4vMs+eos2hoOP6pHd
 o8vg==
X-Gm-Message-State: AOAM532u9kbLu8+lq1h9Qx5t2Y/k79XCFaPlp1V2vFEUvOKdpAMCZmHU
 CUL6A8tUdMRkJRr7JZaMh8sng6Q1kST0RYMZ7agDiQ==
X-Google-Smtp-Source: ABdhPJwNnQce3fAjvAPtno/T9ZHRN8GmyjFyE7aWor4R7AJPaHqgSpcA5rdNdAPZUmFYyl6XyogwCh3EV2PsnITJIlQ=
X-Received: by 2002:a25:af86:: with SMTP id g6mr860065ybh.85.1589495625880;
 Thu, 14 May 2020 15:33:45 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 14 May 2020 15:33:45 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <87sgg26zpv.fsf@HIDDEN> (Jonas Bernoulli's message of "Thu,
 14 May 2020 22:14:36 +0200")
References: <20200514191325.22061-1-jonas@HIDDEN>
 <handler.41276.B.15894836275636.ack <at> debbugs.gnu.org>
 <87sgg26zpv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Date: Thu, 14 May 2020 15:33:45 -0700
Message-ID: <CADwFkmnOv1s2RHRdVtgDJc3=QPcK0siuzVmuPrQMCTHm3qzn2A@HIDDEN>
Subject: Re: bug#41276: Acknowledgement ([PATCH 0/9] Various small
 improvements to EasyPG)
To: Jonas Bernoulli <jonas@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 41276
Cc: 41276 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Jonas Bernoulli <jonas@HIDDEN> writes:

> Please excuse me for ending up opening an issue per commit and just
> delete issues 41268-41275 and 41277 (but not 41276, this issue).

I merged the bugs for now, since AFAIK there's no way to delete bugs in
debbugs.  If anyone has a better solution, please go ahead.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.
Forcibly Merged 41268 41269 41270 41271 41272 41273 41274 41275 41276 41277. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Forcibly Merged 41268 41269 41270 41271 41272 41273 41274 41275 41276. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Forcibly Merged 41268 41269 41270 41271 41272 41273 41274 41276. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Forcibly Merged 41268 41269 41270 41271 41272 41273 41276. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Forcibly Merged 41268 41269 41270 41271 41272 41276. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Forcibly Merged 41268 41269 41270 41271 41276. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Forcibly Merged 41268 41269 41270 41276. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Forcibly Merged 41268 41269 41276. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Forcibly Merged 41268 41276. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:16:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:16:29 2020
Received: from localhost ([127.0.0.1]:35011 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKHN-0003PD-M9
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:29 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60588)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKHF-0003NV-8c
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:22 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id 49EDF166CA
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:20 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id bsVrGLWGxyQR for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:16:19 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 7A46D166C0
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: [PATCH 9/9] * lisp/epa.el (epa-show-key): New command
Date: Thu, 14 May 2020 22:16:18 +0200
Message-Id: <20200514201618.26313-9-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200514201618.26313-1-jonas@HIDDEN>
References: <20200514201618.26313-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Users can move in `epa-key-list-mode' buffers using either
`next-line'/`previous-line' or `widget-forward'/`widget-backward'.
When using the first set of commands, then the cursor stays in the
column and that normally is the first column.  The key widgets do
not begin until the third character of their respective lines.

All `epa' commands work regardless of whether the cursor is on the
widget or before them.  The `epa-show-key' command did not exist until
now because the `widget-button-press' already performs its task.  But
because the widgets don't span complete lines we actually need this
command too.
---
 lisp/epa.el | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/lisp/epa.el b/lisp/epa.el
index 1e0a0132d2..fe5dd4321a 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -25,7 +25,9 @@
 (require 'epg)
 (require 'font-lock)
 (require 'widget)
-(eval-when-compile (require 'wid-edit))
+(eval-when-compile
+  (require 'subr-x)
+  (require 'wid-edit))
 (require 'derived)
 
 ;;; Options
@@ -192,6 +194,7 @@ epa-key-list-mode-map
   (let ((keymap (make-sparse-keymap))
 	(menu-map (make-sparse-keymap)))
     (set-keymap-parent keymap widget-keymap)
+    (define-key keymap "\C-m" 'epa-show-key)
     (define-key keymap "m" 'epa-mark-key)
     (define-key keymap "u" 'epa-unmark-key)
     (define-key keymap "d" 'epa-decrypt-file)
@@ -518,6 +521,14 @@ epa-select-keys
 
 ;;;; Key Details
 
+(defun epa-show-key ()
+  "Show a key on the current line."
+  (interactive)
+  (if-let ((key (get-text-property (point) 'epa-key)))
+      (save-selected-window
+        (epa--show-key key))
+    (error "No key on this line")))
+
 (defun epa--show-key (key)
   (let* ((primary-sub-key (car (epg-key-sub-key-list key)))
 	 (entry (assoc (epg-sub-key-id primary-sub-key)
-- 
2.26.0





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:16:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:16:29 2020
Received: from localhost ([127.0.0.1]:35009 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKHN-0003P6-9J
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:29 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60584)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKHF-0003NS-5w
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:21 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id 475D5166B6
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:20 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id cf0ioTdLAcfT for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:16:19 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 67067166BD
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: [PATCH 7/9] Cosmetic changes to epa libraries
Date: Thu, 14 May 2020 22:16:16 +0200
Message-Id: <20200514201618.26313-7-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200514201618.26313-1-jonas@HIDDEN>
References: <20200514201618.26313-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* lisp/epa-dired.el (epa-dired-do-decrypt, epa-dired-do-verify
epa-dired-do-sign, epa-dired-do-encrypt): Use dolist instead of while.

* lisp/epa-file.el (epa-file-passphrase-callback-function): Set just
  one variable per setq call.
---
 lisp/epa-dired.el | 44 ++++++++++++++++++--------------------------
 lisp/epa-file.el  |  4 ++--
 2 files changed, 20 insertions(+), 28 deletions(-)

diff --git a/lisp/epa-dired.el b/lisp/epa-dired.el
index 1bcfb758ed..4ff1ba3394 100644
--- a/lisp/epa-dired.el
+++ b/lisp/epa-dired.el
@@ -30,48 +30,40 @@
 (defun epa-dired-do-decrypt ()
   "Decrypt marked files."
   (interactive)
-  (let ((file-list (dired-get-marked-files)))
-    (while file-list
-      (epa-decrypt-file (expand-file-name (car file-list)))
-      (setq file-list (cdr file-list)))
-    (revert-buffer)))
+  (dolist (file (dired-get-marked-files))
+    (epa-decrypt-file (expand-file-name file)))
+  (revert-buffer))
 
 ;;;###autoload
 (defun epa-dired-do-verify ()
   "Verify marked files."
   (interactive)
-  (let ((file-list (dired-get-marked-files)))
-    (while file-list
-      (epa-verify-file (expand-file-name (car file-list)))
-      (setq file-list (cdr file-list)))))
+  (dolist (file (dired-get-marked-files))
+    (epa-verify-file (expand-file-name file))))
 
 ;;;###autoload
 (defun epa-dired-do-sign ()
   "Sign marked files."
   (interactive)
-  (let ((file-list (dired-get-marked-files)))
-    (while file-list
-      (epa-sign-file
-       (expand-file-name (car file-list))
-       (epa-select-keys (epg-make-context) "Select keys for signing.
+  (dolist (file (dired-get-marked-files))
+    (epa-sign-file
+     (expand-file-name file)
+     (epa-select-keys (epg-make-context) "Select keys for signing.
 If no one is selected, default secret key is used.  "
-			nil t)
-       (y-or-n-p "Make a detached signature? "))
-      (setq file-list (cdr file-list)))
-    (revert-buffer)))
+		      nil t)
+     (y-or-n-p "Make a detached signature? ")))
+  (revert-buffer))
 
 ;;;###autoload
 (defun epa-dired-do-encrypt ()
   "Encrypt marked files."
   (interactive)
-  (let ((file-list (dired-get-marked-files)))
-    (while file-list
-      (epa-encrypt-file
-       (expand-file-name (car file-list))
-       (epa-select-keys (epg-make-context) "Select recipients for encryption.
-If no one is selected, symmetric encryption will be performed.  "))
-      (setq file-list (cdr file-list)))
-    (revert-buffer)))
+  (dolist (file (dired-get-marked-files))
+    (epa-encrypt-file
+     (expand-file-name file)
+     (epa-select-keys (epg-make-context) "Select recipients for encryption.
+If no one is selected, symmetric encryption will be performed.  ")))
+  (revert-buffer))
 
 (provide 'epa-dired)
 
diff --git a/lisp/epa-file.el b/lisp/epa-file.el
index 3e23c09a51..de51c59c34 100644
--- a/lisp/epa-file.el
+++ b/lisp/epa-file.el
@@ -66,8 +66,8 @@ epa-file-passphrase-callback-function
 	  (or (copy-sequence (cdr entry))
 	      (progn
 		(unless entry
-		  (setq entry (list file)
-			epa-file-passphrase-alist
+		  (setq entry (list file))
+		  (setq epa-file-passphrase-alist
 			(cons entry
 			      epa-file-passphrase-alist)))
 		(setq passphrase (epa-passphrase-callback-function context
-- 
2.26.0





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:16:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:16:29 2020
Received: from localhost ([127.0.0.1]:35007 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKHM-0003Oy-L7
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:29 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60574)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKHE-0003NF-M5
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:21 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id 135CB16693
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:20 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id VyxAyzvIaK3Q for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:16:19 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 18441166AF
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: [PATCH 4/9] Split EasyPG libraries into outline sections
Date: Thu, 14 May 2020 22:16:13 +0200
Message-Id: <20200514201618.26313-4-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200514201618.26313-1-jonas@HIDDEN>
References: <20200514201618.26313-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

lisp/epa-dired.el, lisp/epa-file.el, lisp/epa-hook.el,
lisp/epa-mail.el, lisp/epa.el, lisp/epg-config.el, lisp/epg.el:
Split into outline sections.
---
 lisp/epa-dired.el  |  1 +
 lisp/epa-file.el   |  9 +++++++++
 lisp/epa-hook.el   |  1 +
 lisp/epa-mail.el   |  9 +++++++++
 lisp/epa.el        | 23 +++++++++++++++++++++++
 lisp/epg-config.el |  8 ++++++++
 lisp/epg.el        | 26 +++++++++++++++++++++++++-
 7 files changed, 76 insertions(+), 1 deletion(-)

diff --git a/lisp/epa-dired.el b/lisp/epa-dired.el
index f601d42656..1bcfb758ed 100644
--- a/lisp/epa-dired.el
+++ b/lisp/epa-dired.el
@@ -1,4 +1,5 @@
 ;;; epa-dired.el --- the EasyPG Assistant, dired extension -*- lexical-binding: t -*-
+
 ;; Copyright (C) 2006-2020 Free Software Foundation, Inc.
 
 ;; Author: Daiki Ueno <ueno@HIDDEN>
diff --git a/lisp/epa-file.el b/lisp/epa-file.el
index dedf20b0d7..43399d2852 100644
--- a/lisp/epa-file.el
+++ b/lisp/epa-file.el
@@ -1,4 +1,5 @@
 ;;; epa-file.el --- the EasyPG Assistant, transparent file encryption -*- lexical-binding: t -*-
+
 ;; Copyright (C) 2006-2020 Free Software Foundation, Inc.
 
 ;; Author: Daiki Ueno <ueno@HIDDEN>
@@ -25,6 +26,8 @@
 (require 'epa)
 (require 'epa-hook)
 
+;;; Options
+
 (defcustom epa-file-cache-passphrase-for-symmetric-encryption nil
   "If non-nil, cache passphrase for symmetric encryption.
 
@@ -49,6 +52,8 @@ epa-file-select-keys
 		 (const :tag "Don't ask" silent))
   :group 'epa-file)
 
+;;; Other
+
 (defvar epa-file-passphrase-alist nil)
 
 (eval-and-compile
@@ -82,6 +87,8 @@ epa-file-passphrase-callback-function
 		passphrase))))
     (epa-passphrase-callback-function context key-id file)))
 
+;;; File Handler
+
 (defvar epa-inhibit nil
   "Non-nil means don't try to decrypt .gpg files when operating on them.")
 
@@ -317,6 +324,8 @@ epa-file-write-region
 	(message "Wrote %s" buffer-file-name))))
 (put 'write-region 'epa-file 'epa-file-write-region)
 
+;;; Commands
+
 (defun epa-file-select-keys ()
   "Select recipients for encryption."
   (interactive)
diff --git a/lisp/epa-hook.el b/lisp/epa-hook.el
index d424e7a9fa..002f46ad27 100644
--- a/lisp/epa-hook.el
+++ b/lisp/epa-hook.el
@@ -1,4 +1,5 @@
 ;;; epa-hook.el --- preloaded code to enable epa-file.el -*- lexical-binding: t -*-
+
 ;; Copyright (C) 2006-2020 Free Software Foundation, Inc.
 
 ;; Author: Daiki Ueno <ueno@HIDDEN>
diff --git a/lisp/epa-mail.el b/lisp/epa-mail.el
index 00f560af0b..4c57235394 100644
--- a/lisp/epa-mail.el
+++ b/lisp/epa-mail.el
@@ -1,4 +1,5 @@
 ;;; epa-mail.el --- the EasyPG Assistant, minor-mode for mail composer -*- lexical-binding: t -*-
+
 ;; Copyright (C) 2006-2020 Free Software Foundation, Inc.
 
 ;; Author: Daiki Ueno <ueno@HIDDEN>
@@ -25,6 +26,8 @@
 (require 'epa)
 (require 'mail-utils)
 
+;;; Local Mode
+
 (defvar epa-mail-mode-map
   (let ((keymap (make-sparse-keymap)))
     (define-key keymap "\C-c\C-ed" 'epa-mail-decrypt)
@@ -50,6 +53,8 @@ epa-mail-mode
   "A minor-mode for composing encrypted/clearsigned mails."
   nil " epa-mail" epa-mail-mode-map)
 
+;;; Utilities
+
 (defun epa-mail--find-usable-key (keys usage)
   "Find a usable key from KEYS for USAGE.
 USAGE would be `sign' or `encrypt'."
@@ -64,6 +69,8 @@ epa-mail--find-usable-key
 	  (setq pointer (cdr pointer))))
       (setq keys (cdr keys)))))
 
+;;; Commands
+
 ;;;###autoload
 (defun epa-mail-decrypt ()
   "Decrypt OpenPGP armors in the current buffer.
@@ -238,6 +245,8 @@ epa-mail-import-keys
   (interactive)
   (epa-import-armor-in-region (point-min) (point-max)))
 
+;;; Global Mode
+
 ;;;###autoload
 (define-minor-mode epa-global-mail-mode
   "Minor mode to hook EasyPG into Mail mode."
diff --git a/lisp/epa.el b/lisp/epa.el
index 7fb5a92547..62a4941f9d 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -28,6 +28,8 @@
 (eval-when-compile (require 'wid-edit))
 (require 'derived)
 
+;;; Options
+
 (defgroup epa nil
   "The EasyPG Assistant"
   :version "23.1"
@@ -71,6 +73,8 @@ epa-mail-aliases
   :group 'epa
   :version "24.4")
 
+;;; Faces
+
 (defgroup epa-faces nil
   "Faces for epa-mode."
   :version "23.1"
@@ -141,6 +145,8 @@ epa-validity-face-alist
   :type '(repeat (cons symbol face))
   :group 'epa-faces)
 
+;;; Variables
+
 (defvar epa-font-lock-keywords
   '(("^\\*"
      (0 'epa-mark))
@@ -245,6 +251,8 @@ epa-info-mode-map
 
 (defvar epa-exit-buffer-function #'quit-window)
 
+;;; Key Widget
+
 (define-widget 'epa-key 'push-button
   "Button for representing an epg-key object."
   :format "%[%v%]"
@@ -286,6 +294,8 @@ epa--key-widget-help-echo
 	  (epg-sub-key-id (car (epg-key-sub-key-list
 				(widget-get widget :value))))))
 
+;;; Modes
+
 (define-derived-mode epa-key-list-mode special-mode "EPA Keys"
   "Major mode for `epa-list-keys'."
   (buffer-disable-undo)
@@ -309,6 +319,9 @@ epa-info-mode
   (setq truncate-lines t
 	buffer-read-only t))
 
+;;; Commands
+;;;; Marking
+
 (defun epa-mark-key (&optional arg)
   "Mark a key on the current line.
 If ARG is non-nil, unmark the key."
@@ -331,12 +344,16 @@ epa-unmark-key
   (interactive "P")
   (epa-mark-key (not arg)))
 
+;;;; Quitting
+
 (defun epa-exit-buffer ()
   "Exit the current buffer.
 `epa-exit-buffer-function' is called if it is set."
   (interactive)
   (funcall epa-exit-buffer-function))
 
+;;;; Listing and Selecting
+
 (defun epa--insert-keys (keys)
   (save-excursion
     (save-restriction
@@ -500,6 +517,8 @@ epa-select-keys
   (let ((keys (epg-list-keys context names secret)))
     (epa--select-keys prompt keys)))
 
+;;;; Key Details
+
 (defun epa--show-key (key)
   (let* ((primary-sub-key (car (epg-key-sub-key-list key)))
 	 (entry (assoc (epg-sub-key-id primary-sub-key)
@@ -578,6 +597,8 @@ epa--show-key
     (goto-char (point-min))
     (pop-to-buffer (current-buffer))))
 
+;;;; Encryption and Signatures
+
 (defun epa-display-info (info)
   (if epa-popup-info-window
       (save-selected-window
@@ -1178,6 +1199,8 @@ epa-encrypt-region
 				 'start-open t
 				 'end-open t)))))
 
+;;;; Key Management
+
 ;;;###autoload
 (defun epa-delete-keys (keys &optional allow-secret)
   "Delete selected KEYS."
diff --git a/lisp/epg-config.el b/lisp/epg-config.el
index 1c42924652..a148737f1c 100644
--- a/lisp/epg-config.el
+++ b/lisp/epg-config.el
@@ -25,6 +25,8 @@
 
 (eval-when-compile (require 'cl-lib))
 
+;;; Constants (1/2)
+
 (defconst epg-package-name "epg"
   "Name of this package.")
 
@@ -34,6 +36,8 @@ epg-version-number
 (define-obsolete-variable-alias 'epg-bug-report-address
   'report-emacs-bug-address "27.1")
 
+;;; Options
+
 (defgroup epg ()
   "Interface to the GNU Privacy Guard (GnuPG)."
   :tag "EasyPG"
@@ -106,6 +110,8 @@ epg-debug
 Note that the buffer name starts with a space."
   :type 'boolean)
 
+;;; Constants (2/2)
+
 (defconst epg-gpg-minimum-version "1.4.3")
 (defconst epg-gpg2-minimum-version "2.1.6")
 
@@ -133,6 +139,8 @@ epg-config--configuration-constructor-alist
 either `OpenPGP' or `CMS'.  The second element is a function
 which constructs a configuration object (actually a plist).")
 
+;;; "Configuration"
+
 (defvar epg--configurations nil)
 
 ;;;###autoload
diff --git a/lisp/epg.el b/lisp/epg.el
index 222fd913e1..4bb9e998e1 100644
--- a/lisp/epg.el
+++ b/lisp/epg.el
@@ -1,4 +1,5 @@
 ;;; epg.el --- the EasyPG Library -*- lexical-binding: t -*-
+
 ;; Copyright (C) 1999-2000, 2002-2020 Free Software Foundation, Inc.
 
 ;; Author: Daiki Ueno <ueno@HIDDEN>
@@ -25,6 +26,10 @@
 (require 'epg-config)
 (eval-when-compile (require 'cl-lib))
 
+(define-error 'epg-error "GPG error")
+
+;;; Variables
+
 (defvar epg-user-id nil
   "GnuPG ID of your default identity.")
 
@@ -41,6 +46,8 @@ epg-debug-buffer
 (defvar epg-agent-file nil)
 (defvar epg-agent-mtime nil)
 
+;;; Enums
+
 ;; from gnupg/common/openpgpdefs.h
 (defconst epg-cipher-algorithm-alist
   '((0 . "NONE")
@@ -169,7 +176,8 @@ epg-dn-type-alist
 
 (defvar epg-prompt-alist nil)
 
-(define-error 'epg-error "GPG error")
+;;; Structs
+;;;; Data Struct
 
 (cl-defstruct (epg-data
                (:constructor nil)
@@ -180,6 +188,8 @@ 'epg-error
   (file nil :read-only t)
   (string nil :read-only t))
 
+;;;; Context Struct
+
 (cl-defstruct (epg-context
                (:constructor nil)
                (:constructor epg-context--make
@@ -218,6 +228,8 @@ 'epg-error
   (error-output "")
   error-buffer)
 
+;;;; Context Methods
+
 ;; This is not an alias, just so we can mark it as autoloaded.
 ;;;###autoload
 (defun epg-make-context (&optional protocol armor textmode include-certs
@@ -281,6 +293,8 @@ epg-context-set-signers
   (declare (obsolete setf "25.1"))
   (setf (epg-context-signers context) signers))
 
+;;;; Other Structs
+
 (cl-defstruct (epg-signature
                (:constructor nil)
                (:constructor epg-make-signature
@@ -385,6 +399,8 @@ epg-context-set-signers
   secret-unchanged not-imported
   imports)
 
+;;; Functions
+
 (defun epg-context-result-for (context name)
   "Return the result of CONTEXT associated with NAME."
   (cdr (assq name (epg-context-result context))))
@@ -859,6 +875,8 @@ epg--prompt-GET_BOOL-untrusted_key.override
 		  (format "Untrusted key %s %s.  Use anyway? " key-id user-id))
 	      "Use untrusted key anyway? ")))
 
+;;; Status Functions
+
 (defun epg--status-GET_BOOL (context string)
   (let (inhibit-quit)
     (condition-case nil
@@ -1234,6 +1252,8 @@ epg--status-IMPORT_RES
 			     (epg-context-result-for context 'import-status)))
     (epg-context-set-result-for context 'import-status nil)))
 
+;;; Functions
+
 (defun epg-passphrase-callback-function (context key-id _handback)
   (declare (obsolete epa-passphrase-callback-function "23.1"))
   (if (eq key-id 'SYM)
@@ -1303,6 +1323,8 @@ epg--make-sub-key-1
    (if (aref line 6)
        (epg--time-from-seconds (aref line 6)))))
 
+;;; Public Functions
+
 (defun epg-list-keys (context &optional name mode)
   "Return a list of epg-key objects matched with NAME.
 If MODE is nil or `public', only public keyring should be searched.
@@ -2031,6 +2053,8 @@ epg-edit-key
 			    (epg-errors-to-string errors))))))
     (epg-reset context)))
 
+;;; Decode Functions
+
 (defun epg--decode-percent-escape (string)
   (setq string (encode-coding-string string 'raw-text))
   (let ((index 0))
-- 
2.26.0





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:16:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:16:28 2020
Received: from localhost ([127.0.0.1]:35005 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKHM-0003Or-DT
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:28 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60586)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKHF-0003NU-7g
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:21 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id 4947D166C4
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:20 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id veX5qSJpljbo for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:16:19 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 72BC3166BF
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: [PATCH 8/9] epa-key-list-mode-map: Use widget-keymap as parent keymap
Date: Thu, 14 May 2020 22:16:17 +0200
Message-Id: <20200514201618.26313-8-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200514201618.26313-1-jonas@HIDDEN>
References: <20200514201618.26313-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* lisp/epa.el (epa-key-list-mode-map): Set the parent of this keymap
  while defining this keymap.

* lisp/epa.el (epa--list-keys): Do not set the parent of the local
  keymap here.
---
 lisp/epa.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/epa.el b/lisp/epa.el
index b06b0ac8e4..1e0a0132d2 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -191,6 +191,7 @@ epa-last-coding-system-specified
 (defvar epa-key-list-mode-map
   (let ((keymap (make-sparse-keymap))
 	(menu-map (make-sparse-keymap)))
+    (set-keymap-parent keymap widget-keymap)
     (define-key keymap "m" 'epa-mark-key)
     (define-key keymap "u" 'epa-unmark-key)
     (define-key keymap "d" 'epa-decrypt-file)
@@ -413,8 +414,7 @@ epa--list-keys
       (goto-char point))
 
     (epa--insert-keys (epg-list-keys context name secret))
-    (widget-setup)
-    (set-keymap-parent (current-local-map) widget-keymap))
+    (widget-setup))
   (make-local-variable 'epa-list-keys-arguments)
   (setq epa-list-keys-arguments (list name secret))
   (goto-char (point-min))
-- 
2.26.0





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:16:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:16:28 2020
Received: from localhost ([127.0.0.1]:35003 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKHM-0003Ok-5d
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:28 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60582)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKHF-0003NP-4I
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:21 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id 46EE3166AF
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:20 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id v8MoJHBpTqTo for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:16:19 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 510E2166B8
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: [PATCH 6/9] Drop unnecessary backward compatibility aliases
Date: Thu, 14 May 2020 22:16:15 +0200
Message-Id: <20200514201618.26313-6-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200514201618.26313-1-jonas@HIDDEN>
References: <20200514201618.26313-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* lisp/epa-file.el (epa-file--encode-coding-string,
  epa-file--decode-coding-string): Remove aliases for
  encode-coding-string and decode-coding-string.

* lisp/epa-file.el (epa-file-write-region): Use encode-coding-string
  instead of removed epa-file--encode-coding-string.

encode-coding-string and decode-coding-string existed every since
4ed4686978bd18292e2bb7b87a7b0e0407ecb3b1 added them in 1997.
---
 lisp/epa-file.el | 22 ++++------------------
 1 file changed, 4 insertions(+), 18 deletions(-)

diff --git a/lisp/epa-file.el b/lisp/epa-file.el
index ede7177054..3e23c09a51 100644
--- a/lisp/epa-file.el
+++ b/lisp/epa-file.el
@@ -56,16 +56,6 @@ epa-file-select-keys
 
 (defvar epa-file-passphrase-alist nil)
 
-(eval-and-compile
-  (if (fboundp 'encode-coding-string)
-      (defalias 'epa-file--encode-coding-string 'encode-coding-string)
-    (defalias 'epa-file--encode-coding-string 'identity)))
-
-(eval-and-compile
-  (if (fboundp 'decode-coding-string)
-      (defalias 'epa-file--decode-coding-string 'decode-coding-string)
-    (defalias 'epa-file--decode-coding-string 'identity)))
-
 (defun epa-file-passphrase-callback-function (context key-id file)
   (if (and epa-file-cache-passphrase-for-symmetric-encryption
 	   (eq key-id 'SYM))
@@ -243,11 +233,7 @@ epa-file-write-region
   (setq file (expand-file-name file))
   (let* ((coding-system (or coding-system-for-write
 			    (if (fboundp 'select-safe-coding-system)
-				;; This is needed since Emacs 22 has
-				;; no-conversion setting for *.gpg in
-				;; `auto-coding-alist'.
-			        (let ((buffer-file-name
-				       (file-name-sans-extension file)))
+			        (let ((buffer-file-name file))
 				  (select-safe-coding-system
 				   (point-min) (point-max)))
 			      buffer-file-coding-system)))
@@ -273,7 +259,7 @@ epa-file-write-region
 	      (epg-encrypt-string
 	       context
 	       (if (stringp start)
-		   (epa-file--encode-coding-string start coding-system)
+		   (encode-coding-string start coding-system)
 		 (unless start
 		   (setq start (point-min)
 			 end (point-max)))
@@ -287,8 +273,8 @@ epa-file-write-region
 		   ;; decrypted contents.
 		   (format-encode-buffer (with-current-buffer buffer
 					   buffer-file-format))
-		   (epa-file--encode-coding-string (buffer-string)
-						   coding-system)))
+		   (encode-coding-string (buffer-string)
+					 coding-system)))
 	       (if (or (eq epa-file-select-keys t)
 		       (and (null epa-file-select-keys)
 			    (not (local-variable-p 'epa-file-encrypt-to
-- 
2.26.0





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:16:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:16:28 2020
Received: from localhost ([127.0.0.1]:35001 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKHL-0003Oi-Ss
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:28 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60570)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKHE-0003NE-Fq
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:21 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id CEB661668B
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id Uj5vNbzOl2VB for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:16:19 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 4567B166B6
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: [PATCH 5/9] Improve and add doc-strings
Date: Thu, 14 May 2020 22:16:14 +0200
Message-Id: <20200514201618.26313-5-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200514201618.26313-1-jonas@HIDDEN>
References: <20200514201618.26313-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* lisp/epa-file.el (epa-file-select-keys), lisp/epa-hook.el
  (epa-file-name-regexp), lisp/epa.el (epa-exit-buffer): Improve
  doc-string.

* lisp/epa-hook.el (epa-file-name-regexp-update): Add doc-string.
---
 lisp/epa-file.el |  4 ++--
 lisp/epa-hook.el | 11 +++++++----
 lisp/epa.el      |  3 +--
 3 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/lisp/epa-file.el b/lisp/epa-file.el
index 43399d2852..ede7177054 100644
--- a/lisp/epa-file.el
+++ b/lisp/epa-file.el
@@ -43,9 +43,9 @@ epa-file-cache-passphrase-for-symmetric-encryption
 (defcustom epa-file-select-keys nil
   "Control whether or not to pop up the key selection dialog.
 
-If t, always asks user to select recipients.
+If t, always ask user to select recipients.
 If nil, query user only when `epa-file-encrypt-to' is not set.
-If neither t nor nil, doesn't ask user.  In this case, symmetric
+If neither t nor nil, don't ask user.  In this case, symmetric
 encryption is used."
   :type '(choice (const :tag "Ask always" t)
 		 (const :tag "Ask when recipients are not set" nil)
diff --git a/lisp/epa-hook.el b/lisp/epa-hook.el
index 002f46ad27..6f12f8a6bf 100644
--- a/lisp/epa-hook.el
+++ b/lisp/epa-hook.el
@@ -36,10 +36,10 @@ epa-file--file-name-regexp-set
 (defcustom epa-file-name-regexp (purecopy "\\.gpg\\(~\\|\\.~[0-9]+~\\)?\\'")
   "Regexp which matches filenames to be encrypted with GnuPG.
 
-If you set this outside Custom while epa-file is already enabled, you
-have to call `epa-file-name-regexp-update' after setting it to
-properly update file-name-handler-alist.  Setting this through Custom
-does that automatically."
+If you set this outside Custom while epa-file is already enabled,
+you have to call `epa-file-name-regexp-update' after setting it
+to properly update `file-name-handler-alist'.  Setting this
+through Custom does that automatically."
   :type 'regexp
   :group 'epa-file
   :set 'epa-file--file-name-regexp-set)
@@ -73,6 +73,9 @@ epa-file-auto-mode-alist-entry
   (list epa-file-name-regexp nil 'epa-file))
 
 (defun epa-file-name-regexp-update ()
+  "Update `file-name-handler-alist' after configuring outside Custom.
+After setting `epa-file-name-regexp-update' outside the Custom
+interface, update `file-name-handler-alist'."
   (interactive)
   (unless (equal (car epa-file-handler) epa-file-name-regexp)
     (setcar epa-file-handler epa-file-name-regexp)))
diff --git a/lisp/epa.el b/lisp/epa.el
index 62a4941f9d..b06b0ac8e4 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -347,8 +347,7 @@ epa-unmark-key
 ;;;; Quitting
 
 (defun epa-exit-buffer ()
-  "Exit the current buffer.
-`epa-exit-buffer-function' is called if it is set."
+  "Exit the current buffer using `epa-exit-buffer-function'."
   (interactive)
   (funcall epa-exit-buffer-function))
 
-- 
2.26.0





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:16:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:16:22 2020
Received: from localhost ([127.0.0.1]:34998 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKHG-0003OH-LI
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:22 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60564)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKHE-0003NC-9a
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:20 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id AC407166C2
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id dPz-7dom-vC8 for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:16:19 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 0725A1668B
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: [PATCH 2/9] Add all epa faces to epa-faces Custom group
Date: Thu, 14 May 2020 22:16:11 +0200
Message-Id: <20200514201618.26313-2-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200514201618.26313-1-jonas@HIDDEN>
References: <20200514201618.26313-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

'epa-validity-face-alist' isn't actually a face but belongs in that
group anyway.

* lisp/epa.el (epa-field-name, epa-field-body,
epa-validity-face-alist): Add to epa-faces Custom group
---
 lisp/epa.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/epa.el b/lisp/epa.el
index 0dd1cff465..7fb5a92547 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -117,13 +117,13 @@ epa-field-name
   '((default :weight bold)
     (((class color) (background dark)) :foreground "PaleTurquoise"))
   "Face for the name of the attribute field."
-  :group 'epa)
+  :group 'epa-faces)
 
 (defface epa-field-body
   '((default :slant italic)
     (((class color) (background dark)) :foreground "turquoise"))
   "Face for the body of the attribute field."
-  :group 'epa)
+  :group 'epa-faces)
 
 (defcustom epa-validity-face-alist
   '((unknown . epa-validity-disabled)
@@ -139,7 +139,7 @@ epa-validity-face-alist
     (ultimate . epa-validity-high))
   "An alist mapping validity values to faces."
   :type '(repeat (cons symbol face))
-  :group 'epa)
+  :group 'epa-faces)
 
 (defvar epa-font-lock-keywords
   '(("^\\*"
-- 
2.26.0





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:16:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:16:22 2020
Received: from localhost ([127.0.0.1]:34996 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKHG-0003OA-BJ
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:22 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60556)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKHE-0003NB-9a
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:20 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id A524A1667E
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id KhZi0Tf9jeTu for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:16:19 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 1047D16693
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: [PATCH 3/9] * lisp/epg-config.el
 (epg-config--make-gpg-configuration): Fix indentation
Date: Thu, 14 May 2020 22:16:12 +0200
Message-Id: <20200514201618.26313-3-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
In-Reply-To: <20200514201618.26313-1-jonas@HIDDEN>
References: <20200514201618.26313-1-jonas@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

---
 lisp/epg-config.el | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lisp/epg-config.el b/lisp/epg-config.el
index daa9a5abd1..1c42924652 100644
--- a/lisp/epg-config.el
+++ b/lisp/epg-config.el
@@ -202,13 +202,13 @@ epg-config--make-gpg-configuration
 	(cond
 	 ((eq type 'group)
 	  (if (string-match "\\`\\([^:]+\\):" args)
-		  (setq groups
-			(cons (cons (downcase (match-string 1 args))
-				    (delete "" (split-string
-						(substring args
-							   (match-end 0))
-						";")))
-			      groups))
+	      (setq groups
+		    (cons (cons (downcase (match-string 1 args))
+				(delete "" (split-string
+					    (substring args
+						       (match-end 0))
+					    ";")))
+			  groups))
 	    (if epg-debug
 		(message "Invalid group configuration: %S" args))))
 	 ((memq type '(pubkey cipher digest compress))
-- 
2.26.0





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:16:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:16:22 2020
Received: from localhost ([127.0.0.1]:34994 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKHF-0003Nv-U1
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:22 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60548)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKHE-0003NA-6r
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:16:20 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id 91F17166C1
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:19 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id YvfzBZGkFxU9 for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:16:19 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id F249B1667E
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:16:18 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: [PATCH 1/9] * lisp/epa.el (epa-faces): Move definition
Date: Thu, 14 May 2020 22:16:10 +0200
Message-Id: <20200514201618.26313-1-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Previously option `epa-mail-aliases' was the only option that was
defined right after the group `epa-faces' and right before all the
faces.  Now it is defined with all the other options and thus before
the definition of the `epa-faces' group, which it does not belong to
for obvious reasons.
---
 lisp/epa.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lisp/epa.el b/lisp/epa.el
index 8ec4218735..0dd1cff465 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -56,11 +56,6 @@ epa-info-window-height
   :type 'integer
   :group 'epa)
 
-(defgroup epa-faces nil
-  "Faces for epa-mode."
-  :version "23.1"
-  :group 'epa)
-
 (defcustom epa-mail-aliases nil
   "Alist of aliases of email addresses that stand for encryption keys.
 Each element is a list of email addresses (ALIAS EXPANSIONS...).
@@ -76,6 +71,11 @@ epa-mail-aliases
   :group 'epa
   :version "24.4")
 
+(defgroup epa-faces nil
+  "Faces for epa-mode."
+  :version "23.1"
+  :group 'epa)
+
 (defface epa-validity-high
   '((default :weight bold)
     (((class color) (background dark)) :foreground "PaleTurquoise"))
-- 
2.26.0





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at 41276 <at> debbugs.gnu.org:


Received: (at 41276) by debbugs.gnu.org; 14 May 2020 20:14:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 16:14:49 2020
Received: from localhost ([127.0.0.1]:34982 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZKFl-0003Jr-IO
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 16:14:49 -0400
Received: from mail.hostpark.net ([212.243.197.30]:60462)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZKFj-0003Jh-OK
 for 41276 <at> debbugs.gnu.org; Thu, 14 May 2020 16:14:48 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id 677F81668B
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:14:46 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id L11pKvYkrZFn for <41276 <at> debbugs.gnu.org>;
 Thu, 14 May 2020 22:14:46 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id F15FA1667E
 for <41276 <at> debbugs.gnu.org>; Thu, 14 May 2020 22:14:45 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: 41276 <at> debbugs.gnu.org
Subject: Re: bug#41276: Acknowledgement ([PATCH 0/9] Various small
 improvements to EasyPG)
In-Reply-To: <handler.41276.B.15894836275636.ack <at> debbugs.gnu.org>
References: <20200514191325.22061-1-jonas@HIDDEN>
 <handler.41276.B.15894836275636.ack <at> debbugs.gnu.org>
Date: Thu, 14 May 2020 22:14:36 +0200
Message-ID: <87sgg26zpv.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41276
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Please excuse me for ending up opening an issue per commit and just
delete issues 41268-41275 and 41277 (but not 41276, this issue).

I sent the patches using:
  git send-email 000* --to=bug-gnu-emacs@HIDDEN

I should have used
  git send-email 0000-cover-letter.patch --to=bug-gnu-emacs@HIDDEN
wait for the response
> If you wish to submit further information on this problem, please
> send it to 41276 <at> debbugs.gnu.org.
and then
  0000-cover-letter.patch
  git send-email 000* --to=41276 <at> debbugs.gnu.org

which is what I am gonna do now.  Fingers crossed.  The patches may
arrive in the wrong order again, I don't know how to prevent that.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 14 May 2020 19:13:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 14 15:13:47 2020
Received: from localhost ([127.0.0.1]:34898 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jZJIg-0001Sk-Pl
	for submit <at> debbugs.gnu.org; Thu, 14 May 2020 15:13:46 -0400
Received: from lists.gnu.org ([209.51.188.17]:49266)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1jZJIb-0001S1-CM
 for submit <at> debbugs.gnu.org; Thu, 14 May 2020 15:13:41 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:56366)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1jZJIb-0005rM-7E
 for bug-gnu-emacs@HIDDEN; Thu, 14 May 2020 15:13:41 -0400
Received: from mail.hostpark.net ([212.243.197.30]:50288)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1jZJIQ-0005Oi-6T
 for bug-gnu-emacs@HIDDEN; Thu, 14 May 2020 15:13:40 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id DA203166C1
 for <bug-gnu-emacs@HIDDEN>; Thu, 14 May 2020 21:13:26 +0200 (CEST)
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124)
 with ESMTP id UPKUAf82nmlZ for <bug-gnu-emacs@HIDDEN>;
 Thu, 14 May 2020 21:13:26 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 2CB351667E
 for <bug-gnu-emacs@HIDDEN>; Thu, 14 May 2020 21:13:26 +0200 (CEST)
From: Jonas Bernoulli <jonas@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH 0/9] Various small improvements to EasyPG
Date: Thu, 14 May 2020 21:13:16 +0200
Message-Id: <20200514191325.22061-1-jonas@HIDDEN>
X-Mailer: git-send-email 2.26.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@HIDDEN;
 helo=mail.hostpark.net
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/14 15:13:27
X-ACL-Warn: Detected OS   = ???
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
 RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

This patches make various cosmetic and hopefully uncontroversial
changes to epa and epg libraries.

I am now to contributing to Emacs itself and not yet comfortable
with the commit message conventions among other things.  Tell me
what I am doing wrong please.

  Cheers,
  Jonas


Jonas Bernoulli (9):
  * lisp/epa.el (epa-faces): Move definition
  Add all epa faces to epa-faces Custom group
  * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix
    indentation
  Split EasyPG libraries into outline sections
  Improve and add doc-strings
  Drop unnecessary backward compatibility aliases
  Cosmetic changes to epa libraries
  epa-key-list-mode-map: Use widget-keymap as parent keymap
  * lisp/epa.el (epa-show-key): New command

 lisp/epa-dired.el  | 45 +++++++++++++++--------------------
 lisp/epa-file.el   | 39 +++++++++++++-----------------
 lisp/epa-hook.el   | 12 ++++++----
 lisp/epa-mail.el   |  9 +++++++
 lisp/epa.el        | 59 ++++++++++++++++++++++++++++++++++++----------
 lisp/epg-config.el | 22 +++++++++++------
 lisp/epg.el        | 26 +++++++++++++++++++-
 7 files changed, 139 insertions(+), 73 deletions(-)

-- 
2.26.0





Acknowledgement sent to Jonas Bernoulli <jonas@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#41276; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 15 May 2020 11:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.