GNU bug report logs - #41293
Add Pantheon desktop environment

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41293 in the body.
You can then email your comments to 41293 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Add Pantheon desktop environment
Date: Fri, 15 May 2020 20:21:55 +0000

[Message part 1 (text/plain, inline)]

This first patch adds the Granite library in gnu/packages/pantheon.scm.
It begins a patch series (to follow, 6 patches in total) that contains
some core pieces of the Pantheon desktop environment and a few
applications, laying the groundwork for further Pantheon packaging.

[0001-gnu-Add-granite.patch (text/x-diff, attachment)]

Message #8 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: Add Pantheon desktop environment (cont.)
Date: Fri, 15 May 2020 20:31:46 +0000

[Message part 1 (text/plain, inline)]

This patch adds the Sideload application, a graphical handler for
flatpakrefs.

[0002-gnu-Add-sideload.patch (text/x-diff, attachment)]

Message #11 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: Add Pantheon desktop environment (cont.)
Date: Fri, 15 May 2020 20:33:11 +0000

[Message part 1 (text/plain, inline)]

This patch adds Pantheon Calculator for basic arithmetic.

[0003-gnu-Add-pantheon-calculator.patch (text/x-diff, attachment)]

Message #14 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: Add Pantheon desktop environment (cont.)
Date: Fri, 15 May 2020 20:33:59 +0000

[Message part 1 (text/plain, inline)]

This patch adds Appstream to gnu/packages/freedesktop.

[0004-gnu-Add-appstream.patch (text/x-diff, attachment)]

Message #17 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: Add Pantheon desktop environment (cont.)
Date: Fri, 15 May 2020 20:34:46 +0000

[Message part 1 (text/plain, inline)]

This patch updates GNOME vte to 0.60.2, required for pantheon-terminal
(in next patch.)

[0005-gnu-vte-Update-to-0.60.2.patch (text/x-diff, attachment)]

Message #20 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: Add Pantheon desktop environment (cont.)
Date: Fri, 15 May 2020 20:35:39 +0000

[Message part 1 (text/plain, inline)]

This patch adds pantheon-terminal, a terminal emulator with tabs and
some nice friendly features.

[0006-gnu-Add-pantheon-terminal.patch (text/x-diff, attachment)]

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ryan Prior via Guix-patches via <guix-patches <at> gnu.org>
Cc: Ryan Prior <rprior <at> protonmail.com>, 41293 <at> debbugs.gnu.org
Subject: Re: [bug#41293] Add Pantheon desktop environment
Date: Tue, 19 May 2020 11:49:33 +0200

[Message part 1 (text/plain, inline)]

Hi,

thanks for the patch!

Added this one patch to guix master as commit 9f59a9b4bc93b3ef6cd3bd1c9eed04c30ba2d2d4
after removing gtk-update-icon-cache reference.

[Message part 2 (application/pgp-signature, inline)]

Message #29 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ryan Prior via Guix-patches via <guix-patches <at> gnu.org>
Cc: Ryan Prior <rprior <at> protonmail.com>, 41293 <at> debbugs.gnu.org
Subject: Re: [bug#41293] Add Pantheon desktop environment (cont.)
Date: Tue, 19 May 2020 12:15:56 +0200

[Message part 1 (text/plain, inline)]

Hi,

please do not invoke programs like 

  glib-compile-schemas
  update-desktop-database
  update-icon-cache

in individual packages.

The reason is that we are trying to keep packages modular.

If you add an icon cache with some fixed name that will cache just the icons
of that package in two packages, installing those into the same profile will
create a profile merge conflict.

We have profile hooks that will do glib-compile-schemas,
update-desktop-database and update-icon-cache anyway (in guix/profiles.scm),
so all that is required to do is to disable the invocation of these
programs in your package.

[Message part 2 (application/pgp-signature, inline)]

Message #35 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ryan Prior via Guix-patches via <guix-patches <at> gnu.org>
Cc: Ryan Prior <rprior <at> protonmail.com>, 41293 <at> debbugs.gnu.org
Subject: vte
Date: Tue, 19 May 2020 12:49:47 +0200

[Message part 1 (text/plain, inline)]

Thanks for that patch!

Pushed to guix master as commits 663def11dfa560066a910ebf290df82bcd72bfbc
and 11491e1b1bdac1255f1f529f13b8eecabdb7cc66.

[Message part 2 (application/pgp-signature, inline)]

Message #38 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ryan Prior via Guix-patches via <guix-patches <at> gnu.org>
Cc: Ryan Prior <rprior <at> protonmail.com>, 41293 <at> debbugs.gnu.org
Subject: Add pantheon-calculator
Date: Tue, 19 May 2020 13:00:20 +0200

[Message part 1 (text/plain, inline)]

Hi,

pushed that patch to guix master as commit 969811ad0e51adcbf503e38d9c9265814e3c2e27.

[Message part 2 (application/pgp-signature, inline)]

Message #41 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 41293 <at> debbugs.gnu.org
Cc: rprior <at> protonmail.com
Subject: Re: [bug#41293] Add Pantheon desktop environment (cont.)
Date: Tue, 19 May 2020 13:00:48 +0200

[Message part 1 (text/plain, inline)]

>   glib-compile-schemas

Ok, maybe that one isn't so bad.  Ok for that one.

[Message part 2 (application/pgp-signature, inline)]

Message #44 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ryan Prior via Guix-patches via <guix-patches <at> gnu.org>
Cc: Ryan Prior <rprior <at> protonmail.com>, 41293 <at> debbugs.gnu.org
Subject: Re: [bug#41293] Add Pantheon desktop environment (cont.)
Date: Tue, 19 May 2020 13:08:56 +0200

[Message part 1 (text/plain, inline)]

Why are there only native-inputs ? That doesn't look right.

[Message part 2 (application/pgp-signature, inline)]

Message #50 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: [PATCH 0/1] New Appstream patch
Date: Tue, 19 May 2020 17:36:26 +0000

Sorry about the all-native-inputs appstream package, I stopped paying
attention to it at some point. Here's a new appstream patch that bumps the
version and uses actual inputs.

Ryan

Ryan Prior (1):
  gnu: Add appstream.

 gnu/packages/freedesktop.scm | 59 ++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

-- 
2.26.2

Message #53 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: Add appstream.
Date: Tue, 19 May 2020 17:36:28 +0000

* gnu/packages/freedesktop.scm (appstream): New variable.
---
 gnu/packages/freedesktop.scm | 59 ++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index f00cb1e076..2373cc733c 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
 ;;; Copyright © 2020 Rene Saavedra <pacoon <at> protonmail.com>
 ;;; Copyright © 2020 Nicolò Balzarotti <nicolo <at> nixo.xyz>
+;;; Copyright © 2020 Ryan Prior <rprior <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -55,8 +56,10 @@
   #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages cryptsetup)
+  #:use-module (gnu packages databases)
   #:use-module (gnu packages disk)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages documentation)
@@ -1874,3 +1877,59 @@ useful with system integration.")
 into the Unity menu bar.  Based on KSNI, it also works in KDE and will
 fallback to generic Systray support if none of those are available.")
     (license license:lgpl2.1+)))
+
+(define-public appstream
+  (package
+    (name "appstream")
+    (version "0.12.11")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ximion/appstream.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0ma1nldpc01rr2x14q1ymv2fvf7qcs3wp8fdqsnd17qx0hrz483c"))))
+    (build-system meson-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "-Dvapi=true"
+             "-Dstemming=false"
+             "-Dapidocs=false"
+             "-Dinstall-docs=false")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'disable-stemmer-inc-dirs
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* "meson.build"
+                 (("include_directories\\(\\['\\/usr\\/include'\\]\\)")
+                  "''")
+                 (("subdir\\('docs\\/'\\)")
+                  ""))
+               (substitute* "data/meson.build"
+                 (("\\/etc")
+                   (string-append out "/etc")))
+               #t))))))
+    (inputs
+     `(("glib" ,glib)
+       ("gperf" ,gperf)
+       ("libsoup" ,libsoup)
+       ("libxml2" ,libxml2)
+       ("libxslt" ,libxslt)
+       ("libyaml" ,libyaml)
+       ("lmdb" ,lmdb)))
+    (native-inputs
+     `(("cmake" ,cmake)
+       ("gettext" ,gettext-minimal)
+       ("glib:bin" ,glib "bin") ; for glib-compile-resources
+       ("gobject-introspection" ,gobject-introspection)
+       ("pkg-config" ,pkg-config)
+       ("vala" ,vala)))
+    (home-page "https://www.freedesktop.org/wiki/Distributions/AppStream/")
+    (synopsis "Provides the foundation to build software-center applications")
+    (description "AppStream is a cross-distribution effort for enhancing the way
+we interact with the software repositories provided by GNU/Linux distributions
+by standardizing software component metadata.")
+    (license license:gpl2)))
-- 
2.26.2

Message #56 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: [PATCH 0/3] Updated Pantheon packages
Date: Tue, 02 Jun 2020 01:27:51 +0000

Here are updated patches for Sideload, Appstream, and Pantheon Terminal.

The sideload package is updated to the latest release. (1.1.1)

Sideload & pantheon-terminal packages are modified to disable compiling
schemas and updating desktop database as part of the install process.

These should all apply cleanly on master now. Let me know if there's still
further concerns!

Ryan Prior (3):
  gnu: Add sideload.
  gnu: Add appstream.
  gnu: Add pantheon-terminal.

 gnu/packages/freedesktop.scm |  59 +++++++++++++++++++
 gnu/packages/pantheon.scm    | 110 +++++++++++++++++++++++++++++++++++
 2 files changed, 169 insertions(+)

-- 
2.26.2

Message #59 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: Add sideload.
Date: Tue, 02 Jun 2020 01:27:57 +0000

* gnu/packages/pantheon.scm (sideload): New variable.
---
 gnu/packages/pantheon.scm | 60 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/pantheon.scm b/gnu/packages/pantheon.scm
index 72910e5470..6709cd2d8a 100644
--- a/gnu/packages/pantheon.scm
+++ b/gnu/packages/pantheon.scm
@@ -18,11 +18,14 @@
 
 (define-module (gnu packages pantheon)
   #:use-module (gnu packages cmake)
+  #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages package-management)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages xml)
   #:use-module (gnu packages)
   #:use-module (guix build-system meson)
   #:use-module (guix git-download)
@@ -107,3 +110,60 @@ in apps built for the Pantheon desktop.")
 arithmetic.  It is the default calculator application in the Pantheon
 desktop.")
     (license license:gpl3)))
+
+(define-public sideload
+  (package
+    (name "sideload")
+    (version "1.1.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/elementary/sideload.git")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0mlc3nm2navzxm8k1rwpbw4w6mv30lmhqybm8jqxd4v8x7my73vq"))))
+    (build-system meson-build-system)
+    (arguments
+     `(#:glib-or-gtk? #t
+       #:configure-flags (list (string-append "-Dflatpak="
+                                              (assoc-ref %build-inputs "flatpak")
+                                              "/include"))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'install 'set-environment-variables
+           (lambda _
+             ;; Disable compiling schemas and updating desktop databases
+             (setenv "DESTDIR" "/")
+             #t))
+         (add-after 'install 'install-symlinks
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin/io.elementary.sideload"))
+                    (link (string-append out "/bin/sideload")))
+               (symlink bin link)))))))
+    (inputs
+     `(("flatpak" ,flatpak)
+       ("granite" ,granite)
+       ("gtk" ,gtk+)
+       ("libostree" ,libostree)))
+    (propagated-inputs
+     `(("glib-networking" ,glib-networking)))
+    (native-inputs
+     `(("cmake" ,cmake)
+       ("gettext" ,gettext-minimal)
+       ("glib" ,glib)
+       ("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
+       ("libgee" ,libgee)
+       ("libxml2" ,libxml2)
+       ("pkg-config" ,pkg-config)
+       ("vala" ,vala)))
+    (home-page "https://github.com/elementary/sideload")
+    (synopsis "Graphical application to side-load Flatpaks")
+    (description "Sideload handles flatpakref files, like those you might find
+on Flathub or another third-party website providing a Flatpak app for
+download.")
+    (license license:gpl3)))
-- 
2.26.2

Message #62 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: Add appstream.
Date: Tue, 02 Jun 2020 01:28:06 +0000

* gnu/packages/freedesktop.scm (appstream): New variable.
---
 gnu/packages/freedesktop.scm | 59 ++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 90154cbba9..db1b18e4ee 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
 ;;; Copyright © 2020 Rene Saavedra <pacoon <at> protonmail.com>
 ;;; Copyright © 2020 Nicolò Balzarotti <nicolo <at> nixo.xyz>
+;;; Copyright © 2020 Ryan Prior <rprior <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -55,8 +56,10 @@
   #:use-module (gnu packages bash)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages cryptsetup)
+  #:use-module (gnu packages databases)
   #:use-module (gnu packages disk)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages documentation)
@@ -1870,3 +1873,59 @@ useful with system integration.")
 into the Unity menu bar.  Based on KSNI, it also works in KDE and will
 fallback to generic Systray support if none of those are available.")
     (license license:lgpl2.1+)))
+
+(define-public appstream
+  (package
+    (name "appstream")
+    (version "0.12.11")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/ximion/appstream.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0ma1nldpc01rr2x14q1ymv2fvf7qcs3wp8fdqsnd17qx0hrz483c"))))
+    (build-system meson-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "-Dvapi=true"
+             "-Dstemming=false"
+             "-Dapidocs=false"
+             "-Dinstall-docs=false")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'disable-stemmer-inc-dirs
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* "meson.build"
+                 (("include_directories\\(\\['\\/usr\\/include'\\]\\)")
+                  "''")
+                 (("subdir\\('docs\\/'\\)")
+                  ""))
+               (substitute* "data/meson.build"
+                 (("\\/etc")
+                   (string-append out "/etc")))
+               #t))))))
+    (inputs
+     `(("glib" ,glib)
+       ("gperf" ,gperf)
+       ("libsoup" ,libsoup)
+       ("libxml2" ,libxml2)
+       ("libxslt" ,libxslt)
+       ("libyaml" ,libyaml)
+       ("lmdb" ,lmdb)))
+    (native-inputs
+     `(("cmake" ,cmake)
+       ("gettext" ,gettext-minimal)
+       ("glib:bin" ,glib "bin") ; for glib-compile-resources
+       ("gobject-introspection" ,gobject-introspection)
+       ("pkg-config" ,pkg-config)
+       ("vala" ,vala)))
+    (home-page "https://www.freedesktop.org/wiki/Distributions/AppStream/")
+    (synopsis "Provides the foundation to build software-center applications")
+    (description "AppStream is a cross-distribution effort for enhancing the way
+we interact with the software repositories provided by GNU/Linux distributions
+by standardizing software component metadata.")
+    (license license:gpl2)))
-- 
2.26.2

Message #65 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: Add pantheon-terminal.
Date: Tue, 02 Jun 2020 01:28:11 +0000

* gnu/packages/pantheon.scm (pantheon-terminal): New variable.
---
 gnu/packages/pantheon.scm | 50 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/pantheon.scm b/gnu/packages/pantheon.scm
index 6709cd2d8a..250e8e3b2d 100644
--- a/gnu/packages/pantheon.scm
+++ b/gnu/packages/pantheon.scm
@@ -167,3 +167,53 @@ desktop.")
 on Flathub or another third-party website providing a Flatpak app for
 download.")
     (license license:gpl3)))
+
+(define-public pantheon-terminal
+  (package
+    (name "pantheon-terminal")
+    (version "5.5.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/elementary/terminal.git")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "119iwmzbpkj4nmxinqfsh73lx23g8gbl6ha6wc4mc4fq9hpnc9c2"))))
+    (build-system meson-build-system)
+    (arguments
+     `(#:glib-or-gtk? #t
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'install 'set-environment-variables
+           (lambda _
+             ;; Disable compiling schemas and updating desktop databases
+             (setenv "DESTDIR" "/")
+             #t))
+         (add-after 'install 'install-symlinks
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin/io.elementary.terminal"))
+                    (link (string-append out "/bin/pantheon-terminal")))
+               (symlink bin link)))))))
+    (inputs
+     `(("granite" ,granite)
+       ("gtk" ,gtk+)
+       ("vte" ,vte)))
+    (native-inputs
+     `(("gettext" ,gettext-minimal)
+       ("glib" ,glib)
+       ("appstream" ,appstream)
+       ("libgee" ,libgee)
+       ("desktop-file-utils" ,desktop-file-utils) ; required for tests
+       ("glib:bin" ,glib "bin") ; for glib-compile-resources
+       ("pkg-config" ,pkg-config)
+       ("gobject-introspection" ,gobject-introspection)
+       ("vala" ,vala)))
+    (home-page "https://github.com/elementary/terminal")
+    (synopsis "Graphical terminal with opinionated design and thoughtful touches")
+    (description "A lightweight, beautiful, and simple terminal application.
+Comes with sane defaults, browser-like tabs, sudo paste protection, smart
+copy/paste, and little to no configuration.")
+    (license license:lgpl3)))
-- 
2.26.2

Message #68 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: "41293 <at> debbugs.gnu.org" <41293 <at> debbugs.gnu.org>
Subject: Pantheon packages
Date: Thu, 18 Jun 2020 22:30:49 +0000

[Message part 1 (text/plain, inline)]

Hey folks, just bumping this patch set!

Ryan

[Message part 2 (text/html, inline)]

Message #71 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Ryan Prior <rprior <at> protonmail.com>,
 Ryan Prior via Guix-patches <guix-patches <at> gnu.org>, 41293 <at> debbugs.gnu.org
Subject: Re: [bug#41293] [PATCH 1/3] gnu: Add sideload.
Date: Mon, 22 Jun 2020 21:16:54 +0200

[Message part 1 (text/plain, inline)]

Hello!

Sorry for the slooow response...

Ryan Prior via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/pantheon.scm (sideload): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-before 'install 'set-environment-variables
> +           (lambda _
> +             ;; Disable compiling schemas and updating desktop databases
> +             (setenv "DESTDIR" "/")
> +             #t))

That's an unorthodox workaround :-) does the build system ignore it when
DESTDIR is set, or do they just end up in a different location?

Is the "glib:bin" input still needed?

> +    (inputs
> +     `(("flatpak" ,flatpak)
> +       ("granite" ,granite)
> +       ("gtk" ,gtk+)
> +       ("libostree" ,libostree)))
> +    (propagated-inputs
> +     `(("glib-networking" ,glib-networking)))

Can you add a comment about why this needs to be propagated?

> +    (native-inputs
> +     `(("cmake" ,cmake)

Use 'cmake-minimal' if CMake is required (is it?).

> +       ("gettext" ,gettext-minimal)
> +       ("glib" ,glib)
> +       ("glib:bin" ,glib "bin")
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("libgee" ,libgee)
> +       ("libxml2" ,libxml2)
> +       ("pkg-config" ,pkg-config)
> +       ("vala" ,vala)))
> +    (home-page "https://github.com/elementary/sideload")
> +    (synopsis "Graphical application to side-load Flatpaks")
> +    (description "Sideload handles flatpakref files, like those you might find
> +on Flathub or another third-party website providing a Flatpak app for
> +download.")
> +    (license license:gpl3)))

This should be 'gpl3+' because no source files say "GPL 3 only" (in fact
they explicitly mention GPL 3 or any later version).

[signature.asc (application/pgp-signature, inline)]

Message #77 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Ryan Prior <rprior <at> protonmail.com>,
 Ryan Prior via Guix-patches <guix-patches <at> gnu.org>, 41293 <at> debbugs.gnu.org
Subject: Re: [bug#41293] [PATCH 2/3] gnu: Add appstream.
Date: Mon, 22 Jun 2020 21:23:06 +0200

[Message part 1 (text/plain, inline)]

Ryan Prior via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/freedesktop.scm (appstream): New variable.

[...]

> +    (inputs
> +     `(("glib" ,glib)
> +       ("gperf" ,gperf)
> +       ("libsoup" ,libsoup)
> +       ("libxml2" ,libxml2)
> +       ("libxslt" ,libxslt)
> +       ("libyaml" ,libyaml)
> +       ("lmdb" ,lmdb)))
> +    (native-inputs
> +     `(("cmake" ,cmake)

'cmake-minimal' here too.

> +       ("gettext" ,gettext-minimal)
> +       ("glib:bin" ,glib "bin") ; for glib-compile-resources
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("pkg-config" ,pkg-config)
> +       ("vala" ,vala)))
> +    (home-page "https://www.freedesktop.org/wiki/Distributions/AppStream/")
> +    (synopsis "Provides the foundation to build software-center applications")

I think the GitHub tagline is better: "Tools and libraries to work with
AppStream metadata".

> +    (description "AppStream is a cross-distribution effort for enhancing the way
> +we interact with the software repositories provided by GNU/Linux distributions
> +by standardizing software component metadata.")

Who is 'we' in this context?  Maybe we can use the README description:

"AppStream is a collaborative effort for making machine-readable
software metadata available to programs that need it."

Do you know if Guix is supported?  :-)

> +    (license license:gpl2)))

The library portions of this package seems to be 'lgpl2.1+', and the
tools are 'gpl2' (only).  Can you add a comment about it and list both
licenses?

[signature.asc (application/pgp-signature, inline)]

Message #83 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Ryan Prior <rprior <at> protonmail.com>,
 Ryan Prior via Guix-patches <guix-patches <at> gnu.org>, 41293 <at> debbugs.gnu.org
Subject: Re: [bug#41293] [PATCH 3/3] gnu: Add pantheon-terminal.
Date: Mon, 22 Jun 2020 21:30:46 +0200

[Message part 1 (text/plain, inline)]

Ryan Prior via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/pantheon.scm (pantheon-terminal): New variable.

[...]

> +    (arguments
> +     `(#:glib-or-gtk? #t
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'install 'set-environment-variables
> +           (lambda _
> +             ;; Disable compiling schemas and updating desktop databases
> +             (setenv "DESTDIR" "/")
> +             #t))

Same comment as patch 1/3.

> +    (synopsis "Graphical terminal with opinionated design and thoughtful touches")

This synopsis borders on "marketing language" (see the section about
Synopses and Descriptions in the manual), but maybe it's OK.

> +    (description "A lightweight, beautiful, and simple terminal application.

Can you turn this into a full sentence?  I.e. "pantheon-terminal is a ...".

> +Comes with sane defaults, browser-like tabs, sudo paste protection, smart
> +copy/paste, and little to no configuration.")

Also here, "It comes with a ...".

> +    (license license:lgpl3)))

Indeed LGPL3 only!  Odd choice.  :-)

[signature.asc (application/pgp-signature, inline)]

Message #89 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: 41293 <at> debbugs.gnu.org
Subject: Re: [bug#41293] [PATCH 1/3] gnu: Add sideload.
Date: Wed, 24 Jun 2020 21:39:16 +0200

[Message part 1 (text/plain, inline)]

Hi Ryan,

(+ debbugs, please keep it in CC)

Ryan Prior <rprior <at> protonmail.com> writes:

> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Monday, June 22, 2020 7:16 PM, Marius Bakke <marius <at> gnu.org> wrote:
>
>
>> That's an unorthodox workaround :-) does the build system ignore it when
>> DESTDIR is set, or do they just end up in a different location?
>
> This is a common pattern in build systems for Pantheon software, one you'll see come up again and again as I add more Pantheon packages. The post-install script runs extra steps unless the DESTDIR env variable is set. For example: https://github.com/elementary/sideload/blob/master/meson/post_install.py#L9

OK.  Weird, but works.  :-)

>> Is the "glib:bin" input still needed?
>
> Yes, for glib-compile-resources, which is invoked here as it is with many other GNOME packages in Guix.

Right.

>> > -   (propagated-inputs
>> > -       `(("glib-networking" ,glib-networking)))
>> >
>> >
>>
>> Can you add a comment about why this needs to be propagated?
>
> I didn't take good notes, it was basically "it didn't work without this." And now that I try it again, it seems what I really need to propagate is gpgme and not glib-networking. I will add a note. (I want to get good at patching packages to remove the need for propagation but I don't know where to begin with this one.)

At least for GnuPG, substituting all references to 'gpg' with
(string-append gnupg "/bin/gpg") should work.  I guess something similar
will work for GPGME.

>>
>> > -   (native-inputs
>> > -       `(("cmake" ,cmake)
>> >
>> >
>>
>> Use 'cmake-minimal' if CMake is required (is it?).
>
> Nope was never needed, removed. (I think I was adding cmake to a lot of Meson packages for a while because they complain about not having it in their build output, but it's really just a warning.)

Yes, learning to ignore useless warnings is an important packaging
skill.  :-)

>> > -   (license license:gpl3)))
>>
>> This should be 'gpl3+' because no source files say "GPL 3 only" (in fact
>> they explicitly mention GPL 3 or any later version).
>
> Fixed & updated patch follows.

Applied!  I moved 'glib', 'libgee', and 'libxml2' to inputs because they
were referenced by the io.elementary.sideload binary.  Let me know if
you think this was wrong.

Will you submit updated patches for the other two in this series too?

Thanks!

[signature.asc (application/pgp-signature, inline)]

Message #92 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: "41293 <at> debbugs.gnu.org" <41293 <at> debbugs.gnu.org>
Subject: Re: [bug#41293] Pantheon packages
Date: Wed, 09 Sep 2020 22:57:19 +0200

Hello Ryan,

Did you have a chance to look at the comments Marius made back in June?

  https://issues.guix.gnu.org/41293

It would be nice to unlock this patch series!  :-)

Ludo’.

Message #95 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: altadil <Altadil <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Cc: altadil <altadil <at> protonmail.com>
Subject: [PATCH 1/2] gnu: Add granite-6.
Date: Mon, 11 Sep 2023 12:07:41 +0000

* gnu/packages/pantheon.scm (granite-6): new variable.

This version will be needed to add some pantheon packages.
More precisely, those still using GTK+ 3.
---
guix build --rounds=2 was successfully run on a Zen4 CPU,
for the following --system= options:
- x86_64-linux
- i686-linux
- aarch64-linux.
 gnu/packages/pantheon.scm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/gnu/packages/pantheon.scm b/gnu/packages/pantheon.scm
index 12892db137..f5b19eb452 100644
--- a/gnu/packages/pantheon.scm
+++ b/gnu/packages/pantheon.scm
@@ -72,6 +72,22 @@ (define-public granite
 in apps built for the Pantheon desktop.")
     (license license:lgpl3+)))
 
+;; This is required for pantheon apps that have not been ported to GTK4 yet.
+(define-public granite-6
+  (package
+    (inherit granite)
+    (version "6.2.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/elementary/granite")
+                    (commit version)))
+              (file-name (git-file-name "granite" version))
+              (sha256
+               (base32
+                "0ilslmg63hh2x7h5rvs3mhzw1y9ixhhkqnn1j1lzwm12v2iidkaq"))))
+    (propagated-inputs (list glib libgee gtk+))))
+
 (define-public pantheon-calculator
   (package
     (name "pantheon-calculator")

base-commit: 2eb6df537c36da8bf8e81ff698421f6fb1bfd1ab
-- 
2.41.0

Message #98 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: altadil <Altadil <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Cc: altadil <altadil <at> protonmail.com>
Subject: [PATCH 2/2] gnu: Add pantheon-terminal.
Date: Mon, 11 Sep 2023 12:07:58 +0000

* gnu/packages/pantheon.scm (pantheon-terminal): New variable.
---
This is an update of the package initially sent by rprior.
guix build --rounds=2 was successfully run on a Zen4 CPU,
for the following --system= options:
- x86_64-linux
- i686-linux
- aarch64-linux.
I’ve been using the app for a couple of days.
I’ve detected one bug: right-clicking a tab (in GNOME) segfaults.
But I think debugging this would be way above my level. :(
Apart from this one, everything seems fine.
 gnu/packages/pantheon.scm | 53 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/pantheon.scm b/gnu/packages/pantheon.scm
index f5b19eb452..f01c9778ee 100644
--- a/gnu/packages/pantheon.scm
+++ b/gnu/packages/pantheon.scm
@@ -26,11 +26,13 @@ (define-module (gnu packages pantheon)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages package-management)
+  #:use-module (gnu packages pcre)
   #:use-module (gnu packages photo)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages web)
+  #:use-module (gnu packages xorg)
   #:use-module (gnu packages)
   #:use-module (guix build-system meson)
   #:use-module (guix git-download)
@@ -129,6 +131,57 @@ (define-public pantheon-calculator
 desktop.")
     (license license:gpl3)))
 
+(define-public pantheon-terminal
+  (package
+    (name "pantheon-terminal")
+    (version "6.1.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/elementary/terminal")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0x3gzghnfx4a1q2zhra4dysc0pm1zvlfdxj96qhfb627pz16iv4k"))))
+    (build-system meson-build-system)
+    (arguments
+     `(#:tests? #f
+       #:glib-or-gtk? #t
+       #:phases (modify-phases %standard-phases
+                  (add-before 'install 'set-environment-variables
+                    (lambda _
+                      ;; Disable compiling schemas and updating desktop databases
+                      (setenv "DESTDIR" "/") #t))
+                  (add-after 'install 'install-symlinks
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (bin (string-append out
+                                   "/bin/io.elementary.terminal"))
+                             (link (string-append out "/bin/pantheon-terminal")))
+                        (symlink bin link)))))))
+    (native-inputs (list appstream
+                         desktop-file-utils ;required for tests
+                         gettext-minimal ;for msgfmt
+                         `(,glib "bin") ;for glib-compile-resources
+                         gobject-introspection
+                         pkg-config
+                         vala))
+    (inputs (list granite-6
+                  gtk+
+                  libgee
+                  libhandy
+                  pcre2
+                  vte
+                  xvfb-run))
+    (synopsis "Terminal emulator from elementaryOS")
+    (description "pantheon-terminal is a lightweight, beautiful and simple
+terminal.  It comes with sane defaults, browser-class tabs, sudo paste
+protection, smart copy/paste, and little to no configuration.  It is the default
+terminal in the Pantheon desktop.")
+    (home-page "https://elementary.io/open-source")
+    (license license:lgpl3)))
+
 (define-public sideload
   (package
     (name "sideload")
-- 
2.41.0

Message #103 received at 41293-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: altadil <Altadil <at> protonmail.com>
Cc: 41293-done <at> debbugs.gnu.org
Subject: Re: [bug#41293] [PATCH 2/2] gnu: Add pantheon-terminal.
Date: Thu, 28 Sep 2023 19:36:35 +0300

[Message part 1 (text/plain, inline)]

I've added a copyright line for you at the top of the file. I also moved
xvfb-run to native-inputs since the package doesn't retain a reference
to it. I also added a note by the tests.

Thanks! Patches pushed.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #106 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: altadil <Altadil <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Cc: altadil <altadil <at> protonmail.com>
Subject: [PATCH 1/5] gnu: Add pantheon-stylesheet.
Date: Sun, 01 Oct 2023 12:41:21 +0000

* gnu/packages/pantheon.scm (pantheon-stylesheet): New variable.
---
This package is not very useful by itself, but hopefully will be, once
we manage to get more of Pantheon into Guix. :)
guix build --rounds=2 was successfully run on a Zen4 CPU,
for the following --system= options:
- x86_64-linux
- i686-linux
- aarch64-linux
- armhf-linux
- riscv64-linux.
I am still a packaging noob, so apologies in advance for my mistakes
in this patch series, and thanks for the help!
 gnu/packages/pantheon.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/pantheon.scm b/gnu/packages/pantheon.scm
index 5b83b96801..55cb65045e 100644
--- a/gnu/packages/pantheon.scm
+++ b/gnu/packages/pantheon.scm
@@ -132,6 +132,28 @@ (define-public pantheon-calculator
 desktop.")
     (license license:gpl3)))
 
+(define-public pantheon-stylesheet
+  (package
+    (name "pantheon-stylesheet")
+    (version "7.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/elementary/stylesheet")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0l1xv05zl0jfs9kfv3rnz821a442rpywcvxbcnsm6gp4q0kha7b5"))))
+    (build-system meson-build-system)
+    (native-inputs (list gettext-minimal)) ;for msgfmt
+    (inputs (list sassc))
+    (synopsis "GTK stylesheet for the Pantheon desktop")
+    (description "pantheon-stylesheet is the GTK Stylesheet for the Pantheon
+desktop environment (originally from elementary OS).")
+    (home-page "https://elementary.io/open-source")
+    (license license:gpl3+)))
+
 (define-public pantheon-terminal
   (package
     (name "pantheon-terminal")

base-commit: 337dbf6867597b6e3b72b0bdb2152a42a9f41dbc
-- 
2.41.0

Message #109 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: altadil <Altadil <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Cc: altadil <altadil <at> protonmail.com>
Subject: [PATCH 2/5] gnu: Add pantheon-photos.
Date: Sun, 01 Oct 2023 12:41:50 +0000

* gnu/packages/pantheon.scm (pantheon-photos): New variable.
---
guix build --rounds=2 was successfully run on a Zen4 CPU,
for the following --system= options:
- x86_64-linux
- i686-linux
- aarch64-linux.
 gnu/packages/pantheon.scm | 59 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/gnu/packages/pantheon.scm b/gnu/packages/pantheon.scm
index 55cb65045e..3465e5cb37 100644
--- a/gnu/packages/pantheon.scm
+++ b/gnu/packages/pantheon.scm
@@ -25,14 +25,18 @@ (define-module (gnu packages pantheon)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages package-management)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages photo)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages sqlite)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages web)
+  #:use-module (gnu packages webkit)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages)
   #:use-module (guix build-system meson)
@@ -132,6 +136,61 @@ (define-public pantheon-calculator
 desktop.")
     (license license:gpl3)))
 
+(define-public pantheon-photos
+  (package
+    (name "pantheon-photos")
+    (version "2.8.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/elementary/photos")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1aw77sdh2z7fah3vbi68145wc0xqg2afch1kswvgkmij0f0n04jn"))))
+    (build-system meson-build-system)
+    (arguments
+     `(#:glib-or-gtk? #t
+       #:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'disable-schema-cache-generation
+                    (lambda _
+                      (setenv "DESTDIR" "/")))
+                  (add-after 'install 'install-symlinks
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (bin (string-append out
+                                                 "/bin/io.elementary.photos"))
+                             (link (string-append out "/bin/pantheon-photos")))
+                        (symlink bin link)))))))
+    (native-inputs (list desktop-file-utils
+                         `(,glib "bin") intltool pkg-config vala))
+    (inputs (list geocode-glib-with-libsoup2
+                  gexiv2
+                  granite-6
+                  gstreamer
+                  gst-plugins-base
+                  gtk+
+                  json-glib
+                  libexif
+                  libgee
+                  libgphoto2
+                  libgudev
+                  libhandy
+                  libraw
+                  libsoup-minimal-2
+                  libwebp
+                  rest
+                  sqlite
+                  webkitgtk-with-libsoup2))
+    (synopsis "Photo viewer and organizer designed for the Pantheon desktop")
+    (description
+     "Photos is an image viewer and organizer.  It originally comes
+from elementary OS and is designed for the Pantheon desktop environment (but can
+also be used on others.")
+    (home-page "https://elementary.io/open-source")
+    (license license:lgpl2.1+)))
+
 (define-public pantheon-stylesheet
   (package
     (name "pantheon-stylesheet")
-- 
2.41.0

Message #112 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: altadil <Altadil <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Cc: altadil <altadil <at> protonmail.com>
Subject: [PATCH 4/5] gnu: Add pantheon-iconbrowser.
Date: Sun, 01 Oct 2023 12:41:59 +0000

* gnu/packages/pantheon.scm (pantheon-iconbrowser): New variable.
---
guix build --rounds=2 was successfully run on a Zen4 CPU,
for the following --system= options:
- x86_64-linux
- i686-linux
- aarch64-linux.
 gnu/packages/pantheon.scm | 40 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/pantheon.scm b/gnu/packages/pantheon.scm
index ca124f8939..1864dff5eb 100644
--- a/gnu/packages/pantheon.scm
+++ b/gnu/packages/pantheon.scm
@@ -137,6 +137,46 @@ (define-public pantheon-calculator
 desktop.")
     (license license:gpl3)))
 
+(define-public pantheon-iconbrowser
+  (package
+    (name "pantheon-iconbrowser")
+    (version "2.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/elementary/iconbrowser")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0b1afyizq3c94qkf4cqy5jnb4v3nib5vc88k34r08c604p1z2h8p"))))
+    (build-system meson-build-system)
+    (arguments
+     `(#:glib-or-gtk? #t
+       #:phases (modify-phases %standard-phases
+                  (add-after 'install 'install-symlinks
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (bin (string-append out
+                                   "/bin/io.elementary.iconbrowser"))
+                             (link (string-append out
+                                                  "/bin/pantheon-iconbrowser")))
+                        (symlink bin link)))))))
+    (native-inputs (list gettext-minimal ;for msgfmt
+                         `(,glib "bin")
+                         `(,gtk "bin")
+                         pkg-config
+                         vala))
+    (inputs (list granite gtk gtksourceview))
+    (synopsis "Browse and search system icons")
+    (description
+     "Icon Browser is an application for browsing system icons by
+category or searching them by name.  It displays icons at different sizes, as
+well as code snippets (to use the icons in your own apps).  It is designed for
+the Pantheon desktop environment (originally from elementary OS).")
+    (home-page "https://elementary.io/open-source")
+    (license license:gpl3+)))
+
 (define-public pantheon-photos
   (package
     (name "pantheon-photos")
-- 
2.41.0

Message #115 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: altadil <Altadil <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Cc: altadil <altadil <at> protonmail.com>
Subject: [PATCH 3/5] gnu: Add pantheon-videos.
Date: Sun, 01 Oct 2023 12:41:55 +0000

* gnu/packages/pantheon.scm (pantheon-videos): New variable.
---
guix build --rounds=2 was successfully run on a Zen4 CPU,
for the following --system= options:
- x86_64-linux
- i686-linux
- aarch64-linux.
This one is a work in progress, as there are at least two issues.
First, it is missing some video codecs and I do not know how to fix it.
Second, the trick used in other pantheon packages to prevent the
schemas generation after install won’t work here, as the step is not
made dependent on any condition (if I understand the meson.build file
correctly). Do we have to patch the source for that, or is there a
better way ?
 gnu/packages/pantheon.scm | 49 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/pantheon.scm b/gnu/packages/pantheon.scm
index 3465e5cb37..ca124f8939 100644
--- a/gnu/packages/pantheon.scm
+++ b/gnu/packages/pantheon.scm
@@ -35,6 +35,7 @@ (define-module (gnu packages pantheon)
   #:use-module (gnu packages python)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages xml)
+  #:use-module (gnu packages video)
   #:use-module (gnu packages web)
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages xorg)
@@ -264,6 +265,54 @@ (define-public pantheon-terminal
     (home-page "https://elementary.io/open-source")
     (license license:lgpl3)))
 
+(define-public pantheon-videos
+  (package
+    (name "pantheon-videos")
+    (version "3.0.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/elementary/videos")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0873g3mcrpgwmjamy8dhdya7fxki4qpwp8wa6lv5cdipq7pkiprv"))))
+    (build-system meson-build-system)
+    (arguments
+     `(#:glib-or-gtk? #t
+       #:phases (modify-phases %standard-phases
+                  (add-after 'install 'install-symlinks
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (bin (string-append out
+                                                 "/bin/io.elementary.videos"))
+                             (link (string-append out "/bin/pantheon-videos")))
+                        (symlink bin link)))))))
+    (native-inputs (list gettext-minimal ;for msgfmt.
+                         `(,glib "bin") ;glib-compile-schemas.
+                         pkg-config
+                         vala))
+    (inputs (list flatpak
+                  ffmpeg
+                  granite-6
+                  gst-libav
+                  gst-plugins-bad
+                  gst-plugins-base
+                  gst-plugins-good
+                  gst-plugins-ugly
+                  gstreamer
+                  gtk+
+                  libgee
+                  libhandy))
+    (synopsis "Video player and library app designed for the Pantheon desktop")
+    (description
+     "Videos is a video player and video library application.  It
+originally comes from elementary OS and is designed for the Pantheon desktop
+environment (but can be used with others as well).")
+    (home-page "https://elementary.io/open-source")
+    (license license:gpl3+)))
+
 (define-public sideload
   (package
     (name "sideload")
-- 
2.41.0

Message #118 received at 41293 <at> debbugs.gnu.org (full text, mbox):

From: altadil <Altadil <at> protonmail.com>
To: 41293 <at> debbugs.gnu.org
Cc: altadil <altadil <at> protonmail.com>
Subject: [PATCH 5/5] gnu: Add pantheon-sound-theme.
Date: Sun, 01 Oct 2023 12:42:04 +0000

* gnu/packages/pantheon.scm (pantheon-sound-theme): New variable.
---
guix build --rounds=2 was successfully run on a Zen4 CPU,
for the following --system= options:
- x86_64-linux
- i686-linux
- aarch64-linux
- armhf-linux
- riscv64-linux.
 gnu/packages/pantheon.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/pantheon.scm b/gnu/packages/pantheon.scm
index 1864dff5eb..8e17101bd9 100644
--- a/gnu/packages/pantheon.scm
+++ b/gnu/packages/pantheon.scm
@@ -232,6 +232,30 @@ (define-public pantheon-photos
     (home-page "https://elementary.io/open-source")
     (license license:lgpl2.1+)))
 
+(define-public pantheon-sound-theme
+  (package
+    (name "pantheon-sound-theme")
+    (version "1.1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/elementary/sound-theme")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0kyqh4y6fk0mhlxc5ary17f1fhg2n6f6gl2v8wval9vxmjsa07kx"))))
+    (build-system meson-build-system)
+    (synopsis "Set of system sounds for the Pantheon desktop")
+    (description
+     "pantheon-sound-theme is a set of system sounds for the
+Pantheon desktop (originally from elementary OS).  It is designed to be light,
+natural/physical, and pleasant.")
+    (home-page "https://elementary.io/open-source")
+    ;; dialog-warning.ogg is licensed under Creative Commons Attribution and
+    ;;  was sourced from notificationsounds.com.
+    (license (list license:unlicense license:cc-by4.0))))
+
 (define-public pantheon-stylesheet
   (package
     (name "pantheon-stylesheet")
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.