GNU bug report logs - #41338
Toolbar-bug in Emacs 27.0.91/Pretest

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Konrad Podczeck <konrad.podczeck@HIDDEN>; Done: Juri Linkov <juri@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
bug marked as fixed in version 31.0.50, send any further explanations to 41338 <at> debbugs.gnu.org and Konrad Podczeck <konrad.podczeck@HIDDEN> Request was from Juri Linkov <juri@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 23 Jul 2024 18:02:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 23 14:02:31 2024
Received: from localhost ([127.0.0.1]:60712 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sWJqI-0000Ck-Lc
	for submit <at> debbugs.gnu.org; Tue, 23 Jul 2024 14:02:30 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35375)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>)
 id 1sWJqF-0000CS-V1; Tue, 23 Jul 2024 14:02:28 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 10148E0003;
 Tue, 23 Jul 2024 18:01:54 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: 41338 <at> debbugs.gnu.org
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
In-Reply-To: <86cz5hrjwr.fsf@HIDDEN> (Juri Linkov's message of "Thu, 
 09 Mar 2023 19:14:04 +0200")
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
 <87mu66i5gl.fsf@HIDDEN>
 <8d5d6374-26f8-49b7-badd-c676c9622ea8@default>
 <87k10dz051.fsf@HIDDEN> <87h7vewp6i.fsf@HIDDEN>
 <87o8plb6kh.fsf@HIDDEN> <86cz5hrjwr.fsf@HIDDEN>
Date: Tue, 23 Jul 2024 21:00:41 +0300
Message-ID: <86o76oxa2e.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

close 41338 31.0.50
thanks

>>>> isearch uses overriding-terminal-local-map, so the proper test case is:
>>>>
>>>> (setq overriding-terminal-local-map
>>>>       (let ((map (make-keymap)))
>>>> 	(define-key map [delete-frame]
>>>> 	  (lambda (&rest ignore)
>>>> 	    (interactive)
>>>> 	    (message "DELETE-FRAME")))
>>>> 	(define-key map "!"
>>>> 	  (lambda (&rest ignore)
>>>> 	    (interactive)
>>>> 	    (message "!")))
>>>> 	map))
>>>>
>>>> and indeed typing '!' you get the message,
>>>> but no message when clicking the `X' icon.
>>>
>>> The docstring of 'overriding-terminal-local-map' says:
>>>
>>>   Per-terminal keymap that takes precedence over all other keymaps.
>>>
>>> so maybe this is right for a *per-terminal* keymap not to react
>>> to window events such as clicking the `X' icon?
>>
>> If there is no bug here, then I see two possible solutions for isearch:
>>
>> 1. use special-event-map in isearch.el the same way as isearch.el uses
>>    overriding-terminal-local-map;
>>
>> 2. use the hook ‘delete-frame-functions’ to explicitly exit isearch.
>
> Since nobody proposed a better solution, here is a fix:
>
> diff --git a/lisp/isearch.el b/lisp/isearch.el
> index 505837de988..005376f8257 100644
> --- a/lisp/isearch.el
> +++ b/lisp/isearch.el
> @@ -1330,6 +1333,7 @@ isearch-mode
>    (add-hook 'pre-command-hook 'isearch-pre-command-hook)
>    (add-hook 'post-command-hook 'isearch-post-command-hook)
>    (add-hook 'mouse-leave-buffer-hook 'isearch-mouse-leave-buffer)
> +  (add-hook 'delete-frame-functions 'isearch-done)
>    (add-hook 'kbd-macro-termination-hook 'isearch-done)
>  
>    ;; isearch-mode can be made modal (in the sense of not returning to
> @@ -1430,6 +1434,7 @@ isearch-done
>    (remove-hook 'pre-command-hook 'isearch-pre-command-hook)
>    (remove-hook 'post-command-hook 'isearch-post-command-hook)
>    (remove-hook 'mouse-leave-buffer-hook 'isearch-mouse-leave-buffer)
> +  (remove-hook 'delete-frame-functions 'isearch-done)
>    (remove-hook 'kbd-macro-termination-hook 'isearch-done)
>    (when (buffer-live-p isearch--current-buffer)
>      (with-current-buffer isearch--current-buffer

So now this is pushed to master, and closed.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 9 Mar 2023 17:27:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 09 12:27:35 2023
Received: from localhost ([127.0.0.1]:53028 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1paK3D-0008JY-CI
	for submit <at> debbugs.gnu.org; Thu, 09 Mar 2023 12:27:35 -0500
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:47491)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1paK3B-0008JH-Dc
 for 41338 <at> debbugs.gnu.org; Thu, 09 Mar 2023 12:27:34 -0500
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id 222082000C;
 Thu,  9 Mar 2023 17:27:24 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
In-Reply-To: <87o8plb6kh.fsf@HIDDEN> (Juri Linkov's message of "Mon, 
 15 Jun 2020 01:55:58 +0300")
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
 <87mu66i5gl.fsf@HIDDEN>
 <8d5d6374-26f8-49b7-badd-c676c9622ea8@default>
 <87k10dz051.fsf@HIDDEN> <87h7vewp6i.fsf@HIDDEN>
 <87o8plb6kh.fsf@HIDDEN>
Date: Thu, 09 Mar 2023 19:14:04 +0200
Message-ID: <86cz5hrjwr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Stephen Berman <stephen.berman@HIDDEN>,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>>> isearch uses overriding-terminal-local-map, so the proper test case is:
>>>
>>> (setq overriding-terminal-local-map
>>>       (let ((map (make-keymap)))
>>> 	(define-key map [delete-frame]
>>> 	  (lambda (&rest ignore)
>>> 	    (interactive)
>>> 	    (message "DELETE-FRAME")))
>>> 	(define-key map "!"
>>> 	  (lambda (&rest ignore)
>>> 	    (interactive)
>>> 	    (message "!")))
>>> 	map))
>>>
>>> and indeed typing '!' you get the message,
>>> but no message when clicking the `X' icon.
>>
>> The docstring of 'overriding-terminal-local-map' says:
>>
>>   Per-terminal keymap that takes precedence over all other keymaps.
>>
>> so maybe this is right for a *per-terminal* keymap not to react
>> to window events such as clicking the `X' icon?
>
> If there is no bug here, then I see two possible solutions for isearch:
>
> 1. use special-event-map in isearch.el the same way as isearch.el uses
>    overriding-terminal-local-map;
>
> 2. use the hook ‘delete-frame-functions’ to explicitly exit isearch.

Since nobody proposed a better solution, here is a fix:

diff --git a/lisp/isearch.el b/lisp/isearch.el
index 505837de988..005376f8257 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -1330,6 +1333,7 @@ isearch-mode
   (add-hook 'pre-command-hook 'isearch-pre-command-hook)
   (add-hook 'post-command-hook 'isearch-post-command-hook)
   (add-hook 'mouse-leave-buffer-hook 'isearch-mouse-leave-buffer)
+  (add-hook 'delete-frame-functions 'isearch-done)
   (add-hook 'kbd-macro-termination-hook 'isearch-done)
 
   ;; isearch-mode can be made modal (in the sense of not returning to
@@ -1430,6 +1434,7 @@ isearch-done
   (remove-hook 'pre-command-hook 'isearch-pre-command-hook)
   (remove-hook 'post-command-hook 'isearch-post-command-hook)
   (remove-hook 'mouse-leave-buffer-hook 'isearch-mouse-leave-buffer)
+  (remove-hook 'delete-frame-functions 'isearch-done)
   (remove-hook 'kbd-macro-termination-hook 'isearch-done)
   (when (buffer-live-p isearch--current-buffer)
     (with-current-buffer isearch--current-buffer




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 14 Jun 2020 23:55:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 14 19:55:27 2020
Received: from localhost ([127.0.0.1]:44724 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jkcTH-000514-K0
	for submit <at> debbugs.gnu.org; Sun, 14 Jun 2020 19:55:27 -0400
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:64387)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1jkcTF-00050d-Um
 for 41338 <at> debbugs.gnu.org; Sun, 14 Jun 2020 19:55:26 -0400
X-Originating-IP: 91.129.108.6
Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6])
 (Authenticated sender: juri@HIDDEN)
 by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 5D49A40004;
 Sun, 14 Jun 2020 23:55:18 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
 <87mu66i5gl.fsf@HIDDEN>
 <8d5d6374-26f8-49b7-badd-c676c9622ea8@default>
 <87k10dz051.fsf@HIDDEN> <87h7vewp6i.fsf@HIDDEN>
Date: Mon, 15 Jun 2020 01:55:58 +0300
In-Reply-To: <87h7vewp6i.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 14 Jun 2020 01:56:05 +0300")
Message-ID: <87o8plb6kh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Stephen Berman <stephen.berman@HIDDEN>,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> isearch uses overriding-terminal-local-map, so the proper test case is:
>>
>> (setq overriding-terminal-local-map
>>       (let ((map (make-keymap)))
>> 	(define-key map [delete-frame]
>> 	  (lambda (&rest ignore)
>> 	    (interactive)
>> 	    (message "DELETE-FRAME")))
>> 	(define-key map "!"
>> 	  (lambda (&rest ignore)
>> 	    (interactive)
>> 	    (message "!")))
>> 	map))
>>
>> and indeed typing '!' you get the message,
>> but no message when clicking the `X' icon.
>
> The docstring of 'overriding-terminal-local-map' says:
>
>   Per-terminal keymap that takes precedence over all other keymaps.
>
> so maybe this is right for a *per-terminal* keymap not to react
> to window events such as clicking the `X' icon?

If there is no bug here, then I see two possible solutions for isearch:

1. use special-event-map in isearch.el the same way as isearch.el uses
   overriding-terminal-local-map;

2. use the hook ‘delete-frame-functions’ to explicitly exit isearch.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 13 Jun 2020 22:59:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 13 18:59:16 2020
Received: from localhost ([127.0.0.1]:42620 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jkF7M-0006T4-Ap
	for submit <at> debbugs.gnu.org; Sat, 13 Jun 2020 18:59:16 -0400
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:54161)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1jkF7L-0006SY-7l
 for 41338 <at> debbugs.gnu.org; Sat, 13 Jun 2020 18:59:15 -0400
X-Originating-IP: 91.129.108.6
Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6])
 (Authenticated sender: juri@HIDDEN)
 by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 6E1BF1C0004;
 Sat, 13 Jun 2020 22:59:07 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
 <87mu66i5gl.fsf@HIDDEN>
 <8d5d6374-26f8-49b7-badd-c676c9622ea8@default>
 <87k10dz051.fsf@HIDDEN>
Date: Sun, 14 Jun 2020 01:56:05 +0300
In-Reply-To: <87k10dz051.fsf@HIDDEN> (Juri Linkov's message of "Fri, 
 12 Jun 2020 01:51:54 +0300")
Message-ID: <87h7vewp6i.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Stephen Berman <stephen.berman@HIDDEN>,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> isearch uses overriding-terminal-local-map, so the proper test case is:
>
> (setq overriding-terminal-local-map
>       (let ((map (make-keymap)))
> 	(define-key map [delete-frame]
> 	  (lambda (&rest ignore)
> 	    (interactive)
> 	    (message "DELETE-FRAME")))
> 	(define-key map "!"
> 	  (lambda (&rest ignore)
> 	    (interactive)
> 	    (message "!")))
> 	map))
>
> and indeed typing '!' you get the message,
> but no message when clicking the `X' icon.

The docstring of 'overriding-terminal-local-map' says:

  Per-terminal keymap that takes precedence over all other keymaps.

so maybe this is right for a *per-terminal* keymap not to react
to window events such as clicking the `X' icon?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 11 Jun 2020 23:38:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 11 19:38:49 2020
Received: from localhost ([127.0.0.1]:38378 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jjWmX-0005nr-JU
	for submit <at> debbugs.gnu.org; Thu, 11 Jun 2020 19:38:49 -0400
Received: from relay12.mail.gandi.net ([217.70.178.232]:42425)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1jjWmU-0005nD-Lg
 for 41338 <at> debbugs.gnu.org; Thu, 11 Jun 2020 19:38:47 -0400
Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6])
 (Authenticated sender: juri@HIDDEN)
 by relay12.mail.gandi.net (Postfix) with ESMTPSA id 6DD50200005;
 Thu, 11 Jun 2020 23:38:37 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
 <87mu66i5gl.fsf@HIDDEN>
 <8d5d6374-26f8-49b7-badd-c676c9622ea8@default>
Date: Fri, 12 Jun 2020 01:51:54 +0300
In-Reply-To: <8d5d6374-26f8-49b7-badd-c676c9622ea8@default> (Drew Adams's
 message of "Mon, 18 May 2020 09:25:38 -0700 (PDT)")
Message-ID: <87k10dz051.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: martin rudalics <rudalics@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Stephen Berman <stephen.berman@HIDDEN>,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> Why doesn't clicking the `X' emit the
> `delete-frame' event?
>
> If I use `emacs -Q', in the Emacs 27 pretest
> or in Emacs 26.3 or earlier, and if I do this
> and then click the `X' icon:
>
> (define-key special-event-map [delete-frame]
>   (lambda (&rest ignore)
>     (interactive)
>     (message "HHHHHHHHHHHHHH")))
>
> I just get the message, as expected.

This is not what is used in isearch: isearch doesn't use special-event-map,
isearch uses overriding-terminal-local-map, so the proper test case is:

(setq overriding-terminal-local-map
      (let ((map (make-keymap)))
	(define-key map [delete-frame]
	  (lambda (&rest ignore)
	    (interactive)
	    (message "DELETE-FRAME")))
	(define-key map "!"
	  (lambda (&rest ignore)
	    (interactive)
	    (message "!")))
	map))

and indeed typing '!' you get the message,
but no message when clicking the `X' icon.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 19 May 2020 22:25:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 19 18:25:24 2020
Received: from localhost ([127.0.0.1]:51347 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jbAfs-0003rN-B7
	for submit <at> debbugs.gnu.org; Tue, 19 May 2020 18:25:24 -0400
Received: from relay10.mail.gandi.net ([217.70.178.230]:36553)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1jbAfo-0003qf-Gf
 for 41338 <at> debbugs.gnu.org; Tue, 19 May 2020 18:25:21 -0400
Received: from mail.gandi.net (m91-129-97-200.cust.tele2.ee [91.129.97.200])
 (Authenticated sender: juri@HIDDEN)
 by relay10.mail.gandi.net (Postfix) with ESMTPSA id 6D81D240004;
 Tue, 19 May 2020 22:25:11 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
 <87mu66i5gl.fsf@HIDDEN>
 <8d5d6374-26f8-49b7-badd-c676c9622ea8@default>
Date: Wed, 20 May 2020 01:01:53 +0300
In-Reply-To: <8d5d6374-26f8-49b7-badd-c676c9622ea8@default> (Drew Adams's
 message of "Mon, 18 May 2020 09:25:38 -0700 (PDT)")
Message-ID: <87r1vfbn3i.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: martin rudalics <rudalics@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Stephen Berman <stephen.berman@HIDDEN>,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> If I use `emacs -Q', in the Emacs 27 pretest
> or in Emacs 26.3 or earlier, and if I do this
> and then click the `X' icon:
>
> (define-key special-event-map [delete-frame]
>   (lambda (&rest ignore)
>     (interactive)
>     (message "HHHHHHHHHHHHHH")))
>
> I just get the message, as expected.
>
> (Sorry, haven't been following this thread.)

Indeed, clicking the `X' emits the `delete-frame' event.

The problem is that no one understand this comment in isearch.el:

    ;; Pass frame events transparently so they won't exit the search.
    ;; In particular, if we have more than one display open, then a
    ;; switch-frame might be generated by someone typing at another keyboard.
    (define-key map [switch-frame] nil)
    (define-key map [delete-frame] nil)

added in 1995 by 5f48fc17d16.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 18 May 2020 16:25:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 18 12:25:53 2020
Received: from localhost ([127.0.0.1]:48139 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaiaP-0000Rz-Lg
	for submit <at> debbugs.gnu.org; Mon, 18 May 2020 12:25:53 -0400
Received: from userp2120.oracle.com ([156.151.31.85]:51564)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1jaiaO-0000Ro-I5
 for 41338 <at> debbugs.gnu.org; Mon, 18 May 2020 12:25:53 -0400
Received: from pps.filterd (userp2120.oracle.com [127.0.0.1])
 by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04IGNsK6034551;
 Mon, 18 May 2020 16:25:46 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;
 h=mime-version :
 message-id : date : from : sender : to : cc : subject : references :
 in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29;
 bh=n7wOVdzXMSAQWBTRjCNf4kWjYVhQ/DKJaP6rJmrh2Z0=;
 b=CFdO8SFxzBj2t11USG2gvyD1aWSOWVkULGsMD1zRuVY16f+gqr9f+19IGAFvRGVndcVX
 YaBlxBnu5A41VHGkRwZgugZbtbEKLMaqmztpBStvj17sj4gLxTm/iGorEzc+XJXVwmp2
 ioA5maRs7WDKcH2Bg7ifPhMOeMjVeGWjDyv21BmB0D9CTn7522XAXcYkxxk9/riwJQqI
 5PyOa1rtAfOZ6ZvNfKnY4o/uUwgJeHuTHhvQF+x2JNbAtlh0WhmD0a7+XEYvw6giuHkq
 4Qte6hWTx/t7c/7z5/fN1v17StX8iP8a7amKwHyM/QAOUtM9OAjNW439eLPr8lMVRMhW aw== 
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by userp2120.oracle.com with ESMTP id 3128tn7qsu-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);
 Mon, 18 May 2020 16:25:46 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04IGN4qv073163;
 Mon, 18 May 2020 16:25:46 GMT
Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])
 by userp3020.oracle.com with ESMTP id 312sxqs4ps-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 18 May 2020 16:25:45 +0000
Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14])
 by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 04IGPdhM000477;
 Mon, 18 May 2020 16:25:42 GMT
MIME-Version: 1.0
Message-ID: <8d5d6374-26f8-49b7-badd-c676c9622ea8@default>
Date: Mon, 18 May 2020 09:25:38 -0700 (PDT)
From: Drew Adams <drew.adams@HIDDEN>
To: Juri Linkov <juri@HIDDEN>, martin rudalics <rudalics@HIDDEN>
Subject: RE: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
 <87mu66i5gl.fsf@HIDDEN>
In-Reply-To: <87mu66i5gl.fsf@HIDDEN>
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1  (1003210) [OL
 16.0.4993.0 (x86)]
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9625
 signatures=668686
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
 phishscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000
 definitions=main-2005180139
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9625
 signatures=668686
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0
 bulkscore=0 spamscore=0
 clxscore=1011 cotscore=-2147483648 suspectscore=0 lowpriorityscore=0
 adultscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2004280000 definitions=main-2005180139
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Stephen Berman <stephen.berman@HIDDEN>,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> >> But I don't know why the =E2=80=98delete-frame=E2=80=99 event is not f=
ired on frame
> deletion.
> >
> > How do you delete the frame?  You don't get a 'delete-frame' event
> when
> > you delete a frame via C-x 5 0 or C-x 5 1.
>=20
> The problem is that clicking on the 'X' (close frame button)
> doesn't emit the =E2=80=98delete-frame=E2=80=99 event.

Why doesn't clicking the `X' emit the
`delete-frame' event?

If I use `emacs -Q', in the Emacs 27 pretest
or in Emacs 26.3 or earlier, and if I do this
and then click the `X' icon:

(define-key special-event-map [delete-frame]
  (lambda (&rest ignore)
    (interactive)
    (message "HHHHHHHHHHHHHH")))

I just get the message, as expected.

(Sorry, haven't been following this thread.)




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 May 2020 22:15:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 18:15:09 2020
Received: from localhost ([127.0.0.1]:45011 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaRYq-0005ys-P7
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 18:15:09 -0400
Received: from lists.gnu.org ([209.51.188.17]:52874)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1jaRYp-0005yj-An
 for submit <at> debbugs.gnu.org; Sun, 17 May 2020 18:15:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:35076)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1jaRYj-0007AB-2B
 for bug-gnu-emacs@HIDDEN; Sun, 17 May 2020 18:15:06 -0400
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:44079)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <juri@HIDDEN>)
 id 1jaRYe-00016R-8P; Sun, 17 May 2020 18:14:57 -0400
X-Originating-IP: 91.129.104.245
Received: from mail.gandi.net (m91-129-104-245.cust.tele2.ee [91.129.104.245])
 (Authenticated sender: juri@HIDDEN)
 by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 8189E1BF205;
 Sun, 17 May 2020 22:14:35 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stephen Berman <stephen.berman@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
 <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN>
 <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
 <87sgfyel87.fsf@HIDDEN>
 <3F5C83BD-F7CE-4D22-96E0-E96C263A5B75@HIDDEN>
 <87o8qmehvt.fsf@HIDDEN>
Date: Mon, 18 May 2020 01:03:16 +0300
In-Reply-To: <87o8qmehvt.fsf@HIDDEN> (Stephen Berman's message of "Sun, 17
 May 2020 16:49:26 +0200")
Message-ID: <87y2pqi5i3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@HIDDEN;
 helo=relay8-d.mail.gandi.net
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 16:22:17
X-ACL-Warn: Detected OS   = Linux 3.11 and newer
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
 SPF_PASS=-0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
Cc: martin rudalics <rudalics@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 41338 <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> I found Juri's post confusing, probably because I know next to nothing
> about frame events.  He quotes this comment in isearch-mode-map:
>
>     ;; Pass frame events transparently so they won't exit the search.

Actually this comment is confusing.  It makes no sense to me.

What makes more sense is that frame events should exit the search,
because such frame events as ‘switch-frame’ and ‘delete-frame’
change the current buffer (‘switch-frame’ changes the current buffer
to the buffer on the switched frame, and ‘delete-frame’ changes
the current buffer to the buffer on the remaining frame).

There are precautions in isearch.el that take care to exit isearch
when the current buffer changes because many things break in this case.

One of things that breaks is that reported in this bug report
where isearch-mode remembers tool-bar-map that was active
in the current buffer before starting isearch, then frame deletion
by clicking on the 'X' (close frame button) in the frame's title bar
changes the current buffer to the buffer of the remaining frame
while isearch is still active, then isearch-done called
in another buffer restores tool-bar-map in wrong buffer.

> but then says "and indeed the ‘switch-frame’ event is fired when the
> frame is switched during isearch, and it exits isearch", which seems to
> contradict the comment.

Yes, this contradicts the comment because the comment makes no sense.

> But in any case, according to my tests, switch
> the frame does indeed exit Isearch, whether via `C-x 5 o' or the
> toolkits `Alt-TAB'.

In my tests it exits isearch as well, and this is the right thing to do.

> Juri added: "But I don't know why the
> ‘delete-frame’ event is not fired on frame deletion."  But my tests
> indicate that, unlike when switching the frame, when deleting the frame,
> Isearch is exited only when the delete frame event comes from Emacs, not
> from the toolkit.

And my tests show the same: 'C-x 5 0' exits isearch, but clicking on the
close frame button doesn't exit isearch - that's the problem.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 22:14:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 18:14:50 2020
Received: from localhost ([127.0.0.1]:44993 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaRYX-0005wP-ST
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 18:14:50 -0400
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:48891)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1jaRYW-0005vv-D9
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 18:14:48 -0400
X-Originating-IP: 91.129.104.245
Received: from mail.gandi.net (m91-129-104-245.cust.tele2.ee [91.129.104.245])
 (Authenticated sender: juri@HIDDEN)
 by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B6601C0002;
 Sun, 17 May 2020 22:14:40 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
Date: Mon, 18 May 2020 01:04:10 +0300
In-Reply-To: <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> (martin rudalics's
 message of "Sun, 17 May 2020 10:20:55 +0200")
Message-ID: <87mu66i5gl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Stephen Berman <stephen.berman@HIDDEN>,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> But I don't know why the ‘delete-frame’ event is not fired on frame deletion.
>
> How do you delete the frame?  You don't get a 'delete-frame' event when
> you delete a frame via C-x 5 0 or C-x 5 1.

The problem is that clicking on the 'X' (close frame button)
doesn't emit the ‘delete-frame’ event.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 22:14:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 18:14:46 2020
Received: from localhost ([127.0.0.1]:44990 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaRYU-0005w6-Gt
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 18:14:46 -0400
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:36909)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1jaRYS-0005vg-LI
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 18:14:45 -0400
X-Originating-IP: 91.129.104.245
Received: from mail.gandi.net (m91-129-104-245.cust.tele2.ee [91.129.104.245])
 (Authenticated sender: juri@HIDDEN)
 by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 8189E1BF205;
 Sun, 17 May 2020 22:14:35 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stephen Berman <stephen.berman@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
 <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN>
 <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
 <87sgfyel87.fsf@HIDDEN>
 <3F5C83BD-F7CE-4D22-96E0-E96C263A5B75@HIDDEN>
 <87o8qmehvt.fsf@HIDDEN>
Date: Mon, 18 May 2020 01:03:16 +0300
In-Reply-To: <87o8qmehvt.fsf@HIDDEN> (Stephen Berman's message of "Sun, 17
 May 2020 16:49:26 +0200")
Message-ID: <87y2pqi5i3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: martin rudalics <rudalics@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 41338 <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> I found Juri's post confusing, probably because I know next to nothing
> about frame events.  He quotes this comment in isearch-mode-map:
>
>     ;; Pass frame events transparently so they won't exit the search.

Actually this comment is confusing.  It makes no sense to me.

What makes more sense is that frame events should exit the search,
because such frame events as ‘switch-frame’ and ‘delete-frame’
change the current buffer (‘switch-frame’ changes the current buffer
to the buffer on the switched frame, and ‘delete-frame’ changes
the current buffer to the buffer on the remaining frame).

There are precautions in isearch.el that take care to exit isearch
when the current buffer changes because many things break in this case.

One of things that breaks is that reported in this bug report
where isearch-mode remembers tool-bar-map that was active
in the current buffer before starting isearch, then frame deletion
by clicking on the 'X' (close frame button) in the frame's title bar
changes the current buffer to the buffer of the remaining frame
while isearch is still active, then isearch-done called
in another buffer restores tool-bar-map in wrong buffer.

> but then says "and indeed the ‘switch-frame’ event is fired when the
> frame is switched during isearch, and it exits isearch", which seems to
> contradict the comment.

Yes, this contradicts the comment because the comment makes no sense.

> But in any case, according to my tests, switch
> the frame does indeed exit Isearch, whether via `C-x 5 o' or the
> toolkits `Alt-TAB'.

In my tests it exits isearch as well, and this is the right thing to do.

> Juri added: "But I don't know why the
> ‘delete-frame’ event is not fired on frame deletion."  But my tests
> indicate that, unlike when switching the frame, when deleting the frame,
> Isearch is exited only when the delete frame event comes from Emacs, not
> from the toolkit.

And my tests show the same: 'C-x 5 0' exits isearch, but clicking on the
close frame button doesn't exit isearch - that's the problem.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 14:49:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 10:49:38 2020
Received: from localhost ([127.0.0.1]:44257 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaKbi-0003pR-6f
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 10:49:38 -0400
Received: from mout.gmx.net ([212.227.17.21]:60151)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1jaKbg-0003pF-Cy
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 10:49:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589726967;
 bh=xQrXl4bQrJQhSbe0/Q2SrWuJWk4pRxqNxTeHky1/BtE=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=ZX7pwyvO0bYlRHIGIRIbLJ/SVI55NbvPEk4pmuLE6XuMxPFZ1OZVvfYTK0DA0rsYa
 4yH+xZHx4h/subg6hJo2Kw2nNNhqhZVzwFXzyqWUQbooP3NY6Uqu8G2yY7lAwdO8hY
 Tj18Q2nPmBKP2ZvrUtTBOxMqCqew/LXjXV3y/5kk=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([188.109.150.40]) by mail.gmx.com (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mnpnm-1jHGBx1W14-00pNmk; Sun, 17
 May 2020 16:49:27 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
 <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN>
 <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
 <87sgfyel87.fsf@HIDDEN>
 <3F5C83BD-F7CE-4D22-96E0-E96C263A5B75@HIDDEN>
Date: Sun, 17 May 2020 16:49:26 +0200
In-Reply-To: <3F5C83BD-F7CE-4D22-96E0-E96C263A5B75@HIDDEN> (Eli Zaretskii's
 message of "Sun, 17 May 2020 17:22:14 +0300")
Message-ID: <87o8qmehvt.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:ZQU/C8Gak6Y607LqvfJcXyQEb8Z3F34MPZyy0y/Ke31obj9/26L
 FHnIp4KItVkGrQarQ3oM3zzsTY6nLgfkO71NK0Y0zX73lfqRTk1V1eYWegxr7HH3xbipmRP
 iZF1jWiJ9gKogFudXIfAtXezN1yDeXrafynUpdeECJgfVMudLiEMwpouiChsnNglfWSrKzY
 hbik2Je8RzT+5JH0+A5rQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:PcX/HWmLBwg=:xuZba2Oq6qwc6AT5GW4Bfk
 kv7AiHrwqc9vfmAaVqato88i/D1bcs60O3oiT/88lTkG4cKdRs5S5SHZqZei1cS+wNXv5rimb
 C2PGiR53+LaQ76+D8q4xEt77F3aZx3eFZdBxvQ17hUo4svHv76ZOphjzJOqlt4sUxD4ILyzAP
 mqXg65kcR4JqZkIw8+d/GJiHCUB87LmdiY0BcpBaOWS0zG34xB+4BKwVWC4zR3K/kwO1owJEm
 daaUyDFURlKti5zFLj/uCvNZLPi4r/iiPErTvE+lzejVBHyG1fEk6jx9zfC3ykVifPtaFfaYY
 vTW9OtT5cLrG5sBPkIM1UHRNMyipBJRTeVrZzmGIs7yxMfe9eXbhwSTfD5t+mJ9ZYvtGipRQD
 E/P4XH2CPg88awcppUWRxB/umuAK8rgt5H8Je1Ju36lqy4FS/ECt+1ywAWh/ccp68JXvUOMDU
 Wh042pdveZeZlzEuS1Tg6cdxJp72y4ck/VBAHiij75unuFoX9D9QsSUQqxKa4PSRhl0fYIcx3
 xt3snGLpWOYJluRvMHnCftZvG67sr8bH0ptPw1VlcFvj8RIfJG9Le2nnY5F3T8J5cv/LIeiWm
 011E2OSZe6SMcV/CDUIlbbT5GMXn/8Qni+Odgn9iukER4DQwZcaXUqOUYLOThCWgX1737hjci
 s+RdjMxX66K9iGP9BdKEwJFRL/PXSzcWdkxjnU+Y3XtgPV85ECTOvqW058gKvCSoT6Np418xo
 5jGK/2xTxkvZrb57g/XR4fDq645U1Ui5yaG7aC05Uzr9CqeAO3DJfzdhWUC1gPhXkmqeSEkkv
 1xFb9pnBZ2E0JvdgfDdyh867XPCZxqqyBGjb5UAhZmg3us/QOxwlbNe+N7EOkoWv/Bgl6DMok
 ENc24gPqc7cTDbA6rsqaYqvqkbV4smhISKc49FolRsaTezFwa3O0GLOMz0IVc//kjEwm45j6j
 F1F9HCemRhB5nIXKB18jxyaYVJBdnSZZZvZXbgvAIMcGojU96H645kG4JgyVi3JP1YM0NPOfN
 fAWFbN++Ldzvx9EoYZXwJnVEFa/I2pkfrU0zWG2RJ7THDtv/Rb9X6/RXbf0qul8vHu4CT2gI8
 AtKP30w3NOU5b+/+zoXRecPs4E3d7u2IeQKK7gDCX7ffvaD2cCeQlGpUXcb3jaTGcKIlDIHL8
 //OJS4pnSj4BfuzLiLER12ROcqqqaaIqSpVNFCtcu+fUMf52ajXYXccCJrkLVmoJS7kbwQJMs
 5YoSBirYoCQs2Gzxn
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Sun, 17 May 2020 17:22:14 +0300 Eli Zaretskii <eliz@HIDDEN> wrote:

> On May 17, 2020 4:37:12 PM GMT+03:00, Stephen Berman <stephen.berman@gmx.=
net> wrote:
>> > Does it make sense to remain in Isearch in tbis scenario?  Could it
>> > be that we are over-engineering this stuff?
>>=20
>> As I reported in my followup to Martin, it is only when deleting the
>> frame by clicking the toolkit's close frame button that isearch
>> remains
>> in progress, with `C-x 5 0' it is cancelled.  So the former seems to
>> be
>> the problematic case, since it's also the method used in the OP.

> Yes, I was asking whether wr should simply not try remaining in
> Isearch when frames are switched or deleted.=20=20

I think it would certainly be good if isearch behaved the same in
response to a delete frame event, regardless of how it is generated.

>                                               Juri seems to say that
> we try not to leave Isearch in some of those cases.

I found Juri's post confusing, probably because I know next to nothing
about frame events.  He quotes this comment in isearch-mode-map:

    ;; Pass frame events transparently so they won't exit the search.

but then says "and indeed the =E2=80=98switch-frame=E2=80=99 event is fired=
 when the
frame is switched during isearch, and it exits isearch", which seems to
contradict the comment.  But in any case, according to my tests, switch
the frame does indeed exit Isearch, whether via `C-x 5 o' or the
toolkits `Alt-TAB'.  Juri added: "But I don't know why the
=E2=80=98delete-frame=E2=80=99 event is not fired on frame deletion."  But =
my tests
indicate that, unlike when switching the frame, when deleting the frame,
Isearch is exited only when the delete frame event comes from Emacs, not
from the toolkit.

Steve Berman




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 May 2020 14:49:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 10:49:42 2020
Received: from localhost ([127.0.0.1]:44260 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaKbm-0003pl-GB
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 10:49:42 -0400
Received: from lists.gnu.org ([209.51.188.17]:36324)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1jaKbk-0003pd-Mq
 for submit <at> debbugs.gnu.org; Sun, 17 May 2020 10:49:40 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:44358)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1jaKbk-00055b-E0
 for bug-gnu-emacs@HIDDEN; Sun, 17 May 2020 10:49:40 -0400
Received: from mout.gmx.net ([212.227.17.21]:56527)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1jaKbi-0006e5-Q4; Sun, 17 May 2020 10:49:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589726967;
 bh=xQrXl4bQrJQhSbe0/Q2SrWuJWk4pRxqNxTeHky1/BtE=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=ZX7pwyvO0bYlRHIGIRIbLJ/SVI55NbvPEk4pmuLE6XuMxPFZ1OZVvfYTK0DA0rsYa
 4yH+xZHx4h/subg6hJo2Kw2nNNhqhZVzwFXzyqWUQbooP3NY6Uqu8G2yY7lAwdO8hY
 Tj18Q2nPmBKP2ZvrUtTBOxMqCqew/LXjXV3y/5kk=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([188.109.150.40]) by mail.gmx.com (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mnpnm-1jHGBx1W14-00pNmk; Sun, 17
 May 2020 16:49:27 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
 <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN>
 <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
 <87sgfyel87.fsf@HIDDEN>
 <3F5C83BD-F7CE-4D22-96E0-E96C263A5B75@HIDDEN>
Date: Sun, 17 May 2020 16:49:26 +0200
In-Reply-To: <3F5C83BD-F7CE-4D22-96E0-E96C263A5B75@HIDDEN> (Eli Zaretskii's
 message of "Sun, 17 May 2020 17:22:14 +0300")
Message-ID: <87o8qmehvt.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:ZQU/C8Gak6Y607LqvfJcXyQEb8Z3F34MPZyy0y/Ke31obj9/26L
 FHnIp4KItVkGrQarQ3oM3zzsTY6nLgfkO71NK0Y0zX73lfqRTk1V1eYWegxr7HH3xbipmRP
 iZF1jWiJ9gKogFudXIfAtXezN1yDeXrafynUpdeECJgfVMudLiEMwpouiChsnNglfWSrKzY
 hbik2Je8RzT+5JH0+A5rQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:PcX/HWmLBwg=:xuZba2Oq6qwc6AT5GW4Bfk
 kv7AiHrwqc9vfmAaVqato88i/D1bcs60O3oiT/88lTkG4cKdRs5S5SHZqZei1cS+wNXv5rimb
 C2PGiR53+LaQ76+D8q4xEt77F3aZx3eFZdBxvQ17hUo4svHv76ZOphjzJOqlt4sUxD4ILyzAP
 mqXg65kcR4JqZkIw8+d/GJiHCUB87LmdiY0BcpBaOWS0zG34xB+4BKwVWC4zR3K/kwO1owJEm
 daaUyDFURlKti5zFLj/uCvNZLPi4r/iiPErTvE+lzejVBHyG1fEk6jx9zfC3ykVifPtaFfaYY
 vTW9OtT5cLrG5sBPkIM1UHRNMyipBJRTeVrZzmGIs7yxMfe9eXbhwSTfD5t+mJ9ZYvtGipRQD
 E/P4XH2CPg88awcppUWRxB/umuAK8rgt5H8Je1Ju36lqy4FS/ECt+1ywAWh/ccp68JXvUOMDU
 Wh042pdveZeZlzEuS1Tg6cdxJp72y4ck/VBAHiij75unuFoX9D9QsSUQqxKa4PSRhl0fYIcx3
 xt3snGLpWOYJluRvMHnCftZvG67sr8bH0ptPw1VlcFvj8RIfJG9Le2nnY5F3T8J5cv/LIeiWm
 011E2OSZe6SMcV/CDUIlbbT5GMXn/8Qni+Odgn9iukER4DQwZcaXUqOUYLOThCWgX1737hjci
 s+RdjMxX66K9iGP9BdKEwJFRL/PXSzcWdkxjnU+Y3XtgPV85ECTOvqW058gKvCSoT6Np418xo
 5jGK/2xTxkvZrb57g/XR4fDq645U1Ui5yaG7aC05Uzr9CqeAO3DJfzdhWUC1gPhXkmqeSEkkv
 1xFb9pnBZ2E0JvdgfDdyh867XPCZxqqyBGjb5UAhZmg3us/QOxwlbNe+N7EOkoWv/Bgl6DMok
 ENc24gPqc7cTDbA6rsqaYqvqkbV4smhISKc49FolRsaTezFwa3O0GLOMz0IVc//kjEwm45j6j
 F1F9HCemRhB5nIXKB18jxyaYVJBdnSZZZvZXbgvAIMcGojU96H645kG4JgyVi3JP1YM0NPOfN
 fAWFbN++Ldzvx9EoYZXwJnVEFa/I2pkfrU0zWG2RJ7THDtv/Rb9X6/RXbf0qul8vHu4CT2gI8
 AtKP30w3NOU5b+/+zoXRecPs4E3d7u2IeQKK7gDCX7ffvaD2cCeQlGpUXcb3jaTGcKIlDIHL8
 //OJS4pnSj4BfuzLiLER12ROcqqqaaIqSpVNFCtcu+fUMf52ajXYXccCJrkLVmoJS7kbwQJMs
 5YoSBirYoCQs2Gzxn
Received-SPF: pass client-ip=212.227.17.21;
 envelope-from=stephen.berman@HIDDEN; helo=mout.gmx.net
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 10:49:37
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic]
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001,
 URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

On Sun, 17 May 2020 17:22:14 +0300 Eli Zaretskii <eliz@HIDDEN> wrote:

> On May 17, 2020 4:37:12 PM GMT+03:00, Stephen Berman <stephen.berman@gmx.=
net> wrote:
>> > Does it make sense to remain in Isearch in tbis scenario?  Could it
>> > be that we are over-engineering this stuff?
>>=20
>> As I reported in my followup to Martin, it is only when deleting the
>> frame by clicking the toolkit's close frame button that isearch
>> remains
>> in progress, with `C-x 5 0' it is cancelled.  So the former seems to
>> be
>> the problematic case, since it's also the method used in the OP.

> Yes, I was asking whether wr should simply not try remaining in
> Isearch when frames are switched or deleted.=20=20

I think it would certainly be good if isearch behaved the same in
response to a delete frame event, regardless of how it is generated.

>                                               Juri seems to say that
> we try not to leave Isearch in some of those cases.

I found Juri's post confusing, probably because I know next to nothing
about frame events.  He quotes this comment in isearch-mode-map:

    ;; Pass frame events transparently so they won't exit the search.

but then says "and indeed the =E2=80=98switch-frame=E2=80=99 event is fired=
 when the
frame is switched during isearch, and it exits isearch", which seems to
contradict the comment.  But in any case, according to my tests, switch
the frame does indeed exit Isearch, whether via `C-x 5 o' or the
toolkits `Alt-TAB'.  Juri added: "But I don't know why the
=E2=80=98delete-frame=E2=80=99 event is not fired on frame deletion."  But =
my tests
indicate that, unlike when switching the frame, when deleting the frame,
Isearch is exited only when the delete frame event comes from Emacs, not
from the toolkit.

Steve Berman




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 14:22:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 10:22:48 2020
Received: from localhost ([127.0.0.1]:44231 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaKBk-0003Au-1H
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 10:22:48 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34616)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1jaKBZ-0003AL-3B
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 10:22:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59809)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1jaKBR-0000nV-CH; Sun, 17 May 2020 10:22:29 -0400
Received: from [176.12.226.120] (port=57391 helo=[10.159.73.135])
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1jaKBL-0007Ya-5G; Sun, 17 May 2020 10:22:29 -0400
Date: Sun, 17 May 2020 17:22:14 +0300
User-Agent: K-9 Mail for Android
In-Reply-To: <87sgfyel87.fsf@HIDDEN>
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN> <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN> <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
 <87sgfyel87.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
To: Stephen Berman <stephen.berman@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
Message-ID: <3F5C83BD-F7CE-4D22-96E0-E96C263A5B75@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41338
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On May 17, 2020 4:37:12 PM GMT+03:00, Stephen Berman <stephen=2Eberman@gmx=
=2Enet> wrote:
> On Sun, 17 May 2020 16:12:38 +0300 Eli Zaretskii <eliz@gnu=2Eorg> wrote:
>=20
> > On May 17, 2020 3:59:55 PM GMT+03:00, Stephen Berman
> <stephen=2Eberman@gmx=2Enet> wrote:
> >> The bug reported in the OP (the unexpected tool bar change) seems
> to
> >> be triggered by isearch (it was part of the OP's recipe and I
> haven't
> >> been able to reproduce it without using isearch), but maybe the
> >> observation about isearch I reported in my followup is a separate
> bug
> >> or perhaps no bug, even though it surprised me=2E
> >>
> >> Steve Berman
> >
> > So the problem is that the toolbar is not reconfigured to reflect
> the fact
> > that we are in Isearch?
>=20
> In the OP the tool bar change was in the message-mode buffer, not the
> buffer where isearch was invoked=2E  My additional observation was that
> in
> the latter buffer the tool bar and lighter indicated isearch in
> progress, but the overlays were missing and point was in its
> pre-isearch
> position=2E
>=20
> > Does it make sense to remain in Isearch in tbis scenario?  Could it
> be
> > that we are over-engineering this stuff?
>=20
> As I reported in my followup to Martin, it is only when deleting the
> frame by clicking the toolkit's close frame button that isearch
> remains
> in progress, with `C-x 5 0' it is cancelled=2E  So the former seems to
> be
> the problematic case, since it's also the method used in the OP=2E
>=20
> Steve Berman

Yes, I was asking whether wr should simply not try remaining in Isearch wh=
en frames are switched or deleted=2E  Juri seems to say that we try not to =
leave Isearch in some of those cases=2E




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 May 2020 14:22:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 10:22:34 2020
Received: from localhost ([127.0.0.1]:44228 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaKBV-0003AT-Mb
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 10:22:33 -0400
Received: from lists.gnu.org ([209.51.188.17]:46562)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1jaKBU-0003AM-9D
 for submit <at> debbugs.gnu.org; Sun, 17 May 2020 10:22:32 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:42038)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1jaKBU-00037V-3n
 for bug-gnu-emacs@HIDDEN; Sun, 17 May 2020 10:22:32 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59809)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1jaKBR-0000nV-CH; Sun, 17 May 2020 10:22:29 -0400
Received: from [176.12.226.120] (port=57391 helo=[10.159.73.135])
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1jaKBL-0007Ya-5G; Sun, 17 May 2020 10:22:29 -0400
Date: Sun, 17 May 2020 17:22:14 +0300
User-Agent: K-9 Mail for Android
In-Reply-To: <87sgfyel87.fsf@HIDDEN>
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN> <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN> <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
 <87sgfyel87.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
To: Stephen Berman <stephen.berman@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
Message-ID: <3F5C83BD-F7CE-4D22-96E0-E96C263A5B75@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On May 17, 2020 4:37:12 PM GMT+03:00, Stephen Berman <stephen=2Eberman@gmx=
=2Enet> wrote:
> On Sun, 17 May 2020 16:12:38 +0300 Eli Zaretskii <eliz@gnu=2Eorg> wrote:
>=20
> > On May 17, 2020 3:59:55 PM GMT+03:00, Stephen Berman
> <stephen=2Eberman@gmx=2Enet> wrote:
> >> The bug reported in the OP (the unexpected tool bar change) seems
> to
> >> be triggered by isearch (it was part of the OP's recipe and I
> haven't
> >> been able to reproduce it without using isearch), but maybe the
> >> observation about isearch I reported in my followup is a separate
> bug
> >> or perhaps no bug, even though it surprised me=2E
> >>
> >> Steve Berman
> >
> > So the problem is that the toolbar is not reconfigured to reflect
> the fact
> > that we are in Isearch?
>=20
> In the OP the tool bar change was in the message-mode buffer, not the
> buffer where isearch was invoked=2E  My additional observation was that
> in
> the latter buffer the tool bar and lighter indicated isearch in
> progress, but the overlays were missing and point was in its
> pre-isearch
> position=2E
>=20
> > Does it make sense to remain in Isearch in tbis scenario?  Could it
> be
> > that we are over-engineering this stuff?
>=20
> As I reported in my followup to Martin, it is only when deleting the
> frame by clicking the toolkit's close frame button that isearch
> remains
> in progress, with `C-x 5 0' it is cancelled=2E  So the former seems to
> be
> the problematic case, since it's also the method used in the OP=2E
>=20
> Steve Berman

Yes, I was asking whether wr should simply not try remaining in Isearch wh=
en frames are switched or deleted=2E  Juri seems to say that we try not to =
leave Isearch in some of those cases=2E




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 13:37:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 09:37:26 2020
Received: from localhost ([127.0.0.1]:42644 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaJTq-0007uU-M1
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 09:37:26 -0400
Received: from mout.gmx.net ([212.227.15.15]:39695)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1jaJTo-0007uF-4c
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 09:37:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589722634;
 bh=/waPOGtoLojLlQ5CmCQXiBnl4dKCmD/a2PqWFiu5KFE=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=ZmoTJD7W7IDWVI5+hTwAnx9BYtbzlmkrR+kuL9OPRcdZc24yLZT8+TiK7y/fFxzP+
 azcLyqGVHMbd37V20L/w3+aSNlDqQtkKs+VF1XuOstOvCYtr4rrwG+DJz0T2oEK7Pd
 yTCcQv+sKLFkFUy1eF8eY+W0yJUXJjv6PAwjKxdQ=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([188.109.150.40]) by mail.gmx.com (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MJmGZ-1jKhV23LXF-00K8DQ; Sun, 17
 May 2020 15:37:13 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
 <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN>
 <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
Date: Sun, 17 May 2020 15:37:12 +0200
In-Reply-To: <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN> (Eli Zaretskii's
 message of "Sun, 17 May 2020 16:12:38 +0300")
Message-ID: <87sgfyel87.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:E8C0UHSwSzcS+m1JnXqlZSehPzBy/bkLfUNIX2SGpDljo34mRuw
 nWafXDwOKPp5WPEkO57WHYUuG6IjC1wyPOBOdnJ6h9ovB/PKLWE1d+w1Q0B3jUg55Mxp1II
 dToy1uOSfGsospf7jZjyaUKOTdXoVNyg+egDSVBZ38jIt7tB5rZ0F4kRNlzTdnzPthnqvl8
 /oJtnLf5hhE6VfXEcXpjA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:WYhmxD14h2E=:MQhj8/CyYM+MVBgXKbeZga
 zUzqVmO5rQMflYAVctXdCF0DddxxI0w2hiTHZ7BJw1pbGDZPE2YHwI3vhdMaCUPj0ww6qtb1F
 KYw7CMBFRIHNxhfSmdJWS1bwuxKSfI1oQ3odCbJuCjVP7XuGT05bF5Pc8NPZyzaDPdL+7xbvh
 GwdNsSBuTA+pwo59Fm0MnsiQjQAuFsJTwdN7eXUM/nIgqlkHqsIXX0HUa/A9TZ4lO/UBy4wO6
 fg5m9CZr5vlOEEKZGMB3VwGsmeiYlAI3v1Dip7BKZa1xs76ZvncB4mMe939MYS2NbQ3bj7veG
 BTJufnhuDoYMHfYz5tHvfEvcXAo6D9heAZ0n6wggIfBJHDt6xA/tSCyfCXOPNL6HNWOXJ1zXg
 y2k7AkwhCEF9s/cJF7xVn+Ui9BGbpTD9sOkAd5Xi/1bRMOOWPn5tzx4YtvopWHM2ICDH7WOoG
 0gT2crlrAcb5Z9bsyLneSiottahzUhh1qUNkFbc/f/IRa314PRm6WKKrpYbOhH/o/2Mpe5zH2
 9itS/zSQzUx8/T0FwPoF5/iuXOTwibYY4isjUewbisD/kGM2SOzv1K4cx1hxwPxHYEXycOkeT
 sY/NIZkOa7k1kDmF3pJ+AOwC1dAKfUEepZBTU8CljMXgAt2kE6KZH0bcg76NTcKonWrSsTE/b
 tqmJZJljquzfYxu0cPF7WIL0vS0Gt2lU6IcMBfrchRxDSwKNdKUCyGmzeek+f+0r8P3F7XaU/
 ucmcImwj2+FdyVpMoTGoBGbjQF6bVg/O2HUmEkQF+voRlj6940uSv6B7VYj1CVP0rudDz6ftG
 B7YDQ3jLHs5Ydgw0hwDWSnayVGvXPS4/PpyUaP/LArnGGd1hIPRF8hVhbKlpdIOZRZ6HBGNPn
 kID5VB+l1FgutOm9MAivPslVdHBWUs2OO8X0XsghQrB25mbJyeBvvw6P2Tf7pENtGcT9hvKJ/
 66yscv3jDVV8Lq4bQ29MTQBNwdp0jEhTnZNMoV8Y2ZYQN3wzgtys9nB2Z39gDHtQGnR8WyLSW
 Tvo7dIBZm/Tb6XaPk5NTeWx8qm4A72l5vHFOMrzFbsCWtrMdyBRdrQ6xz2GK7bzmlotsVV9W7
 j4gFV5biTpZkCqb/zsDRHCswzGLXSel1RZyus43ZWp3wyQsizvPf4nZPRRudVnYY/VvczUTJU
 WAckEADHhJqHbk53kReknHnzMuqUgG/kanyrW5lj1SjKtZ17My51sNPYvQ98pU7dkfjlsGOF6
 hZXg+FbirilVjXu8L
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Sun, 17 May 2020 16:12:38 +0300 Eli Zaretskii <eliz@HIDDEN> wrote:

> On May 17, 2020 3:59:55 PM GMT+03:00, Stephen Berman <stephen.berman@gmx=
.net> wrote:
>> The bug reported in the OP (the unexpected tool bar change) seems to
>> be triggered by isearch (it was part of the OP's recipe and I haven't
>> been able to reproduce it without using isearch), but maybe the
>> observation about isearch I reported in my followup is a separate bug
>> or perhaps no bug, even though it surprised me.
>>
>> Steve Berman
>
> So the problem is that the toolbar is not reconfigured to reflect the fa=
ct
> that we are in Isearch?

In the OP the tool bar change was in the message-mode buffer, not the
buffer where isearch was invoked.  My additional observation was that in
the latter buffer the tool bar and lighter indicated isearch in
progress, but the overlays were missing and point was in its pre-isearch
position.

> Does it make sense to remain in Isearch in tbis scenario?  Could it be
> that we are over-engineering this stuff?

As I reported in my followup to Martin, it is only when deleting the
frame by clicking the toolkit's close frame button that isearch remains
in progress, with `C-x 5 0' it is cancelled.  So the former seems to be
the problematic case, since it's also the method used in the OP.

Steve Berman




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 May 2020 13:37:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 09:37:30 2020
Received: from localhost ([127.0.0.1]:42647 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaJTt-0007uk-U1
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 09:37:30 -0400
Received: from lists.gnu.org ([209.51.188.17]:50966)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1jaJTs-0007ud-NS
 for submit <at> debbugs.gnu.org; Sun, 17 May 2020 09:37:28 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:38308)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1jaJTs-0004oS-FN
 for bug-gnu-emacs@HIDDEN; Sun, 17 May 2020 09:37:28 -0400
Received: from mout.gmx.net ([212.227.15.15]:54037)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1jaJTq-0006f1-Q3; Sun, 17 May 2020 09:37:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589722634;
 bh=/waPOGtoLojLlQ5CmCQXiBnl4dKCmD/a2PqWFiu5KFE=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=ZmoTJD7W7IDWVI5+hTwAnx9BYtbzlmkrR+kuL9OPRcdZc24yLZT8+TiK7y/fFxzP+
 azcLyqGVHMbd37V20L/w3+aSNlDqQtkKs+VF1XuOstOvCYtr4rrwG+DJz0T2oEK7Pd
 yTCcQv+sKLFkFUy1eF8eY+W0yJUXJjv6PAwjKxdQ=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([188.109.150.40]) by mail.gmx.com (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MJmGZ-1jKhV23LXF-00K8DQ; Sun, 17
 May 2020 15:37:13 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
 <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN>
 <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
Date: Sun, 17 May 2020 15:37:12 +0200
In-Reply-To: <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN> (Eli Zaretskii's
 message of "Sun, 17 May 2020 16:12:38 +0300")
Message-ID: <87sgfyel87.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:E8C0UHSwSzcS+m1JnXqlZSehPzBy/bkLfUNIX2SGpDljo34mRuw
 nWafXDwOKPp5WPEkO57WHYUuG6IjC1wyPOBOdnJ6h9ovB/PKLWE1d+w1Q0B3jUg55Mxp1II
 dToy1uOSfGsospf7jZjyaUKOTdXoVNyg+egDSVBZ38jIt7tB5rZ0F4kRNlzTdnzPthnqvl8
 /oJtnLf5hhE6VfXEcXpjA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:WYhmxD14h2E=:MQhj8/CyYM+MVBgXKbeZga
 zUzqVmO5rQMflYAVctXdCF0DddxxI0w2hiTHZ7BJw1pbGDZPE2YHwI3vhdMaCUPj0ww6qtb1F
 KYw7CMBFRIHNxhfSmdJWS1bwuxKSfI1oQ3odCbJuCjVP7XuGT05bF5Pc8NPZyzaDPdL+7xbvh
 GwdNsSBuTA+pwo59Fm0MnsiQjQAuFsJTwdN7eXUM/nIgqlkHqsIXX0HUa/A9TZ4lO/UBy4wO6
 fg5m9CZr5vlOEEKZGMB3VwGsmeiYlAI3v1Dip7BKZa1xs76ZvncB4mMe939MYS2NbQ3bj7veG
 BTJufnhuDoYMHfYz5tHvfEvcXAo6D9heAZ0n6wggIfBJHDt6xA/tSCyfCXOPNL6HNWOXJ1zXg
 y2k7AkwhCEF9s/cJF7xVn+Ui9BGbpTD9sOkAd5Xi/1bRMOOWPn5tzx4YtvopWHM2ICDH7WOoG
 0gT2crlrAcb5Z9bsyLneSiottahzUhh1qUNkFbc/f/IRa314PRm6WKKrpYbOhH/o/2Mpe5zH2
 9itS/zSQzUx8/T0FwPoF5/iuXOTwibYY4isjUewbisD/kGM2SOzv1K4cx1hxwPxHYEXycOkeT
 sY/NIZkOa7k1kDmF3pJ+AOwC1dAKfUEepZBTU8CljMXgAt2kE6KZH0bcg76NTcKonWrSsTE/b
 tqmJZJljquzfYxu0cPF7WIL0vS0Gt2lU6IcMBfrchRxDSwKNdKUCyGmzeek+f+0r8P3F7XaU/
 ucmcImwj2+FdyVpMoTGoBGbjQF6bVg/O2HUmEkQF+voRlj6940uSv6B7VYj1CVP0rudDz6ftG
 B7YDQ3jLHs5Ydgw0hwDWSnayVGvXPS4/PpyUaP/LArnGGd1hIPRF8hVhbKlpdIOZRZ6HBGNPn
 kID5VB+l1FgutOm9MAivPslVdHBWUs2OO8X0XsghQrB25mbJyeBvvw6P2Tf7pENtGcT9hvKJ/
 66yscv3jDVV8Lq4bQ29MTQBNwdp0jEhTnZNMoV8Y2ZYQN3wzgtys9nB2Z39gDHtQGnR8WyLSW
 Tvo7dIBZm/Tb6XaPk5NTeWx8qm4A72l5vHFOMrzFbsCWtrMdyBRdrQ6xz2GK7bzmlotsVV9W7
 j4gFV5biTpZkCqb/zsDRHCswzGLXSel1RZyus43ZWp3wyQsizvPf4nZPRRudVnYY/VvczUTJU
 WAckEADHhJqHbk53kReknHnzMuqUgG/kanyrW5lj1SjKtZ17My51sNPYvQ98pU7dkfjlsGOF6
 hZXg+FbirilVjXu8L
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=212.227.15.15;
 envelope-from=stephen.berman@HIDDEN; helo=mout.gmx.net
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 09:37:24
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic]
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001,
 URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

On Sun, 17 May 2020 16:12:38 +0300 Eli Zaretskii <eliz@HIDDEN> wrote:

> On May 17, 2020 3:59:55 PM GMT+03:00, Stephen Berman <stephen.berman@gmx=
.net> wrote:
>> The bug reported in the OP (the unexpected tool bar change) seems to
>> be triggered by isearch (it was part of the OP's recipe and I haven't
>> been able to reproduce it without using isearch), but maybe the
>> observation about isearch I reported in my followup is a separate bug
>> or perhaps no bug, even though it surprised me.
>>
>> Steve Berman
>
> So the problem is that the toolbar is not reconfigured to reflect the fa=
ct
> that we are in Isearch?

In the OP the tool bar change was in the message-mode buffer, not the
buffer where isearch was invoked.  My additional observation was that in
the latter buffer the tool bar and lighter indicated isearch in
progress, but the overlays were missing and point was in its pre-isearch
position.

> Does it make sense to remain in Isearch in tbis scenario?  Could it be
> that we are over-engineering this stuff?

As I reported in my followup to Martin, it is only when deleting the
frame by clicking the toolkit's close frame button that isearch remains
in progress, with `C-x 5 0' it is cancelled.  So the former seems to be
the problematic case, since it's also the method used in the OP.

Steve Berman




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 13:13:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 09:13:13 2020
Received: from localhost ([127.0.0.1]:42586 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaJ6O-0007Gk-Tg
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 09:13:13 -0400
Received: from eggs.gnu.org ([209.51.188.92]:52630)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1jaJ6M-0007GJ-Vn
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 09:13:11 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58809)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1jaJ6E-0007H3-FM; Sun, 17 May 2020 09:13:02 -0400
Received: from [176.12.226.120] (port=57397 helo=[10.159.73.135])
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1jaJ5v-0005FW-Rg; Sun, 17 May 2020 09:13:02 -0400
Date: Sun, 17 May 2020 16:12:38 +0300
User-Agent: K-9 Mail for Android
In-Reply-To: <87wo5aemyc.fsf@HIDDEN>
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN> <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
To: Stephen Berman <stephen.berman@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
Message-ID: <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41338
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On May 17, 2020 3:59:55 PM GMT+03:00, Stephen Berman <stephen=2Eberman@gmx=
=2Enet> wrote:
> On Sun, 17 May 2020 15:36:10 +0300 Eli Zaretskii <eliz@gnu=2Eorg> wrote:
>=20
> > On May 17, 2020 12:11:04 PM GMT+03:00, Stephen Berman
> <stephen=2Eberman@gmx=2Enet> wrote:
> >> On Sun, 17 May 2020 10:56:50 +0200 Stephen Berman
> >> <stephen=2Eberman@gmx=2Enet> wrote:
> >>=20
> >> > On Sun, 17 May 2020 10:20:55 +0200 martin rudalics
> <rudalics@gmx=2Eat>
> >> wrote:
> >> >
> >> >>> But I don't know why the =E2=80=98delete-frame=E2=80=99 event is =
not fired on
> >> frame deletion=2E
> >> >>
> >> >> How do you delete the frame?  You don't get a 'delete-frame'
> event
> >> when
> >> >> you delete a frame via C-x 5 0 or C-x 5 1=2E
> >> >>
> >> >> martin
> >> >
> >> > In my test I followed the OP's recipe:
> >> >
> >> >> (7) Using the mouse, close the frame showing mouse=2Eel, but do so
> in
> >> a state
> >> >> where still isearch overlays show up=2E
> >> >
> >> > I=2Ee=2E, I clicked on the 'X' (close frame button) in the frame's
> title
> >> > bar=2E
> >>=20
> >> But when I close the frame with `C-x 5 0' instead and then proceed
> >> with
> >> the OP's recipe, the tool bar does not change and when I switch to
> the
> >> buffer where isearch had been invoked, the search is now abandoned,
> >> i=2Ee=2E, no isearch tool bar or lighter, no overlays=2E  So only clo=
sing
> >> the
> >> frame by clicking the close frame button with the mouse induces the
> >> surprising behavior=2E
> >>=20
> >> Steve Berman
> >
> > Could someone please explain to me what is deemed to be the bug
> here?  Because
> > I'm confused wrt what is the part of the original description that
> seems to be
> > the problem=2E  In particular, the Isearch overlays are per-window,
> AFAIK=2E
>=20
> The bug reported in the OP (the unexpected tool bar change) seems to
> be
> triggered by isearch (it was part of the OP's recipe and I haven't
> been
> able to reproduce it without using isearch), but maybe the observation
> about isearch I reported in my followup is a separate bug or perhaps
> no
> bug, even though it surprised me=2E
>=20
> Steve Berman

So the problem is that the toolbar is not reconfigured to reflect the fact=
 that we are in Isearch?

Does it make sense to remain in Isearch in tbis scenario?  Could it be tha=
t we are over-engineering this stuff?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 May 2020 13:13:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 09:13:07 2020
Received: from localhost ([127.0.0.1]:42583 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaJ6J-0007GR-Ic
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 09:13:07 -0400
Received: from lists.gnu.org ([209.51.188.17]:34942)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1jaJ6I-0007GK-7K
 for submit <at> debbugs.gnu.org; Sun, 17 May 2020 09:13:06 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60046)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1jaJ6I-0003bR-39
 for bug-gnu-emacs@HIDDEN; Sun, 17 May 2020 09:13:06 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58809)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1jaJ6E-0007H3-FM; Sun, 17 May 2020 09:13:02 -0400
Received: from [176.12.226.120] (port=57397 helo=[10.159.73.135])
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1jaJ5v-0005FW-Rg; Sun, 17 May 2020 09:13:02 -0400
Date: Sun, 17 May 2020 16:12:38 +0300
User-Agent: K-9 Mail for Android
In-Reply-To: <87wo5aemyc.fsf@HIDDEN>
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN> <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
 <87wo5aemyc.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
To: Stephen Berman <stephen.berman@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
Message-ID: <AB248247-FA6D-4FCA-A861-4F74DFB035E2@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On May 17, 2020 3:59:55 PM GMT+03:00, Stephen Berman <stephen=2Eberman@gmx=
=2Enet> wrote:
> On Sun, 17 May 2020 15:36:10 +0300 Eli Zaretskii <eliz@gnu=2Eorg> wrote:
>=20
> > On May 17, 2020 12:11:04 PM GMT+03:00, Stephen Berman
> <stephen=2Eberman@gmx=2Enet> wrote:
> >> On Sun, 17 May 2020 10:56:50 +0200 Stephen Berman
> >> <stephen=2Eberman@gmx=2Enet> wrote:
> >>=20
> >> > On Sun, 17 May 2020 10:20:55 +0200 martin rudalics
> <rudalics@gmx=2Eat>
> >> wrote:
> >> >
> >> >>> But I don't know why the =E2=80=98delete-frame=E2=80=99 event is =
not fired on
> >> frame deletion=2E
> >> >>
> >> >> How do you delete the frame?  You don't get a 'delete-frame'
> event
> >> when
> >> >> you delete a frame via C-x 5 0 or C-x 5 1=2E
> >> >>
> >> >> martin
> >> >
> >> > In my test I followed the OP's recipe:
> >> >
> >> >> (7) Using the mouse, close the frame showing mouse=2Eel, but do so
> in
> >> a state
> >> >> where still isearch overlays show up=2E
> >> >
> >> > I=2Ee=2E, I clicked on the 'X' (close frame button) in the frame's
> title
> >> > bar=2E
> >>=20
> >> But when I close the frame with `C-x 5 0' instead and then proceed
> >> with
> >> the OP's recipe, the tool bar does not change and when I switch to
> the
> >> buffer where isearch had been invoked, the search is now abandoned,
> >> i=2Ee=2E, no isearch tool bar or lighter, no overlays=2E  So only clo=
sing
> >> the
> >> frame by clicking the close frame button with the mouse induces the
> >> surprising behavior=2E
> >>=20
> >> Steve Berman
> >
> > Could someone please explain to me what is deemed to be the bug
> here?  Because
> > I'm confused wrt what is the part of the original description that
> seems to be
> > the problem=2E  In particular, the Isearch overlays are per-window,
> AFAIK=2E
>=20
> The bug reported in the OP (the unexpected tool bar change) seems to
> be
> triggered by isearch (it was part of the OP's recipe and I haven't
> been
> able to reproduce it without using isearch), but maybe the observation
> about isearch I reported in my followup is a separate bug or perhaps
> no
> bug, even though it surprised me=2E
>=20
> Steve Berman

So the problem is that the toolbar is not reconfigured to reflect the fact=
 that we are in Isearch?

Does it make sense to remain in Isearch in tbis scenario?  Could it be tha=
t we are over-engineering this stuff?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 13:00:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 09:00:10 2020
Received: from localhost ([127.0.0.1]:42559 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaItm-0006xI-6d
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 09:00:10 -0400
Received: from mout.gmx.net ([212.227.15.18]:58451)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1jaIti-0006vF-Nm
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 09:00:08 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589720396;
 bh=LwjUrxf5kNpnRkBf7FI0hAaUb3FCVBNKAfaEtjE2o+4=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=XJhtKDQumS63kp165nUMVO3lIEfYnY+r2s34V8bgLcQ6meSnZ1CKVNVuAnhV8/ZDm
 FcGVYlf1v9sq50ulx/d2KcnwnQrLksqAMV7rl8VRruySiaaYoJs/fdI4fgWyWpm/gm
 w8qRjPNAZ6YUmmdH71nBQzbyIDFvVxim6fqRWr4E=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([188.109.150.40]) by mail.gmx.com (mrgmx004
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MFbRs-1jrJ8k1stS-00H6yJ; Sun, 17
 May 2020 14:59:56 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
 <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
Date: Sun, 17 May 2020 14:59:55 +0200
In-Reply-To: <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN> (Eli Zaretskii's
 message of "Sun, 17 May 2020 15:36:10 +0300")
Message-ID: <87wo5aemyc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:FryKDU4/sM+ICkKE5okt+gSMTxw1Jfs+2l6pMi1+H19K+7xVD1x
 PCf9RhXZpXY0v9ey6PVVpjEIaFQDmoJAdzXMzAde/lEQZ/ZA7tZtjxlx+VABxdXar2kptfp
 WFzTNOIF1uW/bn4eiI5AIyKL2Pp3nP+98iW7ZooCHJnLfr2IDvZtYPV4NZCWDK6CCiBbG7k
 evmofHnHjizG/AqkVyBtw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:1dbJBsvaA3w=:PC4DJ+M0/JpCkR2t804KeR
 ARy0srWOhRfFCjMFzs0iEjfCDvbGAdcRhaNgXLzJVO+UILitPPPHr2FORbK6z2nwFktZEt1uB
 M5GXAw3ul+wzhINtKqw2ecjFW0VsO68xFYXTaSgBlrXu1P38NSvfXkZInUUxdr4lYQRtPnzQp
 vtcwhru3KK7wCaOt3lVItIb9kp9gFs9UkKnSVTsV8XseY/O2FNS8g1IiYr0qDX0BeQFHlvW49
 aUWNSyHYKln0Xp6+zEkS0rB+K2abGyZUt7uOrB74I+gI+A0E3GqPSTQgzd2XAdapjf24D6iUd
 DeGMMSuDH6SeuygLkWBPYOCzRzFFx2EQ/BsNWQuh/nXFPXkm1B3rlPK08NuTz6uMJ89BAQgYQ
 xn2z2CcR8sui8ZOuXAdr83MKVCAtKD+EtmIswPqHA3T37ZLeEuLHv4XkHQrnQvxKHYKu/kGzB
 Jjfz5pT3YJ+VtTWgcN576y3FMeJ3WkrioRKdXYhiBWrfOPASM6Zt4cbKjNL2wmr69W3D6sbcv
 Zb2hR1/JPfm5Ei0DKTY6nAp+Auto+vafeOZfCJ1g+IPracgSFyKzWXYDKBo8wRvS0FRYBBnF6
 1v0hGWVU7ngi1722hBUiSh6vZOSqxyppEVVMXk0hiltZnwd3G811IWTcYPOAinvCRAk4gpkYy
 YIdxI3MIAqW/CdObDR+I8ou6FSe6fKfd7uVo7LsBMcvHNmIYzWo5lV5rqxWzd9Y8OSVoyKese
 1INeYG1q7kXEYbortjiOBo7TXLTgo9tKX4lCx7am56m2KmnVe3mLCUmfO1danHbcF4CB2paA9
 VctJlz3YFm3NvhGVujWeqdiipzOVQXP2ay+v79bxonc1yoAZ9BVG4ZAI+t/rzcJ36zFX0NERf
 o3UDy/sTmyhqzh6o1Qyx9Nw2ww0oI+CWmokr1jW0ZFyl/aRyct0g8iDN+mnHJ9f8gd2LaCdVO
 r9HSH7CBMIu4Gi9WSXuBoKs7WzJC2riBRGr5LBpF5YltGbo+8a/3BNrdwaeHsx/r/MPIP92y8
 7vfLBncwQ/TScnF9htLdLuRWm1PXkK668NtWXnIRSFh373AdJdGxxr1vQ7eK2S4O+ZGdM9kz1
 G7wG5ISfldmxRpreF1v6oLmIsMniki2uyoAf1wxtV74PeeuFerxHi7T8dB4LrE6uu5Cq+qUBw
 2rIMIOYpRYFuD+T9NjNPxvsTd+dmhoOh17jhQhb19TtRhrekmOaEdatZhCQSun/phLvjt7IUb
 AsuOhSeNYEWOupeKj
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Sun, 17 May 2020 15:36:10 +0300 Eli Zaretskii <eliz@HIDDEN> wrote:

> On May 17, 2020 12:11:04 PM GMT+03:00, Stephen Berman <stephen.berman@gmx=
.net> wrote:
>> On Sun, 17 May 2020 10:56:50 +0200 Stephen Berman
>> <stephen.berman@HIDDEN> wrote:
>>=20
>> > On Sun, 17 May 2020 10:20:55 +0200 martin rudalics <rudalics@HIDDEN>
>> wrote:
>> >
>> >>> But I don't know why the =E2=80=98delete-frame=E2=80=99 event is not=
 fired on
>> frame deletion.
>> >>
>> >> How do you delete the frame?  You don't get a 'delete-frame' event
>> when
>> >> you delete a frame via C-x 5 0 or C-x 5 1.
>> >>
>> >> martin
>> >
>> > In my test I followed the OP's recipe:
>> >
>> >> (7) Using the mouse, close the frame showing mouse.el, but do so in
>> a state
>> >> where still isearch overlays show up.
>> >
>> > I.e., I clicked on the 'X' (close frame button) in the frame's title
>> > bar.
>>=20
>> But when I close the frame with `C-x 5 0' instead and then proceed
>> with
>> the OP's recipe, the tool bar does not change and when I switch to the
>> buffer where isearch had been invoked, the search is now abandoned,
>> i.e., no isearch tool bar or lighter, no overlays.  So only closing
>> the
>> frame by clicking the close frame button with the mouse induces the
>> surprising behavior.
>>=20
>> Steve Berman
>
> Could someone please explain to me what is deemed to be the bug here?  Be=
cause
> I'm confused wrt what is the part of the original description that seems =
to be
> the problem.  In particular, the Isearch overlays are per-window, AFAIK.

The bug reported in the OP (the unexpected tool bar change) seems to be
triggered by isearch (it was part of the OP's recipe and I haven't been
able to reproduce it without using isearch), but maybe the observation
about isearch I reported in my followup is a separate bug or perhaps no
bug, even though it surprised me.

Steve Berman




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 May 2020 13:00:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 09:00:15 2020
Received: from localhost ([127.0.0.1]:42562 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaItq-0006xa-JE
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 09:00:15 -0400
Received: from lists.gnu.org ([209.51.188.17]:51214)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1jaItp-0006xT-6q
 for submit <at> debbugs.gnu.org; Sun, 17 May 2020 09:00:13 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:57960)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1jaIto-0005YX-Qd
 for bug-gnu-emacs@HIDDEN; Sun, 17 May 2020 09:00:12 -0400
Received: from mout.gmx.net ([212.227.15.18]:46291)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <stephen.berman@HIDDEN>)
 id 1jaItn-0003nF-LD; Sun, 17 May 2020 09:00:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589720396;
 bh=LwjUrxf5kNpnRkBf7FI0hAaUb3FCVBNKAfaEtjE2o+4=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=XJhtKDQumS63kp165nUMVO3lIEfYnY+r2s34V8bgLcQ6meSnZ1CKVNVuAnhV8/ZDm
 FcGVYlf1v9sq50ulx/d2KcnwnQrLksqAMV7rl8VRruySiaaYoJs/fdI4fgWyWpm/gm
 w8qRjPNAZ6YUmmdH71nBQzbyIDFvVxim6fqRWr4E=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([188.109.150.40]) by mail.gmx.com (mrgmx004
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MFbRs-1jrJ8k1stS-00H6yJ; Sun, 17
 May 2020 14:59:56 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
 <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
Date: Sun, 17 May 2020 14:59:55 +0200
In-Reply-To: <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN> (Eli Zaretskii's
 message of "Sun, 17 May 2020 15:36:10 +0300")
Message-ID: <87wo5aemyc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:FryKDU4/sM+ICkKE5okt+gSMTxw1Jfs+2l6pMi1+H19K+7xVD1x
 PCf9RhXZpXY0v9ey6PVVpjEIaFQDmoJAdzXMzAde/lEQZ/ZA7tZtjxlx+VABxdXar2kptfp
 WFzTNOIF1uW/bn4eiI5AIyKL2Pp3nP+98iW7ZooCHJnLfr2IDvZtYPV4NZCWDK6CCiBbG7k
 evmofHnHjizG/AqkVyBtw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:1dbJBsvaA3w=:PC4DJ+M0/JpCkR2t804KeR
 ARy0srWOhRfFCjMFzs0iEjfCDvbGAdcRhaNgXLzJVO+UILitPPPHr2FORbK6z2nwFktZEt1uB
 M5GXAw3ul+wzhINtKqw2ecjFW0VsO68xFYXTaSgBlrXu1P38NSvfXkZInUUxdr4lYQRtPnzQp
 vtcwhru3KK7wCaOt3lVItIb9kp9gFs9UkKnSVTsV8XseY/O2FNS8g1IiYr0qDX0BeQFHlvW49
 aUWNSyHYKln0Xp6+zEkS0rB+K2abGyZUt7uOrB74I+gI+A0E3GqPSTQgzd2XAdapjf24D6iUd
 DeGMMSuDH6SeuygLkWBPYOCzRzFFx2EQ/BsNWQuh/nXFPXkm1B3rlPK08NuTz6uMJ89BAQgYQ
 xn2z2CcR8sui8ZOuXAdr83MKVCAtKD+EtmIswPqHA3T37ZLeEuLHv4XkHQrnQvxKHYKu/kGzB
 Jjfz5pT3YJ+VtTWgcN576y3FMeJ3WkrioRKdXYhiBWrfOPASM6Zt4cbKjNL2wmr69W3D6sbcv
 Zb2hR1/JPfm5Ei0DKTY6nAp+Auto+vafeOZfCJ1g+IPracgSFyKzWXYDKBo8wRvS0FRYBBnF6
 1v0hGWVU7ngi1722hBUiSh6vZOSqxyppEVVMXk0hiltZnwd3G811IWTcYPOAinvCRAk4gpkYy
 YIdxI3MIAqW/CdObDR+I8ou6FSe6fKfd7uVo7LsBMcvHNmIYzWo5lV5rqxWzd9Y8OSVoyKese
 1INeYG1q7kXEYbortjiOBo7TXLTgo9tKX4lCx7am56m2KmnVe3mLCUmfO1danHbcF4CB2paA9
 VctJlz3YFm3NvhGVujWeqdiipzOVQXP2ay+v79bxonc1yoAZ9BVG4ZAI+t/rzcJ36zFX0NERf
 o3UDy/sTmyhqzh6o1Qyx9Nw2ww0oI+CWmokr1jW0ZFyl/aRyct0g8iDN+mnHJ9f8gd2LaCdVO
 r9HSH7CBMIu4Gi9WSXuBoKs7WzJC2riBRGr5LBpF5YltGbo+8a/3BNrdwaeHsx/r/MPIP92y8
 7vfLBncwQ/TScnF9htLdLuRWm1PXkK668NtWXnIRSFh373AdJdGxxr1vQ7eK2S4O+ZGdM9kz1
 G7wG5ISfldmxRpreF1v6oLmIsMniki2uyoAf1wxtV74PeeuFerxHi7T8dB4LrE6uu5Cq+qUBw
 2rIMIOYpRYFuD+T9NjNPxvsTd+dmhoOh17jhQhb19TtRhrekmOaEdatZhCQSun/phLvjt7IUb
 AsuOhSeNYEWOupeKj
Received-SPF: pass client-ip=212.227.15.18;
 envelope-from=stephen.berman@HIDDEN; helo=mout.gmx.net
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 09:00:08
X-ACL-Warn: Detected OS   = Linux 2.2.x-3.x [generic]
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001,
 URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: martin rudalics <rudalics@HIDDEN>, bug-gnu-emacs@HIDDEN,
 Juri Linkov <juri@HIDDEN>, 41338 <at> debbugs.gnu.org,
 Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

On Sun, 17 May 2020 15:36:10 +0300 Eli Zaretskii <eliz@HIDDEN> wrote:

> On May 17, 2020 12:11:04 PM GMT+03:00, Stephen Berman <stephen.berman@gmx=
.net> wrote:
>> On Sun, 17 May 2020 10:56:50 +0200 Stephen Berman
>> <stephen.berman@HIDDEN> wrote:
>>=20
>> > On Sun, 17 May 2020 10:20:55 +0200 martin rudalics <rudalics@HIDDEN>
>> wrote:
>> >
>> >>> But I don't know why the =E2=80=98delete-frame=E2=80=99 event is not=
 fired on
>> frame deletion.
>> >>
>> >> How do you delete the frame?  You don't get a 'delete-frame' event
>> when
>> >> you delete a frame via C-x 5 0 or C-x 5 1.
>> >>
>> >> martin
>> >
>> > In my test I followed the OP's recipe:
>> >
>> >> (7) Using the mouse, close the frame showing mouse.el, but do so in
>> a state
>> >> where still isearch overlays show up.
>> >
>> > I.e., I clicked on the 'X' (close frame button) in the frame's title
>> > bar.
>>=20
>> But when I close the frame with `C-x 5 0' instead and then proceed
>> with
>> the OP's recipe, the tool bar does not change and when I switch to the
>> buffer where isearch had been invoked, the search is now abandoned,
>> i.e., no isearch tool bar or lighter, no overlays.  So only closing
>> the
>> frame by clicking the close frame button with the mouse induces the
>> surprising behavior.
>>=20
>> Steve Berman
>
> Could someone please explain to me what is deemed to be the bug here?  Be=
cause
> I'm confused wrt what is the part of the original description that seems =
to be
> the problem.  In particular, the Isearch overlays are per-window, AFAIK.

The bug reported in the OP (the unexpected tool bar change) seems to be
triggered by isearch (it was part of the OP's recipe and I haven't been
able to reproduce it without using isearch), but maybe the observation
about isearch I reported in my followup is a separate bug or perhaps no
bug, even though it surprised me.

Steve Berman




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 12:36:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 08:36:27 2020
Received: from localhost ([127.0.0.1]:42516 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaIWp-0006KW-AG
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 08:36:27 -0400
Received: from eggs.gnu.org ([209.51.188.92]:48292)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1jaIWn-0006K6-Q5
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 08:36:26 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58406)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1jaIWf-00071Z-3X; Sun, 17 May 2020 08:36:17 -0400
Received: from [176.12.207.139] (port=60483 helo=[10.156.146.116])
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1jaIWe-0008Uj-35; Sun, 17 May 2020 08:36:16 -0400
Date: Sun, 17 May 2020 15:36:10 +0300
User-Agent: K-9 Mail for Android
In-Reply-To: <874ksfexjr.fsf@HIDDEN>
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
To: bug-gnu-emacs@HIDDEN, Stephen Berman <stephen.berman@HIDDEN>,
 martin rudalics <rudalics@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
Message-ID: <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Konrad Podczeck <konrad.podczeck@HIDDEN>,
 Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On May 17, 2020 12:11:04 PM GMT+03:00, Stephen Berman <stephen=2Eberman@gmx=
=2Enet> wrote:
> On Sun, 17 May 2020 10:56:50 +0200 Stephen Berman
> <stephen=2Eberman@gmx=2Enet> wrote:
>=20
> > On Sun, 17 May 2020 10:20:55 +0200 martin rudalics <rudalics@gmx=2Eat>
> wrote:
> >
> >>> But I don't know why the =E2=80=98delete-frame=E2=80=99 event is not=
 fired on
> frame deletion=2E
> >>
> >> How do you delete the frame?  You don't get a 'delete-frame' event
> when
> >> you delete a frame via C-x 5 0 or C-x 5 1=2E
> >>
> >> martin
> >
> > In my test I followed the OP's recipe:
> >
> >> (7) Using the mouse, close the frame showing mouse=2Eel, but do so in
> a state
> >> where still isearch overlays show up=2E
> >
> > I=2Ee=2E, I clicked on the 'X' (close frame button) in the frame's tit=
le
> > bar=2E
>=20
> But when I close the frame with `C-x 5 0' instead and then proceed
> with
> the OP's recipe, the tool bar does not change and when I switch to the
> buffer where isearch had been invoked, the search is now abandoned,
> i=2Ee=2E, no isearch tool bar or lighter, no overlays=2E  So only closin=
g
> the
> frame by clicking the close frame button with the mouse induces the
> surprising behavior=2E
>=20
> Steve Berman

Could someone please explain to me what is deemed to be the bug here?  Bec=
ause I'm confused wrt what is the part of the original description that see=
ms to be the problem=2E  In particular, the Isearch overlays are per-window=
, AFAIK=2E




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 May 2020 12:36:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 08:36:24 2020
Received: from localhost ([127.0.0.1]:42513 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaIWm-0006KH-0b
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 08:36:24 -0400
Received: from lists.gnu.org ([209.51.188.17]:59686)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1jaIWj-0006K8-03
 for submit <at> debbugs.gnu.org; Sun, 17 May 2020 08:36:22 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55706)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1jaIWi-0003fW-Ph
 for bug-gnu-emacs@HIDDEN; Sun, 17 May 2020 08:36:20 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58406)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1jaIWf-00071Z-3X; Sun, 17 May 2020 08:36:17 -0400
Received: from [176.12.207.139] (port=60483 helo=[10.156.146.116])
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1jaIWe-0008Uj-35; Sun, 17 May 2020 08:36:16 -0400
Date: Sun, 17 May 2020 15:36:10 +0300
User-Agent: K-9 Mail for Android
In-Reply-To: <874ksfexjr.fsf@HIDDEN>
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
 <874ksfexjr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
To: bug-gnu-emacs@HIDDEN, Stephen Berman <stephen.berman@HIDDEN>,
 martin rudalics <rudalics@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
Message-ID: <F8F75713-04BE-48F0-B2A8-83028474DD1E@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
Cc: 41338 <at> debbugs.gnu.org, Konrad Podczeck <konrad.podczeck@HIDDEN>,
 Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On May 17, 2020 12:11:04 PM GMT+03:00, Stephen Berman <stephen=2Eberman@gmx=
=2Enet> wrote:
> On Sun, 17 May 2020 10:56:50 +0200 Stephen Berman
> <stephen=2Eberman@gmx=2Enet> wrote:
>=20
> > On Sun, 17 May 2020 10:20:55 +0200 martin rudalics <rudalics@gmx=2Eat>
> wrote:
> >
> >>> But I don't know why the =E2=80=98delete-frame=E2=80=99 event is not=
 fired on
> frame deletion=2E
> >>
> >> How do you delete the frame?  You don't get a 'delete-frame' event
> when
> >> you delete a frame via C-x 5 0 or C-x 5 1=2E
> >>
> >> martin
> >
> > In my test I followed the OP's recipe:
> >
> >> (7) Using the mouse, close the frame showing mouse=2Eel, but do so in
> a state
> >> where still isearch overlays show up=2E
> >
> > I=2Ee=2E, I clicked on the 'X' (close frame button) in the frame's tit=
le
> > bar=2E
>=20
> But when I close the frame with `C-x 5 0' instead and then proceed
> with
> the OP's recipe, the tool bar does not change and when I switch to the
> buffer where isearch had been invoked, the search is now abandoned,
> i=2Ee=2E, no isearch tool bar or lighter, no overlays=2E  So only closin=
g
> the
> frame by clicking the close frame button with the mouse induces the
> surprising behavior=2E
>=20
> Steve Berman

Could someone please explain to me what is deemed to be the bug here?  Bec=
ause I'm confused wrt what is the part of the original description that see=
ms to be the problem=2E  In particular, the Isearch overlays are per-window=
, AFAIK=2E




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 09:11:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 05:11:18 2020
Received: from localhost ([127.0.0.1]:42292 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaFKH-0007Z1-Va
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 05:11:18 -0400
Received: from mout.gmx.net ([212.227.17.21]:37001)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1jaFKF-0007Yn-Dg
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 05:11:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589706665;
 bh=qxsdM+UhRtm26q2Lwjva6fP+abOFHcMvTIxOP/TV3z8=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=EyGH2xmLNQ78iKoMFWT/upLPTy3a2F7+f28tEu2so+wqQTfoM6q3s5PG+JX9Tnt+d
 geHG2ZNEsTYHAnbMzLweviO0yPArmuUJYePQ/HehmH93xGKtadbCaRxdv9AquNJqr5
 ku1IyDng71isBGNZ+oH4mvuOmKss0ySE63uciuok=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([188.109.150.40]) by mail.gmx.com (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M7JzQ-1jhupZ0nt6-007p7T; Sun, 17
 May 2020 11:11:05 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> <878shrey7h.fsf@HIDDEN>
Date: Sun, 17 May 2020 11:11:04 +0200
In-Reply-To: <878shrey7h.fsf@HIDDEN> (Stephen Berman's message of "Sun, 17
 May 2020 10:56:50 +0200")
Message-ID: <874ksfexjr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:SrQK8bkBplYbeT7khcXTpSmgvVjU2S3EroTpsKoRT+ztCRz6zsZ
 Ah3J3FrQXikGc60xtIu9P/9c8zM1Kp9Gmo9gC04aF4Z9XThsAtjYFpfjteNBUPwKRPHkPUP
 Z1m6Zj9iZAlOYU3XibTTm7oG4ZFcqzKd5cyffxyzK7rBmvUTafiCo0FezEu2fzzUVKHGDNc
 P4vkWx3OXKyix0PwOJDuA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:jJfcsDwDCM8=:MCBePfA0B2v0nJ7cmtxP64
 y9g3BHotT0qyDdYDN8PWMpi21KsOL5N98xRo7wdlAWp5+YmFamorkTl1Y95AR1/4cH+ThwP+2
 3sFKh86+apskw6g5f9ukCCDdGKczIi1VqYFgwejRGrhURErNYzb6mnCq4gMupbqjeAY8Hi8e+
 dbpNjRJRfiYmsLYnHYUdaQp1CrQgRQiZ7mcI6y7Nqc9N+buLvn6zxC1IDFg0FQXBbp7JZfslm
 keqwWq4ZlO6XbVzNQeesVx3QHKqPsmm0ZeuZg0UufaY9WKd01n0nQaEp7Y27GSw6mTrM4yZV2
 iZhiTRMpI39VQeDn3RsOri3Dnv3WZCCQmgC2wIc0NSMztgqrZVcfl1Mto/EwUawB9RTGnDkgk
 o9DUL6SJM3KUlUnYYNY38DHDsIYaxw6fioZj3D6kSKftLTsJFCs5JNEVfrV+OmeZN9P5HBmaA
 UiNL9m28aL9aAmhH2cV9h4PZSM1G1/1Cc0qZnhIEMqEhADtSYLdmS//t0U2KxCFnU2o1SE0UE
 O7wMbWePhD3dK491QgmMraz4BUWE1L8dNnW2GNX9S1VLc7HNF5RNGXQEj5bEZRkOZssvSsVkB
 y1FY/+uAfPekrvjBcTZKkl9rqsG5gFbjzFv9D9I8LzkALzjwg4QKtt+ApH+d+LKl+NVg29p88
 RMXrZFbkwmdegN8yNGLK6djQvdLkPt4qw5uT0tTSSXVu9H5wiewnr+YlrPw1EZp9ORiN7RGmy
 bCk1a3x8KpmsPmHhgPCJ1rHdtV+NUZCLxuFSFRLFU4SW482p6/VLHpBjzfdAE+2rVms3hB5mq
 8iNCPMd7SO5Lnko5apNkemrF78kkdmXR+seNXKTI4mqzlKUPh1bBs0jQhQdQ281aEx8AhT0vn
 QuXOb7V9XTSEw6hFa0O1E8NpTybfbFphORLiOWdkr67tgUoJPrUfRJ4zAzOoZdmU5VzHNvWgf
 +bS6ss3BS7LkTrU4j8hv7p+C3f3TzqNSAjCWxeaC/UOp+ocWvWxsDpZpI2QI7uSUbrjFhqVkC
 0IJsfiAYv72ChmLGlsBV1ZCOHjMQ54s4qHQgoxwv6Ne9gezi60SExLti05tS9gNS7U4IYckWi
 Lp+vTEh586LPVOv+uBvAdlJVuLqGbq6uSkHw4bnHEBtDwHea5Hpr7IPgAmEdKnkKi9zn4OYuc
 ACUWOW1Wom7d2rmTbirsamtBIlXnr7EKZasiQt+CkTzOpVFrXDqJWIGBkcPFsq1nMf9t8pOcX
 YofoIVOEKpNYBHT21
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Konrad Podczeck <konrad.podczeck@HIDDEN>,
 Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Sun, 17 May 2020 10:56:50 +0200 Stephen Berman <stephen.berman@HIDDEN> =
wrote:

> On Sun, 17 May 2020 10:20:55 +0200 martin rudalics <rudalics@HIDDEN> wrot=
e:
>
>>> But I don't know why the =E2=80=98delete-frame=E2=80=99 event is not fi=
red on frame deletion.
>>
>> How do you delete the frame?  You don't get a 'delete-frame' event when
>> you delete a frame via C-x 5 0 or C-x 5 1.
>>
>> martin
>
> In my test I followed the OP's recipe:
>
>> (7) Using the mouse, close the frame showing mouse.el, but do so in a st=
ate
>> where still isearch overlays show up.
>
> I.e., I clicked on the 'X' (close frame button) in the frame's title
> bar.

But when I close the frame with `C-x 5 0' instead and then proceed with
the OP's recipe, the tool bar does not change and when I switch to the
buffer where isearch had been invoked, the search is now abandoned,
i.e., no isearch tool bar or lighter, no overlays.  So only closing the
frame by clicking the close frame button with the mouse induces the
surprising behavior.

Steve Berman




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 08:57:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 04:57:17 2020
Received: from localhost ([127.0.0.1]:42287 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaF6W-0007DF-9F
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 04:57:17 -0400
Received: from mout.gmx.net ([212.227.17.21]:60539)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1jaF6T-0007Ck-VQ
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 04:57:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589705813;
 bh=jmePEy7m4fIXKoFQ5TwdUMUTyvAt2ZLmDI7SeKsp0q8=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=YNlY1XmMsbot9+heu8CDY4JVgeGunrQynQv1fJ0N4vtanatwa64/6CZQE0KTg/rSR
 S41Qwq58DQEX320nYNWr16u/CAtX1f1ugLJLLiZMRQ2WQGw94cGxUmS7FEMZ7sY9Iu
 pUwu/wqFDiIC98b9P6895iEpAAnAGyqYMp/bngyI=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([188.109.150.40]) by mail.gmx.com (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MYeR1-1jWYC60cip-00Ve1Z; Sun, 17
 May 2020 10:56:53 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: martin rudalics <rudalics@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
 <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
Date: Sun, 17 May 2020 10:56:50 +0200
In-Reply-To: <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN> (martin rudalics's
 message of "Sun, 17 May 2020 10:20:55 +0200")
Message-ID: <878shrey7h.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:uZZOU2j2I4mu53aU0emN1jZjyWqE8SrBBBlaNXJKSGSFIvFh/PI
 Ugn/Ys+IudwqtEjhO2vTY4chqw764JdV0Bp+TyZRrfsQkBMebFsIr8wXHPSw3qjaGSJhWvO
 WK6bqml4gIPUjqCkHyZxNKQhMaaB3dIU+an42S2DI09F6atxNcFedBfKCuMGD6r2wzBhInX
 Moib4cMwZ0MbHg1lXeCLg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:X/UM7Gg0jcU=:1iKrmQ7zWgKFcdTxYiccZx
 aCjsV853bD+YBs4Un4QAJ8AaZm8KU0ElXl956IN0/Xvz3HpMR4mLOZUoyG96UNtEe6PjMRa7Z
 X0Y0wyixifGrNrONzdQyniT91vHkEoMr6xG7PoHCB5EjHNzS3zjMDEs0WxDEdYNLyk+bobtbZ
 yajJRT7fkug0buSrstwVR/79t+C14EueuphJucXxPQAI+VeZZpYP95nIO9c6VeKFBkGMefDT3
 AMZKhcMPTns+QFILHNe/UR5q4ba9zL7cYrsq+Ul/suEvaalaMKaAfmy5BWXu6fdhoNltlhzsK
 7TTkT5ZI06JDuw4OLtLznOkBlJRgsaVqGVBq2y/v/Tk2WvFzIBHC4GdpVFHn99K36O/nCyr4P
 G20rzdeJuFMYbMgnZeEwGTkYNqrHPupQ4LIpnxM13igMByN4dG5bdk+8vDvfJlHNTieoENOW1
 lefbqqaGmKYRA0zV28ZJZYhwtKqTygy+cupP1yIehamK5Taf8oT9zvbPg67MmSk2yh1XS2GvX
 o5WmKDlSz+DAZn/HHxm6bngefuYbwBIfcfdAYoL2bB3SHAhrYmfsOx0PUF5EyA72C/HYYe/Tq
 DLMg2+rnWEV3TPTctDkM0pNLSotj+bpxmRtUgRJnQmoRrZfPMCal1OSUZfuYxwVXmT1hWDMiY
 RnWe/l4kt/Li4NM07kiqCCiKamDQjUuF2utVsw4qYlU2JdrsYFsLQkp75T5TUu/aW/TGszx6Y
 aTDxX0mFVFuKeXANRScUYmXxKnwxae0qiusNal+QQ4yBQwcizji/bDr3i23FmBLHk3pjlQzpZ
 mV+nnmVzTWf0qCAm33T2dxcwxTzqGXTlZBtzVXIXbaRqVdD1iFWnn+CtYvdoNKmQgm70oHpzf
 EJaBJwHZba8P+wWfnCpxP64IKvGZLPC59pw0u9hPED5TdYjWbMwn8LdmGLXxiDs92unEx7vqd
 1az3zhbtnT9dE6KlKOkdgKIAE8OyGlNp8HewwXngEGC22qUT6yzmXuRfRBteMpd2jdnCeeXa5
 k4FrjzAggl6QNxXBb8WqSd0kyGNZ2fVQVmyuZE3HO2XM9jTgECKd7UqrE/CXkdyFDR3UDy0lt
 YmLQeMAj1jd+lpPnn0aX2Dk5TtU9VZKnaNPuKqNNzkQOFJQUs5B0355RrTqyTrLHq9YX/FB0y
 qfH7V59A9uDLkMtNN4Olnvo0clSj55qJFaH1IaYWes4pxm/Ib7V9XAxK3qRS9KmVmKCH4dyeH
 cJg5WGuaXz0idkyHk
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Konrad Podczeck <konrad.podczeck@HIDDEN>,
 Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Sun, 17 May 2020 10:20:55 +0200 martin rudalics <rudalics@HIDDEN> wrote:

>> But I don't know why the =E2=80=98delete-frame=E2=80=99 event is not fir=
ed on frame deletion.
>
> How do you delete the frame?  You don't get a 'delete-frame' event when
> you delete a frame via C-x 5 0 or C-x 5 1.
>
> martin

In my test I followed the OP's recipe:

> (7) Using the mouse, close the frame showing mouse.el, but do so in a sta=
te
> where still isearch overlays show up.

I.e., I clicked on the 'X' (close frame button) in the frame's title
bar.

Steve Berman




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 17 May 2020 08:21:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 17 04:21:11 2020
Received: from localhost ([127.0.0.1]:42250 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jaEXm-0006MD-Q9
	for submit <at> debbugs.gnu.org; Sun, 17 May 2020 04:21:10 -0400
Received: from mout.gmx.net ([212.227.17.22]:40423)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rudalics@HIDDEN>) id 1jaEXh-0006LL-6B
 for 41338 <at> debbugs.gnu.org; Sun, 17 May 2020 04:21:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589703657;
 bh=iB6orjsp7Pw5QRzO8SPLP/jb8EgDuyzEApxxipfZ3t0=;
 h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;
 b=jyVz1+2duelT+UOC/8yb6moUeTFBMfXSIN1U0J280XaTTr9zZFXUEMMxgf0kGeDSv
 nRL9W6xQA4OzAgJ4WUZUFBwz+y38+YwaUHsGgPXwxvAJGpqhwpRCTaS9YzXaDu44is
 DljXmxP2cTlmfGK/5dDNKH5FyvokVrJGHMtWx/ko=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from [192.168.1.101] ([46.125.249.9]) by mail.gmx.com (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mzyuc-1ipGSk3vGg-00x2Zd; Sun, 17
 May 2020 10:20:57 +0200
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
To: Juri Linkov <juri@HIDDEN>, Stephen Berman <stephen.berman@HIDDEN>
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN> <877dxb4hzh.fsf@HIDDEN>
From: martin rudalics <rudalics@HIDDEN>
Message-ID: <c6561d9f-4014-18f0-2c9a-efc748333a92@HIDDEN>
Date: Sun, 17 May 2020 10:20:55 +0200
MIME-Version: 1.0
In-Reply-To: <877dxb4hzh.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:0MsyPUQPU4dAmSJGgsp/ansDvjykm3jzmFw41JFGfwU9y1P5GUv
 /eFIrn4Xk79OuJFgWx8FWd97LXrQjIwM/369KlJv+jCg8EKgEU14jR+I7cmD2kdzgp9AyBG
 fTbnSzrf2yTC+aaTFwQWeEIWPJyrbuH7nRmoWbZhxb5xVYs2xMI++McEmh74yoqpEiRnAsw
 2AZodx2vgvOLMo/+8hjQw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:AJ7Tw8sgUBE=:YpmF5IZc0/Oc6OcZXx7lAT
 VfieVdBKHBZl8UkNIFjavqwKhuDf7dDvk4gmX3YmhnWT38LgJNlkVuCBjhkGYrjX0lsYbtszI
 J39FcC6w7AOmQThZTnTSC5u5iqPJY9GnDZZjwC1xGQ997GPfQOwvJjWB3WurZ4/UoNzIjsZBd
 PyknAgu/347aCFRDvcWA7WwhtIk8V3C9ddDXHiA489Rv+DTqIQZGYKlv6qQ14SqdooNJXOxOc
 wG7QYkPFPhD+za826iw8p65W3MR/HeHOhqspflYftmuFkGBjlAsj3mJxAz858DqpcHdu6WAPF
 um2bHHjZ5a41XswR4ebEdnzPfQOvIM+p0U0eh+Oblmpu6ojnJ882vvjbmj9iRmyRbk9I5OXc6
 kLE8VFiH9gXqXdOv3ZzuiYrHCwyvYgaa23qaHU2RyacXMHPDTKRU6YT4f8OGAqNqXi7Q8Jbzs
 QvDHFEQfF6gFFD9wh9wIPrmSUiOkFJT0XUfAfNe3mSXQcGul2o6gDKzj5l1ZuRU9UvpltZGPp
 8XA484kU3W1B/neCOumr0lAO+WXYA1j/bapKx4ZgWdrPbijX2DQnXZwOmam2iaYrAmMY/qBni
 3N/YufQ67Hyb3RFEh2G+bOgOaK1g8WQuWnhNA7hbKIBNRovhHgS/yYUxvPSm7LbNmU0ScFP7g
 N6XEvAjmM64INxGcy6HPLV4FemrSKoU2fLzEN4gy/n/Hxf46W2niJ5A/aYUn6lf5u06sinPmr
 2IGNOb3aXsoLPYvec+rRst3gvDmqjGbAaNAtwCur7E66lRuk18/Do8yToVkp8ckCCvj0KCo5x
 GxaYVWIXAzuKzqCVPdXHLzcXZZ7zKB4lZ1GTEN59j5lHy94X20i6DV38QM6WmPlpRArTumQeW
 lZcY2t524KblZOIqSavVeqGFzwdPy0n7MS60gVlEcEUSUeZWMnw2hG2E5qdPvQUIxIn9ZlWXr
 ETVLllcJpqGASy+0eOzA57lw/wcrvfzD0GByRdNMsnrE+5/WUMvJcDRpXH/9s3hjYgLIGrV/F
 ucNZlT1NzRgyiPgcmEwckLAFcXRxWxvFD53FDokjE/y4WzQFPWQbUuFQAluGRtaCllbhd0bFC
 F95/YhPoztEe2DNdvaKHh6umN+aKVogqsFQxPmJ0pfSTmst9CYMAMNNphrtlZoXsKi49CrLXD
 9yHWcbun6DrE2PlDIeQQvvmc+cyoNNgbjfbgC6TU+3OBs3SJsJGobMDy/glke8aT+Clnz84U/
 MDfe43ijtRBdKyStz
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

 > But I don't know why the =E2=80=98delete-frame=E2=80=99 event is not f=
ired on frame deletion.

How do you delete the frame?  You don't get a 'delete-frame' event when
you delete a frame via C-x 5 0 or C-x 5 1.

martin





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 16 May 2020 23:24:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 16 19:24:49 2020
Received: from localhost ([127.0.0.1]:41906 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ja6Aj-000110-JM
	for submit <at> debbugs.gnu.org; Sat, 16 May 2020 19:24:49 -0400
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55873)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1ja6Ah-00010j-8v
 for 41338 <at> debbugs.gnu.org; Sat, 16 May 2020 19:24:48 -0400
X-Originating-IP: 91.129.104.245
Received: from mail.gandi.net (m91-129-104-245.cust.tele2.ee [91.129.104.245])
 (Authenticated sender: juri@HIDDEN)
 by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BAE141C0003;
 Sat, 16 May 2020 23:24:39 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stephen Berman <stephen.berman@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
Organization: LINKOV.NET
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
 <87ftbzva1f.fsf@HIDDEN>
Date: Sun, 17 May 2020 01:55:06 +0300
In-Reply-To: <87ftbzva1f.fsf@HIDDEN> (Stephen Berman's message of "Sat, 16 May
 2020 23:34:36 +0200")
Message-ID: <877dxb4hzh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org, Konrad Podczeck <konrad.podczeck@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> To reproduce:
>>
>> (1) Start Emacs (without any customizations).
>>
>> (2) Open a file which has the standard toolbar, say mouse.el
>>
>> (3) Do C-x m, to open a message buffer; this buffer has a toolbar _different_
>> from the standard one.
>>
>> (4) Do C-x 5 2, to get the message buffer shown in a second frame.
>>
>> (5) In the first frame, make the buffer showing mouse.el active again.
>>
>> (6) In that buffer, do C-s, to invoke isearch and search for some word.
>>
>> (7) Using the mouse, close the frame showing mouse.el, but do so in a state
>> where still isearch overlays show up.
>>
>> (8) Now click with mouse-1 in the remaining frame, i.e., in that showing the
>> message buffer, and the toolbar changes to the standard one.
>>
>> I consider this as a bug. In case it is not platform independent, I us an NS-build.
>
> I see this too, on GNU/Linux (both in 27.0.91 and a recent build from
> master).  Moreover, if in the remaining frame I switch from the message
> buffer to the buffer in which isearch was invoked, the tool bar is now
> the isearch tool bar and the mode line has the "Isearch" lighter, but
> there are no isearch overlays and point is where it was before invoking
> isearch.  This seems surprising.  But now typing C-s restores the
> isearch state the buffer had (i.e. the same overlays) before closing the
> other frame.

isearch-mode-map has such bindings:

    ;; Pass frame events transparently so they won't exit the search.
    ;; In particular, if we have more than one display open, then a
    ;; switch-frame might be generated by someone typing at another keyboard.
    (define-key map [switch-frame] nil)
    (define-key map [delete-frame] nil)

and indeed the ‘switch-frame’ event is fired when the frame is switched
during isearch, and it exits isearch.

But I don't know why the ‘delete-frame’ event is not fired on frame deletion.

Perhaps isearch.el should explicitly use the hook ‘delete-frame-functions’
to exit isearch.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at 41338 <at> debbugs.gnu.org:


Received: (at 41338) by debbugs.gnu.org; 16 May 2020 21:34:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 16 17:34:50 2020
Received: from localhost ([127.0.0.1]:41840 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ja4SH-0006rF-O0
	for submit <at> debbugs.gnu.org; Sat, 16 May 2020 17:34:49 -0400
Received: from mout.gmx.net ([212.227.17.22]:47041)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stephen.berman@HIDDEN>) id 1ja4SF-0006r1-6u
 for 41338 <at> debbugs.gnu.org; Sat, 16 May 2020 17:34:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
 s=badeba3b8450; t=1589664879;
 bh=cogqyV8SVf0vBuLUatqhLRTxpiBQ3oIrR/nJHQF03vI=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
 b=ZmKHYBkRGBj6QdzxcPC0q3Vk2VzRoxEFE1cIKvNpozA5hT9PwLHDvrRl/sXhntxuy
 xdDsR+tF65W1EQ7BU7cP4bbkT/q6xrnpOyCS2BvcZ6JJYNOBX4y5aC5q/mfRw5DUZx
 xDdNbiSBXc3JBn0UPmQe81vaIvurlWo4JL5/Lxz0=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from strobe-jhalfs ([178.1.124.163]) by mail.gmx.com (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MnJhU-1jAwMk3VPo-00jJJ0; Sat, 16
 May 2020 23:34:38 +0200
From: Stephen Berman <stephen.berman@HIDDEN>
To: Konrad Podczeck <konrad.podczeck@HIDDEN>
Subject: Re: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest
References: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
Date: Sat, 16 May 2020 23:34:36 +0200
In-Reply-To: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN> (Konrad
 Podczeck's message of "Sat, 16 May 2020 22:43:25 +0200")
Message-ID: <87ftbzva1f.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:iZQSjPw9+m1Eq9Igkwz4BObufFTtbYxXcPZLVWe7H9MzI/7xn7R
 flgp6pYaGEG0oHqbwISUK1/EQf0MHzY0I5cMAaAhH2oXoCCfUdnvXxbRyuP/RDCcscuxcnD
 5KFOw6oS/8Lu5aicjZqMVX4LX9p3LT9IO9xsPcfnp9tCI6KNUL9KsPt/GCuM0rBaft5xpBu
 n5ZH0tvoLeCvCSW4jUpDg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:N+/iWjGGoH8=:I011X7BvPtLiCVhWpx2BDE
 oNX4mNDUCgvy3gB3S0AQiu32TnueSk8SBwEtpZUrkEECbpZE+yfS70XReoX8sAKrQLbrKcL0O
 kG7WpTQ775TT6eBgJhhgUDOxnknsOEdGNHoQtje87q1jQgSzIMAaKSj3h6xGRN+dtiPtQ1X1a
 pG5cww2yJlzYCOV3jS7P+1AWnY6/+iLqbVinnuz9quW+lyFdVkTh0RJnJ8zQbYS/bqSJtxgNT
 e0y5bIgPGVFL+SUtnjylL+7j3HXxva3yzoCBPNm8VKwMTrsLw3lbwDTI2HBgE5r9Pijeoz+ZU
 6eNTYav2oGNbxEGfd1iznvWgkockNp/kwpms6NDuM2Ta8SAIyqO9Pr5bf4Q1uNqTc5YCcZc9Q
 ZZgsKqmx1Er0TbiR06v4CGjWJcmpzrwskQ2SqUnyOCXerlZ2Ei4eEgPqpBEwKcJvwCAK1pWdt
 9zQjjnHx9AJb9EYXUG++7NRnrTO3uAIktWSIZ73iRoEXfbPH0pCPVABe4jUd58DSp+V+2dJJE
 e8d5adLWpfwGn2q5PXRk+YlYXuXtM9CBCvVorcHLR9mNKiaB0Nm57YRyYfmy8e8zNLFpdBEMU
 aATbLvLqDb4F9FGRMvx0E3558Tgqzeh4HRnb3p8MV9mLWvPf1MtbR2wczDMYmbsYkP+aIdv6r
 zj8FH3Zd1e+Pc1Vgz/1rVxLkAUnneA0FzPFzNPFWtRZdjsd6MR2Vsz250oshDExGAseg1aOEh
 6q1HoNFQusKqnOH3LZHSgazepZoUv59zweGFM1tvtxsUjDXn+QvDv4FWqhn0Dy3x5z6CeCvnN
 uugeiFNfMAYXU4H4EAR2QcLQoRLN2/w7K0cUQkPYLg3I7SuHwQUfaFtJb3yGeWl09uQOvIA1V
 y4iY5s3c9j238zEJm2zzH0wfdLPNXRF5pAs+VWXE0xjMUFL8KV6OEiFWgD4a/OLfOzVXLQVzO
 c6BEvl1z9PFqlti/6xEzKSftH9P2378+TsjaApoCjhT820rxXvTWFKkK7oK5YC+jeTZ1ypxjz
 hHJ02o9R6baqi/C9gAc3NQJruI2ZhS/q7sEyEcMWFtzlgIOPlhD4hXQtd/H9twZGTPbbUbGbN
 fs05tIoke27Nxao6ddpMuBPmCiJYugebvaxpX3GBmgLuUrfUxYA8RHwc5MIgbloYq80BEkWZ2
 v9F+fiuhy+AD5gpiXq+76QmHttU1UVXtXiEKpAJdr8maUwE5p9xN+4fJb6Y3Auzmw+DQ812Ho
 hop+zqU0rsw/7qSy4
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41338
Cc: 41338 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Sat, 16 May 2020 22:43:25 +0200 Konrad Podczeck <konrad.podczeck@HIDDEN> wrote:

> To reproduce:
>
> (1) Start Emacs (without any customizations).
>
> (2) Open a file which has the standard toolbar, say mouse.el
>
> (3) Do C-x m, to open a message buffer; this buffer has a toolbar _different_
> from the standard one.
>
> (4) Do C-x 5 2, to get the message buffer shown in a second frame.
>
> (5) In the first frame, make the buffer showing mouse.el active again.
>
> (6) In that buffer, do C-s, to invoke isearch and search for some word.
>
> (7) Using the mouse, close the frame showing mouse.el, but do so in a state
> where still isearch overlays show up.
>
> (8) Now click with mouse-1 in the remaining frame, i.e., in that showing the
> message buffer, and the toolbar changes to the standard one.
>
> I consider this as a bug. In case it is not platform independent, I us an NS-build.

I see this too, on GNU/Linux (both in 27.0.91 and a recent build from
master).  Moreover, if in the remaining frame I switch from the message
buffer to the buffer in which isearch was invoked, the tool bar is now
the isearch tool bar and the mode line has the "Isearch" lighter, but
there are no isearch overlays and point is where it was before invoking
isearch.  This seems surprising.  But now typing C-s restores the
isearch state the buffer had (i.e. the same overlays) before closing the
other frame.

Steve Berman




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 16 May 2020 20:43:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 16 16:43:43 2020
Received: from localhost ([127.0.0.1]:41817 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ja3ep-0005eK-5h
	for submit <at> debbugs.gnu.org; Sat, 16 May 2020 16:43:43 -0400
Received: from lists.gnu.org ([209.51.188.17]:60638)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <konrad.podczeck@HIDDEN>) id 1ja3eo-0005eD-CR
 for submit <at> debbugs.gnu.org; Sat, 16 May 2020 16:43:42 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:38946)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <konrad.podczeck@HIDDEN>)
 id 1ja3eo-0006nZ-5C
 for bug-gnu-emacs@HIDDEN; Sat, 16 May 2020 16:43:42 -0400
Received: from grace.univie.ac.at ([2001:62a:4:25::25:115]:38584)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <konrad.podczeck@HIDDEN>)
 id 1ja3el-0003h8-Tx
 for bug-gnu-emacs@HIDDEN; Sat, 16 May 2020 16:43:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=univie.ac.at; s=rev2; h=To:Date:Message-Id:Subject:Mime-Version:
 Content-Transfer-Encoding:Content-Type:From:Sender:Reply-To:Cc:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=a4TPqYIj1tFKvTBOsQPp7MTi1K3QVFHumSrPEfA5v44=; b=fjCFYG9J5hJq9+MGcSYWkoizs3
 yPfhVTmJQ2hq75uFitnhQHFMstadJ4pfN+LWwWTUiOYwGuW//ZKCl9gta4zp++8ZPMZ+8tA9Qam3+
 4RVBYYx8AsqiPbOswoHUXbbqsOvAMLajOBT+5ARnNa9TjRDhXcM6q79+zhPYRpfW8J/k=;
Received: from joan.univie.ac.at ([131.130.3.110] helo=joan.univie.ac.at)
 by grace.univie.ac.at with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256)
 (Exim 4.93) (envelope-from <konrad.podczeck@HIDDEN>)
 id 1ja3ed-0005ic-J3
 for bug-gnu-emacs@HIDDEN; Sat, 16 May 2020 22:43:31 +0200
Received: from 217-149-168-185.nat.highway.telekom.at ([217.149.168.185]
 helo=[10.0.0.13])
 by joan.univie.ac.at with esmtpsa (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 (Exim 4.93) (envelope-from <konrad.podczeck@HIDDEN>)
 id 1ja3ed-0003eB-Dx
 for bug-gnu-emacs@HIDDEN; Sat, 16 May 2020 22:43:31 +0200
From: Konrad Podczeck <konrad.podczeck@HIDDEN>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Toolbar-bug in Emacs 27.0.91/Pretest
Message-Id: <A68C1CC2-966B-482F-AF0D-4BDFC1B3A898@HIDDEN>
Date: Sat, 16 May 2020 22:43:25 +0200
To: bug-gnu-emacs@HIDDEN
X-Mailer: Apple Mail (2.3608.80.23.2.2)
X-Univie-Virus-Scan: scanned by ClamAV on joan.univie.ac.at
Received-SPF: none client-ip=2001:62a:4:25::25:115;
 envelope-from=konrad.podczeck@HIDDEN; helo=grace.univie.ac.at
X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache.
 That's all we know.
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

To reproduce:

(1) Start Emacs (without any customizations).

(2) Open a file which has the standard toolbar, say mouse.el

(3) Do C-x m, to open a message buffer; this buffer has a toolbar =
_different_ from the standard one.

(4) Do C-x 5 2, to get the message buffer shown in a second frame.

(5) In the first frame, make the buffer showing mouse.el active again.

(6) In that buffer, do C-s, to invoke isearch and search for some word.

(7) Using the mouse, close the frame showing mouse.el, but do so in a =
state where still isearch overlays show up.

(8) Now click with mouse-1 in the remaining frame, i.e., in that showing =
the message buffer, and the toolbar changes to the standard one.

I consider this as a bug. In case it is not platform independent, I us =
an NS-build.

Konrad





Acknowledgement sent to Konrad Podczeck <konrad.podczeck@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#41338; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 23 Jul 2024 18:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.