GNU bug report logs - #41411
gnu: gnurl: Update to 7.70.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41411 in the body.
You can then email your comments to 41411 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nikita Gillmann <nikita <at> n0.is>
To: guix-patches <at> gnu.org
Subject: gnu: gnurl: Update to 7.70.0
Date: Wed, 20 May 2020 00:17:25 +0200

[Message part 1 (text/plain, inline)]

This updates gnurl to version 7.70.0.

Something to consider (for gnurl and curl):
While all tests pass, gnurl and curl want the python module "impacket"
for some tests since bundled impacket got removed.

runtests.pl:
In the environment of guix, $USER is unset.

# get the name of the current user
my $USER = $ENV{USER};          # Linux
if (!$USER) {
    $USER = $ENV{USERNAME};     # Windows
    if (!$USER) {
        $USER = $ENV{LOGNAME};  # Some Unix (I think)
    }
}


leads to $USER being uninitialized at some point (around line 3600 or
something further below, grep for it). The tests loudly complain to the
log but it's not fatal.
Can I (as gnurl upstream) set a fallback value like "Anonymous" in the
next release, or what's your take on this?

[0001-gnu-gnurl-Update-to-7.70.0.patch (text/plain, attachment)]

Message #8 received at 41411 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Nikita Gillmann <nikita <at> n0.is>
Cc: 41411 <at> debbugs.gnu.org
Subject: Re: [bug#41411] gnu: gnurl: Update to 7.70.0
Date: Wed, 20 May 2020 02:54:22 +0200

> runtests.pl:
> In the environment of guix, $USER is unset.
>
> # get the name of the current user
> my $USER = $ENV{USER};          # Linux
> if (!$USER) {
>     $USER = $ENV{USERNAME};     # Windows
>     if (!$USER) {
>         $USER = $ENV{LOGNAME};  # Some Unix (I think)
>     }
> }
>
>
> leads to $USER being uninitialized at some point (around line 3600 or
> something further below, grep for it). The tests loudly complain to the
> log but it's not fatal.

What is the USER variable used for?  If it’s not needed why set it at all?

-- 
Ricardo

Message #11 received at 41411 <at> debbugs.gnu.org (full text, mbox):

From: Nikita Gillmann <nikita <at> n0.is>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Nikita Gillmann <nikita <at> n0.is>, 41411 <at> debbugs.gnu.org
Subject: Re: [bug#41411] gnu: gnurl: Update to 7.70.0
Date: Wed, 20 May 2020 11:05:08 +0200

Ricardo Wurmus transcribed 0.6K bytes:
> 
> > runtests.pl:
> > In the environment of guix, $USER is unset.
> >
> > # get the name of the current user
> > my $USER = $ENV{USER};          # Linux
> > if (!$USER) {
> >     $USER = $ENV{USERNAME};     # Windows
> >     if (!$USER) {
> >         $USER = $ENV{LOGNAME};  # Some Unix (I think)
> >     }
> > }
> >
> >
> > leads to $USER being uninitialized at some point (around line 3600 or
> > something further below, grep for it). The tests loudly complain to the
> > log but it's not fatal.
> 
> What is the USER variable used for?  If it’s not needed why set it at all?

I did some reading in runtests.pl and then sshserver.pl. My perl knowledge
isn't that good but from what I can gather the main reason it exists is so
that sshserver.pl can check if the arguments passed to it and the env do not
result in user root starting an ssh server.
Most tests run with predefined user, and runtests.pl seems to do some
substition with $USER when it's in the environment. Since gnurl does not build
with ssh enabled I assume the ssh tests are unnecessary anyway (if they are
run at all), so a fallback to 'Anonymous' (like most tests which set this user)
should be free of unexpected side-effects.

> -- 
> Ricardo

Message #16 received at 41411-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nikita Gillmann <nikita <at> n0.is>
Cc: 41411-done <at> debbugs.gnu.org
Subject: Re: [bug#41411] gnu: gnurl: Update to 7.70.0
Date: Wed, 17 Jun 2020 12:01:13 +0200

Hi Nikita,

Nikita Gillmann <nikita <at> n0.is> skribis:

> From 2a2da39e5139a41b0a96531f9919e0225ac02ea4 Mon Sep 17 00:00:00 2001
> From: nikita <nikita <at> n0.is>
> Date: Wed, 20 May 2020 00:06:05 +0200
> Subject: [PATCH] gnu: gnurl: Update to 7.70.0.
>
> * gnu/packages/gnunet.scm (gnurl): Update to 7.70.0.

Applied, thanks!

BTW, the home page is now 404.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.