GNU bug report logs - #41459
[PATCH] gnu: Add python-flask-restx

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41459 in the body.
You can then email your comments to 41459 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Edouard Klein <edk <at> beaver-labs.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-flask-restx
Date: Fri, 22 May 2020 17:06:55 +0200

* gnu/packages/python-web.scm (python-flask-restx): New variable.
* gnu/packages/python-check.scm (python-pytest-benchmark): New variable.
* gnu/packages/python-check.scm (python-pytest-flask): New variable.
* gnu/packages/python-xyz.scm (python-py-cpuinfo): New variable.
---
 gnu/packages/python-check.scm | 49 +++++++++++++++++++++++++++++++++++
 gnu/packages/python-web.scm   | 49 +++++++++++++++++++++++++++++++++++
 gnu/packages/python-xyz.scm   | 20 ++++++++++++++
 3 files changed, 118 insertions(+)

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index 50911673b2..70db8445ee 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -362,6 +362,55 @@ framework.")
 framework.")
     (license license:expat)))
 
+(define-public python-pytest-benchmark
+  (package
+  (name "python-pytest-benchmark")
+  (version "3.2.3")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "pytest-benchmark" version))
+      (sha256
+        (base32
+          "0a4mpb4j73dsyk47hd1prrjpfk4r458s102cn80rf253jg818hxd"))))
+  (build-system python-build-system)
+  (native-inputs
+    `(("python-pathlib2" ,python-pathlib2)
+      ("python-py-cpuinfo" ,python-py-cpuinfo)
+      ("python-pytest" ,python-pytest)))
+  (home-page "https://github.com/ionelmc/pytest-benchmark")
+  (synopsis
+    "Pytest fixture for benchmarking code")
+  (description
+    "This pytest fixture will group the tests into rounds that are calibrated to
+the chosen timer.")
+  (license license:bsd-2)))
+
+(define-public python-pytest-flask
+  (package
+  (name "python-pytest-flask")
+  (version "1.0.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "pytest-flask" version))
+      (sha256
+        (base32
+          "1hln7mwgdzfi5ma0kqfsi768l7p24jhkw8l0imhifwy08nh7hmjd"))))
+  (build-system python-build-system)
+  (native-inputs
+    `(("python-flask" ,python-flask)
+      ("python-pytest" ,python-pytest)
+      ("python-setuptools-scm" ,python-setuptools-scm)
+      ("python-werkzeug" ,python-werkzeug)))
+  (home-page
+    "https://github.com/pytest-dev/pytest-flask")
+  (synopsis
+    "Pytest fixtures to test Flask applications")
+  (description
+   "This pytest plugin provides some fixtures to simplify app testing.")
+  (license license:expat)))
+
 (define-public python-codacy-coverage
   (package
     (name "python-codacy-coverage")
diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 00caf7f229..c1658052d8 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -4024,3 +4024,52 @@ request/response web apps to larger, grown applications.")
 than 326,000 known user-agents.  Users can pick a random one, or select one
 based on filters.")
     (license license:expat)))
+
+(define-public python-flask-restx
+  (package
+  (name "python-flask-restx")
+  (version "0.2.0")
+  (source
+   ;; We fetch from the Git repo because there are no tests in the PyPI
+   ;; archive.
+   (origin
+     (method git-fetch)
+     (uri (git-reference
+           (url "https://github.com/python-restx/flask-restx")
+           (commit version)))
+     (file-name (git-file-name name version))
+     (sha256
+      (base32 "0xf2vkmdngp9cv9klznizai4byxjcf0iqh1pr4b83nann0jxqwy7"))))
+  (build-system python-build-system)
+  (propagated-inputs
+   `(("python-aniso8601" ,python-aniso8601)
+     ("python-flask" ,python-flask)
+     ("python-jsonschema" ,python-jsonschema)
+     ("python-pytz" ,python-pytz)))
+  (native-inputs
+   `(("python-blinker" ,python-blinker)
+      ("python-faker" ,python-faker)
+      ("python-pytest" ,python-pytest)
+      ("python-pytest-benchmark"
+       ,python-pytest-benchmark)
+      ("python-pytest-flask" ,python-pytest-flask)
+      ("python-pytest-mock" ,python-pytest-mock)))
+  (arguments
+   `(#:phases
+     (modify-phases %standard-phases
+       (replace 'check
+         (lambda _
+           (invoke "pytest" "--benchmark-skip" "-k"
+                   ;; Those tests need internet access
+                   "not test_check and not test_valid_value_check"))))))
+  (home-page
+    "https://github.com/python-restx/flask-restx")
+  (synopsis
+    "Framework for fast, easy and documented API development with Flask")
+  (description
+    "Flask-RESTX is an extension for Flask that adds support for quickly building
+REST APIs.  Flask-RESTX encourages best practices with minimal setup.  If you are familiar
+ with Flask, Flask-RESTX should be easy to pick up.  It provides a coherent collection of
+decorators and tools to describe your API and expose its documentation properly using
+Swagger.")
+  (license license:bsd-3)))
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 1b32e7e2a8..d8552276fc 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -20076,6 +20076,26 @@ It builds upon tmux's target and formats to create an object mapping to traverse
 using multi-select lists, confirmations, free text prompts, completion, etc.")
   (license license:expat)))
 
+(define-public python-py-cpuinfo
+  (package
+  (name "python-py-cpuinfo")
+  (version "5.0.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "py-cpuinfo" version))
+      (sha256
+        (base32
+          "0045y6832gqjg63jmw0qj2jwyypgjwr7sfdq3lfv49b6fxpl5xic"))))
+  (build-system python-build-system)
+  (home-page
+    "https://github.com/workhorsy/py-cpuinfo")
+  (synopsis "Get CPU info with pure Python 2 & 3")
+  (description
+    "This module returns the CPU info by using the best sources of information for
+ your OS.")
+  (license license:expat)))
+
 (define-public python-daemux
   (package
     (name "python-daemux")
-- 
2.26.2

Message #8 received at 41459 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Edouard Klein <edk <at> beaver-labs.com>, 41459 <at> debbugs.gnu.org
Subject: Re: [bug#41459] [PATCH] gnu: Add python-flask-restx
Date: Sat, 30 May 2020 15:04:23 +0200

[Message part 1 (text/plain, inline)]

Edouard Klein <edk <at> beaver-labs.com> writes:

> * gnu/packages/python-web.scm (python-flask-restx): New variable.
> * gnu/packages/python-check.scm (python-pytest-benchmark): New variable.
> * gnu/packages/python-check.scm (python-pytest-flask): New variable.
> * gnu/packages/python-xyz.scm (python-py-cpuinfo): New variable.

Can you split this into four different patches?

Please also fix the indentation on each package.

> diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
> index 50911673b2..70db8445ee 100644
> --- a/gnu/packages/python-check.scm
> +++ b/gnu/packages/python-check.scm
> @@ -362,6 +362,55 @@ framework.")
>  framework.")
>      (license license:expat)))
>  
> +(define-public python-pytest-benchmark
> +  (package
> +  (name "python-pytest-benchmark")
> +  (version "3.2.3")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "pytest-benchmark" version))
> +      (sha256
> +        (base32
> +          "0a4mpb4j73dsyk47hd1prrjpfk4r458s102cn80rf253jg818hxd"))))
> +  (build-system python-build-system)
> +  (native-inputs
> +    `(("python-pathlib2" ,python-pathlib2)
> +      ("python-py-cpuinfo" ,python-py-cpuinfo)
> +      ("python-pytest" ,python-pytest)))

py-cpuinfo should probably be propagated according to setup.py.

> +  (home-page "https://github.com/ionelmc/pytest-benchmark")
> +  (synopsis
> +    "Pytest fixture for benchmarking code")

This line break is unnecessary.

[...]

> +(define-public python-pytest-flask
> +  (package
> +  (name "python-pytest-flask")
> +  (version "1.0.0")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "pytest-flask" version))
> +      (sha256
> +        (base32
> +          "1hln7mwgdzfi5ma0kqfsi768l7p24jhkw8l0imhifwy08nh7hmjd"))))
> +  (build-system python-build-system)
> +  (native-inputs
> +    `(("python-flask" ,python-flask)
> +      ("python-pytest" ,python-pytest)
> +      ("python-setuptools-scm" ,python-setuptools-scm)
> +      ("python-werkzeug" ,python-werkzeug)))
> +  (home-page
> +    "https://github.com/pytest-dev/pytest-flask")
> +  (synopsis
> +    "Pytest fixtures to test Flask applications")

These line breaks are unncessary.

> +(define-public python-flask-restx
> +  (package
> +  (name "python-flask-restx")
> +  (version "0.2.0")
> +  (source
> +   ;; We fetch from the Git repo because there are no tests in the PyPI
> +   ;; archive.
> +   (origin
> +     (method git-fetch)
> +     (uri (git-reference
> +           (url "https://github.com/python-restx/flask-restx")
> +           (commit version)))
> +     (file-name (git-file-name name version))
> +     (sha256
> +      (base32 "0xf2vkmdngp9cv9klznizai4byxjcf0iqh1pr4b83nann0jxqwy7"))))
> +  (build-system python-build-system)
> +  (propagated-inputs
> +   `(("python-aniso8601" ,python-aniso8601)
> +     ("python-flask" ,python-flask)
> +     ("python-jsonschema" ,python-jsonschema)
> +     ("python-pytz" ,python-pytz)))
> +  (native-inputs
> +   `(("python-blinker" ,python-blinker)
> +      ("python-faker" ,python-faker)
> +      ("python-pytest" ,python-pytest)
> +      ("python-pytest-benchmark"
> +       ,python-pytest-benchmark)
> +      ("python-pytest-flask" ,python-pytest-flask)
> +      ("python-pytest-mock" ,python-pytest-mock)))
> +  (arguments
> +   `(#:phases
> +     (modify-phases %standard-phases
> +       (replace 'check
> +         (lambda _
> +           (invoke "pytest" "--benchmark-skip" "-k"
> +                   ;; Those tests need internet access
> +                   "not test_check and not test_valid_value_check"))))))
> +  (home-page
> +    "https://github.com/python-restx/flask-restx")

This line break is unnecessary.

> +(define-public python-py-cpuinfo
> +  (package
> +  (name "python-py-cpuinfo")
> +  (version "5.0.0")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "py-cpuinfo" version))
> +      (sha256
> +        (base32
> +          "0045y6832gqjg63jmw0qj2jwyypgjwr7sfdq3lfv49b6fxpl5xic"))))
> +  (build-system python-build-system)
> +  (home-page
> +    "https://github.com/workhorsy/py-cpuinfo")

This line break is unnecessary.

> +  (synopsis "Get CPU info with pure Python 2 & 3")

Maybe just "Get CPU info with Python"

> +  (description
> +    "This module returns the CPU info by using the best sources of information for
> + your OS.")

s/OS/operating system/

Can you send updated patches?  Please also make sure they are in the
correct order, i.e. this last package must come before
'python-pytest-benchmark'.

Thanks in advance!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 41459 <at> debbugs.gnu.org (full text, mbox):

From: Edouard Klein <edk <at> beaver-labs.com>
To: 41459 <at> debbugs.gnu.org
Subject: [PATCH 1/4] gnu: Add python-py-cpuinfo
Date: Tue, 02 Jun 2020 11:41:11 +0200

* gnu/packages/python-xyz.scm (python-py-cpuinfo): New variable.
---
 gnu/packages/python-xyz.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 6aa666430a..5cd3abd956 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -19458,6 +19458,25 @@ using “=” characters.  However this conveys no benefit so many protocols
 choose to use Base64 without the “=” padding.")
     (license license:asl2.0)))
 
+(define-public python-py-cpuinfo
+  (package
+    (name "python-py-cpuinfo")
+    (version "5.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "py-cpuinfo" version))
+       (sha256
+        (base32
+         "0045y6832gqjg63jmw0qj2jwyypgjwr7sfdq3lfv49b6fxpl5xic"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/workhorsy/py-cpuinfo")
+    (synopsis "Get CPU info with Python")
+    (description
+     "This module returns the CPU info by using the best sources of information for
+ your Operating System.")
+    (license license:expat)))
+
 (define-public python-canonicaljson
   (package
     (name "python-canonicaljson")
-- 
2.26.2

Message #14 received at 41459 <at> debbugs.gnu.org (full text, mbox):

From: Edouard Klein <edk <at> beaver-labs.com>
To: 41459 <at> debbugs.gnu.org
Subject: [PATCH 2/4] gnu: Add python-pytest-benchmark
Date: Tue, 02 Jun 2020 11:44:08 +0200

* gnu/packages/python-check.scm (python-pytest-benchmark): New variable.
---
 gnu/packages/python-check.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index 1071abdbad..b13b750bbd 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -360,6 +360,30 @@ framework.")
 for the @code{pytest} framework.")
     (license license:expat)))
 
+(define-public python-pytest-benchmark
+  (package
+    (name "python-pytest-benchmark")
+    (version "3.2.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pytest-benchmark" version))
+       (sha256
+        (base32
+         "0a4mpb4j73dsyk47hd1prrjpfk4r458s102cn80rf253jg818hxd"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-py-cpuinfo" ,python-py-cpuinfo)))
+    (native-inputs
+     `(("python-pathlib2" ,python-pathlib2)
+       ("python-pytest" ,python-pytest)))
+    (home-page "https://github.com/ionelmc/pytest-benchmark")
+    (synopsis "Pytest fixture for benchmarking code")
+    (description
+     "This pytest fixture will group the tests into rounds that are calibrated to
+the chosen timer.")
+    (license license:bsd-2)))
+
 (define-public python-codacy-coverage
   (package
     (name "python-codacy-coverage")
-- 
2.26.2

Date: Tue, 02 Jun 2020 11:44:08 +0200
Message-ID: <87k10pdcpj.fsf <at> alice.lan>

Message #17 received at 41459 <at> debbugs.gnu.org (full text, mbox):

From: Edouard Klein <edk <at> beaver-labs.com>
To: 41459 <at> debbugs.gnu.org
Date: Tue, 02 Jun 2020 11:44:56 +0200

Subject: [PATCH 3/4] gnu: Add python-pytest-flask
* gnu/packages/python-check.scm (python-pytest-flask): New variable.
---
 gnu/packages/python-check.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index b13b750bbd..d7bed91a04 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -384,6 +384,30 @@ for the @code{pytest} framework.")
 the chosen timer.")
     (license license:bsd-2)))
 
+(define-public python-pytest-flask
+  (package
+    (name "python-pytest-flask")
+    (version "1.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pytest-flask" version))
+       (sha256
+        (base32
+         "1hln7mwgdzfi5ma0kqfsi768l7p24jhkw8l0imhifwy08nh7hmjd"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-flask" ,python-flask)
+       ("python-pytest" ,python-pytest)
+       ("python-setuptools-scm" ,python-setuptools-scm)
+       ("python-werkzeug" ,python-werkzeug)))
+    (home-page
+     "https://github.com/pytest-dev/pytest-flask")
+    (synopsis "Pytest fixtures to test Flask applications")
+    (description
+     "This pytest plugin provides some fixtures to simplify app testing.")
+    (license license:expat)))
+
 (define-public python-codacy-coverage
   (package
     (name "python-codacy-coverage")
-- 
2.26.2

Date: Tue, 02 Jun 2020 11:44:56 +0200
Message-ID: <87h7vtdco7.fsf <at> alice.lan>

Message #20 received at 41459 <at> debbugs.gnu.org (full text, mbox):

From: Edouard Klein <edk <at> beaver-labs.com>
To: 41459 <at> debbugs.gnu.org
Date: Tue, 02 Jun 2020 11:45:18 +0200

Subject: [PATCH 4/4] gnu: Add python-flask-restx
From 38a64901c9dcf53b4b32dd83bd6b50c4e4ea4d52 Mon Sep 17 00:00:00 2001
* gnu/packages/python-web.scm (python-flask-restx): New variable.
---
 gnu/packages/python-web.scm | 48 +++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 61d21418d4..f8c61b8a53 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -4024,3 +4024,51 @@ request/response web apps to larger, grown applications.")
 than 326,000 known user-agents.  Users can pick a random one, or select one
 based on filters.")
     (license license:expat)))
+
+(define-public python-flask-restx
+  (package
+    (name "python-flask-restx")
+    (version "0.2.0")
+    (source
+     ;; We fetch from the Git repo because there are no tests in the PyPI
+     ;; archive.
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/python-restx/flask-restx")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0xf2vkmdngp9cv9klznizai4byxjcf0iqh1pr4b83nann0jxqwy7"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-aniso8601" ,python-aniso8601)
+       ("python-flask" ,python-flask)
+       ("python-jsonschema" ,python-jsonschema)
+       ("python-pytz" ,python-pytz)))
+    (native-inputs
+     `(("python-blinker" ,python-blinker)
+       ("python-faker" ,python-faker)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-benchmark"
+        ,python-pytest-benchmark)
+       ("python-pytest-flask" ,python-pytest-flask)
+       ("python-pytest-mock" ,python-pytest-mock)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "pytest" "--benchmark-skip" "-k"
+                     ;; Those tests need internet access
+                     "not test_check and not test_valid_value_check"))))))
+    (home-page "https://github.com/python-restx/flask-restx")
+    (synopsis
+     "Framework for fast, easy and documented API development with Flask")
+    (description
+     "Flask-RESTX is an extension for Flask that adds support for quickly building
+REST APIs.  Flask-RESTX encourages best practices with minimal setup.  If you are familiar
+ with Flask, Flask-RESTX should be easy to pick up.  It provides a coherent collection of
+decorators and tools to describe your API and expose its documentation properly using
+Swagger.")
+    (license license:bsd-3)))
-- 
2.26.2

Date: Tue, 02 Jun 2020 11:45:18 +0200
Message-ID: <87eeqxdcnl.fsf <at> alice.lan>

Message #23 received at 41459 <at> debbugs.gnu.org (full text, mbox):

From: Edouard Klein <edou <at> rdklein.fr>
To: 41459 <at> debbugs.gnu.org
Subject: Re: [bug#41459] [PATCH] gnu: Add python-flask-restx
Date: Tue, 02 Jun 2020 12:06:11 +0200

Hi,

Thank you for reviewing the commits.

For the indentation, I highlighted the changes in emacs and M-x
indent-region, but it did not change anything. Is something wrong with
my emacs config ?

Cheers,

Edouard

Marius Bakke writes:

> Edouard Klein <edk <at> beaver-labs.com> writes:
>
>> * gnu/packages/python-web.scm (python-flask-restx): New variable.
>> * gnu/packages/python-check.scm (python-pytest-benchmark): New variable.
>> * gnu/packages/python-check.scm (python-pytest-flask): New variable.
>> * gnu/packages/python-xyz.scm (python-py-cpuinfo): New variable.
>
> Can you split this into four different patches?
>
> Please also fix the indentation on each package.
>
>> diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
>> index 50911673b2..70db8445ee 100644
>> --- a/gnu/packages/python-check.scm
>> +++ b/gnu/packages/python-check.scm
>> @@ -362,6 +362,55 @@ framework.")
>>  framework.")
>>      (license license:expat)))
>>  
>> +(define-public python-pytest-benchmark
>> +  (package
>> +  (name "python-pytest-benchmark")
>> +  (version "3.2.3")
>> +  (source
>> +    (origin
>> +      (method url-fetch)
>> +      (uri (pypi-uri "pytest-benchmark" version))
>> +      (sha256
>> +        (base32
>> +          "0a4mpb4j73dsyk47hd1prrjpfk4r458s102cn80rf253jg818hxd"))))
>> +  (build-system python-build-system)
>> +  (native-inputs
>> +    `(("python-pathlib2" ,python-pathlib2)
>> +      ("python-py-cpuinfo" ,python-py-cpuinfo)
>> +      ("python-pytest" ,python-pytest)))
>
> py-cpuinfo should probably be propagated according to setup.py.
>
>> +  (home-page "https://github.com/ionelmc/pytest-benchmark")
>> +  (synopsis
>> +    "Pytest fixture for benchmarking code")
>
> This line break is unnecessary.
>
> [...]
>
>> +(define-public python-pytest-flask
>> +  (package
>> +  (name "python-pytest-flask")
>> +  (version "1.0.0")
>> +  (source
>> +    (origin
>> +      (method url-fetch)
>> +      (uri (pypi-uri "pytest-flask" version))
>> +      (sha256
>> +        (base32
>> +          "1hln7mwgdzfi5ma0kqfsi768l7p24jhkw8l0imhifwy08nh7hmjd"))))
>> +  (build-system python-build-system)
>> +  (native-inputs
>> +    `(("python-flask" ,python-flask)
>> +      ("python-pytest" ,python-pytest)
>> +      ("python-setuptools-scm" ,python-setuptools-scm)
>> +      ("python-werkzeug" ,python-werkzeug)))
>> +  (home-page
>> +    "https://github.com/pytest-dev/pytest-flask")
>> +  (synopsis
>> +    "Pytest fixtures to test Flask applications")
>
> These line breaks are unncessary.
>
>> +(define-public python-flask-restx
>> +  (package
>> +  (name "python-flask-restx")
>> +  (version "0.2.0")
>> +  (source
>> +   ;; We fetch from the Git repo because there are no tests in the PyPI
>> +   ;; archive.
>> +   (origin
>> +     (method git-fetch)
>> +     (uri (git-reference
>> +           (url "https://github.com/python-restx/flask-restx")
>> +           (commit version)))
>> +     (file-name (git-file-name name version))
>> +     (sha256
>> +      (base32 "0xf2vkmdngp9cv9klznizai4byxjcf0iqh1pr4b83nann0jxqwy7"))))
>> +  (build-system python-build-system)
>> +  (propagated-inputs
>> +   `(("python-aniso8601" ,python-aniso8601)
>> +     ("python-flask" ,python-flask)
>> +     ("python-jsonschema" ,python-jsonschema)
>> +     ("python-pytz" ,python-pytz)))
>> +  (native-inputs
>> +   `(("python-blinker" ,python-blinker)
>> +      ("python-faker" ,python-faker)
>> +      ("python-pytest" ,python-pytest)
>> +      ("python-pytest-benchmark"
>> +       ,python-pytest-benchmark)
>> +      ("python-pytest-flask" ,python-pytest-flask)
>> +      ("python-pytest-mock" ,python-pytest-mock)))
>> +  (arguments
>> +   `(#:phases
>> +     (modify-phases %standard-phases
>> +       (replace 'check
>> +         (lambda _
>> +           (invoke "pytest" "--benchmark-skip" "-k"
>> +                   ;; Those tests need internet access
>> +                   "not test_check and not test_valid_value_check"))))))
>> +  (home-page
>> +    "https://github.com/python-restx/flask-restx")
>
> This line break is unnecessary.
>
>> +(define-public python-py-cpuinfo
>> +  (package
>> +  (name "python-py-cpuinfo")
>> +  (version "5.0.0")
>> +  (source
>> +    (origin
>> +      (method url-fetch)
>> +      (uri (pypi-uri "py-cpuinfo" version))
>> +      (sha256
>> +        (base32
>> +          "0045y6832gqjg63jmw0qj2jwyypgjwr7sfdq3lfv49b6fxpl5xic"))))
>> +  (build-system python-build-system)
>> +  (home-page
>> +    "https://github.com/workhorsy/py-cpuinfo")
>
> This line break is unnecessary.
>
>> +  (synopsis "Get CPU info with pure Python 2 & 3")
>
> Maybe just "Get CPU info with Python"
>
>> +  (description
>> +    "This module returns the CPU info by using the best sources of information for
>> + your OS.")
>
> s/OS/operating system/
>
> Can you send updated patches?  Please also make sure they are in the
> correct order, i.e. this last package must come before
> 'python-pytest-benchmark'.
>
> Thanks in advance!

Message #26 received at 41459 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Edouard Klein <edk <at> beaver-labs.com>, 41459 <at> debbugs.gnu.org
Subject: Re: [bug#41459] [PATCH 1/4] gnu: Add python-py-cpuinfo
Date: Mon, 22 Jun 2020 21:33:43 +0200

[Message part 1 (text/plain, inline)]

Edouard Klein <edk <at> beaver-labs.com> writes:

> * gnu/packages/python-xyz.scm (python-py-cpuinfo): New variable.

Applied with a minor tweak to the description.

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 41459 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Edouard Klein <edk <at> beaver-labs.com>, 41459 <at> debbugs.gnu.org
Subject: Re: [bug#41459] [PATCH 2/4] gnu: Add python-pytest-benchmark
Date: Mon, 22 Jun 2020 21:36:18 +0200

[Message part 1 (text/plain, inline)]

Edouard Klein <edk <at> beaver-labs.com> writes:

> * gnu/packages/python-check.scm (python-pytest-benchmark): New variable.

Applied with this minor change:

     (description
-     "This pytest fixture will group the tests into rounds that are calibrated to
-the chosen timer.")
+     "This package provides a pytest fixture that will group the tests into
+rounds that are calibrated to the chosen timer.")

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 41459 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Edouard Klein <edk <at> beaver-labs.com>, 41459 <at> debbugs.gnu.org
Subject: Re: [bug#41459] (no subject)
Date: Mon, 22 Jun 2020 21:39:42 +0200

[Message part 1 (text/plain, inline)]

Edouard Klein <edk <at> beaver-labs.com> writes:

> Subject: [PATCH 3/4] gnu: Add python-pytest-flask
> * gnu/packages/python-check.scm (python-pytest-flask): New variable.

Applied with a minor tweak to the description.

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 41459-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Edouard Klein <edk <at> beaver-labs.com>, 41459-done <at> debbugs.gnu.org
Subject: Re: [bug#41459] (no subject)
Date: Mon, 22 Jun 2020 21:43:01 +0200

[Message part 1 (text/plain, inline)]

Edouard Klein <edk <at> beaver-labs.com> writes:

> Subject: [PATCH 4/4] gnu: Add python-flask-restx
>>From 38a64901c9dcf53b4b32dd83bd6b50c4e4ea4d52 Mon Sep 17 00:00:00 2001
> * gnu/packages/python-web.scm (python-flask-restx): New variable.

Applied, thanks!

I added punctuation in the commit message for all four patches.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.