GNU bug report logs - #41461
[PATCH 0/3] Update go-github-com-stretchr-testify

Previous Next

Package: guix-patches;

Reported by: Jakub Kądziołka <kuba <at> kadziolka.net>

Date: Fri, 22 May 2020 16:06:02 UTC

Severity: normal

Tags: patch

Done: Jakub Kądziołka <kuba <at> kadziolka.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41461 in the body.
You can then email your comments to 41461 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#41461; Package guix-patches. (Fri, 22 May 2020 16:06:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jakub Kądziołka <kuba <at> kadziolka.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 22 May 2020 16:06:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] Update go-github-com-stretchr-testify
Date: Fri, 22 May 2020 18:04:49 +0200
While debugging a test failure of a package I was adding, I have guessed
that the old version of testify is to blame. I was wrong, but since it
takes a bit more than a version bump, perhaps we should upgrade it
anyway?

I have tested building all dependent packages and haven't encountered
any issues.

Jakub Kądziołka (3):
  gnu: Add go-github-com-stretchr-objx.
  gnu: go-github-com-davecgh-go-spew: Update to 1.1.1.
  gnu: go-github-com-stretchr-testify: Update to 1.5.1.

 gnu/packages/golang.scm | 114 ++++++++++++++++++++++++----------------
 1 file changed, 68 insertions(+), 46 deletions(-)

-- 
2.26.2





Information forwarded to guix-patches <at> gnu.org:
bug#41461; Package guix-patches. (Fri, 22 May 2020 16:17:02 GMT) Full text and rfc822 format available.

Message #8 received at 41461 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: 41461 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: go-github-com-stretchr-testify: Update to 1.5.1.
Date: Fri, 22 May 2020 18:16:15 +0200
* gnu/packages/golang.scm (go-github-com-stretchr-testify):
  Update to 1.5.1.
---
 gnu/packages/golang.scm | 48 +++++++++++++++++++++--------------------
 1 file changed, 25 insertions(+), 23 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index f3b121a69b..cfab23608d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -940,28 +940,30 @@ Go.")
     (license license:expat)))
 
 (define-public go-github-com-stretchr-testify
-  (let ((commit
-          "b1f989447a57594c728884458a39abf3a73447f7")
-        (revision "0"))
-    (package
-      (name "go-github-com-stretchr-testify")
-      (version (git-version "1.1.4" revision commit))
-      (source
-        (origin
-          (method git-fetch)
-          (uri (git-reference
-                 (url "https://github.com/stretchr/testify.git")
-                 (commit commit)))
-          (file-name (git-file-name name version))
-          (sha256
-            (base32
-              "0p0gkqzh2p8r5g0rxm885ljl7ghih7h7hx9w562imx5ka0vdgixv"))))
-      (build-system go-build-system)
-      (arguments
-        '(#:import-path "github.com/stretchr/testify"))
-      (home-page "https://github.com/stretchr/testify")
-      (synopsis "Go helper library for tests and invariant checking")
-      (description "This package provide many tools for testifying that your
+  (package
+    (name "go-github-com-stretchr-testify")
+    (version "1.5.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/stretchr/testify.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "09r89m1wy4cjv2nps1ykp00qjpi0531r07q3s34hr7m6njk4srkl"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/stretchr/testify"))
+    (propagated-inputs
+     `(("github.com/davecgh/go-spew" ,go-github-com-davecgh-go-spew)
+       ("github.com/pmezard/go-difflib" ,go-github-com-pmezard-go-difflib)
+       ("github.com/stretchr/objx" ,go-github-com-stretchr-objx)
+       ("gopkg.in/yaml.v2" ,go-gopkg-in-yaml-v2)))
+    (home-page "https://github.com/stretchr/testify")
+    (synopsis "Go helper library for tests and invariant checking")
+    (description "This package provide many tools for testifying that your
 code will behave as you intend.
 
 Features include:
@@ -971,7 +973,7 @@ Features include:
 @item HTTP response trapping
 @item Testing suite interfaces and functions.
 @end itemize")
-      (license license:expat))))
+    (license license:expat)))
 
 (define-public go-github-com-tevino-abool
   (let ((commit
-- 
2.26.2





Information forwarded to guix-patches <at> gnu.org:
bug#41461; Package guix-patches. (Fri, 22 May 2020 16:17:02 GMT) Full text and rfc822 format available.

Message #11 received at 41461 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: 41461 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: go-github-com-davecgh-go-spew: Update to 1.1.1.
Date: Fri, 22 May 2020 18:16:14 +0200
* gnu/packages/golang.scm (go-github-com-davecgh-go-spew):
  Update to 1.1.1.
---
 gnu/packages/golang.scm | 44 ++++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 23 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index ccd43cc104..f3b121a69b 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1930,28 +1930,26 @@ that's a lot faster (and only does simple bandwidth metrics).")
       (license license:expat))))
 
 (define-public go-github-com-davecgh-go-spew
-  (let ((commit "d8f796af33cc11cb798c1aaeb27a4ebc5099927d")
-        (revision "0"))
-    (package
-      (name "go-github-com-davecgh-go-spew")
-      (version (git-version "0.0.0" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/davecgh/go-spew.git")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32
-           "19z27f306fpsrjdvkzd61w1bdazcdbczjyjck177g33iklinhpvx"))))
-      (build-system go-build-system)
-      (arguments
-       '(#:unpack-path "github.com/davecgh/go-spew"
-         #:import-path "github.com/davecgh/go-spew/spew"))
-      (home-page "https://github.com/davecgh/go-spew")
-      (synopsis "Deep pretty printer for Go data structures to aid in debugging")
-      (description "Package @command{spew} implements a deep pretty printer
+  (package
+    (name "go-github-com-davecgh-go-spew")
+    (version "1.1.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/davecgh/go-spew.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0hka6hmyvp701adzag2g26cxdj47g21x6jz4sc6jjz1mn59d474y"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:unpack-path "github.com/davecgh/go-spew"
+       #:import-path "github.com/davecgh/go-spew/spew"))
+    (home-page "https://github.com/davecgh/go-spew")
+    (synopsis "Deep pretty printer for Go data structures to aid in debugging")
+    (description "Package @command{spew} implements a deep pretty printer
 for Go data structures to aid in debugging.
 
 A quick overview of the additional features spew provides over the built-in printing facilities for Go data types are as follows:
@@ -1967,7 +1965,7 @@ pointer receiver are optionally invoked when passing non-pointer variables.
 includes offsets, byte values in hex, and ASCII output (only when using Dump
 style).
 @end itemize\n")
-      (license license:isc))))
+    (license license:isc)))
 
 (define-public go-github-com-btcsuite-btclog
   (let ((commit "84c8d2346e9fc8c7b947e243b9c24e6df9fd206a")
-- 
2.26.2





Information forwarded to guix-patches <at> gnu.org:
bug#41461; Package guix-patches. (Fri, 22 May 2020 16:17:03 GMT) Full text and rfc822 format available.

Message #14 received at 41461 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: 41461 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: Add go-github-com-stretchr-objx.
Date: Fri, 22 May 2020 18:16:13 +0200
* gnu/packages/golang.scm (go-github-com-stretchr-objx): New variable.
---
 gnu/packages/golang.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 69f46df743..ccd43cc104 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -917,6 +917,28 @@ increment versions.")
 Go.")
       (license license:expat))))
 
+(define-public go-github-com-stretchr-objx
+  (package
+    (name "go-github-com-stretchr-objx")
+    (version "0.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/stretchr/objx.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0pcdvakxgddaiwcdj73ra4da05a3q4cgwbpm2w75ycq4kzv8ij8k"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/stretchr/objx"))
+    (home-page "https://github.com/stretchr/objx")
+    (synopsis "Go package for dealing with maps, slices, JSON and other data")
+    (description "Go package for dealing with maps, slices, JSON and other data")
+    (license license:expat)))
+
 (define-public go-github-com-stretchr-testify
   (let ((commit
           "b1f989447a57594c728884458a39abf3a73447f7")
-- 
2.26.2





Information forwarded to guix-patches <at> gnu.org:
bug#41461; Package guix-patches. (Wed, 03 Jun 2020 15:54:01 GMT) Full text and rfc822 format available.

Message #17 received at 41461 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 41461 <at> debbugs.gnu.org
Subject: Re: [bug#41461] [PATCH 1/3] gnu: Add go-github-com-stretchr-objx.
Date: Wed, 03 Jun 2020 17:53:49 +0200
Hello,

Jakub Kądziołka <kuba <at> kadziolka.net> skribis:

> * gnu/packages/golang.scm (go-github-com-stretchr-objx): New variable.

[...]

> +    (synopsis "Go package for dealing with maps, slices, JSON and other data")
> +    (description "Go package for dealing with maps, slices, JSON and other data")

Please write a full sentence (or two :-)) for the description (info
"(guix) Synopses and Descriptions").

Otherwise the three patches LGTM!

Ludo’.




Reply sent to Jakub Kądziołka <kuba <at> kadziolka.net>:
You have taken responsibility. (Sun, 07 Jun 2020 19:56:02 GMT) Full text and rfc822 format available.

Notification sent to Jakub Kądziołka <kuba <at> kadziolka.net>:
bug acknowledged by developer. (Sun, 07 Jun 2020 19:56:02 GMT) Full text and rfc822 format available.

Message #22 received at 41461-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41461-done <at> debbugs.gnu.org
Subject: Re: [bug#41461] [PATCH 1/3] gnu: Add go-github-com-stretchr-objx.
Date: Sun, 7 Jun 2020 21:55:27 +0200
[Message part 1 (text/plain, inline)]
On Wed, Jun 03, 2020 at 05:53:49PM +0200, Ludovic Courtès wrote:
> Hello,
> 
> Jakub Kądziołka <kuba <at> kadziolka.net> skribis:
> 
> > * gnu/packages/golang.scm (go-github-com-stretchr-objx): New variable.
> 
> [...]
> 
> > +    (synopsis "Go package for dealing with maps, slices, JSON and other data")
> > +    (description "Go package for dealing with maps, slices, JSON and other data")
> 
> Please write a full sentence (or two :-)) for the description (info
> "(guix) Synopses and Descriptions").
> 
> Otherwise the three patches LGTM!

Thanks for your review! I wrote a fuller description and pushed the
patches.

Regards,
Jakub Kądziołka
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 06 Jul 2020 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 266 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.