GNU bug report logs - #41510
[PATCH] guix: print: Update deprecated method

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41510 in the body.
You can then email your comments to 41510 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] guix: print: Update deprecated method
Date: Sun, 24 May 2020 16:41:30 +0000

Hi,

This patch corrects the following warning:

guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, use 'origin-hash' instead


Best,
Ekaitz




From ac21251092570bd426505f98d4415781e7c66147 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Date: Sun, 24 May 2020 18:36:59 +0200
Subject: [PATCH] guix: print: Update deprecated method

    * guix/import/print.scm (source->code): Replace origin-sha256 with
    origin-hash
---
 guix/import/print.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/import/print.scm b/guix/import/print.scm
index 11cc218285..afbb680607 100644
--- a/guix/import/print.scm
+++ b/guix/import/print.scm
@@ -74,7 +74,7 @@ when evaluated."
   (define (source->code source version)
     (let ((uri       (origin-uri source))
           (method    (origin-method source))
-          (sha256    (origin-sha256 source))
+          (sha256    (origin-hash source))
           (file-name (origin-file-name source))
           (patches   (origin-patches source)))
       `(origin
--
2.26.2

Message #8 received at 41510 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 41510 <at> debbugs.gnu.org
Subject: Re: [bug#41510] [PATCH] guix: print: Update deprecated method
Date: Sat, 30 May 2020 16:17:56 +0200

Hi,

Ekaitz Zarraga <ekaitz <at> elenq.tech> skribis:

> guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, use 'origin-hash' instead

[...]

> -          (sha256    (origin-sha256 source))
> +          (sha256    (origin-hash source))

This is quite correct (contrary to what the warning suggests).  You also
have to use ‘content-hash-value’.  The code also needs to check whether
it’s actually sha256 or some other algorithm.

Make sure to run:

  make check TESTS=tests/print.scm

afterwards!

Thanks,
Ludo’.

Message #11 received at 41510 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: "41510 <at> debbugs.gnu.org" <41510 <at> debbugs.gnu.org>
Subject: Re: [bug#41510] [PATCH] guix: print: Update deprecated method
Date: Sat, 30 May 2020 14:20:30 +0000

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, May 30, 2020 4:17 PM, Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi,
>
> Ekaitz Zarraga ekaitz <at> elenq.tech skribis:
>
> > guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, use 'origin-hash' instead
>
> [...]
>
> > -            (sha256    (origin-sha256 source))
> >
> >
> >
> > -            (sha256    (origin-hash source))
> >
> >
>
> This is quite correct (contrary to what the warning suggests). You also
> have to use ‘content-hash-value’. The code also needs to check whether
> it’s actually sha256 or some other algorithm.
>
> Make sure to run:
>
> make check TESTS=tests/print.scm
>
> afterwards!
>
> Thanks,
> Ludo’.

LOL

Time to fix the warning then? ;)

Message #16 received at 41510-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 41510-done <at> debbugs.gnu.org
Subject: Re: [bug#41510] [PATCH] guix: print: Update deprecated method
Date: Mon, 07 Dec 2020 12:40:29 +0100

Hi,

Ekaitz Zarraga <ekaitz <at> elenq.tech> skribis:

> This patch corrects the following warning:
>
> guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, use 'origin-hash' instead

This was fixed in a9105c2c4c97ffbdb1b09dadc14773566924ab59.

Closing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.