GNU bug report logs - #41524
26.3; Request for 'x' for 'execute' in dired menu

Previous Next

Package: emacs;

Reported by: jan <rtm443x <at> googlemail.com>

Date: Mon, 25 May 2020 11:23:01 UTC

Severity: wishlist

Tags: patch

Found in version 26.3

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41524 in the body.
You can then email your comments to 41524 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#41524; Package emacs. (Mon, 25 May 2020 11:23:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to jan <rtm443x <at> googlemail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 25 May 2020 11:23:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jan <rtm443x <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.3; Request for 'x' for 'execute' in dired menu
Date: Mon, 25 May 2020 12:22:32 +0100
Hi all,
I was using dired recently after a very long break from it.

I marked some files for deletion, wasn't sure how to actually trigger
the delete, had a suspicion it was 'x' but checked the menu anyway (I
often use the menu merely as a handy cheat-sheet for the keyboard
commands). It appears not to be there.

If it is actually missing I request it be added as it makes no sense for
beginners, who may actually use the menu with the mouse, to be able to
variously mark stuff but then lack a way of carrying them out.

thanks

jan



In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
 of 2019-08-29 built on CIRROCUMULUS
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Recent messages:
Contacting host: en.wikipedia.org:443
Mark set
C-x C-g is undefined
Contacting host: en.wikipedia.org:443
Mark set
scroll-down-command: Beginning of buffer [121 times]
scroll-up-command: End of buffer [21 times]
scroll-down-command: Beginning of buffer [4 times]
Contacting host: en.wikipedia.org:443
Making completion list...

Configured using:
 'configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS THREADS LCMS2

Important settings:
  value of $LANG: ENG
  locale-coding-system: cp1252

Major mode: Lisp Interaction

Minor modes in effect:
  desktop-save-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired dired-loaddefs rfc822 mml
mml-sec epa derived epg mm-decode mm-bodies mm-encode mailabbrev
gmm-utils mailheader sendmail parse-time lao-util thai-util thai-word
shr-color color cl-extra help-mode network-stream starttls url-http tls
gnutls mail-parse rfc2231 url-gw nsm rmc url-cache url-auth eww puny
mm-url gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045
ietf-drums mail-utils wid-edit mm-util mail-prsvr url-queue url
url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util mailcap shr svg xml dom browse-url elec-pair
helm-gtags subr-x pulse which-func imenu helm-files helm-buffers
helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec
helm-utils helm-help helm-types helm easy-mmode helm-source eieio-compat
helm-multi-match helm-lib async edmacro kmacro desktop frameset
cus-start cus-load finder-inf info package easymenu epg-config
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib time-date mule-util tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32
ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core term/tty-colors frame cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads w32notify w32
lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 352911 239249)
 (symbols 48 29182 42)
 (miscs 40 52 278)
 (strings 32 69289 14969)
 (string-bytes 1 2747170)
 (vectors 16 28306)
 (vector-slots 8 726417 94096)
 (floats 8 275 772)
 (intervals 56 12156 6748)
 (buffers 992 15))




Severity set to 'wishlist' from 'normal' Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 25 May 2020 14:40:01 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#41524; Package emacs. (Mon, 25 May 2020 15:08:02 GMT) Full text and rfc822 format available.

Message #10 received at 41524 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: jan <rtm443x <at> googlemail.com>, 41524 <at> debbugs.gnu.org
Subject: RE: bug#41524: 26.3; Request for 'x' for 'execute' in dired menu
Date: Mon, 25 May 2020 08:05:25 -0700 (PDT)
> I was using dired recently after a very long break from it.
> 
> I marked some files for deletion, wasn't sure how to actually trigger
> the delete, had a suspicion it was 'x' but checked the menu anyway (I
> often use the menu merely as a handy cheat-sheet for the keyboard
> commands). It appears not to be there.
> 
> If it is actually missing I request it be added as it makes no sense
> for
> beginners, who may actually use the menu with the mouse, to be able to
> variously mark stuff but then lack a way of carrying them out.

Yes, `x' is not in a menu-bar menu.  It should be.

If you use Dired+, it is.  There, you have submenu
`Delete', with menu items `Delete Marked (not Flagged)'
and `Delete Flagged'.  The former has key `D', and the
latter has key `x'.

(In Dired+, menu-bar menu `Operate' is named `Multiple',
so submenu `Delete' is `Multiple > Delete', not `Operate
> Delete'.)




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#41524; Package emacs. (Mon, 24 Aug 2020 00:27:01 GMT) Full text and rfc822 format available.

Message #13 received at 41524 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: jan <rtm443x <at> googlemail.com>, 41524 <at> debbugs.gnu.org
Subject: Re: bug#41524: 26.3; Request for 'x' for 'execute' in dired menu
Date: Sun, 23 Aug 2020 20:26:33 -0400
[Message part 1 (text/plain, inline)]
tags 41524 + patch
thanks

Drew Adams <drew.adams <at> oracle.com> writes:

>> I was using dired recently after a very long break from it.
>>
>> I marked some files for deletion, wasn't sure how to actually trigger
>> the delete, had a suspicion it was 'x' but checked the menu anyway (I
>> often use the menu merely as a handy cheat-sheet for the keyboard
>> commands). It appears not to be there.
>>
>> If it is actually missing I request it be added as it makes no sense
>> for
>> beginners, who may actually use the menu with the mouse, to be able to
>> variously mark stuff but then lack a way of carrying them out.
>
> Yes, `x' is not in a menu-bar menu.  It should be.
>
> If you use Dired+, it is.  There, you have submenu
> `Delete', with menu items `Delete Marked (not Flagged)'
> and `Delete Flagged'.  The former has key `D', and the
> latter has key `x'.
>
> (In Dired+, menu-bar menu `Operate' is named `Multiple',
> so submenu `Delete' is `Multiple > Delete', not `Operate
>> Delete'.)

How does the attached patch look?

(I had a look at Dired+ and lifted some help strings from there.
Thanks Drew.)

Best regards,
Stefan Kangas
[0001-Add-Delete-submenu-to-Dired-Mark-menu.patch (text/x-diff, attachment)]

Added tag(s) patch. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Mon, 24 Aug 2020 00:27:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#41524; Package emacs. (Mon, 24 Aug 2020 15:10:01 GMT) Full text and rfc822 format available.

Message #18 received at 41524 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: jan <rtm443x <at> googlemail.com>, 41524 <at> debbugs.gnu.org
Subject: RE: bug#41524: 26.3; Request for 'x' for 'execute' in dired menu
Date: Mon, 24 Aug 2020 08:09:04 -0700 (PDT)
> > Yes, `x' is not in a menu-bar menu.  It should be.
> >
> > If you use Dired+, it is.  There, you have submenu
> > `Delete', with menu items `Delete Marked (not Flagged)'
> > and `Delete Flagged'.  The former has key `D', and the
> > latter has key `x'.
> >
> > (In Dired+, menu-bar menu `Operate' is named `Multiple',
> > so submenu `Delete' is `Multiple > Delete', not `Operate
> >> Delete'.)
> 
> How does the attached patch look?
> 
> (I had a look at Dired+ and lifted some help strings from there.
> Thanks Drew.)

Thanks for looking into this.

I don't think this belongs on menu `Mark', however.

It belongs on menu `Operate', as it operates on the
(typically) multiple files that are marked (or flagged).

Menu `Mark' is for marking files, not for acting on
marked files.

IMO, it would not be good to start mixing up marking
with acting on marked files, on the same menu.  That
would set a bad precedent.  Once things get set in
an Emacs menu, it seems to take a major earthquake
to later change them, so it's better to try to keep
things clear from the outset.

[When I said in my previous post, that Dired+
has a `Delete' submenu, I should have mentioned
that it is on menu `Multiple' (which corresponds
to vanilla menu `Operate'), not on menu `Marks'
(which corresponds to vanilla menu `Mark'.]




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#41524; Package emacs. (Mon, 24 Aug 2020 15:51:02 GMT) Full text and rfc822 format available.

Message #21 received at 41524 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: jan <rtm443x <at> googlemail.com>, 41524 <at> debbugs.gnu.org
Subject: RE: bug#41524: 26.3; Request for 'x' for 'execute' in dired menu
Date: Mon, 24 Aug 2020 11:50:42 -0400
[Message part 1 (text/plain, inline)]
Drew Adams <drew.adams <at> oracle.com> writes:

> It belongs on menu `Operate', as it operates on the
> (typically) multiple files that are marked (or flagged).

Ah, right.  I never use the menu so I overlooked that.

Should be fixed in the attached.

Best regards,
Stefan Kangas
[0001-Add-Delete-submenu-to-Dired-Operate-menu.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#41524; Package emacs. (Mon, 24 Aug 2020 16:05:02 GMT) Full text and rfc822 format available.

Message #24 received at 41524 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: jan <rtm443x <at> googlemail.com>, 41524 <at> debbugs.gnu.org
Subject: RE: bug#41524: 26.3; Request for 'x' for 'execute' in dired menu
Date: Mon, 24 Aug 2020 09:04:42 -0700 (PDT)
> > It belongs on menu `Operate', as it operates on the
> > (typically) multiple files that are marked (or flagged).
> 
> Ah, right.  I never use the menu so I overlooked that.
> Should be fixed in the attached.

I took only a quick look at the patch, but LGTM.
Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#41524; Package emacs. (Tue, 25 Aug 2020 18:35:02 GMT) Full text and rfc822 format available.

Message #27 received at 41524 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: jan <rtm443x <at> googlemail.com>, 41524 <at> debbugs.gnu.org
Subject: RE: bug#41524: 26.3; Request for 'x' for 'execute' in dired menu
Date: Tue, 25 Aug 2020 11:34:17 -0700
close 41524 28.1
thanks

Drew Adams <drew.adams <at> oracle.com> writes:

> I took only a quick look at the patch, but LGTM.

Thanks, Now pushed to master as commit a17ad0b212.  Closing.




bug marked as fixed in version 28.1, send any further explanations to 41524 <at> debbugs.gnu.org and jan <rtm443x <at> googlemail.com> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Tue, 25 Aug 2020 18:35:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 23 Sep 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 187 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.