GNU bug report logs - #41552
[PATCH] gnu: Add remid-lv2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41552 in the body.
You can then email your comments to 41552 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add remid-lv2.
Date: Wed, 27 May 2020 01:37:46 +0100

[Message part 1 (text/plain, inline)]

Hi,

This patch adds the reMID LV2 plugin.

Thanks,
Alex

[0001-gnu-Add-remid-lv2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 41552 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>, 41552 <at> debbugs.gnu.org
Subject: Re: [bug#41552] [PATCH] gnu: Add remid-lv2.
Date: Sat, 30 May 2020 13:33:17 +0200

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Hi,
>
> This patch adds the reMID LV2 plugin.

Thanks!

[...]

> +(define-public remid-lv2
> +  (package
> +    (name "remid-lv2")
> +    (version "0.3")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://github.com/ssj71/"
> +                            "reMID.lv2/archive/v"
> +                            version ".tar.gz"))

The GitHub /archive/ URLs are not stable: they might fall out of GitHubs
cache and be regenerated, with different time stamps.  So we should use
git-fetch here instead.

This is different from "/releases/", which are uploaded.  Unfortunately
GitHubs UI makes it difficult to tell the difference short of looking at
the URL.

> +        (file-name (string-append name "-" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f))                      ; no tests included
> +    (inputs
> +     `(("glib" ,glib)
> +       ("alsa-lib" ,alsa-lib)
> +       ("jack" ,jack-1)
> +       ("lv2" ,lv2)))

Nit: we usually sort inputs.  Helpful when there are dozens.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (home-page "https://github.com/ssj71/reMID.lv2")
> +    (synopsis
> +      "MIDI-controlled implementation of the SID 6581 chip used in the
> +Commodore 64")
> +    (description
> +      "The 6581 SID chip is the sound chip used in the Commodore 64 computer.
> +reMID is a MIDI implementation of the 6581 SID chip using the reSID library
> +to provide a virtual SID-based synthesizer, controllable in real-time via
> +MIDI.  It includes support for scripted instruments that allow complex sonic
> +control of the chip.")

Why yes, I know some of these words :-) would it make sense to define
"SID" here with @acronym?

> +    (license license:gpl2)))

This is actually GPL2+, because none of the source files say "version 2
only" (and some actually say explicitly GPL2-or-later).

Can you send an updated patch?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 41552 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Marius Bakke <marius <at> gnu.org>, 41552 <at> debbugs.gnu.org
Subject: Re: [bug#41552] [PATCH] gnu: Add remid-lv2.
Date: Wed, 08 Jul 2020 20:43:15 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thanks for the feedback. 

I fixed the patch although I'm not sure what to do with the
description/summary - I don't know what those are either, I just know
that it's a cool audio plugin. Feel free to edit it.

Thanks,
Alex

On Sat, 2020-05-30 at 13:33 +0200, Marius Bakke wrote:
> Alexandros Theodotou <alex <at> zrythm.org> writes:
> 
> > Hi,
> > 
> > This patch adds the reMID LV2 plugin.
> 
> Thanks!
> 
> [...]
> 
> > +(define-public remid-lv2
> > +  (package
> > +    (name "remid-lv2")
> > +    (version "0.3")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (string-append "https://github.com/ssj71/"
> > +                            "reMID.lv2/archive/v"
> > +                            version ".tar.gz"))
> 
> The GitHub /archive/ URLs are not stable: they might fall out of
> GitHubs
> cache and be regenerated, with different time stamps.  So we should
> use
> git-fetch here instead.
> 
> This is different from "/releases/", which are
> uploaded.  Unfortunately
> GitHubs UI makes it difficult to tell the difference short of looking
> at
> the URL.
> 
> > +        (file-name (string-append name "-" version ".tar.gz"))
> > +        (sha256
> > +          (base32
> > +            "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3"
> > ))))
> > +    (build-system cmake-build-system)
> > +    (arguments
> > +     `(#:tests? #f))                      ; no tests included
> > +    (inputs
> > +     `(("glib" ,glib)
> > +       ("alsa-lib" ,alsa-lib)
> > +       ("jack" ,jack-1)
> > +       ("lv2" ,lv2)))
> 
> Nit: we usually sort inputs.  Helpful when there are dozens.
> 
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)))
> > +    (home-page "https://github.com/ssj71/reMID.lv2")
> > +    (synopsis
> > +      "MIDI-controlled implementation of the SID 6581 chip used in
> > the
> > +Commodore 64")
> > +    (description
> > +      "The 6581 SID chip is the sound chip used in the Commodore
> > 64 computer.
> > +reMID is a MIDI implementation of the 6581 SID chip using the
> > reSID library
> > +to provide a virtual SID-based synthesizer, controllable in real-
> > time via
> > +MIDI.  It includes support for scripted instruments that allow
> > complex sonic
> > +control of the chip.")
> 
> Why yes, I know some of these words :-) would it make sense to define
> "SID" here with @acronym?
> 
> > +    (license license:gpl2)))
> 
> This is actually GPL2+, because none of the source files say "version
> 2
> only" (and some actually say explicitly GPL2-or-later).
> 
> Can you send an updated patch?

[0001-gnu-Add-remid-lv2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 41552-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>, 41552-done <at> debbugs.gnu.org
Subject: Re: [bug#41552] [PATCH] gnu: Add remid-lv2.
Date: Tue, 21 Jul 2020 23:06:08 +0200

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Hi,
>
> Thanks for the feedback. 
>
> I fixed the patch although I'm not sure what to do with the
> description/summary - I don't know what those are either, I just know
> that it's a cool audio plugin. Feel free to edit it.

OK.

I applied the patch after fixing the indentation.  Thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.