GNU bug report logs - #41566
[PATCH] gnu: Add emacs-erc-status-sidebar.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41566 in the body.
You can then email your comments to 41566 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-erc-status-sidebar.
Date: Wed, 27 May 2020 19:34:53 +0200

[0001-gnu-Add-emacs-erc-status-sidebar.patch (text/x-patch, inline)]

From 2c47a49177ab0a8ceee52910007a998b73f3bf81 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Wed, 27 May 2020 19:31:46 +0200
Subject: [PATCH] gnu: Add emacs-erc-status-sidebar.

* gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 45a10f4689..338bd270e0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3216,6 +3216,28 @@ appropriate console.")
 IRC bouncer with ERC.")
     (license license:expat)))
 
+(define-public emacs-erc-status-sidebar
+  (package
+    (name "emacs-erc-status-sidebar")
+    (version "20171223.2124")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/erc-status-sidebar-"
+                           version ".el"))
+       (sha256
+        (base32 "1jjz4zs4fx45i9nvy2h7nfzkv0qrpp1pfhr8fx3hb6wxvi6zjis0"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-seq" ,emacs-seq)))
+    (home-page "https://github.com/drewbarbs/erc-status-sidebar")
+    (synopsis "Hexchat-like activity overview for ERC channels")
+    (description
+     "This package is provides a hexchat-like status bar for joined
+channels in ERC.  It relies on the @code{erc-track} module, and displays
+all the same information erc-track does in the mode line, but in an
+alternative format.")
+    (license license:gpl3)))
+
 (define-public emacs-shut-up
   (package
     (name "emacs-shut-up")
-- 
2.26.2

[Message part 2 (text/plain, inline)]

-- 
A vegan, an IntelliJ user, a Mac user, and a Linux user walked into a bar.
How do I know?
AFTER 2 MINUTES, THE WHOLE DARN BAR KNEW!

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 41566 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>, 41566 <at> debbugs.gnu.org
Subject: Re: [bug#41566] [PATCH] gnu: Add emacs-erc-status-sidebar.
Date: Sat, 30 May 2020 16:00:43 +0200

[Message part 1 (text/plain, inline)]

Michael Rohleder <mike <at> rohleder.de> writes:

> From 2c47a49177ab0a8ceee52910007a998b73f3bf81 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike <at> rohleder.de>
> Date: Wed, 27 May 2020 19:31:46 +0200
> Subject: [PATCH] gnu: Add emacs-erc-status-sidebar.
>
> * gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): New variable.

Thanks!
  
> +(define-public emacs-erc-status-sidebar
> +  (package
> +    (name "emacs-erc-status-sidebar")
> +    (version "20171223.2124")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/erc-status-sidebar-"
> +                           version ".el"))
> +       (sha256
> +        (base32 "1jjz4zs4fx45i9nvy2h7nfzkv0qrpp1pfhr8fx3hb6wxvi6zjis0"))))

IIRC melpa.org purges old versions, so we should probably change to
'git-fetch' here.

> +    (build-system emacs-build-system)
> +    (propagated-inputs `(("emacs-seq" ,emacs-seq)))
> +    (home-page "https://github.com/drewbarbs/erc-status-sidebar")
> +    (synopsis "Hexchat-like activity overview for ERC channels")
> +    (description
> +     "This package is provides a hexchat-like status bar for joined
> +channels in ERC.  It relies on the @code{erc-track} module, and displays
> +all the same information erc-track does in the mode line, but in an
> +alternative format.")
> +    (license license:gpl3)))

Well this is awkward, the LICENSE file is GPL3, but the headers in
erc-status-sidebar.el actually uses the Expat license.  So this should
be license:expat.

It would be good to notify upstream about this inconstency, but not a
blocking issue.

Can you send an updated patch?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 41566 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Marius Bakke <marius <at> gnu.org>
Cc: 41566 <at> debbugs.gnu.org
Subject: Re: [bug#41566] [PATCH] gnu: Add emacs-erc-status-sidebar.
Date: Tue, 02 Jun 2020 08:27:46 +0200

[Message part 1 (text/plain, inline)]

Hi Marius,

thank you reviewing!

Marius Bakke <marius <at> gnu.org> writes:
> IIRC melpa.org purges old versions, so we should probably change to
> 'git-fetch' here.

done.

>> +    (license license:gpl3)))
>
> Well this is awkward, the LICENSE file is GPL3, but the headers in
> erc-status-sidebar.el actually uses the Expat license.  So this should
> be license:expat.

oh, good catch, I didnt notice!

[0001-gnu-Add-emacs-erc-status-sidebar.patch (text/x-patch, inline)]

From 5da5a1e7322dc00f8900724060de3d5fe2a826e0 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Tue, 2 Jun 2020 08:20:18 +0200
Subject: [PATCH] gnu: Add emacs-erc-status-sidebar.

* gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b64a964916..76c67d859e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3280,6 +3280,31 @@ appropriate console.")
 IRC bouncer with ERC.")
     (license license:expat)))
 
+(define-public emacs-erc-status-sidebar
+  (let ((commit "ea4189a1dbfe60117359c36e681ad7c389e2968c")
+        (revision "1"))
+    (package
+      (name "emacs-erc-status-sidebar")
+      (version (git-version "0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/drewbarbs/erc-status-sidebar.git")
+               (commit commit)))
+         (sha256
+          (base32 "1hwlhzgx03z8891sblz56zdp8zj0izh72kxykgcnz5rrkyc3vfi3"))))
+      (build-system emacs-build-system)
+      (propagated-inputs `(("emacs-seq" ,emacs-seq)))
+      (home-page "https://github.com/drewbarbs/erc-status-sidebar")
+      (synopsis "A hexchat-like activity overview for ERC channels")
+      (description
+       "This package is provides a hexchat-like status bar for joined
+channels in ERC.  It relies on the `erc-track' module, and displays
+all the same information erc-track does in the mode line, but in an
+alternative format.")
+      (license license:expat))))
+
 (define-public emacs-shut-up
   (package
     (name "emacs-shut-up")
-- 
2.26.2

[Message part 3 (text/plain, inline)]

-- 
In most countries selling harmful things like drugs is punishable.
Then howcome people can sell Microsoft software and go unpunished?
(By hasku <at> rost.abo.fi, Hasse Skrifvars)

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 41566-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 41566-done <at> debbugs.gnu.org, Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#41566] [PATCH] gnu: Add emacs-erc-status-sidebar.
Date: Sun, 14 Jun 2020 23:05:45 +0200

Hi Michael,

Michael Rohleder <mike <at> rohleder.de> skribis:

> From 5da5a1e7322dc00f8900724060de3d5fe2a826e0 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike <at> rohleder.de>
> Date: Tue, 2 Jun 2020 08:20:18 +0200
> Subject: [PATCH] gnu: Add emacs-erc-status-sidebar.
>
> * gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)

This seems to address what Marius commented on so I went ahead and
applied it.  I followed up with small changes to placate ‘guix lint’.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.