GNU bug report logs - #41573
[PATCH Shepherd] shepherd: service: Add #:supplementary-groups.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41573 in the body.
You can then email your comments to 41573 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH Shepherd] shepherd: service: Add #:supplementary-groups.
Date: Thu, 28 May 2020 08:19:27 +0300

[Message part 1 (text/plain, inline)]

Hello Guix,

This patch provides a way to specify supplementary groups for services.
It's useful for services which could be used with a Docker group,
e.g. Jenkins.

‘shepherd’ package in Guix succeeded to build with current patch.  And I
succeeded to pull and reconfigure my Guix system with it.  Also ‘make
check’ in Shepherd's Git repository passes tests.

[0001-service-Add-supplementary-groups.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 41573 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 41573 <at> debbugs.gnu.org
Subject: Re: [bug#41573] [PATCH Shepherd] shepherd: service: Add
 #:supplementary-groups.
Date: Sun, 14 Jun 2020 22:53:14 +0200

Hello,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> From 5718eb5f4130530b48df896d7f7e4a126e08428a Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Sun, 24 May 2020 20:30:27 +0300
> Subject: [PATCH] service: Add #:supplementary-groups.
>
> * modules/shepherd/service.scm (format-supplementary-groups): New procedure.
> (exec-command, fork+exec-command, make-forkexec-constructor): Add
> '#:supplementary-groups'.
> * doc/shepherd.texi (Service De- and Constructors): Document this.

[...]

> +(define (format-supplementary-groups supplementary-groups)
> +  (if (vector? supplementary-groups)
> +      supplementary-groups
> +      (list->vector (map (lambda (group) (group:gid (getgr group)))
> +                         supplementary-groups))))

Perhaps we should remove the ‘vector?’ case, no?  I find it clearer when
the interface accepts just one single data type.

Apart from that, it LGTM!

Note that for compatibility reasons we’ll have to wait before using it
in Guix System.

Thanks,
Ludo’.

Message #11 received at 41573 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41573 <at> debbugs.gnu.org
Subject: Re: [bug#41573] [PATCH Shepherd] shepherd: service: Add
 #:supplementary-groups.
Date: Fri, 19 Jun 2020 04:28:57 +0300

[Message part 1 (text/plain, inline)]

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> From 5718eb5f4130530b48df896d7f7e4a126e08428a Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust <at> gmail.com>
>> Date: Sun, 24 May 2020 20:30:27 +0300
>> Subject: [PATCH] service: Add #:supplementary-groups.
>>
>> * modules/shepherd/service.scm (format-supplementary-groups): New procedure.
>> (exec-command, fork+exec-command, make-forkexec-constructor): Add
>> '#:supplementary-groups'.
>> * doc/shepherd.texi (Service De- and Constructors): Document this.
>
> [...]
>
>> +(define (format-supplementary-groups supplementary-groups)
>> +  (if (vector? supplementary-groups)
>> +      supplementary-groups
>> +      (list->vector (map (lambda (group) (group:gid (getgr group)))
>> +                         supplementary-groups))))
>
> Perhaps we should remove the ‘vector?’ case, no?  I find it clearer when
> the interface accepts just one single data type.

OK.

> Apart from that, it LGTM!
>
> Note that for compatibility reasons we’ll have to wait before using it
> in Guix System.

No problem.

I updated the patch and tested it again with make check and
reconfiguring my system.

[0001-service-Add-supplementary-groups.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 41573-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 41573-done <at> debbugs.gnu.org
Subject: Re: [bug#41573] [PATCH Shepherd] shepherd: service: Add
 #:supplementary-groups.
Date: Fri, 19 Jun 2020 09:56:22 +0200

[Message part 1 (text/plain, inline)]

Hi,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> From 20a08c750c4d6126d36835c64fed211299cb03e3 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Sun, 24 May 2020 20:30:27 +0300
> Subject: [PATCH] service: Add #:supplementary-groups.
>
> * modules/shepherd/service.scm (format-supplementary-groups): New procedure.
> (exec-command, fork+exec-command, make-forkexec-constructor): Add
> '#:supplementary-groups'.
> * doc/shepherd.texi (Service De- and Constructors): Document this.

Applied with the change below, thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/doc/shepherd.texi b/doc/shepherd.texi
index 18f1a4d..696477e 100644
--- a/doc/shepherd.texi
+++ b/doc/shepherd.texi
@@ -967,7 +967,7 @@ immediately before invoking @var{command}.  @var{user} may be a string,
 indicating a user name, or a number, indicating a user ID.  Likewise,
 @var{command} will be run under the current group, unless the
 @var{group} keyword argument is present and not false, and
-supplementary-groups is not '().
+@var{supplementary-groups} is not @code{'()}.
 
 @code{fork+exec-command} does the same as @code{exec-command}, but in
 a separate process whose PID it returns.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.