GNU bug report logs - #41587
Configuring DejaGnu using a relative path causes the testsuite to fail

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41587 in the body.
You can then email your comments to 41587 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jacob Bachmeyer <jcb62281 <at> gmail.com>
To: bug-dejagnu <at> gnu.org
Subject: Configuring DejaGnu using a relative path causes the testsuite to fail
Date: Thu, 28 May 2020 20:25:53 -0500

In current Git master, some parts of the DejaGnu testsuite fail if 
DejaGnu was configured using a relative srcdir, as by 
"../src/dejagnu/configure".  This was uncovered while investigating the 
issue that became bug#41585.

Message #10 received at 41587 <at> debbugs.gnu.org (full text, mbox):

From: Rob Savoye <rob <at> senecass.com>
To: jcb62281 <at> gmail.com, 41587 <at> debbugs.gnu.org
Subject: Re: bug#41587: Configuring DejaGnu using a relative path causes the
 testsuite to fail
Date: Thu, 28 May 2020 19:52:50 -0600

On 5/28/20 7:25 PM, Jacob Bachmeyer wrote:
> In current Git master, some parts of the DejaGnu testsuite fail if
> DejaGnu was configured using a relative srcdir, as by
> "../src/dejagnu/configure".  This was uncovered while investigating the
> issue that became bug#41585.

  Interesting, relative paths to configure are working fine for me.

	- rob -

Message #13 received at 41587 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Bachmeyer <jcb62281 <at> gmail.com>
To: Rob Savoye <rob <at> senecass.com>
Cc: 41587 <at> debbugs.gnu.org
Subject: Re: bug#41587: Configuring DejaGnu using a relative path causes the
 testsuite to fail
Date: Thu, 28 May 2020 22:06:04 -0500

Rob Savoye wrote:
> On 5/28/20 7:25 PM, Jacob Bachmeyer wrote:
>   
>> In current Git master, some parts of the DejaGnu testsuite fail if
>> DejaGnu was configured using a relative srcdir, as by
>> "../src/dejagnu/configure".  This was uncovered while investigating the
>> issue that became bug#41585.
>>     
>
>   Interesting, relative paths to configure are working fine for me.
>   

Very interesting; they cause options.exp and the launcher tests to fail 
here.  In any case, commit 6a5b5861457230cc9ff5e01dc2ad3e1435051b93 
should make the code more readable in the future and the other patches 
submitted on temporary branch PR41587 should make the testsuite more 
robust in general.

The change in runtest.exp was the beginning of a different development 
direction:  making "testsuite file" sensitive to changing directories if 
the original directories had relative names.  That path might be good as 
a future feature improvement, but it would not have fixed the observed 
problem here, so it was quickly abandoned.  I saw that were two 
procedure definitions between setting and reporting $logname, so I moved 
those closer together.  I was looking for a place to add storing and 
reporting the initial working directory, but later realized that the 
init file could legitimately change it along with setting different 
srcdir/objdir/etc. values.

On a side note, you can close a bug on debbugs by sending mail to 
<bugnumber>-done <at> debbugs.gnu.org.  The "closing note" also goes out as 
part of the bug records.  I will take care of closing these two bugs and 
deleting the temporary branches if you want.


-- Jacob

Message #16 received at 41587 <at> debbugs.gnu.org (full text, mbox):

From: Rob Savoye <rob <at> senecass.com>
To: jcb62281 <at> gmail.com
Cc: 41587 <at> debbugs.gnu.org
Subject: Re: bug#41587: Configuring DejaGnu using a relative path causes the
 testsuite to fail
Date: Thu, 28 May 2020 21:21:06 -0600

On 5/28/20 9:06 PM, Jacob Bachmeyer wrote:

> The change in runtest.exp was the beginning of a different development
> direction:  making "testsuite file" sensitive to changing directories if

  I stand corrected. Configure worked, but make check did fail.

	- rob -

Message #21 received at 41587-done <at> debbugs.gnu.org (full text, mbox):

From: Jacob Bachmeyer <jcb62281 <at> gmail.com>
To: 41587-done <at> debbugs.gnu.org
Subject: Patch applied; closing report
Date: Tue, 30 Jun 2020 23:45:18 -0500

Fix landed on master at commit d37c15b4d569a3d70493653efe82a78c3550e903 
on 2020-05-28.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.