GNU bug report logs - #41601
[PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less prominent.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Marius Bakke <marius@HIDDEN>; Keywords: patch; dated Fri, 29 May 2020 15:01:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 41601 <at> debbugs.gnu.org:


Received: (at 41601) by debbugs.gnu.org; 29 May 2020 15:36:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 29 11:36:38 2020
Received: from localhost ([127.0.0.1]:55851 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jeh3l-0006pG-Md
	for submit <at> debbugs.gnu.org; Fri, 29 May 2020 11:36:37 -0400
Received: from lepiller.eu ([89.234.186.109]:51684)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <julien@HIDDEN>) id 1jeh3h-0006ox-2J
 for 41601 <at> debbugs.gnu.org; Fri, 29 May 2020 11:36:33 -0400
Received: from lepiller.eu (localhost [127.0.0.1])
 by lepiller.eu (OpenSMTPD) with ESMTP id 7e2518d8;
 Fri, 29 May 2020 15:36:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date
 :in-reply-to:references:mime-version:content-type
 :content-transfer-encoding:subject:to:from:message-id; s=dkim;
 bh=s05gjssyn+DCL8f5vQ2cRXnjZ/oUlL/ctO04rX5ualM=; b=oAlhYMtA8964
 1AG8hTPnLrRIUhw+A2S2C/6T3h8Vx6vvEG1/lu897kMn0WUgrGFVlswH8e4bjfay
 a9ekL6DOUksnNKuDGbMBAsKuWJntoTnimIOEerx0NFD/qeB/O2DpD80qe5BMaV41
 nHneZgHh9e2z7HkZcHOBmr8Mmg+QG7UM7h8kKI9QosNlsshWAzlBTXp+4udvMBlL
 ZFgjUDnRQVhtWX/43u8Ji9ocrlsAvQyROVKyvVocRDMddBl8vNpqrP7+imcRrp83
 iiFhTDtlZUONPzviIzxzg9Wj8euzFNWGFyiqrp3OqcTTMjo57uq0aDsa4WsJ7M4b
 awt8uke+4Q==
Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 52f003d6
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); 
 Fri, 29 May 2020 15:36:30 +0000 (UTC)
Date: Fri, 29 May 2020 11:36:15 -0400
User-Agent: K-9 Mail for Android
In-Reply-To: <20200529150003.4560-1-marius@HIDDEN>
References: <20200529150003.4560-1-marius@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [bug#41601] [PATCH] doc: Make 'sudo -E ./pre-inst-env
 guix-daemon' example less prominent.
To: Marius Bakke <marius@HIDDEN>,41601 <at> debbugs.gnu.org
From: Julien Lepiller <julien@HIDDEN>
Message-ID: <CC63FA2F-5B74-4AE3-A5F9-CFE92591EA6A@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 41601
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Le 29 mai 2020 11:00:03 GMT-04:00, Marius Bakke <marius@gnu=2Eorg> a =C3=A9=
crit :
>* doc/contributing=2Etexi (Running Guix Before It Is Installed): Move
>'=2E/pre-inst-env guix-daemon' example after the mention of
>GUILE_LOAD_PATH &
>co, because running the daemon from the checkout frequently trips new
>users=2E
>Additionally clarify that sudo must be setuid=2E
>---
> doc/contributing=2Etexi | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
>diff --git a/doc/contributing=2Etexi b/doc/contributing=2Etexi
>index 88128e5498=2E=2Ed9e54dd23b 100644
>--- a/doc/contributing=2Etexi
>+++ b/doc/contributing=2Etexi
>@@ -161,13 +161,8 @@ with all the dependencies available
>(@pxref{Building from Git}), and then
> simply prefix each command with
> @command{=2E/pre-inst-env} (the @file{pre-inst-env} script lives in the
> top build tree of Guix; it is generated by @command{=2E/configure})=2E
>-An example@footnote{The @option{-E} flag to
>-@command{sudo} guarantees that @code{GUILE_LOAD_PATH} is correctly set
>-such that @command{guix-daemon} and the tools it uses can find the
>Guile
>-modules they need=2E}:
>=20
> @example
>-$ sudo -E =2E/pre-inst-env guix-daemon --build-users-group=3Dguixbuild
> $ =2E/pre-inst-env guix build hello
> @end example
>=20
>@@ -205,6 +200,16 @@ $1 =3D 361
>The @command{pre-inst-env} script sets up all the environment variables
>necessary to support this, including @env{PATH} and
>@env{GUILE_LOAD_PATH}=2E
>=20
>+When root privileges are required, use the @option{-E} argument to
>+@command{sudo} to preserve the environment@footnote{Additionally, make
>sure
>+to use the installed @command{sudo} such as
>@file{/run/setuid-programs/sudo}
>+instead of the @code{sudo} package, otherwise sudo won't be able to
>elevate
>+privileges}=2E  E=2Eg=2E if you are testing changes to
>@command{guix-daemon}:
>+
>+@example
>+$ sudo -E =2E/pre-inst-env guix-daemon --build-users-group=3Dguixbuild
>+@end example
>+
>Note that @command{=2E/pre-inst-env guix pull} does @emph{not} upgrade
>the
> local source tree; it simply updates the @file{~/=2Econfig/guix/current}
>symlink (@pxref{Invoking guix pull})=2E  Run @command{git pull} instead
>if

Looks good, but you should mention that, before running the daemon that wa=
y, the one running on the system must be stopped (herd stop guix-daemon or =
whatever init system is installed)=2E




Information forwarded to guix-patches@HIDDEN:
bug#41601; Package guix-patches. Full text available.

Message received at 41601 <at> debbugs.gnu.org:


Received: (at 41601) by debbugs.gnu.org; 29 May 2020 15:35:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 29 11:35:06 2020
Received: from localhost ([127.0.0.1]:55844 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jeh2I-0006mm-2S
	for submit <at> debbugs.gnu.org; Fri, 29 May 2020 11:35:06 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:55055)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1jeh2G-0006m8-MC
 for 41601 <at> debbugs.gnu.org; Fri, 29 May 2020 11:35:05 -0400
X-Originating-IP: 185.131.40.67
Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67])
 (Authenticated sender: admin@HIDDEN)
 by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id D287D20008;
 Fri, 29 May 2020 15:34:57 +0000 (UTC)
From: Nicolas Goaziou <mail@HIDDEN>
To: Marius Bakke <marius@HIDDEN>
Subject: Re: [bug#41601] [PATCH] doc: Make 'sudo -E ./pre-inst-env
 guix-daemon' example less prominent.
References: <20200529150003.4560-1-marius@HIDDEN>
Date: Fri, 29 May 2020 17:34:55 +0200
In-Reply-To: <20200529150003.4560-1-marius@HIDDEN> (Marius Bakke's message of
 "Fri, 29 May 2020 17:00:03 +0200")
Message-ID: <87h7vywy8w.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 41601
Cc: 41601 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

Marius Bakke <marius@HIDDEN> writes:

> +privileges}.  E.g. if you are testing changes to @command{guix-daemon}:
                  ^^^^
Beware the dot above. You could write

  E.g.@: if you=E2=80=A6

or

  E.g., if you=E2=80=A6
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20

instead.

Regards,

--=20
Nicolas Goaziou




Information forwarded to guix-patches@HIDDEN:
bug#41601; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 29 May 2020 15:00:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 29 11:00:10 2020
Received: from localhost ([127.0.0.1]:55782 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jegUT-0003iQ-HG
	for submit <at> debbugs.gnu.org; Fri, 29 May 2020 11:00:09 -0400
Received: from lists.gnu.org ([209.51.188.17]:34254)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <marius@HIDDEN>) id 1jegUR-0003iH-3Q
 for submit <at> debbugs.gnu.org; Fri, 29 May 2020 11:00:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40790)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <marius@HIDDEN>) id 1jegUQ-0004XZ-Nm
 for guix-patches@HIDDEN; Fri, 29 May 2020 11:00:06 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:40629)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <marius@HIDDEN>) id 1jegUQ-0004tY-BN
 for guix-patches@HIDDEN; Fri, 29 May 2020 11:00:06 -0400
Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:59020
 helo=localhost)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <marius@HIDDEN>) id 1jegUP-000609-LN
 for guix-patches@HIDDEN; Fri, 29 May 2020 11:00:06 -0400
From: Marius Bakke <marius@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less
 prominent.
Date: Fri, 29 May 2020 17:00:03 +0200
Message-Id: <20200529150003.4560-1-marius@HIDDEN>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

* doc/contributing.texi (Running Guix Before It Is Installed): Move
'./pre-inst-env guix-daemon' example after the mention of GUILE_LOAD_PATH &
co, because running the daemon from the checkout frequently trips new users.
Additionally clarify that sudo must be setuid.
---
 doc/contributing.texi | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 88128e5498..d9e54dd23b 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -161,13 +161,8 @@ with all the dependencies available (@pxref{Building from Git}), and then
 simply prefix each command with
 @command{./pre-inst-env} (the @file{pre-inst-env} script lives in the
 top build tree of Guix; it is generated by @command{./configure}).
-An example@footnote{The @option{-E} flag to
-@command{sudo} guarantees that @code{GUILE_LOAD_PATH} is correctly set
-such that @command{guix-daemon} and the tools it uses can find the Guile
-modules they need.}:
 
 @example
-$ sudo -E ./pre-inst-env guix-daemon --build-users-group=guixbuild
 $ ./pre-inst-env guix build hello
 @end example
 
@@ -205,6 +200,16 @@ $1 = 361
 The @command{pre-inst-env} script sets up all the environment variables
 necessary to support this, including @env{PATH} and @env{GUILE_LOAD_PATH}.
 
+When root privileges are required, use the @option{-E} argument to
+@command{sudo} to preserve the environment@footnote{Additionally, make sure
+to use the installed @command{sudo} such as @file{/run/setuid-programs/sudo}
+instead of the @code{sudo} package, otherwise sudo won't be able to elevate
+privileges}.  E.g. if you are testing changes to @command{guix-daemon}:
+
+@example
+$ sudo -E ./pre-inst-env guix-daemon --build-users-group=guixbuild
+@end example
+
 Note that @command{./pre-inst-env guix pull} does @emph{not} upgrade the
 local source tree; it simply updates the @file{~/.config/guix/current}
 symlink (@pxref{Invoking guix pull}).  Run @command{git pull} instead if
-- 
2.26.2





Acknowledgement sent to Marius Bakke <marius@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#41601; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 29 May 2020 15:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.