GNU bug report logs - #41662
[PATCH] gnu: zsh: Set default '$fpath'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41662 in the body.
You can then email your comments to 41662 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: zsh: Set default '$fpath'.
Date: Tue,  2 Jun 2020 15:20:48 +0200

* gnu/packages/shells.scm (zsh)[arguments]: Add configure-flags
'disable-site-dir' and 'enable-additional-fpath'.
---
 gnu/packages/shells.scm | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index 74d08e02bc..250c6d5576 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -441,8 +441,16 @@ history mechanism, job control and a C-like syntax.")
                (base32
                 "09yyaadq738zlrnlh1hd3ycj1mv3q5hh4xl1ank70mjnqm6bbi6w"))))
     (build-system gnu-build-system)
-    (arguments `(#:configure-flags '("--with-tcsetpgrp" "--enable-pcre"
-                                     "--enable-maildir-support")
+    (arguments `(#:configure-flags
+                 `("--with-tcsetpgrp"
+                  "--enable-pcre"
+                  "--enable-maildir-support"
+                  ;; share/zsh/site-functions isn't populated
+                  "--disable-site-fndir"
+                  ,(string-append
+                    "--enable-additional-fpath="
+                    "/usr/local/share/zsh/site-functions," ; for foreign OS
+                    "/run/current-system/profile/share/zsh/site-functions"))
                  #:phases
                  (modify-phases %standard-phases
                    (add-before 'configure 'fix-sh
-- 
2.26.2

Message #8 received at 41662 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 41662 <at> debbugs.gnu.org
Subject: Re: [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
Date: Thu, 11 Jun 2020 19:08:35 +0200

Hi,

Brice Waegeneire <brice <at> waegenei.re> skribis:

> * gnu/packages/shells.scm (zsh)[arguments]: Add configure-flags
> 'disable-site-dir' and 'enable-additional-fpath'.

[...]

> +                  ,(string-append
> +                    "--enable-additional-fpath="
> +                    "/usr/local/share/zsh/site-functions," ; for foreign OS
> +                    "/run/current-system/profile/share/zsh/site-functions"))

/usr/local seems arbitrary.  What if we omit it, will that break zsh on
foreign distros?

Ludo’.

Message #11 received at 41662 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41662 <at> debbugs.gnu.org
Subject: Re: [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
Date: Thu, 11 Jun 2020 18:36:18 +0000

Hello Ludo',

On 2020-06-11 17:08, Ludovic Courtès wrote:
>> +                  ,(string-append
>> +                    "--enable-additional-fpath="
>> +                    "/usr/local/share/zsh/site-functions," ; for 
>> foreign OS
>> +                    
>> "/run/current-system/profile/share/zsh/site-functions"))
> 
> /usr/local seems arbitrary.  What if we omit it, will that break zsh on
> foreign distros?

I let it there because it's a default[0] and because it was already 
present
in our current zsh package, you can test that with “zsh -df -c 'echo 
$fpath'”.
If I remember correctly I put it there for people using foreign OS who 
still
wants some zsh functions from their host OS.

[0]: https://github.com/zsh-users/zsh/blob/master/NEWS#L415-L424

- Brice

Message #14 received at 41662 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 41662 <at> debbugs.gnu.org
Subject: Re: [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
Date: Fri, 12 Jun 2020 16:46:00 +0200

Hi,

Brice Waegeneire <brice <at> waegenei.re> skribis:

> On 2020-06-11 17:08, Ludovic Courtès wrote:
>>> +                  ,(string-append
>>> +                    "--enable-additional-fpath="
>>> +                    "/usr/local/share/zsh/site-functions," ; for
>>> foreign OS
>>> +
>>> "/run/current-system/profile/share/zsh/site-functions"))
>>
>> /usr/local seems arbitrary.  What if we omit it, will that break zsh on
>> foreign distros?
>
> I let it there because it's a default[0] and because it was already
> present
> in our current zsh package, you can test that with “zsh -df -c 'echo
> $fpath'”.

OK, that makes sense to me.

Thanks,
Ludo’.

Message #19 received at 41662-done <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41662-done <at> debbugs.gnu.org
Subject: Re: [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
Date: Sun, 14 Jun 2020 15:33:38 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Brice Waegeneire <brice <at> waegenei.re> skribis:
>
>> On 2020-06-11 17:08, Ludovic Courtès wrote:
>>>> +                  ,(string-append
>>>> +                    "--enable-additional-fpath="
>>>> +                    "/usr/local/share/zsh/site-functions," ; for
>>>> foreign OS
>>>> +
>>>> "/run/current-system/profile/share/zsh/site-functions"))
>>>
>>> /usr/local seems arbitrary.  What if we omit it, will that break zsh on
>>> foreign distros?
>>
>> I let it there because it's a default[0] and because it was already
>> present
>> in our current zsh package, you can test that with “zsh -df -c 'echo
>> $fpath'”.
>
> OK, that makes sense to me.

Pushed as 4f6e6c0442368ac3fd7e95f1fc264671d9182c00.

- Brice

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.