GNU bug report logs - #41679
[PATCH] gnu: Update protonvpn-cli to 2.2.4

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41679 in the body.
You can then email your comments to 41679 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Update protonvpn-cli to 2.2.4
Date: Tue, 02 Jun 2020 23:43:48 +0000

* gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4
---
 gnu/packages/vpn.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index 0f0157806c..cdfddc1e54 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -51,6 +51,7 @@
   #:use-module (gnu packages guile)
   #:use-module (gnu packages libevent)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages ncurses)
   #:use-module (gnu packages nss)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
@@ -316,7 +317,7 @@ traversing network address translators (@dfn{NAT}s) and firewalls.")
 (define-public protonvpn-cli
   (package
     (name "protonvpn-cli")
-    (version "2.2.2")
+    (version "2.2.4")
     (source
      (origin
        ;; PyPI has a ".whl" file but not a proper source release.
@@ -328,7 +329,7 @@ traversing network address translators (@dfn{NAT}s) and firewalls.")
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "0ixjb02kj4z79whm1izd8mrn2h0rp9cmw4im1qvp93rahqxdd4n8"))))
+         "08yca0a0prrnrc7ir7ajd56yxvxpcs4m1k8f5kf273f5whgr7wzw"))))
     (build-system python-build-system)
     (arguments '(#:tests? #f)) ; no tests in repo
     (native-inputs
@@ -337,7 +338,8 @@ traversing network address translators (@dfn{NAT}s) and firewalls.")
      `(("pythondialog" ,python-pythondialog)
        ("requests" ,python-requests)))
     (propagated-inputs
-     `(("openvpn" ,openvpn)))
+     `(("openvpn" ,openvpn)
+       ("dialog" ,dialog)))
     (synopsis "Command-line client for ProtonVPN")
     (description
      "This is the official command-line interface for ProtonVPN, a secure
-- 
2.26.2

Message #8 received at 41679 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: 41679 <at> debbugs.gnu.org
Subject: Re: [bug#41679] [PATCH] gnu: Update protonvpn-cli to 2.2.4
Date: Sun, 07 Jun 2020 23:18:21 +0200

Hello Ryan,

Thank you for the patch!

Ryan Prior <rprior <at> protonmail.com> writes:

> * gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4
> ---
>  gnu/packages/vpn.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

The update is fine, but that package is missing several dependencies, at
least: python-jinja2, coreutils and iproute. Try running it in a pure
environment and it will crash “guix environment --pure --container
--ad-hoc protonvpn-cli -- protonvpn -h”.

Searching the source for “subprocess.run” I find call to other binaries
which aren't listed as dependencies. Could you wrap the “protonvpn”
binary with the “PATH” of all the binaries it uses to avoid propagating
a whole lot of packages. Probably only “python-jinja2” should be
propagated.

- Brice

Message #11 received at 41679 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: 41679 <at> debbugs.gnu.org, Brice Waegeneire <brice <at> waegenei.re>
Subject: Re: [bug#41679] [PATCH] gnu: Update protonvpn-cli to 2.2.4
Date: Wed, 09 Sep 2020 23:08:29 +0200

Hi Ryan,

Ryan Prior <rprior <at> protonmail.com> skribis:

> * gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4

Applied!

Brice Waegeneire <brice <at> waegenei.re> skribis:

> The update is fine, but that package is missing several dependencies, at
> least: python-jinja2, coreutils and iproute. Try running it in a pure
> environment and it will crash “guix environment --pure --container
> --ad-hoc protonvpn-cli -- protonvpn -h”.
>
> Searching the source for “subprocess.run” I find call to other binaries
> which aren't listed as dependencies. Could you wrap the “protonvpn”
> binary with the “PATH” of all the binaries it uses to avoid propagating
> a whole lot of packages. Probably only “python-jinja2” should be
> propagated.

Alternatively, we can substitute file names (of jinja2, coreutils, and
iproute programs) with absolute file names.

That can be addressed separately, though.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.