GNU bug report logs - #41685
[PATCH] doc: Add note to 'udisks-service'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41685 in the body.
You can then email your comments to 41685 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] doc: Add note to 'udisks-service'.
Date: Wed,  3 Jun 2020 13:52:18 +0200

* doc/guix.texi (Desktop Services): Specify how to add file-systems
utilities to 'udisks-service'.
---
 doc/guix.texi | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 8335373145..12ed7923b3 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -16631,9 +16631,14 @@ Possible values are:
 
 @deffn {Scheme Procedure} udisks-service [#:udisks @var{udisks}]
 Return a service for @uref{https://udisks.freedesktop.org/docs/latest/,
-UDisks}, a @dfn{disk management} daemon that provides user interfaces with
-notifications and ways to mount/unmount disks.  Programs that talk to UDisks
-include the @command{udisksctl} command, part of UDisks, and GNOME Disks.
+UDisks}, a @dfn{disk management} daemon that provides user interfaces
+with notifications and ways to mount/unmount disks.  Programs that talk
+to UDisks include the @command{udisksctl} command, part of UDisks, and
+GNOME Disks.  Note that Udisks rely on the @command{mount} command, so
+it will only be able to use the file-system utilities which are
+installed in the system profile.  For example if you want to be able to
+mount NTFS file-systems in read and write fashion, you'll need to have
+@code{ntfs-3g} installed system-wide.
 @end deffn
 
 @deffn {Scheme Variable} colord-service-type
-- 
2.26.2

Message #8 received at 41685 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 41685 <at> debbugs.gnu.org
Subject: Re: [bug#41685] [PATCH] doc: Add note to 'udisks-service'.
Date: Tue, 09 Jun 2020 09:39:45 +0200

Hi!

Brice Waegeneire <brice <at> waegenei.re> skribis:

> * doc/guix.texi (Desktop Services): Specify how to add file-systems
> utilities to 'udisks-service'.

[...]

> +UDisks}, a @dfn{disk management} daemon that provides user interfaces
> +with notifications and ways to mount/unmount disks.  Programs that talk
> +to UDisks include the @command{udisksctl} command, part of UDisks, and
> +GNOME Disks.  Note that Udisks rely on the @command{mount} command, so

s/rely/relies/

> +it will only be able to use the file-system utilities which are

s/which are//

> +installed in the system profile.  For example if you want to be able to
> +mount NTFS file-systems in read and write fashion, you'll need to have
> +@code{ntfs-3g} installed system-wide.
>  @end deffn

LGTM!

Thanks,
Ludo’.

Message #13 received at 41685-done <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41685-done <at> debbugs.gnu.org
Subject: Re: [bug#41685] [PATCH] doc: Add note to 'udisks-service'.
Date: Tue, 09 Jun 2020 10:35:43 +0200

Hi Ludo',

Thank you for the review.

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi!
>
> Brice Waegeneire <brice <at> waegenei.re> skribis:
>
>> * doc/guix.texi (Desktop Services): Specify how to add file-systems
>> utilities to 'udisks-service'.
>
> [...]
>
>> +UDisks}, a @dfn{disk management} daemon that provides user interfaces
>> +with notifications and ways to mount/unmount disks.  Programs that talk
>> +to UDisks include the @command{udisksctl} command, part of UDisks, and
>> +GNOME Disks.  Note that Udisks rely on the @command{mount} command, so
>
> s/rely/relies/
>
>> +it will only be able to use the file-system utilities which are
>
> s/which are//
>
>> +installed in the system profile.  For example if you want to be able to
>> +mount NTFS file-systems in read and write fashion, you'll need to have
>> +@code{ntfs-3g} installed system-wide.
>>  @end deffn
>
> LGTM!
>
> Thanks,
> Ludo’.
>

Pushed as 1b5d26c967b17b635c88a094e010cd42a9afb220 with the 2 fixes you
suggested.

-Brice

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.