GNU bug report logs - #41689
[PATCH] Add cl-rdkafka

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41689 in the body.
You can then email your comments to 41689 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Add cl-rdkafka
Date: Wed, 3 Jun 2020 09:36:04 -0500

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-cl-rdkafka.patch (text/x-patch, attachment)]

Message #10 received at 41689 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Cc: 41689 <at> debbugs.gnu.org
Subject: Re: [bug#41689] Add cl-rdkafka
Date: Fri, 05 Jun 2020 16:01:56 +0200

[Message part 1 (text/plain, inline)]

Hi,

Katherine Cox-Buday <cox.katherine.e <at> gmail.com> skribis:

> (propagated-inputs
>  `(("librdkafka" ,librdkafka)))

Why is the librdkafka library a propagated input instead of a regular
input?

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 41689 <at> debbugs.gnu.org (full text, mbox):

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 41689 <at> debbugs.gnu.org
Subject: Re: [bug#41689] Add cl-rdkafka
Date: Sat, 6 Jun 2020 11:24:26 -0500

[Message part 1 (text/plain, inline)]

That is a mistake; there's no reason it can't be listed as a regular input.

During my tests to confirm this, I realized that sbcl-cl-rdkafka
wasn't actually producing any useful output. This led me down a
rabbit-hole (albeit a productive one). Below is a new patch set.

11:23 kate says: guix refresh -l sbcl-lparallel
Building the following 4 packages would ensure 8 dependent packages
are rebuilt: ecl-cl-rdkafka <at> 1.0.2 cl-rdkafka <at> 1.0.2
cl-random-forest <at> 0.1-0.85fbdd4 next <at> 1.5.0

All dependent packages continue to build.

On Fri, Jun 5, 2020 at 9:01 AM Guillaume Le Vaillant <glv <at> posteo.net> wrote:
>
>
> Hi,
>
> Katherine Cox-Buday <cox.katherine.e <at> gmail.com> skribis:
>
> > (propagated-inputs
> >  `(("librdkafka" ,librdkafka)))
>
> Why is the librdkafka library a propagated input instead of a regular
> input?

[0002-gnu-Add-cl-rdkafka.patch (text/x-patch, attachment)]

[0001-gnu-lparallel-Modify-system-definition-to-require-sb.patch (text/x-patch, attachment)]

Message #16 received at 41689 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Cc: 41689 <at> debbugs.gnu.org
Subject: Re: [bug#41689] Add cl-rdkafka
Date: Sun, 07 Jun 2020 11:17:40 +0200

[Message part 1 (text/plain, inline)]

Katherine Cox-Buday <cox.katherine.e <at> gmail.com> skribis:

> That is a mistake; there's no reason it can't be listed as a regular input.
>
> During my tests to confirm this, I realized that sbcl-cl-rdkafka
> wasn't actually producing any useful output. This led me down a
> rabbit-hole (albeit a productive one). Below is a new patch set.
>
> 11:23 kate says: guix refresh -l sbcl-lparallel
> Building the following 4 packages would ensure 8 dependent packages
> are rebuilt: ecl-cl-rdkafka <at> 1.0.2 cl-rdkafka <at> 1.0.2
> cl-random-forest <at> 0.1-0.85fbdd4 next <at> 1.5.0
>
> All dependent packages continue to build.
>
> On Fri, Jun 5, 2020 at 9:01 AM Guillaume Le Vaillant <glv <at> posteo.net> wrote:
>>
>>
>> Hi,
>>
>> Katherine Cox-Buday <cox.katherine.e <at> gmail.com> skribis:
>>
>> > (propagated-inputs
>> >  `(("librdkafka" ,librdkafka)))
>>
>> Why is the librdkafka library a propagated input instead of a regular
>> input?

Thanks. Patches pushed as 388a89750ec60a320dd7b6a0b0f174cbed4f50c6 and
64174aff927f4f9da18ea452247c838e6bab3306. Except I didn't push the
definition for ecl-cl-rdkafka because it didn't build (because of the
phase moving a file before the cleanup phase IIRC).

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 41689 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>, 41689 <at> debbugs.gnu.org
Subject: Re: [bug#41689] Add cl-rdkafka
Date: Tue, 23 Jun 2020 23:50:34 +0200

Hi,

Guillaume Le Vaillant <glv <at> posteo.net> skribis:

>>> Katherine Cox-Buday <cox.katherine.e <at> gmail.com> skribis:
>>>
>>> > (propagated-inputs
>>> >  `(("librdkafka" ,librdkafka)))
>>>
>>> Why is the librdkafka library a propagated input instead of a regular
>>> input?
>
> Thanks. Patches pushed as 388a89750ec60a320dd7b6a0b0f174cbed4f50c6 and
> 64174aff927f4f9da18ea452247c838e6bab3306. Except I didn't push the
> definition for ecl-cl-rdkafka because it didn't build (because of the
> phase moving a file before the cleanup phase IIRC).

Katherine, Guillaume: should we close this issue or wait for a fix for
ecl-cl-rdkafka?  (I guess the former.)

Thanks,
Ludo’.

Message #22 received at 41689 <at> debbugs.gnu.org (full text, mbox):

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Guillaume Le Vaillant <glv <at> posteo.net>, 41689 <at> debbugs.gnu.org
Subject: Re: [bug#41689] Add cl-rdkafka
Date: Tue, 23 Jun 2020 17:26:45 -0500

[Message part 1 (text/plain, inline)]

Closing is fine. I won't have time in the near future to get the ecl
package working. Thanks ludo!

On Tue, Jun 23, 2020, 16:50 Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi,
>
> Guillaume Le Vaillant <glv <at> posteo.net> skribis:
>
> >>> Katherine Cox-Buday <cox.katherine.e <at> gmail.com> skribis:
> >>>
> >>> > (propagated-inputs
> >>> >  `(("librdkafka" ,librdkafka)))
> >>>
> >>> Why is the librdkafka library a propagated input instead of a regular
> >>> input?
> >
> > Thanks. Patches pushed as 388a89750ec60a320dd7b6a0b0f174cbed4f50c6 and
> > 64174aff927f4f9da18ea452247c838e6bab3306. Except I didn't push the
> > definition for ecl-cl-rdkafka because it didn't build (because of the
> > phase moving a file before the cleanup phase IIRC).
>
> Katherine, Guillaume: should we close this issue or wait for a fix for
> ecl-cl-rdkafka?  (I guess the former.)
>
> Thanks,
> Ludo’.
>

[Message part 2 (text/html, inline)]

Message #27 received at 41689-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Cc: Guillaume Le Vaillant <glv <at> posteo.net>, 41689-done <at> debbugs.gnu.org
Subject: Re: [bug#41689] Add cl-rdkafka
Date: Wed, 24 Jun 2020 15:11:00 +0200

Katherine Cox-Buday <cox.katherine.e <at> gmail.com> skribis:

> Closing is fine. I won't have time in the near future to get the ecl
> package working. Thanks ludo!

Cool, done.  Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.