GNU bug report logs - #41696
27.0.91; comment-line in js-jsx-mode does not handle ReactJS markup

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41696 in the body.
You can then email your comments to 41696 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <bkleung89 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.91; comment-line in js-jsx-mode does not handle ReactJS markup
Date: Wed, 3 Jun 2020 16:56:56 -0700

[Message part 1 (text/plain, inline)]

With the following example code:

import * as React from "react";
import { render } from "react-dom";

const App = () => {
  return (
    <React.StrictMode>
      <div>Hello</div>
    </React.StrictMode>
  );
};

render(<App />, document.getElementById("root"));


If you move to the live with the <div> and call M-x comment-line, the
line is commented out with two forward slashes, instead of the proper

{{/* <div>Hello</div> */}}

In GNU Emacs 27.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20)
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: NixOS 20.09 (Nightingale)

[Message part 2 (text/html, inline)]

Message #8 received at 41696 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 41696 <at> debbugs.gnu.org
Subject: Re: bug#41696: 27.0.91; comment-line in js-jsx-mode does not handle
 ReactJS markup
Date: Thu, 22 Oct 2020 15:21:48 +0200

Brian Leung <bkleung89 <at> gmail.com> writes:

> If you move to the live with the <div> and call M-x comment-line, the
> line is commented out with two forward slashes, instead of the proper
>
> {{/* <div>Hello</div> */}}

I know nothing about JSX, but googling for three seconds seems to say
that the comment syntax is

{/* <div>Hello</div> */}

?  In any case, I've now made js-jsx-mode comment lines in this way if
inside a JSX block.  But like I said, I don't really know the language,
so it'd be nice if somebody else gave it a look-over.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.