GNU bug report logs - #41718
[PATCH] Update StumpWM Contrib Package Names and Add New Ones

Previous Next

Package: guix-patches;

Reported by: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>

Date: Thu, 4 Jun 2020 22:46:02 UTC

Severity: normal

Tags: patch

Done: Oleg Pykhalov <go.wigust <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41718 in the body.
You can then email your comments to 41718 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#41718; Package guix-patches. (Thu, 04 Jun 2020 22:46:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Katherine Cox-Buday <cox.katherine.e <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 04 Jun 2020 22:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update StumpWM Contrib Package Names and Add New Ones
Date: Thu, 4 Jun 2020 17:44:50 -0500
[Message part 1 (text/plain, inline)]

[0006-gnu-Add-sbcl-stumpwm-kbd-layouts.patch (text/x-patch, attachment)]
[0004-gnu-Add-sbcl-stumpwm-wifi.patch (text/x-patch, attachment)]
[0002-gnu-stumpwm-Update-Contrib-Module-Package-Names.patch (text/x-patch, attachment)]
[0003-gnu-Add-sbcl-stumpwm-net.patch (text/x-patch, attachment)]
[0005-gnu-Add-sbcl-stumpwm-stumptray.patch (text/x-patch, attachment)]
[0001-gnu-Add-clx-xembed.patch (text/x-patch, attachment)]

Reply sent to Oleg Pykhalov <go.wigust <at> gmail.com>:
You have taken responsibility. (Tue, 09 Jun 2020 19:12:02 GMT) Full text and rfc822 format available.

Notification sent to Katherine Cox-Buday <cox.katherine.e <at> gmail.com>:
bug acknowledged by developer. (Tue, 09 Jun 2020 19:12:02 GMT) Full text and rfc822 format available.

Message #10 received at 41718-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Cc: 41718-done <at> debbugs.gnu.org
Subject: Re: [bug#41718] [PATCH] Update StumpWM Contrib Package Names and Add
 New Ones
Date: Tue, 09 Jun 2020 22:11:02 +0300
[Message part 1 (text/plain, inline)]
Hi.

Thank you!  I successfully tested my StumpWM config on a virtual machine
with current changes and pushed them to master.

Oleg.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#41718; Package guix-patches. (Tue, 09 Jun 2020 22:01:01 GMT) Full text and rfc822 format available.

Message #13 received at 41718-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 41718-done <at> debbugs.gnu.org, Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Subject: Re: bug#41718: [PATCH] Update StumpWM Contrib Package Names and Add
 New Ones
Date: Wed, 10 Jun 2020 00:00:39 +0200
[Message part 1 (text/plain, inline)]
Katherine, Oleg,

Thanks for the patches and testing!  I pushed a bug-fix in commit 
9bb102dc1c47275d2906a9f4e0b813e1940176d3:

+(define-public stumpish
+  (package
+    (inherit stumpwm-contrib)
+    (name "stumpish")
+    (inputs
+     `(("bash" ,bash)
+       ("rlwrap" ,rlwrap)))
+    (build-system trivial-build-system)
+    (arguments
+     '(#:modules ((guix build utils))
+       #:tests? #f

The ‘tests?’ keyword isn't understood by the trivial build system, 
and broke ‘guix pull’.

Oleg Pykhalov 写道:
> Thank you!  I successfully tested my StumpWM config on a virtual 
> machine
> with current changes and pushed them to master.

It's interesting that this didn't throw an error.  I guess the 
only way to test such things is to ‘guix pull’ yourself, which can 
be tedious and slow.

Kind regards,

T G-R
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#41718; Package guix-patches. (Tue, 09 Jun 2020 22:47:02 GMT) Full text and rfc822 format available.

Message #16 received at 41718-done <at> debbugs.gnu.org (full text, mbox):

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 41718-done <at> debbugs.gnu.org
Subject: Re: bug#41718: [PATCH] Update StumpWM Contrib Package Names and Add
 New Ones
Date: Tue, 09 Jun 2020 17:46:02 -0500
Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> The ‘tests?’ keyword isn't understood by the trivial build system, and
> broke ‘guix pull’.

Ugh. That was leftover from my own testing anyway, and was meant to be
removed. I'm sorry about that. Ironically I broke myself and I was
wondering why `guix pull` wasn't working. Serves me right!

> It's interesting that this didn't throw an error.  I guess the only
> way to test such things is to ‘guix pull’ yourself, which can be
> tedious and slow.

Yes, that's very strange... is that something that's correctable?

-- 
Katherine




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 08 Jul 2020 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 264 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.