GNU bug report logs - #41735
[PATCH 0/2] Remove X libraries from bare-bones system closure.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41735 in the body.
You can then email your comments to 41735 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <othacehe <at> gnu.org>
Subject: [PATCH 0/2] Remove X libraries from bare-bones system closure.
Date: Sat,  6 Jun 2020 11:14:28 +0200

Hello,

Here's a small serie to remove X libraries from bare-bones system closure.

Thanks,

Mathieu

Mathieu Othacehe (2):
  gnu: Add openssh-no-x.
  system: bare-bones: Remove dependency to X libraries.

 gnu/packages/ssh.scm                | 8 ++++++++
 gnu/system/examples/bare-bones.tmpl | 3 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)

-- 
2.26.2

Message #8 received at 41735 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: 41735 <at> debbugs.gnu.org
Cc: Mathieu Othacehe <othacehe <at> gnu.org>
Subject: [PATCH 1/2] gnu: Add openssh-no-x.
Date: Sat,  6 Jun 2020 11:15:51 +0200

* gnu/packages/ssh.scm (openssh-no-x): New variable.
---
 gnu/packages/ssh.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
index 73841db6b5..13cf305695 100644
--- a/gnu/packages/ssh.scm
+++ b/gnu/packages/ssh.scm
@@ -239,6 +239,14 @@ Additionally, various channel-specific options can be negotiated.")
                                "See LICENSE in the distribution."))
    (home-page "https://www.openssh.com/")))
 
+;; OpenSSH without X support. This allows to use OpenSSH without dragging X
+;; libraries to the closure.
+(define-public openssh-no-x
+  (package
+    (inherit openssh)
+    (name "openssh-no-x")
+    (inputs (alist-delete "xauth" (package-inputs openssh)))))
+
 (define-public guile-ssh
   (package
     (name "guile-ssh")
-- 
2.26.2

Message #11 received at 41735 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: 41735 <at> debbugs.gnu.org
Cc: Mathieu Othacehe <othacehe <at> gnu.org>
Subject: [PATCH 2/2] system: bare-bones: Remove dependency to X libraries.
Date: Sat,  6 Jun 2020 11:15:52 +0200

Use "openssh-no-x" to prevent the inclusion of X libraries to the bare-bones
system closure.

* gnu/system/examples/bare-bones.tmpl (operating-system)[services]: Use
openssh-no-x instead of openssh.
---
 gnu/system/examples/bare-bones.tmpl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/system/examples/bare-bones.tmpl b/gnu/system/examples/bare-bones.tmpl
index 4f30a5b756..deed3c6c7a 100644
--- a/gnu/system/examples/bare-bones.tmpl
+++ b/gnu/system/examples/bare-bones.tmpl
@@ -3,7 +3,7 @@
 
 (use-modules (gnu))
 (use-service-modules networking ssh)
-(use-package-modules screen)
+(use-package-modules screen ssh)
 
 (operating-system
   (host-name "komputilo")
@@ -46,5 +46,6 @@
   (services (append (list (service dhcp-client-service-type)
                           (service openssh-service-type
                                    (openssh-configuration
+                                    (openssh openssh-no-x)
                                     (port-number 2222))))
                     %base-services)))
-- 
2.26.2

Message #14 received at 41735 <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>, 41735 <at> debbugs.gnu.org
Subject: Re: [bug#41735] [PATCH 1/2] gnu: Add openssh-no-x.
Date: Sat, 06 Jun 2020 12:00:46 +0200

Mathieu Othacehe writes:

Hello!

> * gnu/packages/ssh.scm (openssh-no-x): New variable.
[..]
> diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
[..]
> +;; OpenSSH without X support. This allows to use OpenSSH without dragging X
> +;; libraries to the closure.
> +(define-public openssh-no-x
> +  (package
> +    (inherit openssh)
> +    (name "openssh-no-x")
> +    (inputs (alist-delete "xauth" (package-inputs openssh)))))

I like it!  Maybe use -sans-x?

Two remarks: after merging, we may want to use openssh-no-x for the Hurd
too and drop this from openssh proper:

             ,@(if (hurd-target?)
                   '()
                   `(("xauth" ,xauth)))))         ; for 'ssh -X' and 'ssh -Y'

We have this bit because xauth does not compile for the Hurd yet,
but it's kind of a kludge.

Not to hold this up and maybe we should take this discussion
elsewhere...but I have a ~5y old, bit-rotting stack of LilyPond cross
build packages (foo-SANS-X) laying around.  At the time--much to my
suprise--I found the LilyPond community less than enthousiastic to move
their binary package builds to Guix (yet); but adding these -NO-X
packages felt a bit weird.  So, I wonder if we could address the X'yness
of packages in a more structured way, that would be nice...

Greetings,
Janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Message #17 received at 41735 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>, 41735 <at> debbugs.gnu.org
Cc: Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: [bug#41735] [PATCH 1/2] gnu: Add openssh-no-x.
Date: Sat, 06 Jun 2020 14:40:46 +0200

[Message part 1 (text/plain, inline)]

Mathieu Othacehe <m.othacehe <at> gmail.com> writes:

> * gnu/packages/ssh.scm (openssh-no-x): New variable.
> ---
>  gnu/packages/ssh.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
> index 73841db6b5..13cf305695 100644
> --- a/gnu/packages/ssh.scm
> +++ b/gnu/packages/ssh.scm
> @@ -239,6 +239,14 @@ Additionally, various channel-specific options can be negotiated.")
>                                 "See LICENSE in the distribution."))
>     (home-page "https://www.openssh.com/")))
>  
> +;; OpenSSH without X support. This allows to use OpenSSH without dragging X
> +;; libraries to the closure.
> +(define-public openssh-no-x
> +  (package
> +    (inherit openssh)
> +    (name "openssh-no-x")
> +    (inputs (alist-delete "xauth" (package-inputs openssh)))))

Maybe add a synopsis so users don't have to guess what this package
does.  I.e. (synopsis "OpenSSH client and server without X11 support").

I also think 'openssh-sans-x' is better, and is already a fairly common
convention.  :-)

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 41735-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Marius Bakke <marius <at> gnu.org>
Cc: 41735-done <at> debbugs.gnu.org
Subject: Re: [bug#41735] [PATCH 1/2] gnu: Add openssh-no-x.
Date: Mon, 08 Jun 2020 11:23:57 +0200

Hello Marius,

> Maybe add a synopsis so users don't have to guess what this package
> does.  I.e. (synopsis "OpenSSH client and server without X11 support").
>
> I also think 'openssh-sans-x' is better, and is already a fairly common
> convention.  :-)

Fixed and pushed,

Thanks,

Mathieu

Message #25 received at 41735 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>
Cc: 41735 <at> debbugs.gnu.org
Subject: Re: [bug#41735] [PATCH 1/2] gnu: Add openssh-no-x.
Date: Mon, 08 Jun 2020 11:27:01 +0200

Hey Jan,

> Two remarks: after merging, we may want to use openssh-no-x for the Hurd
> too and drop this from openssh proper:
>
>              ,@(if (hurd-target?)
>                    '()
>                    `(("xauth" ,xauth)))))         ; for 'ssh -X' and 'ssh -Y'
>
> We have this bit because xauth does not compile for the Hurd yet,
> but it's kind of a kludge.

I just did push the serie, so I think you could maybe adapt the openssh
package used by the Hurd and remove the snippet above, if it's ok for
you?

> Not to hold this up and maybe we should take this discussion
> elsewhere...but I have a ~5y old, bit-rotting stack of LilyPond cross
> build packages (foo-SANS-X) laying around.  At the time--much to my
> suprise--I found the LilyPond community less than enthousiastic to move
> their binary package builds to Guix (yet); but adding these -NO-X
> packages felt a bit weird.  So, I wonder if we could address the X'yness
> of packages in a more structured way, that would be nice...

Yes I share your concerns on that one, sadly I don't have much better to
propose, and I think it's important to have a bare-bones template as
minimal as possible. Anyway, this is not a big hack and it will be easy
to revert it if we find a better way.

Thanks,

Mathieu

Message #28 received at 41735 <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 41735 <at> debbugs.gnu.org
Subject: Re: [bug#41735] [PATCH 1/2] gnu: Add openssh-no-x.
Date: Mon, 08 Jun 2020 15:19:11 +0200

Mathieu Othacehe writes:

Hi Mathieu,

> I just did push the serie, so I think you could maybe adapt the openssh
> package used by the Hurd and remove the snippet above, if it's ok for
> you?

Yes, sure; I'm right on it.

I just sent my final patch set for wip-hurd-vm, still using plain
"openssh" -- will create an and test updated patch.

>> Not to hold this up and maybe we should take this discussion
>> elsewhere...but I have a ~5y old, bit-rotting stack of LilyPond cross
>> build packages (foo-SANS-X) laying around.  At the time--much to my
>> suprise--I found the LilyPond community less than enthousiastic to move
>> their binary package builds to Guix (yet); but adding these -NO-X
>> packages felt a bit weird.  So, I wonder if we could address the X'yness
>> of packages in a more structured way, that would be nice...
>
> Yes I share your concerns on that one, sadly I don't have much better to
> propose, and I think it's important to have a bare-bones template as
> minimal as possible. Anyway, this is not a big hack and it will be easy
> to revert it if we find a better way.

Okay...I'm sure this will come around another time.

Janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.