GNU bug report logs - #41769
[PATCH] system: Fix typo that breaks grub.cfg generation

Previous Next

Package: guix-patches;

Reported by: Royce Strange <royball <at> disroot.org>

Date: Tue, 9 Jun 2020 01:14:01 UTC

Severity: normal

Tags: patch

Done: maxim.cournoyer <at> gmail.com

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41769 in the body.
You can then email your comments to 41769 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#41769; Package guix-patches. (Tue, 09 Jun 2020 01:14:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Royce Strange <royball <at> disroot.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 09 Jun 2020 01:14:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Royce Strange <royball <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] system: Fix typo that breaks grub.cfg generation
Date: Mon,  8 Jun 2020 20:12:24 -0500
* gnu/system.scm (boot-parameters->menu-entry):
Delete quote to evalutate and get kernel boot parameters.
---
 gnu/system.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/system.scm b/gnu/system.scm
index 21d0fbd190..081e0f2fb3 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -400,7 +400,7 @@ The object has its kernel-arguments extended in order to make it bootable."
      (device (boot-parameters-store-device conf))
      (device-mount-point (boot-parameters-store-mount-point conf))
      (linux (and (not multiboot?) kernel))
-     (linux-arguments (if (not multiboot?) '
+     (linux-arguments (if (not multiboot?)
                           (boot-parameters-kernel-arguments conf)
                           '()))
      (initrd (boot-parameters-initrd conf))
-- 
2.26.2





Reply sent to maxim.cournoyer <at> gmail.com:
You have taken responsibility. (Tue, 09 Jun 2020 05:31:02 GMT) Full text and rfc822 format available.

Notification sent to Royce Strange <royball <at> disroot.org>:
bug acknowledged by developer. (Tue, 09 Jun 2020 05:31:02 GMT) Full text and rfc822 format available.

Message #10 received at 41769-done <at> debbugs.gnu.org (full text, mbox):

From: maxim.cournoyer <at> gmail.com
To: Royce Strange <royball <at> disroot.org>
Cc: 41769-done <at> debbugs.gnu.org
Subject: Re: [bug#41769] [PATCH] system: Fix typo that breaks grub.cfg
 generation
Date: Tue, 09 Jun 2020 01:30:10 -0400
Royce Strange <royball <at> disroot.org> writes:

> * gnu/system.scm (boot-parameters->menu-entry):
> Delete quote to evalutate and get kernel boot parameters.
> ---
>  gnu/system.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/system.scm b/gnu/system.scm
> index 21d0fbd190..081e0f2fb3 100644
> --- a/gnu/system.scm
> +++ b/gnu/system.scm
> @@ -400,7 +400,7 @@ The object has its kernel-arguments extended in order to make it bootable."
>       (device (boot-parameters-store-device conf))
>       (device-mount-point (boot-parameters-store-mount-point conf))
>       (linux (and (not multiboot?) kernel))
> -     (linux-arguments (if (not multiboot?) '
> +     (linux-arguments (if (not multiboot?)
>                            (boot-parameters-kernel-arguments conf)
>                            '()))
>       (initrd (boot-parameters-initrd conf))

Pushed, thank you!

Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 07 Jul 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 265 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.