GNU bug report logs - #41845
[PATCH] tests: lint: Add origin patch file name test cases.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41845 in the body.
You can then email your comments to 41845 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chris Marusich <cmmarusich <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: guix-patches <at> gnu.org
Subject: [PATCH] tests: lint: Add origin patch file name test cases.
Date: Sat, 13 Jun 2020 22:34:11 -0700

[Message part 1 (text/plain, inline)]

Hi Ludo and others,

Here's a patch to add some missing lint test cases.  I confirmed that
all the lint tests pass.  I also confirmed that the new "<origin>
patches: same file name -> no warnings" test case fails (as expected)
when commit 21887021b9acf60157b1b0a39c16f2ec6498021b is reverted, so the
new tests do seem to be working as intended.

Thank you for encouraging me to add these test cases, Ludo!

-- 
Chris

[0001-tests-lint-Add-origin-patch-file-name-test-cases.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 41845 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: 41845 <at> debbugs.gnu.org
Subject: Re: [bug#41845] [PATCH] tests: lint: Add origin patch file name test
 cases.
Date: Sun, 14 Jun 2020 22:45:09 +0200

Hi Chris,

Chris Marusich <cmmarusich <at> gmail.com> skribis:

> From 5fa2156f8561afb87d7f9a63de0243334e9da53b Mon Sep 17 00:00:00 2001
> From: Chris Marusich <cmmarusich <at> gmail.com>
> Date: Sat, 13 Jun 2020 22:09:46 -0700
> Subject: [PATCH] tests: lint: Add origin patch file name test cases.
>
> In particular, "<origin> patches: same file name -> no warnings" would
> have caught the issue which was fixed in commit
> 21887021b9acf60157b1b0a39c16f2ec6498021b.
>
> * tests/lint.scm (patches: file names): Rename this test case...
> ("file patches: different file name -> warning"): ... to this.
> ("file patches: same file name -> no warnings")
> ("<origin> patches: different file name -> warning")
> ("<origin> patches: same file name -> no warnings"): New test cases.

LGTM.  Thanks for taking the time to write these tests!

Ludo’.

Message #13 received at 41845-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: 41845-done <at> debbugs.gnu.org
Subject: Re: [bug#41845] [PATCH] tests: lint: Add origin patch file name
 test cases.
Date: Mon, 07 Dec 2020 12:50:47 +0100

Hi Chris,

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Chris Marusich <cmmarusich <at> gmail.com> skribis:
>
>> From 5fa2156f8561afb87d7f9a63de0243334e9da53b Mon Sep 17 00:00:00 2001
>> From: Chris Marusich <cmmarusich <at> gmail.com>
>> Date: Sat, 13 Jun 2020 22:09:46 -0700
>> Subject: [PATCH] tests: lint: Add origin patch file name test cases.
>>
>> In particular, "<origin> patches: same file name -> no warnings" would
>> have caught the issue which was fixed in commit
>> 21887021b9acf60157b1b0a39c16f2ec6498021b.
>>
>> * tests/lint.scm (patches: file names): Rename this test case...
>> ("file patches: different file name -> warning"): ... to this.
>> ("file patches: same file name -> no warnings")
>> ("<origin> patches: different file name -> warning")
>> ("<origin> patches: same file name -> no warnings"): New test cases.
>
> LGTM.  Thanks for taking the time to write these tests!

I went ahead and pushed it as d8ae7852057d5c1818c9c8bb77e8c41407a0d985.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.