GNU bug report logs - #41849
[PATCH] Add frozen-bubble

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41849 in the body.
You can then email your comments to 41849 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add frozen-bubble
Date: Sun, 14 Jun 2020 14:26:41 +0200

[Message part 1 (text/plain, inline)]

Hello,

These three patches add perl-alien-sdl, perl-sdl, and, ultimately,
frozen-bubble.

Feedback welcome,

Regards,
-- 
Nicolas Goaziou

[0001-gnu-Add-perl-alien-sdl.patch (text/x-diff, attachment)]

[0002-gnu-Add-perl-sdl.patch (text/x-diff, attachment)]

[0003-gnu-Add-frozen-bubble.patch (text/x-diff, attachment)]

Message #8 received at 41849 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 41849 <at> debbugs.gnu.org
Subject: Re: [bug#41849] [PATCH] Add frozen-bubble
Date: Wed, 17 Jun 2020 11:35:08 +0200

Hi,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

>>From 2586c90f5a25985bd02b0ea5bc65c5fc982b50d8 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
> Date: Sun, 14 Jun 2020 11:50:43 +0200
> Subject: [PATCH 1/3] gnu: Add perl-alien-sdl.
>
> * gnu/packages/perl.scm (perl-alien-sdl): New variable.

LGTM.

>>From 64744949f1d80b40317d942807b871f3c3f0f490 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
> Date: Sun, 14 Jun 2020 12:44:28 +0200
> Subject: [PATCH 2/3] gnu: Add perl-sdl.
>
> * gnu/packages/perl.scm (perl-sdl): New variable.

LGTM.

>>From 6ff230c8ec69cdc21d6b8148b54f170b3fd859e9 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
> Date: Sun, 14 Jun 2020 12:50:34 +0200
> Subject: [PATCH 3/3] gnu: Add frozen-bubble.
>
> * gnu/packages/games.scm (frozen-bubble): New variable.

[...]

> +(define-public frozen-bubble
> +  (let ((commit "d6a029110ad6ab9e4960052e175addc98807fb7e")
> +        (revision "1"))

Please add a comment stating why we’re pick this revision.

> +           (add-after 'unpack 'fix-permissions
> +             (lambda _ (invoke "chmod" "-R" "+w" "server")))

How about: (for-each make-file-writable
                     (find-files "servers" "." #:directories? #t))

Otherwise LGTM.

I can’t wait to try it again, so many years later.  :-)

Thanks!

Ludo’.

Message #13 received at 41849-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41849-done <at> debbugs.gnu.org
Subject: Re: [bug#41849] [PATCH] Add frozen-bubble
Date: Wed, 17 Jun 2020 12:05:23 +0200

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Please add a comment stating why we’re pick this revision.

Done.

>> +           (add-after 'unpack 'fix-permissions
>> +             (lambda _ (invoke "chmod" "-R" "+w" "server")))
>
> How about: (for-each make-file-writable
>                      (find-files "servers" "." #:directories? #t))

OK.

I also removed the #:module-build-flags argument in frozen-bubble
package, as it didn't seem to be necessary, and I was not sure why I had
added it in the first place.

> I can’t wait to try it again, so many years later.  :-)

Heh.

Thank you for the review. I pushed the changes.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.