GNU bug report logs - #41950
gnu: Add poke.

Previous Next

Package: guix-patches;

Reported by: elaexuotee <at> wilsonb.com

Date: Fri, 19 Jun 2020 14:18:02 UTC

Severity: normal

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41950 in the body.
You can then email your comments to 41950 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#41950; Package guix-patches. (Fri, 19 Jun 2020 14:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to elaexuotee <at> wilsonb.com:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 19 Jun 2020 14:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: elaexuotee <at> wilsonb.com
To: guix-patches <at> gnu.org
Subject: gnu: Add poke.
Date: Fri, 19 Jun 2020 23:17:13 +0900
[Message part 1 (text/plain, inline)]
This was recently announced on one of the mailing lists. There aren't any
tagged releases yet, but I got it packaged up with the latest commit.

It ended up taking quite a bit of patching to get working, but luckily I was
able to work closely with upstream and they merged these in.

Anyway, I am still somewhat new to packaging, so let me know if I missed
anything obvious.

Cheers,

[0001-gnu-Add-poke.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Sun, 21 Jun 2020 09:09:01 GMT) Full text and rfc822 format available.

Notification sent to elaexuotee <at> wilsonb.com:
bug acknowledged by developer. (Sun, 21 Jun 2020 09:09:02 GMT) Full text and rfc822 format available.

Message #10 received at 41950-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: elaexuotee <at> wilsonb.com
Cc: 41950-done <at> debbugs.gnu.org
Subject: Re: [bug#41950] gnu: Add poke.
Date: Sun, 21 Jun 2020 11:08:43 +0200
Hey,

> Anyway, I am still somewhat new to packaging, so let me know if I missed
> anything obvious.

No, everything looks fine :) I fixed a small indentation mistake and
pushed!

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#41950; Package guix-patches. (Mon, 22 Jun 2020 02:46:01 GMT) Full text and rfc822 format available.

Message #13 received at 41950-done <at> debbugs.gnu.org (full text, mbox):

From: elaexuotee <at> wilsonb.com
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 41950-done <at> debbugs.gnu.org
Subject: Re: [bug#41950] gnu: Add poke.
Date: Mon, 22 Jun 2020 11:45:28 +0900
[Message part 1 (text/plain, inline)]
Awesome. Thanks for merging this.

By the way, that indentation was intentional. The form that etc/indent-code.el
wants is kind of awkward in this case:

    (invoke "./bootstrap" "--no-git"
            "--no-bootstrap-sync"
            "--gnulib-srcdir=gnulib")

I think it makes more sense to line up *command options* rather than the
arguments to `invoke'. This is what I originally had:

    (invoke "./bootstrap" "--no-git"
                          "--no-bootstrap-sync"
                          "--gnulib-srcdir=gnulib")

Does this make sense? For future reference, is there a better way to format
this that also plays well with indent-code.el?

Mathieu Othacehe <othacehe <at> gnu.org> wrote:
> 
> Hey,
> 
> > Anyway, I am still somewhat new to packaging, so let me know if I missed
> > anything obvious.
> 
> No, everything looks fine :) I fixed a small indentation mistake and
> pushed!
> 
> Thanks,
> 
> Mathieu


[signature.asc (application/pgp-signature, attachment)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 20 Jul 2020 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 251 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.