GNU bug report logs - #42024
[PATCH] nix: Tweak .gitignore files.

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Tue, 23 Jun 2020 17:28:01 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42024 in the body.
You can then email your comments to 42024 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#42024; Package guix-patches. (Tue, 23 Jun 2020 17:28:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Christopher Baines <mail <at> cbaines.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 23 Jun 2020 17:28:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] nix: Tweak .gitignore files.
Date: Tue, 23 Jun 2020 18:27:17 +0100
Remove .gitignore entries where they match source files that are tracked in
Git.  This is relevant to me at least, as some code searching tools use
.gitignore files and will ignore matched files.

* nix/boost/.gitignore: Delete this file.
* nix/libutils/.gitignore: Delete this file.
* nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
(/schema.sql.hh): New entry.
---
 nix/boost/.gitignore    | 3 ---
 nix/libstore/.gitignore | 3 +--
 nix/libutil/.gitignore  | 2 --
 3 files changed, 1 insertion(+), 7 deletions(-)
 delete mode 100644 nix/boost/.gitignore
 delete mode 100644 nix/libutil/.gitignore

diff --git a/nix/boost/.gitignore b/nix/boost/.gitignore
deleted file mode 100644
index 1f188e3b65..0000000000
--- a/nix/boost/.gitignore
+++ /dev/null
@@ -1,3 +0,0 @@
-*.hpp
-*.cpp
-*.cc
diff --git a/nix/libstore/.gitignore b/nix/libstore/.gitignore
index 512a0d022f..805301d6d7 100644
--- a/nix/libstore/.gitignore
+++ b/nix/libstore/.gitignore
@@ -1,3 +1,2 @@
-*.cc
-*.hh
 /schema.sql
+/schema.sql.hh
diff --git a/nix/libutil/.gitignore b/nix/libutil/.gitignore
deleted file mode 100644
index e539428b1b..0000000000
--- a/nix/libutil/.gitignore
+++ /dev/null
@@ -1,2 +0,0 @@
-*.cc
-*.hh
-- 
2.26.2





Information forwarded to guix-patches <at> gnu.org:
bug#42024; Package guix-patches. (Tue, 23 Jun 2020 21:15:02 GMT) Full text and rfc822 format available.

Message #8 received at 42024 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 42024 <at> debbugs.gnu.org
Subject: Re: [bug#42024] [PATCH] nix: Tweak .gitignore files.
Date: Tue, 23 Jun 2020 23:14:30 +0200
Christopher Baines <mail <at> cbaines.net> skribis:

> Remove .gitignore entries where they match source files that are tracked in
> Git.  This is relevant to me at least, as some code searching tools use
> .gitignore files and will ignore matched files.
>
> * nix/boost/.gitignore: Delete this file.
> * nix/libutils/.gitignore: Delete this file.
> * nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
> (/schema.sql.hh): New entry.

LGTM!  I don’t know what the rationale was.

BTW, no need to bother with ChangeLog entries for this.

Ludo’.




Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Wed, 24 Jun 2020 19:01:01 GMT) Full text and rfc822 format available.

Notification sent to Christopher Baines <mail <at> cbaines.net>:
bug acknowledged by developer. (Wed, 24 Jun 2020 19:01:01 GMT) Full text and rfc822 format available.

Message #13 received at 42024-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 42024-done <at> debbugs.gnu.org
Subject: Re: [bug#42024] [PATCH] nix: Tweak .gitignore files.
Date: Wed, 24 Jun 2020 20:00:18 +0100
[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Remove .gitignore entries where they match source files that are tracked in
>> Git.  This is relevant to me at least, as some code searching tools use
>> .gitignore files and will ignore matched files.
>>
>> * nix/boost/.gitignore: Delete this file.
>> * nix/libutils/.gitignore: Delete this file.
>> * nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
>> (/schema.sql.hh): New entry.
>
> LGTM!  I don’t know what the rationale was.
>
> BTW, no need to bother with ChangeLog entries for this.

Great, I've removed the ChangeLog entries and pushed this as
cd43b55da7ab51c996a7a3449c78f2a493616106.

Thanks,

Chris
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 23 Jul 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 249 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.