GNU bug report logs - #42097
[PATCH] gnu: artanis: Use guile2.2 version of guile-redis.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42097 in the body.
You can then email your comments to 42097 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Masaya Tojo <masaya <at> tojo.tokyo>
To: guix-patches <at> gnu.org
Cc: Masaya Tojo <masaya <at> tojo.tokyo>
Subject: [PATCH] gnu: artanis: Use guile2.2 version of guile-redis.
Date: Sun, 28 Jun 2020 07:42:03 +0900

* gnu/packages/guile-xyz.scm (artanis)[propagated-inputs]: Change from
guile-redis to guile2.2-redis.
---
 gnu/packages/guile-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index f8e59b0b21..5416b30c2e 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -28,6 +28,7 @@
 ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
 ;;; Copyright © 2020 Julien Lepiler <julien <at> lepiller.eu>
 ;;; Copyright © 2020 Marius Bakke <marius <at> gnu.org>
+;;; Copyright © 2020 Masaya Tojo <masaya <at> tojo.tokyo>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -157,7 +158,7 @@
     (propagated-inputs
      `(("guile-json" ,guile-json-1)
        ("guile-readline" ,guile2.2-readline)
-       ("guile-redis" ,guile-redis)))
+       ("guile-redis" ,guile2.2-redis)))
     (native-inputs
      `(("bash"       ,bash)         ;for the `source' builtin
        ("pkgconfig"  ,pkg-config)
-- 
2.26.2

Message #8 received at 42097 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Masaya Tojo <masaya <at> tojo.tokyo>
Cc: 42097 <at> debbugs.gnu.org
Subject: Re: [bug#42097] [PATCH] gnu: artanis: Use guile2.2 version of
 guile-redis.
Date: Sun, 28 Jun 2020 10:56:38 +0300

[Message part 1 (text/plain, inline)]

On Sun, Jun 28, 2020 at 07:42:03AM +0900, Masaya Tojo wrote:
> * gnu/packages/guile-xyz.scm (artanis)[propagated-inputs]: Change from
> guile-redis to guile2.2-redis.
> ---
>  gnu/packages/guile-xyz.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index f8e59b0b21..5416b30c2e 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -28,6 +28,7 @@
>  ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
>  ;;; Copyright © 2020 Julien Lepiler <julien <at> lepiller.eu>
>  ;;; Copyright © 2020 Marius Bakke <marius <at> gnu.org>
> +;;; Copyright © 2020 Masaya Tojo <masaya <at> tojo.tokyo>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -157,7 +158,7 @@
>      (propagated-inputs
>       `(("guile-json" ,guile-json-1)
>         ("guile-readline" ,guile2.2-readline)
> -       ("guile-redis" ,guile-redis)))
> +       ("guile-redis" ,guile2.2-redis)))
>      (native-inputs
>       `(("bash"       ,bash)         ;for the `source' builtin
>         ("pkgconfig"  ,pkg-config)
> -- 
> 2.26.2
> 

Should guile-json-1 be switched to guile2.2-json-1 also?

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 42097 <at> debbugs.gnu.org (full text, mbox):

From: Masaya Tojo <masaya <at> tojo.tokyo>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 42097 <at> debbugs.gnu.org
Subject: Re: [bug#42097] [PATCH] gnu: artanis: Use guile2.2 version of
 guile-redis.
Date: Sun, 28 Jun 2020 19:58:37 +0900

Hello,

Thank you for reviewing my patch.

> Should guile-json-1 be switched to guile2.2-json-1 also?

Guile-json-1 seem version of guile2.2. I search for guile2.2-json-1, but it
does not exist yet.

So, I think that it's not necessary.

Regards,

Message #16 received at 42097-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Masaya Tojo <masaya <at> tojo.tokyo>
Cc: 42097-done <at> debbugs.gnu.org
Subject: Re: [bug#42097] [PATCH] gnu: artanis: Use guile2.2 version of
 guile-redis.
Date: Mon, 29 Jun 2020 09:21:26 +0300

[Message part 1 (text/plain, inline)]

On Sun, Jun 28, 2020 at 07:58:37PM +0900, Masaya Tojo wrote:
> 
> Hello,
> 
> Thank you for reviewing my patch.
> 
> > Should guile-json-1 be switched to guile2.2-json-1 also?
> 
> Guile-json-1 seem version of guile2.2. I search for guile2.2-json-1, but it
> does not exist yet.
> 
> So, I think that it's not necessary.
> 

Agreed. I added a comment mentioning that guile-json-1 was already using
guile-2.2 so no one else gets confused and pushed the patch. Thanks!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.