GNU bug report logs - #42112
27.0.91; whitespace-empty face not extended beyond EOL

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42112 in the body.
You can then email your comments to 42112 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.91; whitespace-empty face not extended beyond EOL
Date: Sun, 28 Jun 2020 17:41:48 +0100

Severity: minor

Steps to reproduce:

0. emacs -Q
1. M-x whitespace-mode RET
2. M-<

In Emacs 26, line 3 is highlighted with the whitespace-empty face all
the way to the right fringe.

In Emacs 27, only the first two columns of line 3 are highlighted with
the whitespace-empty face.

Is this TRT?  Should whitespace-empty get an ':extend t' attribute or
inherit from some other face which already has that?

Thanks,

-- 
Basil

In GNU Emacs 27.0.91 (build 23, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2020-06-28 built on thunk
Repository revision: cce00bef0313bc42beee8096d9312313889dc92d
Repository branch: emacs-27
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux bullseye/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O0 -g3 -ggdb -gdwarf-4'
 --config-cache --prefix=/home/blc/.local --program-suffix=27
 --enable-checking=yes,glyphs --enable-check-lisp-object-type
 --with-x-toolkit=lucid --with-file-notification=yes --with-x'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF
XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS
LIBSYSTEMD JSON PDUMPER LCMS2 GMP

Message #8 received at 42112 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 42112 <at> debbugs.gnu.org
Subject: Re: bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL
Date: Sun, 28 Jun 2020 19:54:10 +0300

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Date: Sun, 28 Jun 2020 17:41:48 +0100
> 
> 0. emacs -Q
> 1. M-x whitespace-mode RET
> 2. M-<
> 
> In Emacs 26, line 3 is highlighted with the whitespace-empty face all
> the way to the right fringe.
> 
> In Emacs 27, only the first two columns of line 3 are highlighted with
> the whitespace-empty face.
> 
> Is this TRT?

I don't know: I don't use this mode.

> Should whitespace-empty get an ':extend t' attribute or inherit from
> some other face which already has that?

If we want the empty lines to be shown in this face in their entirety,
then it should have the :extend attribute, yes.  Just make sure it
looks OK with underline and other non-color attributes.

Message #11 received at 42112 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42112 <at> debbugs.gnu.org
Subject: Re: bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL
Date: Sun, 28 Jun 2020 18:34:56 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
>> Date: Sun, 28 Jun 2020 17:41:48 +0100
>> 
>> 0. emacs -Q
>> 1. M-x whitespace-mode RET
>> 2. M-<
>> 
>> In Emacs 26, line 3 is highlighted with the whitespace-empty face all
>> the way to the right fringe.
>> 
>> In Emacs 27, only the first two columns of line 3 are highlighted with
>> the whitespace-empty face.
>> 
>> Is this TRT?
>
> I don't know: I don't use this mode.

I do, but I'm not sure what constitutes correct behaviour.  I guess the
Emacs 26 behaviour is how the feature was designed and what users have
come to expect, in which case Emacs 27 exhibits a regression.

>> Should whitespace-empty get an ':extend t' attribute or inherit from
>> some other face which already has that?
>
> If we want the empty lines to be shown in this face in their entirety,
> then it should have the :extend attribute, yes.

Is there any practical difference or preference between giving
whitespace-empty an :extend attribute vs making it inherit from a face
with an :extend attribute?

> Just make sure it looks OK with underline and other non-color
> attributes.

Will do in about a week's time if no-one beats me to it.

Thanks,

-- 
Basil

Message #14 received at 42112 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 42112 <at> debbugs.gnu.org
Subject: Re: bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL
Date: Sun, 28 Jun 2020 21:17:19 +0300

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Cc: 42112 <at> debbugs.gnu.org
> Date: Sun, 28 Jun 2020 18:34:56 +0100
> 
> Is there any practical difference or preference between giving
> whitespace-empty an :extend attribute vs making it inherit from a face
> with an :extend attribute?

Inheritance makes display slightly slower (due to the need to chase
the inheritance chain).  And frankly I don't see why we would need to
use inheritance here in the first place.

Message #17 received at 42112 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 42112 <at> debbugs.gnu.org
Subject: Re: bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL
Date: Sat, 31 Jul 2021 16:53:02 +0200

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> In Emacs 26, line 3 is highlighted with the whitespace-empty face all
> the way to the right fringe.

I've now restored this in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.