GNU bug report logs - #42155
--with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42155 in the body.
You can then email your comments to 42155 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pkill9 <pkill9 <at> runbox.com>
To: bug-guix <at> gnu.org
Subject: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively
Date: Wed, 1 Jul 2020 17:53:31 +0100

For example, `guix build --with-source=youtube-dl=blahblah mpv` builds
mpv normally, after giving a message: guix build: warning:
transformation 'with-source' had no effect on mpv <at> 0.32.0

Message #8 received at 42155 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: pkill9 <pkill9 <at> runbox.com>
Cc: 42155 <at> debbugs.gnu.org
Subject: Re: bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work
 recursively
Date: Thu, 2 Jul 2020 10:12:06 +0300

[Message part 1 (text/plain, inline)]

On Wed, Jul 01, 2020 at 05:53:31PM +0100, pkill9 wrote:
> For example, `guix build --with-source=youtube-dl=blahblah mpv` builds
> mpv normally, after giving a message: guix build: warning:
> transformation 'with-source' had no effect on mpv <at> 0.32.0
> 

From 'guix build --help:'
      --with-source=SOURCE
                         use SOURCE when building the corresponding package
      --with-input=PACKAGE=REPLACEMENT
                         replace dependency PACKAGE by REPLACEMENT

I think what you're looking for is more of:

guix build --no-grafts mpv --with-input=youtube-dl=$(guix build --no-grafts youtube-dl --with-source=https://github.com/ytdl-org/youtube-dl/releases/download/2020.06.16/youtube-dl-2020.06.16.tar.gz)

This didn't work for me though, I got:
guix build: error: /gnu/store/9ncacjhzwlchpr1y5fd8ahdq59dsya20-youtube-dl-2020.06.16: unknown package

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 42155 <at> debbugs.gnu.org (full text, mbox):

From: pkill9 <pkill9 <at> runbox.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 42155 <at> debbugs.gnu.org
Subject: Re: bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't
 work recursively
Date: Thu, 2 Jul 2020 18:44:07 +0100

> I think what you're looking for is more of:
> 
> guix build --no-grafts mpv --with-input=youtube-dl=$(guix build
> --no-grafts youtube-dl
> --with-source=https://github.com/ytdl-org/youtube-dl/releases/download/2020.06.16/youtube-dl-2020.06.16.tar.gz)
> 
> This didn't work for me though, I got:
> guix build: error:
> /gnu/store/9ncacjhzwlchpr1y5fd8ahdq59dsya20-youtube-dl-2020.06.16:
> unknown package

Even if that worked, it doesn't fix the issue of the --with-source flag
not working on the specified package's inputs.

That command doesn't work because you're giving it a store path, not a
package specification.

Message #14 received at 42155 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: pkill9 <pkill9 <at> runbox.com>
Cc: Efraim Flashner <efraim <at> flashner.co.il>, 42155 <at> debbugs.gnu.org
Subject: Re: bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work
 recursively
Date: Thu, 02 Jul 2020 23:59:05 +0200

pkill9 <pkill9 <at> runbox.com> skribis:

>> I think what you're looking for is more of:
>> 
>> guix build --no-grafts mpv --with-input=youtube-dl=$(guix build
>> --no-grafts youtube-dl
>> --with-source=https://github.com/ytdl-org/youtube-dl/releases/download/2020.06.16/youtube-dl-2020.06.16.tar.gz)
>> 
>> This didn't work for me though, I got:
>> guix build: error:
>> /gnu/store/9ncacjhzwlchpr1y5fd8ahdq59dsya20-youtube-dl-2020.06.16:
>> unknown package
>
> Even if that worked, it doesn't fix the issue of the --with-source flag
> not working on the specified package's inputs.

‘--with-source’ is documented to be “shallow”: unlike ‘--with-input’ &
co., it doesn’t apply recursively.

I think we should change it though.

Ludo’.

Message #17 received at 42155 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 42155 <at> debbugs.gnu.org
Subject: re: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively
Date: Thu, 27 Aug 2020 16:10:38 -0600

(In response to issue at https://issues.guix.info/issue/42155):

I want to be able to specify dependency sources, so I am working on this 
issue. It's complicated because --with-source= can take a simple source 
(implying the package being built should be built from SOURCE) or 
package=source (AIUI implying PACKAGE in the specified list of packages 
should be built from SOURCE).  Should we deprecate the current 
interpretation of "--with-source=package=source"? Or would it be better 
to preserve these options and make a new recursive 
'--with-dependency-source=package=source' option?

I'm leaning towards making the option 
"--with-dependency-source=package=source" because I think that will be 
easier to accomplish and maintain. But if anyone has a compelling reason 
to deprecate the old usage, I am willing to listen.

Message #22 received at 42155-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: pkill9 <pkill9 <at> runbox.com>, 42155-done <at> debbugs.gnu.org,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't
 work recursively
Date: Tue, 21 Feb 2023 08:18:46 -0500

Hi,

Ludovic Courtès <ludo <at> gnu.org> writes:

> pkill9 <pkill9 <at> runbox.com> skribis:
>
>>> I think what you're looking for is more of:
>>> 
>>> guix build --no-grafts mpv --with-input=youtube-dl=$(guix build
>>> --no-grafts youtube-dl
>>> --with-source=https://github.com/ytdl-org/youtube-dl/releases/download/2020.06.16/youtube-dl-2020.06.16.tar.gz)
>>> 
>>> This didn't work for me though, I got:
>>> guix build: error:
>>> /gnu/store/9ncacjhzwlchpr1y5fd8ahdq59dsya20-youtube-dl-2020.06.16:
>>> unknown package
>>
>> Even if that worked, it doesn't fix the issue of the --with-source flag
>> not working on the specified package's inputs.
>
> ‘--with-source’ is documented to be “shallow”: unlike ‘--with-input’ &
> co., it doesn’t apply recursively.
>
> I think we should change it though.

Closing, since that's been implemented per
28ade1bab207974cce6a014e7187968511fc5526 ("transformations:
'--with-source' now operates in depth.") last September.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.