GNU bug report logs - #42158
python-grequests broken, add zope dependencies to fix.

Previous Next

Package: guix;

Reported by: Christopher Lemmer Webber <cwebber <at> dustycloud.org>

Date: Wed, 1 Jul 2020 20:40:01 UTC

Severity: normal

Done: Christopher Lemmer Webber <cwebber <at> dustycloud.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42158 in the body.
You can then email your comments to 42158 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#42158; Package guix. (Wed, 01 Jul 2020 20:40:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Christopher Lemmer Webber <cwebber <at> dustycloud.org>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Wed, 01 Jul 2020 20:40:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: bug-guix <at> gnu.org
Subject: python-grequests broken, add zope dependencies to fix.
Date: Wed, 01 Jul 2020 16:39:05 -0400
[Message part 1 (text/plain, inline)]
Fix attached.  Ok to push?

[0001-gnu-python-grequests-Fix-tests-by-adding-zope-depend.patch (text/x-patch, inline)]
From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Date: Wed, 1 Jul 2020 16:36:29 -0400
Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.

* gnu/packages/python-web.scm (python-grequests): Add zope
  dependencies to native-inputs for tests.
---
 gnu/packages/python-web.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 030abef9c2..c929e254f7 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -2010,7 +2010,9 @@ library.")
      `(("python-gevent" ,python-gevent)
        ("python-requests" ,python-requests)))
     (native-inputs
-     `(("python-nose" ,python-nose)))
+     `(("python-nose" ,python-nose)
+       ("python-zope.interface" ,python-zope-interface)
+       ("python-zope.event" ,python-zope-event)))
     (home-page "https://github.com/kennethreitz/grequests")
     (synopsis "Python library for asynchronous HTTP requests")
     (description "GRequests is a Python library that allows you to use
-- 
2.26.2


Information forwarded to bug-guix <at> gnu.org:
bug#42158; Package guix. (Thu, 02 Jul 2020 07:29:02 GMT) Full text and rfc822 format available.

Message #8 received at 42158 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
Cc: 42158 <at> debbugs.gnu.org
Subject: Re: bug#42158: python-grequests broken, add zope dependencies to fix.
Date: Thu, 2 Jul 2020 10:27:33 +0300
[Message part 1 (text/plain, inline)]
On Wed, Jul 01, 2020 at 04:39:05PM -0400, Christopher Lemmer Webber wrote:
> Fix attached.  Ok to push?
> 

Looks good to me. I will note however that the test suite doesn't seem
to actually be run.

> From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
> From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
> Date: Wed, 1 Jul 2020 16:36:29 -0400
> Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.
> 
> * gnu/packages/python-web.scm (python-grequests): Add zope
>   dependencies to native-inputs for tests.

should be:

* gnu/packages/python-web.scm (python-grequests)[native-inputs]:
Add python-zope.interface, python-zope.event.


> ---
>  gnu/packages/python-web.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 030abef9c2..c929e254f7 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -2010,7 +2010,9 @@ library.")
>       `(("python-gevent" ,python-gevent)
>         ("python-requests" ,python-requests)))
>      (native-inputs
> -     `(("python-nose" ,python-nose)))
> +     `(("python-nose" ,python-nose)
> +       ("python-zope.interface" ,python-zope-interface)
> +       ("python-zope.event" ,python-zope-event)))
>      (home-page "https://github.com/kennethreitz/grequests")
>      (synopsis "Python library for asynchronous HTTP requests")
>      (description "GRequests is a Python library that allows you to use
> -- 
> 2.26.2
> 


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Reply sent to Christopher Lemmer Webber <cwebber <at> dustycloud.org>:
You have taken responsibility. (Thu, 02 Jul 2020 12:17:01 GMT) Full text and rfc822 format available.

Notification sent to Christopher Lemmer Webber <cwebber <at> dustycloud.org>:
bug acknowledged by developer. (Thu, 02 Jul 2020 12:17:02 GMT) Full text and rfc822 format available.

Message #13 received at 42158-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 42158-done <at> debbugs.gnu.org
Subject: Re: bug#42158: python-grequests broken, add zope dependencies to fix.
Date: Thu, 02 Jul 2020 08:16:37 -0400
Efraim Flashner writes:

> On Wed, Jul 01, 2020 at 04:39:05PM -0400, Christopher Lemmer Webber wrote:
>> Fix attached.  Ok to push?
>> 
>
> Looks good to me. I will note however that the test suite doesn't seem
> to actually be run.

Huh.  Well at least it's no longer breaking, which is what was happening
for me before.

>> From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
>> From: Christopher Lemmer Webber <cwebber <at> dustycloud.org>
>> Date: Wed, 1 Jul 2020 16:36:29 -0400
>> Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.
>> 
>> * gnu/packages/python-web.scm (python-grequests): Add zope
>>   dependencies to native-inputs for tests.
>
> should be:
>
> * gnu/packages/python-web.scm (python-grequests)[native-inputs]:
> Add python-zope.interface, python-zope.event.
>

Done.  Changed and pushed!

>> ---
>>  gnu/packages/python-web.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
>> index 030abef9c2..c929e254f7 100644
>> --- a/gnu/packages/python-web.scm
>> +++ b/gnu/packages/python-web.scm
>> @@ -2010,7 +2010,9 @@ library.")
>>       `(("python-gevent" ,python-gevent)
>>         ("python-requests" ,python-requests)))
>>      (native-inputs
>> -     `(("python-nose" ,python-nose)))
>> +     `(("python-nose" ,python-nose)
>> +       ("python-zope.interface" ,python-zope-interface)
>> +       ("python-zope.event" ,python-zope-event)))
>>      (home-page "https://github.com/kennethreitz/grequests")
>>      (synopsis "Python library for asynchronous HTTP requests")
>>      (description "GRequests is a Python library that allows you to use
>> -- 
>> 2.26.2
>> 





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 31 Jul 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 241 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.