GNU bug report logs - #42278
[PATCH] gnu: Add ninjas2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42278 in the body.
You can then email your comments to 42278 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add ninjas2.
Date: Wed, 08 Jul 2020 22:23:22 +0100

[Message part 1 (text/plain, inline)]

Hi,

This patch adds ninjas2 (lv2 plugin).

Thanks,
Alex

[0001-gnu-Add-ninjas2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 42278-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>, 42278-done <at> debbugs.gnu.org
Subject: Re: [bug#42278] [PATCH] gnu: Add ninjas2.
Date: Mon, 20 Jul 2020 23:57:32 +0200

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Hi,
>
> This patch adds ninjas2 (lv2 plugin).

Applied with these changes:

[diff (text/x-patch, inline)]

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 4943249705..989c65a932 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -923,17 +923,17 @@ Sega Master System/Mark III, Sega Genesis/Mega Drive, BBC Micro
         (git-reference
          (url "https://github.com/clearly-broken-software/ninjas2.git")
          (commit (string-append "v" version))
-         ;; bundles a specific commit of the DISTRHO plugin framework
+         ;; Bundles a specific commit of the DISTRHO plugin framework.
          (recursive? #t)))
        (file-name (git-file-name name version))
        (sha256
         (base32 "1kwp6pmnfar2ip9693gprfbcfscklgri1k1ycimxzlqr61nkd2k9"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #f                      ; no "check" target
+     `(#:tests? #f                      ;no tests
        #:make-flags
        (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
-             "CC=gcc")
+             (string-append "CC=" ,(cc-for-target)))
        #:phases
        (modify-phases %standard-phases
          (delete 'configure)            ;no configure target
@@ -973,7 +973,7 @@ Sega Master System/Mark III, Sega Genesis/Mega Drive, BBC Micro
     (description
      "Ninjas 2 is a rewrite of the Ninjas sample slicer audio plugin.
 Its goal is to be an easy to use sample slicer with quick slicing of samples
-and auto-mapping slices to midi note numbers.")
+and auto-mapping slices to MIDI note numbers.")
     (home-page "https://github.com/clearly-broken-software/ninjas2")
     (license license:gpl3+)))
 

[Message part 3 (text/plain, inline)]

Thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.