GNU bug report logs - #42279
[PATCH] gnu: Add distrho-ports.

Previous Next

To reply to this bug, email your comments to 42279 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add distrho-ports.
Date: Wed, 08 Jul 2020 22:27:21 +0100

[Message part 1 (text/plain, inline)]

Hi,

This patch adds distrho-ports, a collection of LV2 plugins ported from
other platforms/frameworks. 

The meson build system was recently added and not released yet (it used
an old version of premake before and failed to build on guix).

Thanks,
Alex

[0001-gnu-Add-distrho-ports.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 42279 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>, 42279 <at> debbugs.gnu.org
Subject: Re: [bug#42279] [PATCH] gnu: Add distrho-ports.
Date: Tue, 21 Jul 2020 00:07:41 +0200

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Hi,
>
> This patch adds distrho-ports, a collection of LV2 plugins ported from
> other platforms/frameworks. 
>
> The meson build system was recently added and not released yet (it used
> an old version of premake before and failed to build on guix).

[...]

> * gnu/packages/music.scm (distrho-ports): New variable.

[...]
  
> +(define-public distrho-ports
> +  ;; the previous release required a version of premake not present
> +  ;; in guix. it has now been ported to meson but not released yet

Please use capitalizations like in normal sentences, and for names such
as Guix and Meson.

Actually it seems to be released now:

https://github.com/DISTRHO/DISTRHO-Ports/releases/tag/2020-07-14

> +      (synopsis "Collection of audio plugins and LV2 ports")
> +      (description
> +       "DISTRHO is a project with the goal of making cross-platform audio
> +  plugins and GNU/Linux ports.
> +  This package includes HiReSam, LUFSMeter-Multi, LUFSMeter, Arctican Function,
> +  Arctican Pilgrim, Dexed, dRowAudio Distortion, dRowAudio Distortion Shaper,
> +  dRowAudio Flanger, dRowAudioReverb, dRowAudio Tremolo, DrumSynth, easySSP,
> +  EQuinox, JUCE Demo Plugin, JUCE OPL, Klangfalter, Luftikus, Obxd, Pitched
> +  Delay, Refine, Stereo Source Separation, TAL Dub 3, TAL Noise Maker, TAL
> +  Reverb 2, TAL Reverb 3, TAL Reverb, TAL Vocoder 2, Temper, Vex and
> +  Wolpertinger.")
> +      (home-page "http://distrho.sourceforge.net/ports")
> +      (license (list license:gpl2      ; found in doc directory
> +                     license:lgpl3+    ; found in doc directory
> +                     license:gpl3)))))  ; mentioned in meson file

This is a problem: GPL3 is famously incompatible with GPL2.  If these
plugins are licensed separately it would be good to list the license for
each and take it from there.

Even better (I think?) is to package each plugin separately.  Then users
can choose whether to combine these incompatibly-licensed plugins, but
we as a distribution can not (and probably not DISTRHO either).

Not sure what to do about it.  Ideas?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 42279 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Marius Bakke <marius <at> gnu.org>, 42279 <at> debbugs.gnu.org
Subject: Re: [bug#42279] [PATCH] gnu: Add distrho-ports.
Date: Mon, 20 Jul 2020 23:24:01 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thanks for the review.

On Tue, 2020-07-21 at 00:07 +0200, Marius Bakke wrote:
> > +  Wolpertinger.")
> > +      (home-page "http://distrho.sourceforge.net/ports")
> > +      (license (list license:gpl2      ; found in doc directory
> > +                     license:lgpl3+    ; found in doc directory
> > +                     license:gpl3)))))  ; mentioned in meson file
> 
> This is a problem: GPL3 is famously incompatible with GPL2.  If these
> plugins are licensed separately it would be good to list the license
> for
> each and take it from there.
> 
> Even better (I think?) is to package each plugin separately.  Then
> users
> can choose whether to combine these incompatibly-licensed plugins,
> but
> we as a distribution can not (and probably not DISTRHO either).
> 
> Not sure what to do about it.  Ideas?

Why is it a problem? It's only a problem if you link them together
afaik. The plugins that this project produces are all separate
binaries, each under its own license.

I think we should just list the license for each included plugin. I'm a
bit against making separate packages - it would be a pain to maintain
and the plugins don't take up much disk space.

Thanks,
Alex

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 42279 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>, 42279 <at> debbugs.gnu.org
Subject: Re: [bug#42279] [PATCH] gnu: Add distrho-ports.
Date: Tue, 21 Jul 2020 00:59:06 +0200

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Hi,
>
> Thanks for the review.
>
> On Tue, 2020-07-21 at 00:07 +0200, Marius Bakke wrote:
>> > +  Wolpertinger.")
>> > +      (home-page "http://distrho.sourceforge.net/ports")
>> > +      (license (list license:gpl2      ; found in doc directory
>> > +                     license:lgpl3+    ; found in doc directory
>> > +                     license:gpl3)))))  ; mentioned in meson file
>> 
>> This is a problem: GPL3 is famously incompatible with GPL2.  If these
>> plugins are licensed separately it would be good to list the license
>> for
>> each and take it from there.
>> 
>> Even better (I think?) is to package each plugin separately.  Then
>> users
>> can choose whether to combine these incompatibly-licensed plugins,
>> but
>> we as a distribution can not (and probably not DISTRHO either).
>> 
>> Not sure what to do about it.  Ideas?
>
> Why is it a problem? It's only a problem if you link them together
> afaik. The plugins that this project produces are all separate
> binaries, each under its own license.

Right.  If they don't share code it's probably okay.

> I think we should just list the license for each included plugin. I'm a
> bit against making separate packages - it would be a pain to maintain
> and the plugins don't take up much disk space.

Listing the license of each plugin sounds good to me.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 42279 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: 42279 <at> debbugs.gnu.org
Subject: Re: [bug#42279] [PATCH] gnu: Add distrho-ports.
Date: Mon, 04 Jan 2021 11:30:19 +0000

[Message part 1 (text/plain, inline)]

Hi,

I'm trying to build the latest version but I'm running into issues with
fonts not showing (same issues as before, I just didn't bother until
now). Attaching the current package definition.

After building, I am running the plugins like:
`LV2_PATH=/gnu/store/z2xjjfpaybyv1byal7nxrvqxd7b1hjqh-distrho-ports-
2020-12-27/lib/lv2 jalv.gtk3 urn:juce:TalFilter2`
This requires JACK to be running and jalv to be installed. I'm not sure
if there's an easier way to test.

The problem I am having is described here, with a screenshot:
https://github.com/DISTRHO/DISTRHO-Ports/issues/63

Strace log is included in that issue.

How can I fix this?

Thanks,
Alex

[paste_1179629.scm (text/x-scheme, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.