GNU bug report logs - #42281
[PATCH] gnu: Add python-buku.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42281 in the body.
You can then email your comments to 42281 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add python-buku.
Date: Wed, 08 Jul 2020 22:38:54 +0100

[Message part 1 (text/plain, inline)]

Hi,

This patch adds python-buku, a command line bookmark manager.

Thanks,
Alex

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 42281 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: 42281 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add python-buku.
Date: Wed, 08 Jul 2020 22:41:17 +0100

[Message part 1 (text/plain, inline)]

Forgot patch

[0001-gnu-Add-python-buku.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 42281 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>, 42281 <at> debbugs.gnu.org
Subject: Re: [bug#42281] [PATCH] gnu: Add python-buku.
Date: Tue, 21 Jul 2020 00:29:19 +0200

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> * gnu/packages/python-xyz.scm (python-buku): New variable.

As this seems like a general-purpose tool and not a Python library, it
would be good to place this elsewhere.  I'm not sure where though, maybe
(gnu packages web)?

Also I think the 'python-' prefix can be removed.

[...]
  
> +(define-public python-buku
> +  (package
> +    (name "python-buku")
> +    (version "4.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "buku" version))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1g1xhdskfn72xaraqzz2v8dl2iza7bzfpn17z2wdrzkq3ih7yvgg"))))
> +    (build-system python-build-system)
> +    (arguments
> +      `(#:tests? #f)) ; needs python-mypy-extensions which fails to build

Actually python-mypy-extensions seems to not be in Guix at all.  Can you
adjust the comment with a TODO?

> +    (propagated-inputs
> +      `(("python-html5lib" ,python-html5lib)
> +        ("python-urllib3" ,python-urllib3)
> +        ("python-beautifulsoup4" ,python-beautifulsoup4)
> +        ("python-pytest" ,python-pytest)
> +        ("python-pytest-cov" ,python-pytest-cov)
> +        ("python-pylint" ,python-pylint)
> +        ("python-vcrpy" ,python-vcrpy)))

These can probably be regular inputs, as python-build-system will
automatically 'wrap' the executables with these on PYTHONPATH.

> +    (home-page "https://github.com/jarun/buku")
> +    (synopsis
> +      "Bookmark manager")
> +    (description
> +      "buku is a powerful bookmark manager written in Python3 and SQLite3.")

It's a chore, but it would be great if you could expand on the
description.  Something along the lines of "@command{buku} can
auto-import bookmarks from your browser and present them in an
interactive command-line interface that lets you compose and update
bookmarks directly.  It can also present them in a web interface with
@command{bukuserver}."

Can you send an updated patch?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 42281 <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Marius Bakke <marius <at> gnu.org>, 42281 <at> debbugs.gnu.org
Subject: Re: [bug#42281] [PATCH] gnu: Add python-buku.
Date: Thu, 10 Sep 2020 16:57:53 +0100

[Message part 1 (text/plain, inline)]

Hi Marius,

On Tue, 2020-07-21 at 00:29 +0200, Marius Bakke wrote:
> As this seems like a general-purpose tool and not a Python library,
> it
> would be good to place this elsewhere.  I'm not sure where though,
> maybe
> (gnu packages web)?
> 
> Also I think the 'python-' prefix can be removed.

Done.

> > +    (arguments
> > +      `(#:tests? #f)) ; needs python-mypy-extensions which fails
> > to build
> 
> Actually python-mypy-extensions seems to not be in Guix at all.  Can
> you
> adjust the comment with a TODO?

Done.

> 
> > +    (propagated-inputs
> > +      `(("python-html5lib" ,python-html5lib)
> > +        ("python-urllib3" ,python-urllib3)
> > +        ("python-beautifulsoup4" ,python-beautifulsoup4)
> > +        ("python-pytest" ,python-pytest)
> > +        ("python-pytest-cov" ,python-pytest-cov)
> > +        ("python-pylint" ,python-pylint)
> > +        ("python-vcrpy" ,python-vcrpy)))
> 
> These can probably be regular inputs, as python-build-system will
> automatically 'wrap' the executables with these on PYTHONPATH.

Done.

> 
> > +    (home-page "https://github.com/jarun/buku")
> > +    (synopsis
> > +      "Bookmark manager")
> > +    (description
> > +      "buku is a powerful bookmark manager written in Python3 and
> > SQLite3.")
> 
> It's a chore, but it would be great if you could expand on the
> description.  Something along the lines of "@command{buku} can
> auto-import bookmarks from your browser and present them in an
> interactive command-line interface that lets you compose and update
> bookmarks directly.  It can also present them in a web interface with
> @command{bukuserver}."

Added your proposed text.

> Can you send an updated patch?

Please find the new patch attached.

Thanks,
Alex

[0001-gnu-Add-buku.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 42281-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>
Cc: 42281-done <at> debbugs.gnu.org, Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#42281] [PATCH] gnu: Add python-buku.
Date: Fri, 18 Dec 2020 15:02:02 +0100

Alexandros Theodotou <alex <at> zrythm.org> skribis:

> From 217d5661c4d76f79176d947b2376dfa89e5dcc01 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex <at> zrythm.org>
> Date: Thu, 10 Sep 2020 16:54:52 +0100
> Subject: [PATCH] gnu: Add buku.
>
> * gnu/packages/web.scm (buku): New variable.

Applied in 26f6bd0403ed20c1d26eca9d4f28a0da519a56ac, closing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.