GNU bug report logs - #42282
[PATCH] gnu: Add ttaenc.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42282 in the body.
You can then email your comments to 42282 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexandros Theodotou <alex <at> zrythm.org>
To: Guix patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add ttaenc.
Date: Wed, 08 Jul 2020 22:44:31 +0100

[Message part 1 (text/plain, inline)]

Hi,

This patch adds the TTA encoder.

Thanks,
Alex

[0001-gnu-Add-ttaenc.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 42282-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Alexandros Theodotou <alex <at> zrythm.org>, 42282-done <at> debbugs.gnu.org
Subject: Re: [bug#42282] [PATCH] gnu: Add ttaenc.
Date: Tue, 21 Jul 2020 00:40:29 +0200

[Message part 1 (text/plain, inline)]

Alexandros Theodotou <alex <at> zrythm.org> writes:

> Hi,
>
> This patch adds the TTA encoder.

[...]

> * gnu/packages/audio.scm (ttaenc): New variable.

[...]
  
> +(define-public ttaenc
> +  (package
> +    (name "ttaenc")
> +    (version "3.4.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "mirror://sourceforge/tta/"
> +                            "tta/ttaenc-src"
> +                            "/ttaenc-" version "-src.tgz"))
> +        (sha256
> +          (base32
> +            "1iixpr4b89g9g1hwn8ak8k8iflcww3r5f09a117qdidc2nqcijdj"))))

If you don't use Emacs, please run ./etc/indent-code.el before
submitting packages.  :-)

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags
> +       (list "CC=gcc" (string-append "INSDIR=" (assoc-ref %outputs "out") "/bin"))

I used (string-append "CC=" ,(cc-for-target)) here to aid
cross-compilation.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure) ; no configure
> +         (delete 'check)     ; no check

And added #:tests? #f instead of deleting the phase.

> +        (add-before 'install 'make-bindir
> +          (lambda* (#:key outputs #:allow-other-keys)
> +            (let* ((out (assoc-ref outputs "out")))
> +              (mkdir-p (string-append out "/bin"))
> +              #t))))))
> +    (synopsis "TTA lossless audio encoder")
> +    (description
> +      "TTA performs lossless compression on multichannel 8,16 and 24 bits
> +data of the Wav audio files.  Being lossless means that no data-
> +quality is lost in the compression - when uncompressed, the data will
> +be identical to the original.  The compression ratios of TTA depend on
> +the type of music file being compressed, but the compression size
> +will generally range between 30% - 70% of the original.  TTA format
> +supports both of ID3v1/v2 and APEv2 tags. Detailed format description
> +is available at http://tta.sourceforge.net")

I removed the last sentence, because that URL just redirects to the home
page and did not actually contain a detailed format description.  Also,
it was missing punctuation, and lacked two spaces after the previous
punctuation (did you forget to use 'guix lint'?).

> +    (home-page "http://tausoft.org/")
> +    (license license:gpl2)))

This is GPL2+, as explicitly stated in the README.

Applied with those changes, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.