GNU bug report logs - #42284
[PATCH] gnu: icecat: Add libxscrnsaver to runtime LD_LIBRARY_PATH

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42284 in the body.
You can then email your comments to 42284 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Kozlov <kanichos <at> yandex.ru>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: icecat: Add libxscrnsaver to runtime LD_LIBRARY_PATH
Date: Thu, 09 Jul 2020 01:00:05 +0300

IceCat loads libXss.so at runtime to inhibit screen locking if other interfaces are unavailable.

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index fa430837f9..123e8bd889 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1115,10 +1115,12 @@ from forcing GEXP-PROMISE."
                     (mesa (assoc-ref inputs "mesa"))
                     (mesa-lib (string-append mesa "/lib"))
                     (pulseaudio (assoc-ref inputs "pulseaudio"))
-                    (pulseaudio-lib (string-append pulseaudio "/lib")))
+                    (pulseaudio-lib (string-append pulseaudio "/lib"))
+                    (libxscrnsaver (assoc-ref inputs "libxscrnsaver"))
+                    (libxscrnsaver-lib (string-append libxscrnsaver "/lib")))
                (wrap-program (car (find-files lib "^icecat$"))
                  `("XDG_DATA_DIRS" prefix (,gtk-share))
-                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib)))
+                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib ,libxscrnsaver-lib)))
                #t))))))
     (home-page "https://www.gnu.org/software/gnuzilla/")
     (synopsis "Entirely free browser derived from Mozilla Firefox")

Message #10 received at 42284-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Ivan Kozlov <kanichos <at> yandex.ru>
Cc: 42284-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: icecat: Add libxscrnsaver to runtime LD_LIBRARY_PATH
Date: Sun, 26 Jul 2020 13:14:30 +0200

[Message part 1 (text/plain, inline)]

On Thu, Jul 09, 2020 at 01:00:05AM +0300, Ivan Kozlov wrote:
> IceCat loads libXss.so at runtime to inhibit screen locking if other interfaces are unavailable.
> 
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index fa430837f9..123e8bd889 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -1115,10 +1115,12 @@ from forcing GEXP-PROMISE."
>                      (mesa (assoc-ref inputs "mesa"))
>                      (mesa-lib (string-append mesa "/lib"))
>                      (pulseaudio (assoc-ref inputs "pulseaudio"))
> -                    (pulseaudio-lib (string-append pulseaudio "/lib")))
> +                    (pulseaudio-lib (string-append pulseaudio "/lib"))
> +                    (libxscrnsaver (assoc-ref inputs "libxscrnsaver"))
> +                    (libxscrnsaver-lib (string-append libxscrnsaver "/lib")))
>                 (wrap-program (car (find-files lib "^icecat$"))
>                   `("XDG_DATA_DIRS" prefix (,gtk-share))
> -                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib)))
> +                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib ,libxscrnsaver-lib)))
>                 #t))))))
>      (home-page "https://www.gnu.org/software/gnuzilla/")
>      (synopsis "Entirely free browser derived from Mozilla Firefox")

Hi Ivan,

I gave your patch a test ride and playing videos in IceCat now correctly
inhibits the screensaver. Thanks!

I adjusted the commit message a bit and pushed the patch to master:

commit f11d429071e9350f671bc75cb899fb464c147092 (HEAD -> master, upstream/master)
Author: Ivan Kozlov <kanichos <at> yandex.ru>
Date:   Thu Jul 9 01:00:05 2020 +0300

    gnu: icecat: Add libxscrnsaver to runtime LD_LIBRARY_PATH

    IceCat loads libXss.so at runtime to inhibit screen locking if other interfaces are unavailable.

    * gnu/packages/gnuzilla.scm (icecat)[arguments]: Add libxscrnsaver to
    wrap-program arguments.

    Signed-off-by: Jakub Kądziołka <kuba <at> kadziolka.net>

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.