GNU bug report logs - #42422
fix: url-https-proxy-connect - CONNECT with Proxy-Authorization header

Previous Next

Package: emacs;

Reported by: Satoshi Nakagawa <ghnacker <at> gmail.com>

Date: Sun, 19 Jul 2020 01:45:02 UTC

Severity: normal

Tags: fixed

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42422 in the body.
You can then email your comments to 42422 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#42422; Package emacs. (Sun, 19 Jul 2020 01:45:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Satoshi Nakagawa <ghnacker <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 19 Jul 2020 01:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Satoshi Nakagawa <ghnacker <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: fix: url-https-proxy-connect - CONNECT with Proxy-Authorization
 header 
Date: Sun, 19 Jul 2020 10:10:33 +0900
commit 27b37d16418cd64321505e721b40b6b5d730ebdf (HEAD -> fix/url-https-proxy-connect, fork/fix/url-https-proxy-connect)
Author: Satoshi Nakagawa <ghnacker <at> gmail.com>
Date:   Sun Jul 19 10:05:27 2020 +0900

    fix: url-https-proxy-connect - CONNECT with Proxy-Authorization header

diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 669c24571f..9c1219d5c0 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -1406,6 +1406,10 @@ The return value of this function is the retrieval buffer."
   (setq url-http-after-change-function 'url-https-proxy-after-change-function)
   (process-send-string connection (format (concat "CONNECT %s:%d HTTP/1.1\r\n"
                                                   "Host: %s\r\n"
+                                                  (let ((proxy-auth (let ((url-basic-auth-storage
+                                                                           'url-http-proxy-basic-auth-storage))
+                                                                      (url-get-authentication url-http-proxy nil 'any nil))))
+                                                    (if proxy-auth (concat "Proxy-Authorization: " proxy-auth "\r\n")))
                                                   "\r\n")
                                           (url-host url-current-object)
                                           (or (url-port url-current-object)





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#42422; Package emacs. (Sun, 19 Jul 2020 19:13:01 GMT) Full text and rfc822 format available.

Message #8 received at 42422 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Satoshi Nakagawa <ghnacker <at> gmail.com>
Cc: 42422 <at> debbugs.gnu.org
Subject: Re: bug#42422: fix: url-https-proxy-connect - CONNECT with
 Proxy-Authorization header
Date: Sun, 19 Jul 2020 21:12:37 +0200
Satoshi Nakagawa <ghnacker <at> gmail.com> writes:

>     fix: url-https-proxy-connect - CONNECT with Proxy-Authorization header

Looks good to me; applied to Emacs 28.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 19 Jul 2020 19:13:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 42422 <at> debbugs.gnu.org and Satoshi Nakagawa <ghnacker <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 19 Jul 2020 19:13:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 17 Aug 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 224 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.