GNU bug report logs - #42453
[PATCH] gnu: chroma: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42453 in the body.
You can then email your comments to 42453 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: chroma: Fix build.
Date: Tue, 21 Jul 2020 00:05:38 -0600

* gnu/packages/games.scm: chroma:

[configure-flags]: Add "CFLAGS=-fgnu89-inline"
---
gnu/packages/games.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f4d75eedd4..cff1c0af99 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -40,7 +40,7 @@
;;; Copyright © 2019, 2020 Oleg Pykhalov <go.wigust <at> gmail.com>
;;; Copyright © 2019 Pierre Langlois <pierre.langlois <at> gmx.com>
;;; Copyright © 2019 Julien Lepiller <julien <at> lepiller.eu>
-;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix <at> gmail.com>
+;;; Copyright © 2019, 2020 Jesse Gibbons <jgibbons2357+guix <at> gmail.com>
;;; Copyright © 2019 Dan Frumin <dfrumin <at> cs.ru.nl>
;;; Copyright © 2019, 2020 Guillaume Le Vaillant <glv <at> posteo.net>
;;; Copyright © 2019, 2020 Timotej Lazar <timotej.lazar <at> araneo.si>
@@ -5895,7 +5895,8 @@ with the mouse isn’t always trivial.")
"047sf00x71xbmi8bqrhfbmr9bk89l2gbykkqsfpw4wz6yfjscs6y"))))
(build-system gnu-build-system)
(arguments
- `(#:tests? #f)) ; no tests included
+ `(#:tests? #f ; no tests included
+ #:configure-flags '("CFLAGS=-fgnu89-inline"))) ; fix inlines
(inputs
`(("sdl-union" ,(sdl-union (list sdl sdl-image sdl-mixer sdl-ttf)))
("freetype" ,freetype)

Message #8 received at 42453 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Cc: 42453 <at> debbugs.gnu.org
Subject: Re: [bug#42453] [PATCH] gnu: chroma: Fix build.
Date: Tue, 21 Jul 2020 18:30:01 +0200

Hi,

Jesse Gibbons <jgibbons2357 <at> gmail.com> skribis:

> * gnu/packages/games.scm: chroma:
>
> [configure-flags]: Add "CFLAGS=-fgnu89-inline"
> ---
> gnu/packages/games.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index f4d75eedd4..cff1c0af99 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -40,7 +40,7 @@
> ;;; Copyright © 2019, 2020 Oleg Pykhalov <go.wigust <at> gmail.com>
> ;;; Copyright © 2019 Pierre Langlois <pierre.langlois <at> gmx.com>
> ;;; Copyright © 2019 Julien Lepiller <julien <at> lepiller.eu>
> -;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix <at> gmail.com>
> +;;; Copyright © 2019, 2020 Jesse Gibbons <jgibbons2357+guix <at> gmail.com>
> ;;; Copyright © 2019 Dan Frumin <dfrumin <at> cs.ru.nl>
> ;;; Copyright © 2019, 2020 Guillaume Le Vaillant <glv <at> posteo.net>
> ;;; Copyright © 2019, 2020 Timotej Lazar <timotej.lazar <at> araneo.si>
> @@ -5895,7 +5895,8 @@ with the mouse isn’t always trivial.")
> "047sf00x71xbmi8bqrhfbmr9bk89l2gbykkqsfpw4wz6yfjscs6y"))))
> (build-system gnu-build-system)
> (arguments
> - `(#:tests? #f)) ; no tests included
> + `(#:tests? #f ; no tests included
> + #:configure-flags '("CFLAGS=-fgnu89-inline"))) ; fix inlines

Looks like your email client mangled the patch, probably due to
“format=flowed”.

Could you try sending it with ‘git send-email’ or as an attachment, to
42453 <at> debbugs.gnu.org?

TIA!

Ludo’.

Message #11 received at 42453 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 42453 <at> debbugs.gnu.org
Subject: [PATCH] gnu: chroma: Fix build.
Date: Tue, 21 Jul 2020 12:56:03 -0600

[Message part 1 (text/plain, inline)]

Attached is a patch that fixes the build of Chroma in gnu/packaes/games.scm

[0001-gnu-chroma-Fix-build.patch (text/x-patch, attachment)]

Message #14 received at 42453 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Cc: 42453 <at> debbugs.gnu.org
Subject: Re: [bug#42453] [PATCH] gnu: chroma: Fix build.
Date: Fri, 24 Jul 2020 20:19:42 -0500

Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:

> Attached is a patch that fixes the build of Chroma in gnu/packaes/games.scm

Hi Jesse!

Thanks for submitting the unmangled patch! I have reviewed it and pushed
it to master with 982a6e79a2d674ea905e2c63c2378b9df7d64af6. Along with
the push I revised the git commit message and sub-header to be more
descriptive. Thank you, again!

Brett Gilio

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.