GNU bug report logs - #42457
[PATCH] gnu: knights: Fix build.

Previous Next

Package: guix-patches;

Reported by: Jesse Gibbons <jgibbons2357 <at> gmail.com>

Date: Tue, 21 Jul 2020 06:12:02 UTC

Severity: normal

Tags: patch

Done: Oleg Pykhalov <go.wigust <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42457 in the body.
You can then email your comments to 42457 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#42457; Package guix-patches. (Tue, 21 Jul 2020 06:12:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jesse Gibbons <jgibbons2357 <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 21 Jul 2020 06:12:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: knights: Fix build.
Date: Tue, 21 Jul 2020 00:11:05 -0600
* gnu/packages/games.scm (knights):
[make-flags] add "CXXFLAGS=-lpthread"
---
gnu/packages/games.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index cff1c0af99..dc0511e55a 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1366,7 +1366,8 @@ built-in level editor.")
(build-system gnu-build-system)
(arguments
'(#:make-flags
- (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+ (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+ "CXXFLAGS=-lpthread")
#:phases
(modify-phases %standard-phases
;; No configure script.




Information forwarded to guix-patches <at> gnu.org:
bug#42457; Package guix-patches. (Sat, 25 Jul 2020 12:17:02 GMT) Full text and rfc822 format available.

Message #8 received at 42457 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Cc: 42457 <at> debbugs.gnu.org
Subject: Re: [bug#42457] [PATCH] gnu: knights: Fix build.
Date: Sat, 25 Jul 2020 15:16:07 +0300
[Message part 1 (text/plain, inline)]
Hi,

Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:

> * gnu/packages/games.scm (knights):
> [make-flags] add "CXXFLAGS=-lpthread"
> ---
> gnu/packages/games.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index cff1c0af99..dc0511e55a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1366,7 +1366,8 @@ built-in level editor.")
> (build-system gnu-build-system)
> (arguments
> '(#:make-flags
> - (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> + "CXXFLAGS=-lpthread")
> #:phases
> (modify-phases %standard-phases
> ;; No configure script.

This patch looks broken for me, could you resend it, please?

Thanks,
Oleg.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#42457; Package guix-patches. (Tue, 28 Jul 2020 04:06:02 GMT) Full text and rfc822 format available.

Message #11 received at 42457 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 42457 <at> debbugs.gnu.org
Subject: Re: [bug#42457] [PATCH] gnu: knights: Fix build.
Date: Mon, 27 Jul 2020 22:05:13 -0600
[Message part 1 (text/plain, inline)]
Attached.

On 7/25/20 6:16 AM, Oleg Pykhalov wrote:
> Hi,
>
> Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:
>
>> * gnu/packages/games.scm (knights):
>> [make-flags] add "CXXFLAGS=-lpthread"
>> ---
>> gnu/packages/games.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
>> index cff1c0af99..dc0511e55a 100644
>> --- a/gnu/packages/games.scm
>> +++ b/gnu/packages/games.scm
>> @@ -1366,7 +1366,8 @@ built-in level editor.")
>> (build-system gnu-build-system)
>> (arguments
>> '(#:make-flags
>> - (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
>> + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
>> + "CXXFLAGS=-lpthread")
>> #:phases
>> (modify-phases %standard-phases
>> ;; No configure script.
> This patch looks broken for me, could you resend it, please?
>
> Thanks,
> Oleg.
[0001-gnu-knights-Fix-build.patch (text/x-patch, attachment)]

Reply sent to Oleg Pykhalov <go.wigust <at> gmail.com>:
You have taken responsibility. (Tue, 28 Jul 2020 18:14:02 GMT) Full text and rfc822 format available.

Notification sent to Jesse Gibbons <jgibbons2357 <at> gmail.com>:
bug acknowledged by developer. (Tue, 28 Jul 2020 18:14:02 GMT) Full text and rfc822 format available.

Message #16 received at 42457-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Cc: 42457-done <at> debbugs.gnu.org
Subject: Re: [bug#42457] [PATCH] gnu: knights: Fix build.
Date: Tue, 28 Jul 2020 21:13:17 +0300
[Message part 1 (text/plain, inline)]
Hi,

[…]

> * gnu/packages/games.scm (knights):
> [make-flags] add "CXXFLAGS=-lpthread"

Rather:
* gnu/packages/games.scm (knights)[arguments]<#:make-flags>: Add
"CXXFLAGS=-lpthread".

> ---
>  gnu/packages/games.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index cff1c0af99..dc0511e55a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1366,7 +1366,8 @@ built-in level editor.")
>      (build-system gnu-build-system)
>      (arguments
>       '(#:make-flags
> -       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> +       (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +	     "CXXFLAGS=-lpthread")

^
Please, use spaces instead of tabs. ;-)

>         #:phases
>         (modify-phases %standard-phases
>           ;; No configure script.

Pushed to master with mentioned changes.

Oleg.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 26 Aug 2020 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 214 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.