GNU bug report logs - #42460
[PATCH 0/2] gnu: vlc: add support for MIDI and chiptunes

Previous Next

To reply to this bug, email your comments to 42460 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] gnu: vlc: add support for MIDI and chiptunes
Date: Tue, 21 Jul 2020 00:26:41 -0600

The following patch series adds support for MIDI (with FluidSynth) and 
chiptunes (with gme) in VLC.

-Jesse

Message #8 received at 42460 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 42460 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: vlc: Add support for MIDI files
Date: Tue, 21 Jul 2020 00:28:49 -0600

* gnu/packages/video.scm (vlc): add MIDI support with FluidSynth
[inputs]: Add FluidSynth.
[arguments]: Pass "--enable-fluidsynth" to configure
---
gnu/packages/video.scm | 2 ++
1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 4120174484..a4e097e9a2 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1249,6 +1249,7 @@ videoformats depend on the configuration flags of 
ffmpeg.")
("dbus" ,dbus)
("eudev" ,eudev)
("flac" ,flac)
+ ("fluidsynth" ,fluidsynth)
("ffmpeg" ,ffmpeg)
("fontconfig" ,fontconfig)
("freetype" ,freetype)
@@ -1319,6 +1320,7 @@ videoformats depend on the configuration flags of 
ffmpeg.")
(arguments
`(#:configure-flags
`("BUILDCC=gcc"
+ "--enable-fluidsynth"
,(string-append "LDFLAGS=-Wl,-rpath -Wl,"
(assoc-ref %build-inputs "ffmpeg")
"/lib")) ;needed for the tests

Message #11 received at 42460 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 42460 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: vlc: Add support for gme.
Date: Tue, 21 Jul 2020 00:29:18 -0600

* gnu/packages/video.scm: vlc (inputs): Add libgme.
---
gnu/packages/video.scm | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a4e097e9a2..6b57d384e1 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -44,6 +44,7 @@
;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
;;; Copyright © 2020 Vinicius Monego <monego <at> posteo.net>
;;; Copyright © 2020 Brett Gilio <brettg <at> gnu.org>
+;;; Copyright © 2020 Jesse Gibbons <jgibbons2357+guix <at> gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -131,6 +132,7 @@
#:use-module (gnu packages markup)
#:use-module (gnu packages maths)
#:use-module (gnu packages mp3)
+ #:use-module (gnu packages music)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages networking)
#:use-module (gnu packages ocr)
@@ -1268,6 +1270,7 @@ videoformats depend on the configuration flags of 
ffmpeg.")
("libdvdread" ,libdvdread)
("libebml" ,libebml)
("libgcrypt" ,libgcrypt)
+ ("libgme" ,libgme)
("libidn" ,libidn)
("libkate" ,libkate)
("libmad" ,libmad)
@@ -1321,6 +1324,7 @@ videoformats depend on the configuration flags of 
ffmpeg.")
`(#:configure-flags
`("BUILDCC=gcc"
"--enable-fluidsynth"
+ "--enable-gme"
,(string-append "LDFLAGS=-Wl,-rpath -Wl,"
(assoc-ref %build-inputs "ffmpeg")
"/lib")) ;needed for the tests

Message #14 received at 42460 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>, 42460 <at> debbugs.gnu.org
Subject: Re: [bug#42460] [PATCH 0/2] gnu: vlc: add support for MIDI and
 chiptunes
Date: Sat, 25 Jul 2020 17:31:07 +0200

[Message part 1 (text/plain, inline)]

Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:

> The following patch series adds support for MIDI (with FluidSynth) and 
> chiptunes (with gme) in VLC.

These patches are also ill-formatted.

And note that the libgme GCC issue should be fixed before adding it as a
dependency to packages.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 42460 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: Marius Bakke <marius <at> gnu.org>, 42460 <at> debbugs.gnu.org
Subject: Re: [bug#42460] [PATCH 0/2] gnu: vlc: add support for MIDI and
 chiptunes
Date: Mon, 27 Jul 2020 19:57:54 -0600

I'll look into this and combine with #42455 when libgme doesn't have gcc 
as a transitive package.

On 7/25/20 9:31 AM, Marius Bakke wrote:
> Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:
>
>> The following patch series adds support for MIDI (with FluidSynth) and
>> chiptunes (with gme) in VLC.
> These patches are also ill-formatted.
>
> And note that the libgme GCC issue should be fixed before adding it as a
> dependency to packages.

Message #20 received at 42460 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: Marius Bakke <marius <at> gnu.org>, 42460 <at> debbugs.gnu.org
Subject: Re: [bug#42460] [PATCH 0/2] gnu: vlc: add support for MIDI and
 chiptunes
Date: Tue, 28 Jul 2020 19:23:49 -0600

Is there a bug corresponding to the libgme GCC issue?

On 7/25/20 9:31 AM, Marius Bakke wrote:
> Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:
>
>> The following patch series adds support for MIDI (with FluidSynth) and 
>> chiptunes (with gme) in VLC.
> These patches are also ill-formatted.
>
> And note that the libgme GCC issue should be fixed before adding it as a
> dependency to packages.

Message #23 received at 42460 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: 42460 <at> debbugs.gnu.org
Date: Fri, 22 Sep 2023 17:18:30 +0200

[Message part 1 (text/plain, inline)]

Hi,

Any update on this patch?

It looks like libgme GCC is fixed: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=5c4b76ce372899db9d6e85dbadfb168436e0123f

Thanks,
Clément

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.