GNU bug report logs - #42474
[PATCH 0/3] WIP: Add hunspell-dict-de.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42474 in the body.
You can then email your comments to 42474 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: guix-patches <at> gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: [PATCH 0/3] WIP: Add hunspell-dict-de.
Date: Wed, 22 Jul 2020 14:26:49 +0200

Hi folks,

as I'm missing spell checker in Icecat and Libreoffice (Icedove let you install one), I tried to package
hunspell-dict-de.

It's more engaged then I thought before :P I added byacc as an yacc implementation required
by ispell. That part is working, so not WIP.

ispell
======
It's Makefiles are a bit ugly so you need to patch them somehow.
At the current state the binaries are looking at the wrong place for the "/lib/ispell/*.hash" files.
So I guess that is where
```
ice-9/boot-9.scm:1669:16: In procedure raise-exception:
In procedure open-file: No such file or directory: "/gnu/store/smvi9sk3s3xvn0xx6az0hvzl6mhy7zyn-ispell-3.4.00/lib/ispell/english.hash"
```
comes from.
```
$ /gnu/store/smvi9sk3s3xvn0xx6az0hvzl6mhy7zyn-ispell-3.4.00/bin/ispell
Can't open /lib/ispell/english.hash
```
Do I need to wrap this somehow?

hunspell-dict-de
================
It's blocked by ispell. It only requires buildhash which seems to be working.

In general wouldn't it make sense to rename aspell.scm to spell.scm and move the hunspell* stuff from
libreoffice.scm there?

Jonathan Brielmaier (3):
  gnu: Add byacc.
  WIP: gnu: Add ispell.
  WIP: gnu: Add hunspell-dict-de.

 gnu/packages/aspell.scm      | 45 ++++++++++++++++++++++++++++++++++++
 gnu/packages/c.scm           | 20 ++++++++++++++++
 gnu/packages/libreoffice.scm | 28 +++++++++++++++++++++-
 3 files changed, 92 insertions(+), 1 deletion(-)

--
2.27.0

Message #8 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 42474 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: [PATCH 2/3] WIP: gnu: Add ispell.
Date: Wed, 22 Jul 2020 14:30:12 +0200

* gnu/packages/aspell.scm (ispell): New variable.
---
 gnu/packages/aspell.scm | 45 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
index 22256f750b..023f6bc8c4 100644
--- a/gnu/packages/aspell.scm
+++ b/gnu/packages/aspell.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2019 Jens Mølgaard <jens <at> zete.tk>
 ;;; Copyright © 2020 Timotej Lazar <timotej.lazar <at> araneo.si>
 ;;; Copyright © 2020 Marcin Karpezo <sirmacik <at> wioo.waw.pl>
+;;; Copyright © 2020 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -33,7 +34,9 @@
   #:use-module (guix utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages c)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
   #:use-module (ice-9 match))

@@ -453,3 +456,45 @@ under permissive licensing terms.  See the 'Copyright' file."))))
 (define-word-list-dictionary hunspell-dict-en-us
   "en_US"
   (synopsis "Hunspell dictionary for United States English"))
+
+(define-public ispell
+  (package
+    (name "ispell")
+    (version "3.4.00")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://www.cs.hmc.edu/~geoff/tars/ispell-"
+                           version ".tar.gz"))
+       (sha256
+         (base32
+            "1hmfnz55qzfpz7lz0r3m4kkv31smir92ks9s5l1iiwimhr2jxi2x"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags
+        (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
+              "local.h" "config.sh")
+       #:phases
+        (modify-phases %standard-phases
+          (delete 'configure)
+          (add-before 'build 'correct-hardcoding
+            (lambda* (#:key inputs outputs #:allow-other-keys)
+              (substitute* '("config.X"
+                             "local.h.linux"
+                             "local.h.generic")
+                        ;; gcc-toolchain does not provide symlink cc -> gcc
+                        (("\"cc\"") "\"gcc\"")
+                        (("/bin/sh") (which "sh"))
+                        (("/usr/local/bin") "/bin")
+                        (("/usr/local/lib") "/lib/ispell")
+                        (("/usr/local/man") "/share/man"))
+            #t)))
+       #:tests? #f)) ;no tests
+    (native-inputs
+     `(("byacc" ,byacc)
+       ("ncurses" ,ncurses)))
+    (synopsis "Interactive spell-checking tool for Unix")
+    (description "Ispell is an interactive spell-checking tool supporting many
+European languages.")
+    (home-page "https://www.cs.hmc.edu/~geoff/ispell.html")
+    (license bsd-3)))
--
2.27.0

Message #11 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 42474 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: [PATCH 1/3] gnu: Add byacc.
Date: Wed, 22 Jul 2020 14:30:11 +0200

* gnu/packages/c.scm (byacc): New variable.
---
 gnu/packages/c.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm
index 25bc78e6bf..fde10f5a43 100644
--- a/gnu/packages/c.scm
+++ b/gnu/packages/c.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2020 Marius Bakke <marius <at> gnu.org>
 ;;; Copyright @ 2020 Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2020 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -473,3 +474,22 @@ avoiding distractions when studying code that uses @code{#ifdef} heavily for
 portability.")
     (license (list license:bsd-2        ;all files except...
                    license:bsd-3))))    ;...the unidef.1 manual page
+
+(define-public byacc
+  (package
+    (name "byacc")
+    (version "20200330")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://invisible-mirror.net/archives/byacc/"
+                           "byacc-" version ".tgz"))
+       (sha256
+        (base32
+         "1c0zyn6v286i09jlc8gx6jyaa5438qyy985rqsd76kb8ibfy56g0"))))
+    (build-system gnu-build-system)
+    (synopsis "LARL(1) parser generator")
+    (description "Berkley yacc is a Look-Ahead LR (@dfn{LARL}) parser generator trying to be
+compatible with AT&T yacc as much as possible.")
+    (home-page "https://invisible-island.net/byacc/byacc.html")
+    (license license:public-domain)))
--
2.27.0

Message #14 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 42474 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: [PATCH 3/3] WIP: gnu: Add hunspell-dict-de.
Date: Wed, 22 Jul 2020 14:30:13 +0200

* gnu/packages/libreoffice.scm (hunspell-dict-de): New variable.
---
 gnu/packages/libreoffice.scm | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index ebe4fd7246..9e964fb096 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -10,7 +10,7 @@
 ;;; Copyright © 2017, 2018, 2019 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado <at> elephly.net>
-;;; Copyright © 2018 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
+;;; Copyright © 2018, 2020 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
 ;;; Copyright © 2019 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2020 Marcin Karpezo <sirmacik <at> wioo.waw.pl>
 ;;;
@@ -971,6 +971,32 @@ library.")
     (license
      (list license:gpl2 license:mpl1.1 license:cc-by4.0 license:lgpl2.1 license:asl2.0))))

+(define-public hunspell-dict-de
+  (package
+   (name "hunspell-dict-de")
+   (version "20161207")
+   (source
+    (origin
+      (method url-fetch)
+      (uri (string-append "https://www.j3e.de/ispell/igerman98/dict/"
+                           "igerman98-" version ".tar.bz2"))
+      (sha256 (base32
+               "1a3055hp2bc4q4nlg3gmg0147p3a1zlfnc65xiv2v9pyql1nya8p"))))
+   (build-system gnu-build-system)
+   (arguments
+    `(#:make-flags '("hunspell/de_DE.dic")
+      #:phases
+       (modify-phases %standard-phases
+         (delete 'configure))
+      #:tests? #f)) ;no tests
+   (native-inputs
+    `(("perl" ,perl)))
+   (synopsis "Hunspell dictionary for German")
+   (description "This package provides a dictionary for the Hunspell
+spell-checking library.")
+   (home-page "https://www.j3e.de/ispell/igerman98/")
+   (license (list license:gpl2 license:gpl3))))
+
 (define-public hyphen
   (package
     (name "hyphen")
--
2.27.0

Message #17 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 42474 <at> debbugs.gnu.org
Subject: Re: [bug#42474] [PATCH 0/3] WIP: Add hunspell-dict-de.
Date: Thu, 23 Jul 2020 10:56:37 +0300

[Message part 1 (text/plain, inline)]

On Wed, Jul 22, 2020 at 02:26:49PM +0200, Jonathan Brielmaier wrote:
> Hi folks,
> 
> ```
> ice-9/boot-9.scm:1669:16: In procedure raise-exception:
> In procedure open-file: No such file or directory: "/gnu/store/smvi9sk3s3xvn0xx6az0hvzl6mhy7zyn-ispell-3.4.00/lib/ispell/english.hash"
> ```
> comes from.
> ```
> $ /gnu/store/smvi9sk3s3xvn0xx6az0hvzl6mhy7zyn-ispell-3.4.00/bin/ispell
> Can't open /lib/ispell/english.hash
> ```
> Do I need to wrap this somehow?

Is this the type of thing where a search path would work?

> 
> In general wouldn't it make sense to rename aspell.scm to spell.scm and move the hunspell* stuff from
> libreoffice.scm there?
> 

I'm very in favor of this. It's something I've thought about doing
before.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 42474 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: [PATCH v2 0/3] Add hunspell-dict-de.
Date: Sat, 25 Jul 2020 00:38:35 +0200

Changes compared to v1:
* ispell builds now. The ispell binary is still broken and needs some patch magic
  or so.
* hunspell-dict-de builds now as well and ships the file we need. I installed it
  and LibreOffice and Icecat have no German spell checking.
* Fixed identation with indent script.

It would be nice if we can add packages for de_AT and de_CH as well, but I don't
know what would be a proper approach: inherit + something...

Jonathan Brielmaier (3):
  gnu: Add byacc.
  WIP: gnu: Add ispell.
  WIP: gnu: Add hunspell-dict-de.

 gnu/packages/aspell.scm      | 49 ++++++++++++++++++++++++++++++++++++
 gnu/packages/c.scm           | 20 +++++++++++++++
 gnu/packages/libreoffice.scm | 38 +++++++++++++++++++++++++++-
 3 files changed, 106 insertions(+), 1 deletion(-)

--
2.27.0

Message #23 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 42474 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: [PATCH v2 1/3] gnu: Add byacc.
Date: Sat, 25 Jul 2020 00:38:36 +0200

* gnu/packages/c.scm (byacc): New variable.
---
 gnu/packages/c.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm
index 25bc78e6bf..fde10f5a43 100644
--- a/gnu/packages/c.scm
+++ b/gnu/packages/c.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2020 Marius Bakke <marius <at> gnu.org>
 ;;; Copyright @ 2020 Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2020 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -473,3 +474,22 @@ avoiding distractions when studying code that uses @code{#ifdef} heavily for
 portability.")
     (license (list license:bsd-2        ;all files except...
                    license:bsd-3))))    ;...the unidef.1 manual page
+
+(define-public byacc
+  (package
+    (name "byacc")
+    (version "20200330")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://invisible-mirror.net/archives/byacc/"
+                           "byacc-" version ".tgz"))
+       (sha256
+        (base32
+         "1c0zyn6v286i09jlc8gx6jyaa5438qyy985rqsd76kb8ibfy56g0"))))
+    (build-system gnu-build-system)
+    (synopsis "LARL(1) parser generator")
+    (description "Berkley yacc is a Look-Ahead LR (@dfn{LARL}) parser generator trying to be
+compatible with AT&T yacc as much as possible.")
+    (home-page "https://invisible-island.net/byacc/byacc.html")
+    (license license:public-domain)))
--
2.27.0

Message #26 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 42474 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: [PATCH v2 2/3] WIP: gnu: Add ispell.
Date: Sat, 25 Jul 2020 00:38:37 +0200

* gnu/packages/aspell.scm (ispell): New variable.
---
 gnu/packages/aspell.scm | 49 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
index 22256f750b..31346d5ba7 100644
--- a/gnu/packages/aspell.scm
+++ b/gnu/packages/aspell.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2019 Jens Mølgaard <jens <at> zete.tk>
 ;;; Copyright © 2020 Timotej Lazar <timotej.lazar <at> araneo.si>
 ;;; Copyright © 2020 Marcin Karpezo <sirmacik <at> wioo.waw.pl>
+;;; Copyright © 2020 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -33,7 +34,9 @@
   #:use-module (guix utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages c)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
   #:use-module (ice-9 match))

@@ -453,3 +456,49 @@ under permissive licensing terms.  See the 'Copyright' file."))))
 (define-word-list-dictionary hunspell-dict-en-us
   "en_US"
   (synopsis "Hunspell dictionary for United States English"))
+
+; FIXME: ispell binary is not working, needs some path mangling
+(define-public ispell
+  (package
+    (name "ispell")
+    (version "3.4.00")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://www.cs.hmc.edu/~geoff/tars/ispell-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "1hmfnz55qzfpz7lz0r3m4kkv31smir92ks9s5l1iiwimhr2jxi2x"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags
+       (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
+             "local.h" "config.sh")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (add-before 'build 'correct-hardcoding
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (substitute* '("config.X"
+                            "local.h.linux"
+                            "local.h.generic")
+               ;; gcc-toolchain does not provide symlink cc -> gcc
+               (("\"cc\"") "\"gcc\"")
+               (("/bin/sh") (which "sh"))
+               (("/usr/local/bin") "/bin")
+               (("/usr/local/lib") "/lib/ispell")
+               (("/usr/local/man") "/share/man"))
+             (substitute* '("Makefile")
+               (("\\$\\(DESTDIR\\)\\$\\$MASTERHASH")
+                "$(DESTDIR)/lib/ispell/$$MASTERHASH"))
+             #t)))
+       #:tests? #f))                    ;no tests
+    (native-inputs
+     `(("byacc" ,byacc)
+       ("ncurses" ,ncurses)))
+    (synopsis "Interactive spell-checking tool for Unix")
+    (description "Ispell is an interactive spell-checking tool supporting many
+European languages.")
+    (home-page "https://www.cs.hmc.edu/~geoff/ispell.html")
+    (license bsd-3)))
--
2.27.0

Message #29 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 42474 <at> debbugs.gnu.org
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: [PATCH v2 3/3] WIP: gnu: Add hunspell-dict-de.
Date: Sat, 25 Jul 2020 00:38:38 +0200

* gnu/packages/libreoffice.scm (hunspell-dict-de): New variable.
---
 gnu/packages/libreoffice.scm | 38 +++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index ebe4fd7246..98d81587c5 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -10,7 +10,7 @@
 ;;; Copyright © 2017, 2018, 2019 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado <at> elephly.net>
-;;; Copyright © 2018 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
+;;; Copyright © 2018, 2020 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
 ;;; Copyright © 2019 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2020 Marcin Karpezo <sirmacik <at> wioo.waw.pl>
 ;;;
@@ -42,6 +42,7 @@
   #:use-module (ice-9 match)
   #:use-module (gnu packages)
   #:use-module (gnu packages aidc)
+  #:use-module (gnu packages aspell)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bison)
@@ -971,6 +972,41 @@ library.")
     (license
      (list license:gpl2 license:mpl1.1 license:cc-by4.0 license:lgpl2.1 license:asl2.0))))

+(define-public hunspell-dict-de
+  (package
+    (name "hunspell-dict-de")
+    (version "20161207")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://www.j3e.de/ispell/igerman98/dict/"
+                           "igerman98-" version ".tar.bz2"))
+       (sha256 (base32
+                "1a3055hp2bc4q4nlg3gmg0147p3a1zlfnc65xiv2v9pyql1nya8p"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags '("hunspell/de_DE.dic")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (replace 'install              ;no install target
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (share (string-append out "/share/hunspell/")))
+               (mkdir-p share)
+               (copy-file "hunspell/de_DE.aff" (string-append share "de_DE.aff"))
+               (copy-file "hunspell/de_DE.dic" (string-append share "de_DE.dic"))))))
+       #:tests? #f))                    ;no tests
+    (native-inputs
+     `(("hunspell" ,hunspell)
+       ("ispell" ,ispell)
+       ("perl" ,perl)))
+    (synopsis "Hunspell dictionary for German (de_DE)")
+    (description "This package provides a dictionary for the Hunspell
+spell-checking library.")
+    (home-page "https://www.j3e.de/ispell/igerman98/")
+    (license (list license:gpl2 license:gpl3))))
+
 (define-public hyphen
   (package
     (name "hyphen")
--
2.27.0

Message #32 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: 42474 <at> debbugs.gnu.org
Cc: efraim <at> flashner.co.il, jonathan.brielmaier <at> web.de
Subject: [PATCH v3 1/2] gnu: Add ispell.
Date: Tue, 28 Jul 2020 13:36:09 +0200

* gnu/packages/aspell.scm (ispell): New variable.

Co-authored-by: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
---

Hi,

DESTDIR is a variable that should always be / on Guix. Its meaning is
that the package should be installed to $DESTDIR/$prefix/bin/foo, but
will be ran at $prefix/bin/foo - useful when you're managing the
creation of a binary tarball manually, but useless and misleading for
Guix.

Also, we already have an implementation of Yacc - I've replaced the
input with Bison.

Moreover, instead of patching the defaults, a configuration file is now
created.

I haven't tried spellchecking anything with ispell or using the German
dictionary, but both packages now build.

Regards,
Jakub Kądziołka

 gnu/packages/aspell.scm | 51 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
index 22256f750b..a9c7e0d615 100644
--- a/gnu/packages/aspell.scm
+++ b/gnu/packages/aspell.scm
@@ -9,6 +9,8 @@
 ;;; Copyright © 2019 Jens Mølgaard <jens <at> zete.tk>
 ;;; Copyright © 2020 Timotej Lazar <timotej.lazar <at> araneo.si>
 ;;; Copyright © 2020 Marcin Karpezo <sirmacik <at> wioo.waw.pl>
+;;; Copyright © 2020 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
+;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -33,7 +35,9 @@
   #:use-module (guix utils)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
   #:use-module (ice-9 match))
 
@@ -453,3 +457,50 @@ under permissive licensing terms.  See the 'Copyright' file."))))
 (define-word-list-dictionary hunspell-dict-en-us
   "en_US"
   (synopsis "Hunspell dictionary for United States English"))
+
+(define-public ispell
+  (package
+    (name "ispell")
+    (version "3.4.00")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://www.cs.hmc.edu/~geoff/tars/ispell-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "1hmfnz55qzfpz7lz0r3m4kkv31smir92ks9s5l1iiwimhr2jxi2x"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:parallel-build? #f
+       #:tests? #f ; no tests
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             ;; Based on local.h.linux
+             (let* ((grep (assoc-ref inputs "grep"))
+                    (out (assoc-ref outputs "out")))
+               (call-with-output-file "local.h"
+                 (lambda (port)
+                   (format port "#define MINIMENU~%")
+                   (format port "#define USG~%")
+                   (format port "#define HAS_RENAME~%")
+                   (format port "#define CC \"gcc\"~%")
+                   (format port "#define POUNDBANG \"#!~a\"~%" (which "sh"))
+                   (format port "#define EGREPCMD \"~a/bin/grep -Ei\"~%" grep)
+                   (format port "#define BINDIR \"~a/bin\"~%" out)
+                   (format port "#define LIBDIR \"~a/lib/ispell\"~%" out)
+                   (format port "#define MAN1DIR \"~a/share/man/man1\"~%" out)
+                   (format port "#define MAN45DIR \"~a/share/man/man5\"~%" out))))
+             #t)))))
+    (inputs
+     `(("grep" ,grep)
+       ("ncurses" ,ncurses)))
+    (native-inputs
+     `(("bison" ,bison)))
+    (synopsis "Interactive spell-checking tool for Unix")
+    (description "Ispell is an interactive spell-checking tool supporting many
+European languages.")
+    (home-page "https://www.cs.hmc.edu/~geoff/ispell.html")
+    (license bsd-3)))
-- 
2.27.0

Message #35 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: 42474 <at> debbugs.gnu.org
Cc: efraim <at> flashner.co.il, jonathan.brielmaier <at> web.de
Subject: [PATCH v3 2/2] gnu: Add hunspell-dict-de.
Date: Tue, 28 Jul 2020 13:36:44 +0200

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>

* gnu/packages/libreoffice.scm (hunspell-dict-de): New variable.
---
 gnu/packages/libreoffice.scm | 38 +++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index ebe4fd7246..98d81587c5 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -10,7 +10,7 @@
 ;;; Copyright © 2017, 2018, 2019 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado <at> elephly.net>
-;;; Copyright © 2018 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
+;;; Copyright © 2018, 2020 Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
 ;;; Copyright © 2019 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2020 Marcin Karpezo <sirmacik <at> wioo.waw.pl>
 ;;;
@@ -42,6 +42,7 @@
   #:use-module (ice-9 match)
   #:use-module (gnu packages)
   #:use-module (gnu packages aidc)
+  #:use-module (gnu packages aspell)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bison)
@@ -971,6 +972,41 @@ library.")
     (license
      (list license:gpl2 license:mpl1.1 license:cc-by4.0 license:lgpl2.1 license:asl2.0))))
 
+(define-public hunspell-dict-de
+  (package
+    (name "hunspell-dict-de")
+    (version "20161207")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://www.j3e.de/ispell/igerman98/dict/"
+                           "igerman98-" version ".tar.bz2"))
+       (sha256 (base32
+                "1a3055hp2bc4q4nlg3gmg0147p3a1zlfnc65xiv2v9pyql1nya8p"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags '("hunspell/de_DE.dic")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (replace 'install              ;no install target
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (share (string-append out "/share/hunspell/")))
+               (mkdir-p share)
+               (copy-file "hunspell/de_DE.aff" (string-append share "de_DE.aff"))
+               (copy-file "hunspell/de_DE.dic" (string-append share "de_DE.dic"))))))
+       #:tests? #f))                    ;no tests
+    (native-inputs
+     `(("hunspell" ,hunspell)
+       ("ispell" ,ispell)
+       ("perl" ,perl)))
+    (synopsis "Hunspell dictionary for German (de_DE)")
+    (description "This package provides a dictionary for the Hunspell
+spell-checking library.")
+    (home-page "https://www.j3e.de/ispell/igerman98/")
+    (license (list license:gpl2 license:gpl3))))
+
 (define-public hyphen
   (package
     (name "hyphen")
-- 
2.27.0

Message #38 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Jakub Kądziołka <kuba <at> kadziolka.net>,
 42474 <at> debbugs.gnu.org
Cc: efraim <at> flashner.co.il
Subject: Re: [PATCH v3 1/2] gnu: Add ispell.
Date: Tue, 28 Jul 2020 14:51:14 +0200

On 28.07.20 13:36, Jakub Kądziołka wrote:
> * gnu/packages/aspell.scm (ispell): New variable.
>
> Co-authored-by: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
> ---
>
> Hi,
>
> DESTDIR is a variable that should always be / on Guix. Its meaning is
> that the package should be installed to $DESTDIR/$prefix/bin/foo, but
> will be ran at $prefix/bin/foo - useful when you're managing the
> creation of a binary tarball manually, but useless and misleading for
> Guix.

Okay, thanks for that explanation :)

> Also, we already have an implementation of Yacc - I've replaced the
> input with Bison.

I search for yacc in my /gnu/store but there was no build of Bison so I
couldn't find it. We(TM) need definitly a tool to search binaries in all
packages :)

> Moreover, instead of patching the defaults, a configuration file is now
> created.
>
> I haven't tried spellchecking anything with ispell or using the German
> dictionary, but both packages now build.

I tested your version with LibreOffice and Icecat and it's still
working. So I'm fine with it for pushing. Thank for your review and
additional work!

Message #41 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Jakub Kądziołka <kuba <at> kadziolka.net>,
 42474 <at> debbugs.gnu.org
Cc: efraim <at> flashner.co.il, Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Subject: Re: [PATCH v3 2/2] gnu: Add hunspell-dict-de.
Date: Thu, 27 Aug 2020 22:15:17 +0200

Ping.

Message #44 received at 42474 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Jakub Kądziołka <kuba <at> kadziolka.net>,
 42474 <at> debbugs.gnu.org
Cc: efraim <at> flashner.co.il
Subject: Re: [PATCH v3 2/2] gnu: Add hunspell-dict-de.
Date: Thu, 15 Oct 2020 22:07:30 +0200

Another friendly ping. I'm using the patch for almost three months now
and other German users should also profit from our work :)

Message #49 received at 42474-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: Jakub Kądziołka <kuba <at> kadziolka.net>,
 42474-done <at> debbugs.gnu.org
Subject: Re: [PATCH v3 2/2] gnu: Add hunspell-dict-de.
Date: Sun, 18 Oct 2020 12:20:43 +0300

[Message part 1 (text/plain, inline)]

On Thu, Oct 15, 2020 at 10:07:30PM +0200, Jonathan Brielmaier wrote:
> Another friendly ping. I'm using the patch for almost three months now
> and other German users should also profit from our work :)

Indeed. Patch pushed with minor tweaks.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.