GNU bug report logs - #42526
[PATCH] gnu: Add emacs-shx.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42526 in the body.
You can then email your comments to 42526 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-shx.
Date: Fri, 24 Jul 2020 21:40:16 -0500

[Message part 1 (text/plain, inline)]

Patch file is attached.

--
Joseph LaFreniere

[0001-gnu-Add-emacs-shx.patch (text/x-patch, attachment)]

Message #8 received at 42526 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
Cc: 42526 <at> debbugs.gnu.org
Subject: Re: [bug#42526] [PATCH] gnu: Add emacs-shx.
Date: Sat, 25 Jul 2020 11:12:35 +0300

[Message part 1 (text/plain, inline)]

Hi,

"LaFreniere, Joseph" <joseph <at> lafreniere.xyz> writes:

> Patch file is attached.

Could you also take a look on running test suite in a package recipe,
please?

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 42526 <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>, 42526 <at> debbugs.gnu.org
Subject: Re: [bug#42526] [PATCH] gnu: Add emacs-shx.
Date: Sat, 25 Jul 2020 08:29:26 -0500

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:
> Could you also take a look on running test suite in a package 
> recipe, please?

Thank you for pointing that out.  A new patch file is attached 
with tests enabled and passing:
> starting phase `check'
> ✔ shx-tokenize works with apostrophes.
> ✔ shx-tokenize works with partial apostrophes.
> ✔ shx-tokenize returns nil when quoting doesn't match.
> ✔ shx-tokenize works with apostrophes and quotation marks.
> ✔ shx-tokenize works with escaped spaces.
> ✔ shx-tokenize works with escaped quotation marks.
> ✔ shx-tokenize works with escaped characters
> ✔ shx-tokenize works with a directory specified.
> ✔ shx--get-user-cmd returns nil for empty string
> ✔ shx--get-user-cmd returns command with correct prefix
> ✔ shx--safe-as-markup-p recognizes unsafe command
> ✔ shx--safe-as-markup-p recognizes a safe command
> ✔ shx--safe-as-markup-p handles undocumented command
> ✔ shx--quote-regexp matches escaped regexps correctly
> ✔ shx--quote-regexp matches unescaped regexps correctly
> ✔ shx--get-timer-list is empty
> ✔ shx--shx-timer-list grows by 1
> ✔ shx--get-timer-list becomes empty
> ✔ shx.el passes checkdoc
> ✔ shx-cat concatenates strings correctly
> ✔ shx-cat propertizes text correctly
> ✔ shx--shell-command finds the default shell
> ✔ shx--replace-from-list acts sequentially
> ✔ shx--replace-from-list performs the correct replacements
> ✔ shx-el passes check-declare-file
> ✔ shx-cmd-syntax recognizes command with arguments
> ✔ shx-cmd-syntax recognizes alphabetical command names
> ✔ shx-cmd-syntax recognizes hyphenated command names
> ✔ shx--shell-quote-no-quotation-marks escapes string
> ✔ shx.el passes byte-compilation
> ✔ shx-tokenize-filenames works with relative and absolute paths.
> ✔ shx--all-commands lists user command functions
> phase `check' succeeded after 0.2 seconds

--
Joseph LaFreniere

[0001-gnu-Add-emacs-shx.patch (text/x-patch, attachment)]

Message #16 received at 42526-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
Cc: 42526-done <at> debbugs.gnu.org
Subject: Re: [bug#42526] [PATCH] gnu: Add emacs-shx.
Date: Sat, 25 Jul 2020 17:07:05 +0300

[Message part 1 (text/plain, inline)]

"LaFreniere, Joseph" <joseph <at> lafreniere.xyz> writes:

[…]

> A new patch file is attached with tests enabled and passing:

Pushed to master.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.