GNU bug report logs - #42534
28.0.50; package-test-macro-compilation test fails on macOS

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42534 in the body.
You can then email your comments to 42534 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; package-test-macro-compilation test fails on macOS
Date: Sat, 25 Jul 2020 20:35:46 +0200

This is a follow-up to Bug#30700, reporting each test failure as
individual bug.  In this case, the test package-test-macro-compilation
fails on macOS:

Test package-test-macro-compilation backtrace:
  signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
  ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal 
  #f(compiled-function () #<bytecode 0x1f953e56a3a07011>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name package-test-macro-compilation :docum
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/package-t
  command-line()
  normal-top-level()
Test package-test-macro-compilation condition:
    (ert-test-failed
     ((should
       (equal
	(macro-problem-func)
	'...))
      :form
      (equal
       (progn a b)
       (1 b))
      :value nil :explanation
      (proper-lists-of-different-length 3 2
					(progn a b)
					(1 b)
					first-mismatch-at 0)))
   FAILED  23/32  package-test-macro-compilation (1.641010 sec)



In GNU Emacs 28.0.50 (build 67, x86_64-apple-darwin19.5.0, NS appkit-1894.50 Version 10.15.5 (Build 19F101))
 of 2020-07-25
Repository revision: 3b44829823f43d3736b8ec9db2258eeff7f6c16a
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.5

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --with-modules --without-xml2 --without-pop --with-mailutils
 --enable-gcc-warnings=warn-only --enable-checking=all
 --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0''

Configured features:
JPEG TIFF GIF PNG NOTIFY KQUEUE ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS
MODULES THREADS JSON PDUMPER LCMS2

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822
mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs
text-property-search time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro
kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json map url-vars mailcap subr-x rx gnutls puny seq
byte-opt gv bytecomp byte-compile cconv dbus xml compile comint
ansi-color ring cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win
ucs-normalize mule-util term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads kqueue cocoa ns
lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 69913 5569)
 (symbols 48 8650 1)
 (strings 32 23673 1933)
 (string-bytes 1 769982)
 (vectors 16 14334)
 (vector-slots 8 180946 11780)
 (floats 8 26 29)
 (intervals 56 206 0)
 (buffers 992 10))

Message #10 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philipp <p.stephani2 <at> gmail.com>
Cc: 42534 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 07:27:19 +0100

Philipp <p.stephani2 <at> gmail.com> writes:

> This is a follow-up to Bug#30700, reporting each test failure as
> individual bug.  In this case, the test package-test-macro-compilation
> fails on macOS:
>
> Test package-test-macro-compilation backtrace:
>   signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
>   ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal 

I'm now seeing this build failure on Macos (Catalina) any more -- has it
gone away for you, too?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 07:29:10 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> I just did the obvious:
>
>   cd test
>   make lisp/emacs-lisp/package-tests.log

[...]

>      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
>
> In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)

I tried this (with mingw64) in Emacs 28, and this test didn't fail for
me.  Are you still seeing this?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 09:54:34 +0200

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: 37615 <at> debbugs.gnu.org,  42534 <at> debbugs.gnu.org
> Date: Fri, 25 Dec 2020 07:29:10 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I just did the obvious:
> >
> >   cd test
> >   make lisp/emacs-lisp/package-tests.log
> 
> [...]
> 
> >      FAILED  13/21  package-test-macro-compilation (0.796875 sec)
> >
> > In GNU Emacs 27.0.50 (build 1452, i686-pc-mingw32)
> 
> I tried this (with mingw64) in Emacs 28, and this test didn't fail for
> me.  Are you still seeing this?

Yes (with current master).  I get this in the failure message:

  Test package-test-macro-compilation condition:
      (ert-test-failed
       ((should
	 (equal
	  (macro-problem-func)
	  '...))
	:form
	(equal
	 (progn a b)
	 (1 b))
	:value nil :explanation
	(proper-lists-of-different-length 3 2
					  (progn a b)
					  (1 b)
					  first-mismatch-at 0)))
     FAILED  23/32  package-test-macro-compilation (0.953125 sec)

I'm happy to provide more details if needed, or debug this more given
some instructions.

Message #19 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 42534 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50;
 package-test-macro-compilation test fails on macOS
Date: Fri, 25 Dec 2020 12:03:45 +0100

Am Fr., 25. Dez. 2020 um 07:27 Uhr schrieb Lars Ingebrigtsen <larsi <at> gnus.org>:
>
> Philipp <p.stephani2 <at> gmail.com> writes:
>
> > This is a follow-up to Bug#30700, reporting each test failure as
> > individual bug.  In this case, the test package-test-macro-compilation
> > fails on macOS:
> >
> > Test package-test-macro-compilation backtrace:
> >   signal(ert-test-failed (((should (equal (macro-problem-func) '(1 b))
> >   ert-fail(((should (equal (macro-problem-func) '(1 b))) :form (equal
>
> I'm now seeing this build failure on Macos (Catalina) any more -- has it
> gone away for you, too?
>

I'm still seeing this on Big Sur.

Message #22 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 20:37:49 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>      FAILED  23/32  package-test-macro-compilation (0.953125 sec)

I'm getting this failure instead (on a brand new msys2/mingw
installation): 

1 unexpected results:
   FAILED  package-test-signed

> I'm happy to provide more details if needed, or debug this more given
> some instructions.

I'm pretty unfamiliar with package.el and wholly unfamiliar with
Windows, so I'll leave that to somebody else.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #25 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 42534 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 21:29:13 +0100

Philipp Stephani <p.stephani2 <at> gmail.com> writes:

>> I'm now seeing this build failure on Macos (Catalina) any more -- has it
>> gone away for you, too?
>>
>
> I'm still seeing this on Big Sur.

And now I'm getting it on Catalina again:

1 unexpected results:
   FAILED  package-test-macro-compilation

Either I missed it the last time, or it's unstable, I guess.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #28 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>,
 Artur Malabarba <bruce.connor.am <at> gmail.com>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 22:42:17 +0200

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: 37615 <at> debbugs.gnu.org,  42534 <at> debbugs.gnu.org
> Date: Fri, 25 Dec 2020 20:37:49 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >      FAILED  23/32  package-test-macro-compilation (0.953125 sec)

First signs of trouble are here:

  In macro-problem-10-and-90:
  macro-problem.el:27:45: Warning: reference to free variable `hehe'

  In end of data:
  macro-problem.el:31:1: Warning: the function `macro-aux-3' is not known to be
      defined.

I cannot understand why this happens on MS-Windows, but not on
GNU/Linux.

> I'm getting this failure instead (on a brand new msys2/mingw
> installation): 
> 
> 1 unexpected results:
>    FAILED  package-test-signed

On my system this is skipped because gpg2 is not installed.

> > I'm happy to provide more details if needed, or debug this more given
> > some instructions.
> 
> I'm pretty unfamiliar with package.el and wholly unfamiliar with
> Windows, so I'll leave that to somebody else.

CC'ing the author of package-tests in the hope that he could suggest
some ideas for fixing this.

Message #31 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org,
 Artur Malabarba <bruce.connor.am <at> gmail.com>
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 21:49:31 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> I cannot understand why this happens on MS-Windows, but not on
> GNU/Linux.

The test that fails is this:

(ert-deftest package-test-macro-compilation ()
  "Install a package which includes a dependency."
  (with-package-test (:basedir (ert-resource-directory))
    (package-install-file (expand-file-name "macro-problem-package-1.0/"))
    (require 'macro-problem)
    ;; `macro-problem-func' uses a macro from `macro-aux'.
    (should (equal (macro-problem-func) '(progn a b)))
    (package-install-file (expand-file-name "macro-problem-package-2.0/"))
    ;; After upgrading, `macro-problem-func' depends on a new version
    ;; of the macro from `macro-aux'.
    (should (equal (macro-problem-func) '(1 b)))
    ;; `macro-problem-10-and-90' depends on an entirely new macro from `macro-aux'.
    (should (equal (macro-problem-10-and-90) '(10 90)))))

The thing that doesn't work is:

    (package-install-file (expand-file-name "macro-problem-package-2.0/"))

This does not reload the files, and that's because
package--load-files-for-activation doesn't reload them.  Which is
because package--list-loaded-files doesn't identify the files as
something that needs to be reloaded, as far as I can tell.

That function does a whole lot of comparison of file paths, and my guess
is that whatever it's doing (I'm having a hard time following the logic)
only works on GNU/Linux systems.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #34 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org,
 Artur Malabarba <bruce.connor.am <at> gmail.com>
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Fri, 25 Dec 2020 22:43:24 +0100

The problem on Macos seems to be that it's comparing file-truenames, but
that's not what's in the load history.  For instance,
"/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"
is in load-history, but it's finding conflicts by truenaming:

(file-truename "/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads")
=> "/private/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"

And indeed:

larsi <at> open-catalina test % ls -ld /var
lrwxr-xr-x@ 1 root  admin  11 Dec 18 15:11 /var -> private/var

The following seems to fix the problem for me on Macos and doesn't lead
to any breakages on Debian, so I'm pushing it now.  Can you check
whether this fixes the problem on Windows?

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 0170e61e12..bc450b09d0 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -830,7 +830,7 @@ package--files-load-history
         (mapcar (lambda (x)
                   (let ((f (car x)))
                     (and (stringp f)
-                         (file-name-sans-extension f))))
+                         (file-name-sans-extension (file-truename f)))))
                 load-history)))
 
 (defun package--list-of-conflicts (dir history)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #37 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org, bruce.connor.am <at> gmail.com
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Sat, 26 Dec 2020 10:39:03 +0200

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: Artur Malabarba <bruce.connor.am <at> gmail.com>,  37615 <at> debbugs.gnu.org,
>   42534 <at> debbugs.gnu.org
> Date: Fri, 25 Dec 2020 22:43:24 +0100
> 
> The problem on Macos seems to be that it's comparing file-truenames, but
> that's not what's in the load history.  For instance,
> "/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"
> is in load-history, but it's finding conflicts by truenaming:
> 
> (file-truename "/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads")
> => "/private/var/folders/l4/brbf3lnd693fpdl8bn87q5w80000gn/T/pkg-test-user-dir-FaftUD/macro-problem-1.0/macro-problem-autoloads"
> 
> And indeed:
> 
> larsi <at> open-catalina test % ls -ld /var
> lrwxr-xr-x@ 1 root  admin  11 Dec 18 15:11 /var -> private/var
> 
> The following seems to fix the problem for me on Macos and doesn't lead
> to any breakages on Debian, so I'm pushing it now.  Can you check
> whether this fixes the problem on Windows?

Yes, thanks.

In my case, the problem was that MS-Windows (in the version I run
here) produces short 8+3 alias file names for long directory names,
the file name for temporary-file-directory didn't compare equal to
what Emacs expected, exactly as on macOS; file-truename fixed that.

Message #44 received at 42534 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 42534 <at> debbugs.gnu.org, 37615 <at> debbugs.gnu.org, bruce.connor.am <at> gmail.com
Subject: Re: bug#42534: 28.0.50; package-test-macro-compilation test fails
 on macOS
Date: Sat, 26 Dec 2020 23:00:35 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> In my case, the problem was that MS-Windows (in the version I run
> here) produces short 8+3 alias file names for long directory names,
> the file name for temporary-file-directory didn't compare equal to
> what Emacs expected, exactly as on macOS; file-truename fixed that.

Ah, I see.  Apparently the Windows setup I'm using (for Emacs build
tests) isn't doing the 8+3 thing (Windows 10 with msys2/mingw shell).

Anyway, thanks for checking; closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.