GNU bug report logs - #42586
[PATCH] emacs-google-translate

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42586 in the body.
You can then email your comments to 42586 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: andremegafone <at> gmail.com (André Alexandre Gomes)
To: guix-patches <at> gnu.org 
Subject: [PATCH] emacs-google-translate
Date: Tue, 28 Jul 2020 16:26:34 +0100

[Message part 1 (text/plain, inline)]

I missed the attachment in the last message, sorry!

[emacs-google-translate.patch (text/x-patch, inline)]

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8618a07a21..36f8d27743 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -78,6 +78,7 @@
 ;;; Copyright © 2020 Eric Bavier <bavier <at> posteo.net>
 ;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;; Copyright © 2020 Peng Mei Yu <i <at> pengmeiyu.com>
+;;; Copyright © 2020 André A. Gomes <andremegafone <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -16975,7 +16976,7 @@ the GIF result.")
 (define-public emacs-google-translate
   (package
     (name "emacs-google-translate")
-    (version "0.11.18")
+    (version "0.12.0")
     (source
      (origin
        (method git-fetch)

[Message part 3 (text/plain, inline)]

-- 
André Alexandre Gomes
"Free Thought, Free World"

Message #8 received at 42586 <at> debbugs.gnu.org (full text, mbox):

From: andremegafone <at> gmail.com (André Alexandre Gomes)
To: 42586 <at> debbugs.gnu.org
Subject: Update
Date: Tue, 28 Jul 2020 17:36:10 +0100

Please ignore this thread since I forgot to actually add the patch.  Thanks.

--
André Alexandre Gomes
"Free Thought, Free World"

Message #11 received at 42586 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: andremegafone <at> gmail.com (André Alexandre Gomes)
Cc: 42586 <at> debbugs.gnu.org
Subject: Re: [bug#42586] [PATCH] emacs-google-translate
Date: Thu, 06 Aug 2020 22:45:03 -0500

andremegafone <at> gmail.com (André Alexandre Gomes) writes:

> I missed the attachment in the last message, sorry!
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 8618a07a21..36f8d27743 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -78,6 +78,7 @@
>  ;;; Copyright © 2020 Eric Bavier <bavier <at> posteo.net>
>  ;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
>  ;;; Copyright © 2020 Peng Mei Yu <i <at> pengmeiyu.com>
> +;;; Copyright © 2020 André A. Gomes <andremegafone <at> gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -16975,7 +16976,7 @@ the GIF result.")
>  (define-public emacs-google-translate
>    (package
>      (name "emacs-google-translate")
> -    (version "0.11.18")
> +    (version "0.12.0")
>      (source
>       (origin
>         (method git-fetch)

Hello Andre,

Thank you for your contribution. There are a few problems we need to
address before continuing. I will try to explain:

1. Each package comes with a checksum hash that needs to match to verify
the authenticity of the originating source. You modified the version,
but did not update that hash. This has can be obtained directly through
git or by running our build system on your change and letting the build
fail and it'll output the correct hash. On that note, please make sure
you are checking your changes by running the build system against them,
it would have caught this discrepency.

2. Your submission appears to be a git diff, we use git formatted
patches emailed through git send-mail to share and apply patches in our
work tree. Will you please resend your change (with the revised checksum
hash) using git format-patch and git send-mail? When doing so, please
take care to review our commit message protocol. These can be reviewed
from our contributing page.

If you need further explanations, or can not find the links to the
information I am referencing, let me know!

Thanks,
Brett Gilio

Message #16 received at 42586-close <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: andremegafone <at> gmail.com (André Alexandre Gomes)
Cc: 42586-close <at> debbugs.gnu.org
Subject: Re: [bug#42586] [PATCH] emacs-google-translate
Date: Thu, 06 Aug 2020 23:03:31 -0500

This package was already updated, on a second look. I hope you will
consider contributing again in the future though! :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.